bisecting fixing commit since 521b619acdc8f1f5acdac15b84f81fd9515b2aff building syzkaller on 64069d48f293e0be98d4a78a6f7be23861cc1e06 testing commit 521b619acdc8f1f5acdac15b84f81fd9515b2aff with gcc (GCC) 8.1.0 kernel signature: 3e2905ceb5145de4cf91cb98e751c1f3742dbe369bfbf00a84d5daca8f9ec11e run #0: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #2: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #3: basic kernel testing failed: timed out run #4: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #5: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #6: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #7: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #8: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #9: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction testing current HEAD 71c061d2443814de15e177489d5cc00a4a253ef3 testing commit 71c061d2443814de15e177489d5cc00a4a253ef3 with gcc (GCC) 8.1.0 kernel signature: 1da1a459be970a44a5867e7310d1cda90cb9ff0a32e32cae1a2d1d9728c3d131 all runs: OK # git bisect start 71c061d2443814de15e177489d5cc00a4a253ef3 521b619acdc8f1f5acdac15b84f81fd9515b2aff Bisecting: 8005 revisions left to test after this (roughly 13 steps) [d635a69dd4981cc51f90293f5f64268620ed1565] Merge tag 'net-next-5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit d635a69dd4981cc51f90293f5f64268620ed1565 with gcc (GCC) 8.1.0 kernel signature: 0f2eec9f0ca9fa582493aba848468fafeb1b1cb97fa5fe2e4a823aa8cc79940a all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction # git bisect good d635a69dd4981cc51f90293f5f64268620ed1565 Bisecting: 4013 revisions left to test after this (roughly 12 steps) [945433be3677955255fabecbf1076c17864ff9da] Merge tag 'leds-5.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds testing commit 945433be3677955255fabecbf1076c17864ff9da with gcc (GCC) 8.1.0 kernel signature: 594842bfa9c5ebdd93c94cf1e3958ec4e49e9fc2acb738d1c898860c784d719b run #0: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #2: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad 945433be3677955255fabecbf1076c17864ff9da Bisecting: 1963 revisions left to test after this (roughly 11 steps) [ee249d30fadec7677364063648f5547e243bf93f] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input testing commit ee249d30fadec7677364063648f5547e243bf93f with gcc (GCC) 8.1.0 kernel signature: 58591a3605c1dfc86821b94bd245d092da91e47e8bd6e7d6dd3adac25ad7173f all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction # git bisect good ee249d30fadec7677364063648f5547e243bf93f Bisecting: 981 revisions left to test after this (roughly 10 steps) [d3eb52113d162cc88975fbd03c9e6f9cf2f8a771] Merge tag 'printk-for-5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux testing commit d3eb52113d162cc88975fbd03c9e6f9cf2f8a771 with gcc (GCC) 8.1.0 kernel signature: c27afa0c6abef4f910fce9f15d1f7a5ddae19067251ac47cd60e48b912424e59 all runs: OK # git bisect bad d3eb52113d162cc88975fbd03c9e6f9cf2f8a771 Bisecting: 402 revisions left to test after this (roughly 9 steps) [f1ee3b8829006b3fda999f00f0059aa327e3f3d0] Merge tag 'for-5.11-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux testing commit f1ee3b8829006b3fda999f00f0059aa327e3f3d0 with gcc (GCC) 8.1.0 kernel signature: e1bfe5bcf0dc91554450f6f827ccbeb98cda7c0fee0ed1edce7d9bd9b9b1bfb3 all runs: OK # git bisect bad f1ee3b8829006b3fda999f00f0059aa327e3f3d0 Bisecting: 264 revisions left to test after this (roughly 8 steps) [489e9fea66f31086f85d9a18e61e4791d94a56a4] Merge tag 'pci-v5.11-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci testing commit 489e9fea66f31086f85d9a18e61e4791d94a56a4 with gcc (GCC) 8.1.0 kernel signature: dfb0cce062b0e3ef34417fdbf9a825fecb146093f10fb11fb32c624dfa55e0fe all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction # git bisect good 489e9fea66f31086f85d9a18e61e4791d94a56a4 Bisecting: 132 revisions left to test after this (roughly 7 steps) [445d8ab53f69f4c4062b668c6a25b88a79753136] btrfs: sysfs: remove unneeded semicolon testing commit 445d8ab53f69f4c4062b668c6a25b88a79753136 with gcc (GCC) 8.1.0 kernel signature: d37ec4e5d157b7846582d5300d93b49d3e51134a0e96ac7414d89da72217c818 all runs: OK # git bisect bad 445d8ab53f69f4c4062b668c6a25b88a79753136 Bisecting: 65 revisions left to test after this (roughly 6 steps) [2ca08c56e813323ee470f7fd8d836f30600e3960] btrfs: explicitly protect ->last_byte_to_unpin in unpin_extent_range testing commit 2ca08c56e813323ee470f7fd8d836f30600e3960 with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2330:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 2ca08c56e813323ee470f7fd8d836f30600e3960 Bisecting: 65 revisions left to test after this (roughly 6 steps) [22b6331d961712ac2735423e5a6c04e9d0fd7897] btrfs: store precalculated csum_size in fs_info testing commit 22b6331d961712ac2735423e5a6c04e9d0fd7897 with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2331:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 22b6331d961712ac2735423e5a6c04e9d0fd7897 Bisecting: 65 revisions left to test after this (roughly 6 steps) [882dbe0cec9651bf6a6df500178149453726c1e1] btrfs: introduce mount option rescue=ignoredatacsums testing commit 882dbe0cec9651bf6a6df500178149453726c1e1 with gcc (GCC) 8.1.0 kernel signature: 165a8672fb0f8ad39bace574b0bd49a872ec273ef2f57d9660481653253fb308 run #0: boot failed: create image operation failed: &{Code:ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS Location: Message:The zone 'projects/syzkaller/zones/us-central1-c' does not have enough resources available to fulfill the request. '(resource type:compute)'. ForceSendFields:[] NullFields:[]}. run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #4: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #5: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #6: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #7: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #8: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction run #9: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction # git bisect good 882dbe0cec9651bf6a6df500178149453726c1e1 Bisecting: 56 revisions left to test after this (roughly 6 steps) [a26663e7a2f456b8111de0135394c04c72831930] btrfs: make csum_tree_block() handle node smaller than page testing commit a26663e7a2f456b8111de0135394c04c72831930 with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2330:9: error: too many arguments to function 'set_extent_bit' # git bisect skip a26663e7a2f456b8111de0135394c04c72831930 Bisecting: 56 revisions left to test after this (roughly 6 steps) [2f4d60dfae0ee4ad1c8d57e102c3b032b8f9d4d5] btrfs: grab fs_info from extent_buffer in btrfs_mark_buffer_dirty testing commit 2f4d60dfae0ee4ad1c8d57e102c3b032b8f9d4d5 with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2330:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 2f4d60dfae0ee4ad1c8d57e102c3b032b8f9d4d5 Bisecting: 56 revisions left to test after this (roughly 6 steps) [098e63082b9bd26b61a57310385efc3e9f363dea] btrfs: replace div_u64 by shift in free_space_bitmap_size testing commit 098e63082b9bd26b61a57310385efc3e9f363dea with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2331:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 098e63082b9bd26b61a57310385efc3e9f363dea Bisecting: 56 revisions left to test after this (roughly 6 steps) [77bf40a2ba2e6eded53a74f94d1be448bd8db030] btrfs: extract extent buffer verification from btrfs_validate_metadata_buffer() testing commit 77bf40a2ba2e6eded53a74f94d1be448bd8db030 with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2330:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 77bf40a2ba2e6eded53a74f94d1be448bd8db030 Bisecting: 56 revisions left to test after this (roughly 6 steps) [5d81230baa9096bd5a7ad40822505b89ca7f9dfe] btrfs: pass the root owner and level around for readahead testing commit 5d81230baa9096bd5a7ad40822505b89ca7f9dfe with gcc (GCC) 8.1.0 fs/btrfs/inode.c:2330:9: error: too many arguments to function 'set_extent_bit' # git bisect skip 5d81230baa9096bd5a7ad40822505b89ca7f9dfe Bisecting: 56 revisions left to test after this (roughly 6 steps) [ecdcf3c259e4c36ec6c81e7a807b4924be898b20] btrfs: open code insert_orphan_item testing commit ecdcf3c259e4c36ec6c81e7a807b4924be898b20 with gcc (GCC) 8.1.0 kernel signature: da7741ca107bcffb170ee131fb81bf142de219ba111d69b44d76600acc1fb47a all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in start_transaction # git bisect good ecdcf3c259e4c36ec6c81e7a807b4924be898b20 Bisecting: 55 revisions left to test after this (roughly 6 steps) [bc5b5b1e5111005363094da1d5f5ffb0e83165f1] btrfs: stop incrementing log batch when joining log transaction testing commit bc5b5b1e5111005363094da1d5f5ffb0e83165f1 with gcc (GCC) 8.1.0 kernel signature: 049c822746b38843467e08b6feae77d7f0b9caedf9960edfbb3978b97b638cd0 run #0: crashed: WARNING: ODEBUG bug in netdev_run_todo run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good bc5b5b1e5111005363094da1d5f5ffb0e83165f1 Bisecting: 1 revision left to test after this (roughly 1 step) [d5286a92ea76a124d6cfa1e261394da858125d99] btrfs: remove useless return value statement in split_node testing commit d5286a92ea76a124d6cfa1e261394da858125d99 with gcc (GCC) 8.1.0 kernel signature: 58f787a377d1bae62e1dbe8a01c607fcf606918e0e1dd777aa2863e3da9e1285 all runs: OK # git bisect bad d5286a92ea76a124d6cfa1e261394da858125d99 Bisecting: 0 revisions left to test after this (roughly 0 steps) [f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc] btrfs: remove unnecessary attempt to drop extent maps after adding inline extent testing commit f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc with gcc (GCC) 8.1.0 kernel signature: 7e6aab46982edfe75afda9a62fae7c03a97d7b8c70940661aacb3ba02a20c84b all runs: OK # git bisect bad f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc is the first bad commit commit f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc Author: Filipe Manana Date: Fri Nov 13 11:24:17 2020 +0000 btrfs: remove unnecessary attempt to drop extent maps after adding inline extent At inode.c:cow_file_range_inline(), after we insert the inline extent in the fs/subvolume btree, we call btrfs_drop_extent_cache() to drop all extent maps in the file range, however that is not necessary because we have already done it in the call to btrfs_drop_extents(), which calls btrfs_drop_extent_cache() for us, and since at this point we have the file range locked in the inode's iotree (we are in the writeback path), we know no other task can come in and read stale file extent items or find none and therefore create either stale extent maps or an extent map that represents a hole. So just remove that unnecessary call to btrfs_drop_extent_cache(), as it's doing nothing and only wasting time. This call has been around since 2008, introduced in commit c8b978188c9a ("Btrfs: Add zlib compression support"), but even back then it seems it was not necessary, since we had the range locked in the inode's iotree and the call to btrfs_drop_extents() already used to always call btrfs_drop_extent_cache(). Reviewed-by: Josef Bacik Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba fs/btrfs/inode.c | 1 - 1 file changed, 1 deletion(-) culprit signature: 7e6aab46982edfe75afda9a62fae7c03a97d7b8c70940661aacb3ba02a20c84b parent signature: 049c822746b38843467e08b6feae77d7f0b9caedf9960edfbb3978b97b638cd0 Reproducer flagged being flaky revisions tested: 14, total time: 3h18m16.653348044s (build: 1h28m53.316113685s, test: 1h47m35.859581167s) first good commit: f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc btrfs: remove unnecessary attempt to drop extent maps after adding inline extent recipients (to): ["dsterba@suse.com" "fdmanana@suse.com" "josef@toxicpanda.com"] recipients (cc): []