bisecting fixing commit since 68d7a45eec101bc1550294c0e675a490c047b2e5 building syzkaller on 8e3c52b11d5d0843be47f41e00c5612ce29811b0 testing commit 68d7a45eec101bc1550294c0e675a490c047b2e5 with gcc (GCC) 8.1.0 kernel signature: b10755f74a95b9c122686467f21c1ae75a151c25 all runs: crashed: WARNING in notify_change testing current HEAD 43598c571e7ed29e4c81e35b4a870fe6b9f8d58e testing commit 43598c571e7ed29e4c81e35b4a870fe6b9f8d58e with gcc (GCC) 8.1.0 kernel signature: 73c96bbfdb797fc39c3b7a8993e9abd2622b82a0 all runs: OK # git bisect start 43598c571e7ed29e4c81e35b4a870fe6b9f8d58e 68d7a45eec101bc1550294c0e675a490c047b2e5 Bisecting: 1666 revisions left to test after this (roughly 11 steps) [dd10423ef68e3cd66fc6b180737bb3f0cefe3404] Btrfs: fix incremental send failure after deduplication testing commit dd10423ef68e3cd66fc6b180737bb3f0cefe3404 with gcc (GCC) 8.1.0 kernel signature: 9fb1243e3914d9a06ea140238940207b32bd6bba all runs: OK # git bisect bad dd10423ef68e3cd66fc6b180737bb3f0cefe3404 Bisecting: 833 revisions left to test after this (roughly 10 steps) [1bd33537171499e1ed0528442d31fc1d5698b4c8] memcg: make it work on sparse non-0-node systems testing commit 1bd33537171499e1ed0528442d31fc1d5698b4c8 with gcc (GCC) 8.1.0 kernel signature: 11ae8d174a09b2ff164d140614ec822424bcf62d all runs: crashed: WARNING in notify_change # git bisect good 1bd33537171499e1ed0528442d31fc1d5698b4c8 Bisecting: 416 revisions left to test after this (roughly 9 steps) [2b0ce4096f1aad23fdc541156299bd7b00728e68] dt-bindings: can: mcp251x: add mcp25625 support testing commit 2b0ce4096f1aad23fdc541156299bd7b00728e68 with gcc (GCC) 8.1.0 kernel signature: 0fa9ed8ee6f0a2f3d0934efe6db7babea9787efa all runs: OK # git bisect bad 2b0ce4096f1aad23fdc541156299bd7b00728e68 Bisecting: 208 revisions left to test after this (roughly 8 steps) [155656d0e3da6a381575886f73b4f418717e7bcd] sunhv: Fix device naming inconsistency between sunhv_console and sunhv_reg testing commit 155656d0e3da6a381575886f73b4f418717e7bcd with gcc (GCC) 8.1.0 kernel signature: 0c0f8829fbff831e6d358fdb216bff1030ccb132 all runs: crashed: WARNING in notify_change # git bisect good 155656d0e3da6a381575886f73b4f418717e7bcd Bisecting: 104 revisions left to test after this (roughly 7 steps) [d4fe45ddfe61c126155b50cf2c3c220c52697c62] net/9p: include trans_common.h to fix missing prototype warning. testing commit d4fe45ddfe61c126155b50cf2c3c220c52697c62 with gcc (GCC) 8.1.0 kernel signature: 62ac92269da039ac102bfc03f61efd85a5995132 all runs: OK # git bisect bad d4fe45ddfe61c126155b50cf2c3c220c52697c62 Bisecting: 51 revisions left to test after this (roughly 6 steps) [38ea8c0429a750ad4905c7e0edad442a02518cb4] parport: Fix mem leak in parport_register_dev_model testing commit 38ea8c0429a750ad4905c7e0edad442a02518cb4 with gcc (GCC) 8.1.0 kernel signature: 07093d74542135750ac56a41e3d9782e2f3ba643 all runs: OK # git bisect bad 38ea8c0429a750ad4905c7e0edad442a02518cb4 Bisecting: 25 revisions left to test after this (roughly 5 steps) [60ac7a4840466992b1ac808e1dbc503359bf83ab] scsi: libcxgbi: add a check for NULL pointer in cxgbi_check_route() testing commit 60ac7a4840466992b1ac808e1dbc503359bf83ab with gcc (GCC) 8.1.0 kernel signature: a75d44d583e124098a91e35562a3e48bf9355150 all runs: crashed: WARNING in notify_change # git bisect good 60ac7a4840466992b1ac808e1dbc503359bf83ab Bisecting: 12 revisions left to test after this (roughly 4 steps) [f1a58e1bcad882ea08778320147c7ef9118f704f] objtool: Support per-function rodata sections testing commit f1a58e1bcad882ea08778320147c7ef9118f704f with gcc (GCC) 8.1.0 kernel signature: 6c4476c013ef764a8756440e8272d9d2bf00b744 all runs: OK # git bisect bad f1a58e1bcad882ea08778320147c7ef9118f704f Bisecting: 6 revisions left to test after this (roughly 3 steps) [6fff9ed6bcf0f4acb4d69b0c7472cfc305ef58a0] HID: wacom: Don't report anything prior to the tool entering range testing commit 6fff9ed6bcf0f4acb4d69b0c7472cfc305ef58a0 with gcc (GCC) 8.1.0 kernel signature: dc5d39ba39f94a8b4d327e13597ed562f63c666e all runs: crashed: WARNING in notify_change # git bisect good 6fff9ed6bcf0f4acb4d69b0c7472cfc305ef58a0 Bisecting: 3 revisions left to test after this (roughly 2 steps) [7ab0cb70c2d2c7615b2b489d55e850cdae5400ef] infiniband: fix race condition between infiniband mlx4, mlx5 driver and core dumping testing commit 7ab0cb70c2d2c7615b2b489d55e850cdae5400ef with gcc (GCC) 8.1.0 kernel signature: cdd5e59076d984fc5badde59db2cd63365ddecdd all runs: crashed: WARNING in notify_change # git bisect good 7ab0cb70c2d2c7615b2b489d55e850cdae5400ef Bisecting: 1 revision left to test after this (roughly 1 step) [a5758c5311775625be7f6dd54757ed356dbf2977] Linux 4.14.129 testing commit a5758c5311775625be7f6dd54757ed356dbf2977 with gcc (GCC) 8.1.0 kernel signature: e6341fb78cda9aeda377e3b44d7fe8a77034ae3b all runs: OK # git bisect bad a5758c5311775625be7f6dd54757ed356dbf2977 Bisecting: 0 revisions left to test after this (roughly 0 steps) [2c54624255635a4f421fef9c7692f7fc9314b453] Abort file_remove_privs() for non-reg. files testing commit 2c54624255635a4f421fef9c7692f7fc9314b453 with gcc (GCC) 8.1.0 kernel signature: 83b39b920fcd04b570499e162445c55345cb25e5 all runs: OK # git bisect bad 2c54624255635a4f421fef9c7692f7fc9314b453 2c54624255635a4f421fef9c7692f7fc9314b453 is the first bad commit commit 2c54624255635a4f421fef9c7692f7fc9314b453 Author: Alexander Lochmann Date: Fri Dec 14 11:55:52 2018 +0100 Abort file_remove_privs() for non-reg. files commit f69e749a49353d96af1a293f56b5b56de59c668a upstream. file_remove_privs() might be called for non-regular files, e.g. blkdev inode. There is no reason to do its job on things like blkdev inodes, pipes, or cdevs. Hence, abort if file does not refer to a regular inode. AV: more to the point, for devices there might be any number of inodes refering to given device. Which one to strip the permissions from, even if that made any sense in the first place? All of them will be observed with contents modified, after all. Found by LockDoc (Alexander Lochmann, Horst Schirmeier and Olaf Spinczyk) Reviewed-by: Jan Kara Signed-off-by: Alexander Lochmann Signed-off-by: Horst Schirmeier Signed-off-by: Al Viro Cc: Zubin Mithra Signed-off-by: Greg Kroah-Hartman fs/inode.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) kernel signature: 83b39b920fcd04b570499e162445c55345cb25e5 previous signature: cdd5e59076d984fc5badde59db2cd63365ddecdd revisions tested: 14, total time: 3h39m23.623330151s (build: 1h48m21.496214003s, test: 1h46m43.343511129s) first good commit: 2c54624255635a4f421fef9c7692f7fc9314b453 Abort file_remove_privs() for non-reg. files cc: ["alexander.lochmann@tu-dortmund.de" "gregkh@linuxfoundation.org" "horst.schirmeier@tu-dortmund.de" "jack@suse.cz" "viro@zeniv.linux.org.uk" "zsm@chromium.org"]