bisecting fixing commit since c98875d930e915d01e8c40c7d3c16f00b3c8abe1 building syzkaller on b617407b25b37a7a8efa47127005d1f20dd0abe1 testing commit c98875d930e915d01e8c40c7d3c16f00b3c8abe1 with gcc (GCC) 8.1.0 kernel signature: 2c5cfdd443a471bc42da4c1919c8e7e2f07ea652 all runs: crashed: WARNING in notify_change testing current HEAD 14260788bbb9c94b0e36abc17294266b69dd46e4 testing commit 14260788bbb9c94b0e36abc17294266b69dd46e4 with gcc (GCC) 8.1.0 kernel signature: d06d0bf29d56efd7e08827234802f490573e5800 all runs: OK # git bisect start 14260788bbb9c94b0e36abc17294266b69dd46e4 c98875d930e915d01e8c40c7d3c16f00b3c8abe1 Bisecting: 2497 revisions left to test after this (roughly 11 steps) [1bb2dd37cb878da69b43957804f2925d6ce33d1b] ip6_tunnel: fix possible use-after-free on xmit testing commit 1bb2dd37cb878da69b43957804f2925d6ce33d1b with gcc (GCC) 8.1.0 kernel signature: b1ddf8667e73de7e7a718d922911c02056e5818c all runs: OK # git bisect bad 1bb2dd37cb878da69b43957804f2925d6ce33d1b Bisecting: 1248 revisions left to test after this (roughly 10 steps) [221c44d2d7fa51c90d0a278b3c20da64e5c068d9] Revert "MIPS: perf: ath79: Fix perfcount IRQ assignment" testing commit 221c44d2d7fa51c90d0a278b3c20da64e5c068d9 with gcc (GCC) 8.1.0 kernel signature: 8f20597cdd28f0098fee4c2e08e1c3d482a0ca8e all runs: crashed: WARNING in notify_change # git bisect good 221c44d2d7fa51c90d0a278b3c20da64e5c068d9 Bisecting: 624 revisions left to test after this (roughly 9 steps) [d202b5adccfb093c4859d67ec74d5f3fb9fcfc54] VMCI: Fix integer overflow in VMCI handle arrays testing commit d202b5adccfb093c4859d67ec74d5f3fb9fcfc54 with gcc (GCC) 8.1.0 kernel signature: dfe3882f5d36b61c7b76370a395447ed9660bb7f all runs: OK # git bisect bad d202b5adccfb093c4859d67ec74d5f3fb9fcfc54 Bisecting: 311 revisions left to test after this (roughly 8 steps) [d64f99ef010dba5ffc19d233442479f207f91067] brcmfmac: sdio: Don't tune while the card is off testing commit d64f99ef010dba5ffc19d233442479f207f91067 with gcc (GCC) 8.1.0 kernel signature: 17d0443cfa6889dfe654cf62cf18202259d98081 all runs: OK # git bisect bad d64f99ef010dba5ffc19d233442479f207f91067 Bisecting: 155 revisions left to test after this (roughly 7 steps) [b7f8bbbbb97368b9187b42da20d33f5d7309759c] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk testing commit b7f8bbbbb97368b9187b42da20d33f5d7309759c with gcc (GCC) 8.1.0 kernel signature: acb8da45c29fb00de2a34140881e5ece955b163b all runs: crashed: WARNING in notify_change # git bisect good b7f8bbbbb97368b9187b42da20d33f5d7309759c Bisecting: 77 revisions left to test after this (roughly 6 steps) [b6a1eabf72a01228543462d3961fc3e298832318] net: mvpp2: prs: Fix parser range for VID filtering testing commit b6a1eabf72a01228543462d3961fc3e298832318 with gcc (GCC) 8.1.0 kernel signature: 5eeb540e5a0c567f3ba74b7421500e523b0c8fcc all runs: crashed: WARNING in notify_change # git bisect good b6a1eabf72a01228543462d3961fc3e298832318 Bisecting: 38 revisions left to test after this (roughly 5 steps) [214c5933ffcf703112656f5e3d98505fbfb97cb3] scsi: libcxgbi: add a check for NULL pointer in cxgbi_check_route() testing commit 214c5933ffcf703112656f5e3d98505fbfb97cb3 with gcc (GCC) 8.1.0 kernel signature: d4a6ee20b7ab001e0185a331e66caca5e321165d all runs: crashed: WARNING in notify_change # git bisect good 214c5933ffcf703112656f5e3d98505fbfb97cb3 Bisecting: 19 revisions left to test after this (roughly 4 steps) [0319ef1d40ff39d2c0f942a46fb73918669b2350] ovl: fix bogus -Wmaybe-unitialized warning testing commit 0319ef1d40ff39d2c0f942a46fb73918669b2350 with gcc (GCC) 8.1.0 kernel signature: 0b297fc399bf3a1b2d36d21879c54a76d4a76085 all runs: OK # git bisect bad 0319ef1d40ff39d2c0f942a46fb73918669b2350 Bisecting: 9 revisions left to test after this (roughly 3 steps) [dad3a9314ac95dedc007bc7dacacb396ea10e376] tcp: refine memory limit test in tcp_fragment() testing commit dad3a9314ac95dedc007bc7dacacb396ea10e376 with gcc (GCC) 8.1.0 kernel signature: 22f0f8aca929a6179de59cc6c21d9f7670347791 all runs: OK # git bisect bad dad3a9314ac95dedc007bc7dacacb396ea10e376 Bisecting: 4 revisions left to test after this (roughly 2 steps) [fedb1b9c9191687a7ceb117b8dc444d0d321692a] mlxsw: spectrum: Prevent force of 56G testing commit fedb1b9c9191687a7ceb117b8dc444d0d321692a with gcc (GCC) 8.1.0 kernel signature: 80e73b7e279f3844561062617f3c2ced6b973397 all runs: crashed: WARNING in notify_change # git bisect good fedb1b9c9191687a7ceb117b8dc444d0d321692a Bisecting: 2 revisions left to test after this (roughly 1 step) [465ce9a50f8a4e2fcd257ce37e11db3104a83ebb] coredump: fix race condition between collapse_huge_page() and core dumping testing commit 465ce9a50f8a4e2fcd257ce37e11db3104a83ebb with gcc (GCC) 8.1.0 kernel signature: 8ca4d9fc6e118798e47f2a83a647b4788515b963 all runs: crashed: WARNING in notify_change # git bisect good 465ce9a50f8a4e2fcd257ce37e11db3104a83ebb Bisecting: 0 revisions left to test after this (roughly 1 step) [63bbbcd8ed53c404649e0b4248c1e5d42c41ac97] Linux 4.19.54 testing commit 63bbbcd8ed53c404649e0b4248c1e5d42c41ac97 with gcc (GCC) 8.1.0 kernel signature: 059b186bbc2183fa8ebe6e1de86903d3c7027548 all runs: OK # git bisect bad 63bbbcd8ed53c404649e0b4248c1e5d42c41ac97 Bisecting: 0 revisions left to test after this (roughly 0 steps) [e8e448b08450b05d54cf99eb4e3473b708c8fcc0] Abort file_remove_privs() for non-reg. files testing commit e8e448b08450b05d54cf99eb4e3473b708c8fcc0 with gcc (GCC) 8.1.0 kernel signature: 22e9b3233a00ba6fefc583d4487c96ad80c9ffaa all runs: OK # git bisect bad e8e448b08450b05d54cf99eb4e3473b708c8fcc0 e8e448b08450b05d54cf99eb4e3473b708c8fcc0 is the first bad commit commit e8e448b08450b05d54cf99eb4e3473b708c8fcc0 Author: Alexander Lochmann Date: Fri Dec 14 11:55:52 2018 +0100 Abort file_remove_privs() for non-reg. files commit f69e749a49353d96af1a293f56b5b56de59c668a upstream. file_remove_privs() might be called for non-regular files, e.g. blkdev inode. There is no reason to do its job on things like blkdev inodes, pipes, or cdevs. Hence, abort if file does not refer to a regular inode. AV: more to the point, for devices there might be any number of inodes refering to given device. Which one to strip the permissions from, even if that made any sense in the first place? All of them will be observed with contents modified, after all. Found by LockDoc (Alexander Lochmann, Horst Schirmeier and Olaf Spinczyk) Reviewed-by: Jan Kara Signed-off-by: Alexander Lochmann Signed-off-by: Horst Schirmeier Signed-off-by: Al Viro Cc: Zubin Mithra Signed-off-by: Greg Kroah-Hartman fs/inode.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) kernel signature: 22e9b3233a00ba6fefc583d4487c96ad80c9ffaa previous signature: 8ca4d9fc6e118798e47f2a83a647b4788515b963 revisions tested: 15, total time: 3h55m4.774289625s (build: 2h5m6.550661645s, test: 1h45m18.458946845s) first good commit: e8e448b08450b05d54cf99eb4e3473b708c8fcc0 Abort file_remove_privs() for non-reg. files cc: ["alexander.lochmann@tu-dortmund.de" "gregkh@linuxfoundation.org" "horst.schirmeier@tu-dortmund.de" "jack@suse.cz" "viro@zeniv.linux.org.uk" "zsm@chromium.org"]