bisecting fixing commit since 60ec7fcfe76892a1479afab51ff17a4281923156 building syzkaller on 44068e196185e2f5a7c94629b6245cdde008b140 testing commit 60ec7fcfe76892a1479afab51ff17a4281923156 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8c7352d46ca32927f1d6212d5aaf631f3b05cb25533f3de15ed459c9166ef700 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: possible deadlock in __inet_stream_connect run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #10: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #11: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #12: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #13: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #14: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #15: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #16: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #17: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #18: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #19: OK testing current HEAD afa114d987c40e72ebbbc36bedf7d66b7cdc5883 testing commit afa114d987c40e72ebbbc36bedf7d66b7cdc5883 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: efc7ad85112e683689afd0abc25b7eae0c9d0dbb4a5f41a13c8b0fcae40d4b15 all runs: OK # git bisect start afa114d987c40e72ebbbc36bedf7d66b7cdc5883 60ec7fcfe76892a1479afab51ff17a4281923156 Bisecting: 5969 revisions left to test after this (roughly 13 steps) [6f38be8f2ccd9babf04b9b23539108542a59fcb8] Merge tag 'docs-5.17' of git://git.lwn.net/linux testing commit 6f38be8f2ccd9babf04b9b23539108542a59fcb8 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d6d6d8446e026b76b3139aebf148808a131d4d739d44dbd3b0962ef3c9e5aece all runs: OK # git bisect bad 6f38be8f2ccd9babf04b9b23539108542a59fcb8 Bisecting: 3014 revisions left to test after this (roughly 12 steps) [75b950ef6166e4ef52e43e7ec80985c5705f7e81] Revert "drm/amd/display: Fix for otg synchronization logic" testing commit 75b950ef6166e4ef52e43e7ec80985c5705f7e81 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 846b86b0a9cccb00cc79410397f405cb624be39c0d7c9f672b99e1d059d72049 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: OK run #9: OK # git bisect good 75b950ef6166e4ef52e43e7ec80985c5705f7e81 Bisecting: 1550 revisions left to test after this (roughly 11 steps) [d430dffbe9dd30759f3c64b65bf85b0245c8d8ab] mt76: mt7921: fix a possible race enabling/disabling runtime-pm testing commit d430dffbe9dd30759f3c64b65bf85b0245c8d8ab compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ad4c74900599777df620357a40660c5d97336d5380bbc6469ef7c68d408b73c3 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: OK run #9: OK # git bisect good d430dffbe9dd30759f3c64b65bf85b0245c8d8ab Bisecting: 772 revisions left to test after this (roughly 10 steps) [8aaaf2f3af2ae212428f4db1af34214225f5cec3] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 8aaaf2f3af2ae212428f4db1af34214225f5cec3 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 53e364faa060da3d6c72ff6ecd10d5054d74e1dd081d00a588265a9adb8cbce1 all runs: OK # git bisect bad 8aaaf2f3af2ae212428f4db1af34214225f5cec3 Bisecting: 388 revisions left to test after this (roughly 9 steps) [1aae5cc0a55c097f16ccce1493415c63d60babc9] chelsio: cxgb: Use dma_set_mask_and_coherent() and simplify code testing commit 1aae5cc0a55c097f16ccce1493415c63d60babc9 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5cc3b72646c18bfffaade115db174b1bc9c08ff8df6c55bb0501aba3cdd15687 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: OK run #9: OK # git bisect good 1aae5cc0a55c097f16ccce1493415c63d60babc9 Bisecting: 187 revisions left to test after this (roughly 8 steps) [26abf15c49e0fbbcb6dbd70c52ecbde221f1b0fa] Merge tag 'mlx5-updates-2022-01-06' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux testing commit 26abf15c49e0fbbcb6dbd70c52ecbde221f1b0fa compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2fdd333126b9fa4e42759d63917e1a242d96d701d5332ed70da22e62afb291c7 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: OK run #8: OK run #9: OK # git bisect good 26abf15c49e0fbbcb6dbd70c52ecbde221f1b0fa Bisecting: 80 revisions left to test after this (roughly 7 steps) [77bbcb60f734fe25e1d17a7bdc9a4260868efb0f] Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next testing commit 77bbcb60f734fe25e1d17a7bdc9a4260868efb0f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a71d4b93a5bc8ac6cf8cddd70c14fa0e55efebeb632fc8135778370f7a0448f8 all runs: OK # git bisect bad 77bbcb60f734fe25e1d17a7bdc9a4260868efb0f Bisecting: 53 revisions left to test after this (roughly 6 steps) [335c818c5a7ace740da837a8bb8591d5896938db] can: mcp251xfd: move chip FIFO init into separate file testing commit 335c818c5a7ace740da837a8bb8591d5896938db compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 93ada9fbb1905b99fc40b375d1f441d3c981171ff293fb69eb80b941c45a3c42 all runs: OK # git bisect bad 335c818c5a7ace740da837a8bb8591d5896938db Bisecting: 26 revisions left to test after this (roughly 5 steps) [327b9a94e2a805dea5238940c9660ca367dbfdef] selftests: mptcp: more stable join tests-cases testing commit 327b9a94e2a805dea5238940c9660ca367dbfdef compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ac09ca3538dd8a864a518afa1dbb7dab05f2f438b12fa1d286de184b8af6a226 all runs: OK # git bisect bad 327b9a94e2a805dea5238940c9660ca367dbfdef Bisecting: 12 revisions left to test after this (roughly 4 steps) [e9d09baca67625cfb41c0f2b547b9dbb4043ae95] mptcp: avoid atomic bit manipulation when possible testing commit e9d09baca67625cfb41c0f2b547b9dbb4043ae95 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6ec4a26c5e68e735eeee545ecf40df96b6f46d81031b80fcb98263651f4f3ec9 all runs: OK # git bisect bad e9d09baca67625cfb41c0f2b547b9dbb4043ae95 Bisecting: 6 revisions left to test after this (roughly 3 steps) [05be5e273c84f6329b3cac4f5bb7b1fe6eaefd5d] selftests: mptcp: add disconnect tests testing commit 05be5e273c84f6329b3cac4f5bb7b1fe6eaefd5d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d2acea9c31242da32bb3a72bdb3eb95aca3036f5d73a04f3e8d1a11a381ab924 all runs: OK # git bisect bad 05be5e273c84f6329b3cac4f5bb7b1fe6eaefd5d Bisecting: 2 revisions left to test after this (roughly 2 steps) [b29fcfb54cd70caca5b11c80d8d238854938884a] mptcp: full disconnect implementation testing commit b29fcfb54cd70caca5b11c80d8d238854938884a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a5dce8e798eb2342a30bca5c3d740d77d33ff68a15b3b5fed0cb04656684f4dd all runs: OK # git bisect bad b29fcfb54cd70caca5b11c80d8d238854938884a Bisecting: 0 revisions left to test after this (roughly 1 step) [f284c0c7732189fa77567dc061c5f4205c4fa05b] mptcp: implement fastclose xmit path testing commit f284c0c7732189fa77567dc061c5f4205c4fa05b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c8bbe5ef9762755a88af40e432fc0eb6231a15d38b2c9f54597ed8e573181a54 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: OK # git bisect good f284c0c7732189fa77567dc061c5f4205c4fa05b b29fcfb54cd70caca5b11c80d8d238854938884a is the first bad commit commit b29fcfb54cd70caca5b11c80d8d238854938884a Author: Paolo Abeni Date: Thu Jan 6 16:20:16 2022 -0800 mptcp: full disconnect implementation The current mptcp_disconnect() implementation lacks several steps, we additionally need to reset the msk socket state and flush the subflow list. Factor out the needed helper to avoid code duplication. Additionally ensure that the initial subflow is disposed only after mptcp_close(), just reset it at disconnect time. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau Signed-off-by: David S. Miller net/mptcp/pm.c | 10 +++-- net/mptcp/protocol.c | 101 ++++++++++++++++++++++++++++++++++++++------------- net/mptcp/protocol.h | 14 +++++++ net/mptcp/token.c | 1 + 4 files changed, 98 insertions(+), 28 deletions(-) culprit signature: a5dce8e798eb2342a30bca5c3d740d77d33ff68a15b3b5fed0cb04656684f4dd parent signature: c8bbe5ef9762755a88af40e432fc0eb6231a15d38b2c9f54597ed8e573181a54 revisions tested: 15, total time: 2h57m9.325961614s (build: 1h37m57.369258562s, test: 1h17m39.695340948s) first good commit: b29fcfb54cd70caca5b11c80d8d238854938884a mptcp: full disconnect implementation recipients (to): ["davem@davemloft.net" "mathew.j.martineau@linux.intel.com" "pabeni@redhat.com"] recipients (cc): []