bisecting fixing commit since 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8 building syzkaller on 409809d8a7c9c775eaea317add40e7a86a1e836c testing commit 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8 with gcc (GCC) 8.1.0 kernel signature: 6f3ea505a5ae79e9fe94e988ef16049b22c6ad976f245563809717635200457a run #0: crashed: WARNING in __proc_create run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #2: crashed: WARNING: proc registration bug in afs_manage_cell run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK testing current HEAD f8394f232b1eab649ce2df5c5f15b0e528c92091 testing commit f8394f232b1eab649ce2df5c5f15b0e528c92091 with gcc (GCC) 8.1.0 kernel signature: 1cabab632d4cf2c452e269942d55b488372ebba6c68bab459298b298473b06fa all runs: OK # git bisect start f8394f232b1eab649ce2df5c5f15b0e528c92091 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8 Bisecting: 8233 revisions left to test after this (roughly 13 steps) [c48b75b7271db23c1b2d1204d6e8496d91f27711] Merge tag 'sound-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound testing commit c48b75b7271db23c1b2d1204d6e8496d91f27711 with gcc (GCC) 8.1.0 kernel signature: 7f841900a2bd6c76da7c6c202a5230bdcc33952a6535296439dc712c476f058d run #0: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #1: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor813408532" "root@10.128.10.61:./syz-executor813408532"]: exit status 1 ssh: connect to host 10.128.10.61 port 22: Connection timed out lost connection run #2: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor489708387" "root@10.128.10.63:./syz-executor489708387"]: exit status 1 ssh: connect to host 10.128.10.63 port 22: Connection timed out lost connection run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good c48b75b7271db23c1b2d1204d6e8496d91f27711 Bisecting: 4031 revisions left to test after this (roughly 12 steps) [a1e16bc7d5f7ca3599d8a7f061841c93a563665e] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma testing commit a1e16bc7d5f7ca3599d8a7f061841c93a563665e with gcc (GCC) 8.1.0 kernel signature: a16d55a309aabb5b193ef9eda7bfcbe497f4c2b47aa7f07d4d6393741d404690 all runs: OK # git bisect bad a1e16bc7d5f7ca3599d8a7f061841c93a563665e Bisecting: 2101 revisions left to test after this (roughly 11 steps) [7c89d9d9f90931f170e510e9e4b84d9dafdd616a] Merge branch 'net-ravb-Add-support-for-explicit-internal-clock-delay-c onfiguration' testing commit 7c89d9d9f90931f170e510e9e4b84d9dafdd616a with gcc (GCC) 8.1.0 kernel signature: f95c5380fd97c6740783f8fa01ae329dd0d9153721ded85051f8330613ce650f run #0: crashed: general protection fault in afs_dns_query run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 7c89d9d9f90931f170e510e9e4b84d9dafdd616a Bisecting: 1028 revisions left to test after this (roughly 10 steps) [9ff9b0d392ea08090cd1780fb196f36dbb586529] Merge tag 'net-next-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 9ff9b0d392ea08090cd1780fb196f36dbb586529 with gcc (GCC) 8.1.0 kernel signature: 46c3264ef9a00dba7f4234a486fdf9f64f6b311d74be86a9735378b81a1a5699 run #0: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #2: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor150963167" "root@10.128.15.197:./syz-executor150963167"]: exit status 1 ssh: connect to host 10.128.15.197 port 22: Connection timed out lost connection run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 9ff9b0d392ea08090cd1780fb196f36dbb586529 Bisecting: 554 revisions left to test after this (roughly 9 steps) [847d4287a0c6709fd1ce24002b96d404a6da8b5b] Merge tag 's390-5.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux testing commit 847d4287a0c6709fd1ce24002b96d404a6da8b5b with gcc (GCC) 8.1.0 kernel signature: 42ce29bf87ccae9df0b7be5c51837ef1b21ab662f5d26770118e05aaa408e3ba run #0: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #1: crashed: WARNING: ODEBUG bug in __do_softirq run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #3: crashed: no output from test machine run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 847d4287a0c6709fd1ce24002b96d404a6da8b5b Bisecting: 279 revisions left to test after this (roughly 8 steps) [5a77b6a0131f7197e1a037f65fc7cbabcb4fe680] Merge tag 'thermal-v5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux testing commit 5a77b6a0131f7197e1a037f65fc7cbabcb4fe680 with gcc (GCC) 8.1.0 kernel signature: 41281eb7172921fb3f28a16a5d8ef9c0d47d26b3a067f3f278f1e721fc67603d all runs: OK # git bisect bad 5a77b6a0131f7197e1a037f65fc7cbabcb4fe680 Bisecting: 168 revisions left to test after this (roughly 7 steps) [93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e] Merge tag 'trace-v5.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace testing commit 93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e with gcc (GCC) 8.1.0 kernel signature: 3d7cf95214d42c62ea79951ab1dc189d054e813507721d6af8fcc441da761cdd run #0: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e Bisecting: 92 revisions left to test after this (roughly 6 steps) [54a4c789ca8091ab8fcd70285caeee2c5bc62997] Merge tag 'docs/v5.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media testing commit 54a4c789ca8091ab8fcd70285caeee2c5bc62997 with gcc (GCC) 8.1.0 kernel signature: 18e741dcc3aab43b094a855648aa260650c177685a2da312220314d7d448bea2 run #0: crashed: WARNING: proc registration bug in afs_manage_cell run #1: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #2: crashed: WARNING in __proc_create run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 54a4c789ca8091ab8fcd70285caeee2c5bc62997 Bisecting: 46 revisions left to test after this (roughly 6 steps) [86f33603f8c51537265ff7ac0320638fd2cbdb1b] f2fs: handle errors of f2fs_get_meta_page_nofail testing commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b with gcc (GCC) 8.1.0 kernel signature: 6d1cac24c238196057321b68585febed6d33acac6addda8b97baf2ed6ac3e6a3 run #0: crashed: general protection fault in afs_proc_cell_setup run #1: crashed: general protection fault in afs_proc_cell_remove run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 86f33603f8c51537265ff7ac0320638fd2cbdb1b Bisecting: 19 revisions left to test after this (roughly 5 steps) [071a0578b0ce0b0e543d1e38ee6926b9cc21c198] Merge tag 'ovl-update-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs testing commit 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 with gcc (GCC) 8.1.0 kernel signature: 9f2481235104bfa0ab55e71ab370eda630a3a93861abc718c363d4c9d7799e62 all runs: OK # git bisect bad 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 Bisecting: 13 revisions left to test after this (roughly 4 steps) [fad70111d57e0b728b587eabc6f9f9b5240faa17] Merge tag 'afs-fixes-20201016' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs testing commit fad70111d57e0b728b587eabc6f9f9b5240faa17 with gcc (GCC) 8.1.0 kernel signature: c923124facd850e8fa9c8ef3059d3434070a2b27f88946c810ef39f90908fcb5 all runs: OK # git bisect bad fad70111d57e0b728b587eabc6f9f9b5240faa17 Bisecting: 6 revisions left to test after this (roughly 3 steps) [7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8] afs: Don't assert on unpurgeable server records testing commit 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8 with gcc (GCC) 8.1.0 kernel signature: 5bb50d298fb701d2410ffec46937ce4fedcf0aca584cb46e66e345c082f71aaf all runs: OK # git bisect bad 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8 Bisecting: 2 revisions left to test after this (roughly 2 steps) [286377f6bdf71568a4cf07104fe44006ae0dba6d] afs: Fix cell purging with aliases testing commit 286377f6bdf71568a4cf07104fe44006ae0dba6d with gcc (GCC) 8.1.0 kernel signature: 1f502faebe6bd87448667a22d13a7c816d9320f87ad1e74bbee269c0c2f91d83 run #0: crashed: WARNING: proc registration bug in afs_manage_cell_work run #1: crashed: INFO: task hung in synchronize_rcu run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 286377f6bdf71568a4cf07104fe44006ae0dba6d Bisecting: 0 revisions left to test after this (roughly 1 step) [dca54a7bbb8ca9148ae10d60c66c926e222a9c4b] afs: Add tracing for cell refcount and active user count testing commit dca54a7bbb8ca9148ae10d60c66c926e222a9c4b with gcc (GCC) 8.1.0 kernel signature: cacfd3d721b5e4d93d28e7ded926110d1ca1d138e321e2bb8fb234b4722abc22 all runs: OK # git bisect bad dca54a7bbb8ca9148ae10d60c66c926e222a9c4b Bisecting: 0 revisions left to test after this (roughly 0 steps) [1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6] afs: Fix cell removal testing commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 with gcc (GCC) 8.1.0 kernel signature: 27fcc1fbbf549525b2dcf49efc6205ff41566b2b3cbc5cc5293d6cc87e748359 all runs: OK # git bisect bad 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 is the first bad commit commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 Author: David Howells Date: Fri Oct 16 13:21:14 2020 +0100 afs: Fix cell removal Fix cell removal by inserting a more final state than AFS_CELL_FAILED that indicates that the cell has been unpublished in case the manager is already requeued and will go through again. The new AFS_CELL_REMOVED state will just immediately leave the manager function. Going through a second time in the AFS_CELL_FAILED state will cause it to try to remove the cell again, potentially leading to the proc list being removed. Fixes: 989782dcdc91 ("afs: Overhaul cell database management") Reported-by: syzbot+b994ecf2b023f14832c1@syzkaller.appspotmail.com Reported-by: syzbot+0e0db88e1eb44a91ae8d@syzkaller.appspotmail.com Reported-by: syzbot+2d0585e5efcd43d113c2@syzkaller.appspotmail.com Reported-by: syzbot+1ecc2f9d3387f1d79d42@syzkaller.appspotmail.com Reported-by: syzbot+18d51774588492bf3f69@syzkaller.appspotmail.com Reported-by: syzbot+a5e4946b04d6ca8fa5f3@syzkaller.appspotmail.com Suggested-by: Hillf Danton Signed-off-by: David Howells cc: Hillf Danton fs/afs/cell.c | 16 ++++++++++------ fs/afs/internal.h | 1 + 2 files changed, 11 insertions(+), 6 deletions(-) culprit signature: 27fcc1fbbf549525b2dcf49efc6205ff41566b2b3cbc5cc5293d6cc87e748359 parent signature: 1f502faebe6bd87448667a22d13a7c816d9320f87ad1e74bbee269c0c2f91d83 revisions tested: 17, total time: 4h19m36.206913805s (build: 1h20m1.372470242s, test: 2h57m49.121598042s) first good commit: 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 afs: Fix cell removal recipients (to): ["dhowells@redhat.com" "dhowells@redhat.com" "linux-afs@lists.infradead.org"] recipients (cc): ["linux-kernel@vger.kernel.org"]