bisecting fixing commit since fb0155a09b0224a7147cb07a4ce6034c8d29667f building syzkaller on 1b88c6d5c8477f1d4fb3b389443b200acc32e9a8 testing commit fb0155a09b0224a7147cb07a4ce6034c8d29667f with gcc (GCC) 8.1.0 kernel signature: 11c2edb6d0b21ae177e544419404d48ed572eea722b27fb78dddce8c493939d6 run #0: crashed: WARNING in __xlate_proc_name run #1: crashed: general protection fault in afs_proc_cell_setup run #2: crashed: WARNING: ODEBUG bug in __do_softirq run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #4: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #5: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #6: crashed: WARNING: ODEBUG bug in __do_softirq run #7: crashed: WARNING in __xlate_proc_name run #8: crashed: BUG: unable to handle kernel paging request in afs_proc_cell_remove run #9: crashed: WARNING: proc registration bug in afs_manage_cell testing current HEAD b9c0f4bd5b8114ee1773734e07cda921b6e8248b testing commit b9c0f4bd5b8114ee1773734e07cda921b6e8248b with gcc (GCC) 8.1.0 kernel signature: 70cb7bba62dc4bbd63a8e0a1574e80452a01aa7ffedc9e431f1ea5ca1142e6b5 all runs: OK # git bisect start b9c0f4bd5b8114ee1773734e07cda921b6e8248b fb0155a09b0224a7147cb07a4ce6034c8d29667f Bisecting: 7371 revisions left to test after this (roughly 13 steps) [c48b75b7271db23c1b2d1204d6e8496d91f27711] Merge tag 'sound-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound testing commit c48b75b7271db23c1b2d1204d6e8496d91f27711 with gcc (GCC) 8.1.0 kernel signature: b974ef13095fd786e6ba64c7c9ddbae41bdc5fec1edd9325a771da3e108845f2 run #0: crashed: general protection fault in afs_proc_cell_setup run #1: crashed: WARNING in __proc_create run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_proc_cell_setup run #3: crashed: BUG: unable to handle kernel paging request in afs_proc_cell_setup run #4: crashed: WARNING: proc registration bug in afs_manage_cell run #5: crashed: no output from test machine run #6: crashed: no output from test machine run #7: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor680814871" "root@10.128.15.198:./syz-executor680814871"]: exit status 1 ssh: connect to host 10.128.15.198 port 22: Connection timed out lost connection run #8: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor345072522" "root@10.128.0.121:./syz-executor345072522"]: exit status 1 ssh: connect to host 10.128.0.121 port 22: Connection timed out lost connection run #9: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor366224225" "root@10.128.15.207:./syz-executor366224225"]: exit status 1 ssh: connect to host 10.128.15.207 port 22: Connection timed out lost connection # git bisect good c48b75b7271db23c1b2d1204d6e8496d91f27711 Bisecting: 3724 revisions left to test after this (roughly 12 steps) [847d4287a0c6709fd1ce24002b96d404a6da8b5b] Merge tag 's390-5.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux testing commit 847d4287a0c6709fd1ce24002b96d404a6da8b5b with gcc (GCC) 8.1.0 kernel signature: 6fe4d59b48e4cf2008783299af94fa89cdae8b36bf869a71825d80b0f66e95be run #0: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #1: crashed: WARNING: proc registration bug in afs_manage_cell run #2: crashed: WARNING: ODEBUG bug in __do_softirq run #3: crashed: WARNING: ODEBUG bug in __do_softirq run #4: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #5: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #6: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor735055931" "root@10.128.0.9:./syz-executor735055931"]: exit status 1 ssh: connect to host 10.128.0.9 port 22: Connection timed out lost connection run #7: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor977473118" "root@10.128.15.200:./syz-executor977473118"]: exit status 1 ssh: connect to host 10.128.15.200 port 22: Connection timed out lost connection run #8: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor354637861" "root@10.128.15.201:./syz-executor354637861"]: exit status 1 ssh: connect to host 10.128.15.201 port 22: Connection timed out lost connection run #9: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor833856320" "root@10.128.10.0:./syz-executor833856320"]: exit status 1 ssh: connect to host 10.128.10.0 port 22: Connection timed out lost connection # git bisect good 847d4287a0c6709fd1ce24002b96d404a6da8b5b Bisecting: 1846 revisions left to test after this (roughly 11 steps) [746b25b1aa0f5736d585728ded70a8141da91edb] Merge tag 'kbuild-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild testing commit 746b25b1aa0f5736d585728ded70a8141da91edb with gcc (GCC) 8.1.0 kernel signature: dff58129603d39d675344c2f40db0eb24efbb58800bb1fbe8e9159550b93f8f3 all runs: OK # git bisect bad 746b25b1aa0f5736d585728ded70a8141da91edb Bisecting: 942 revisions left to test after this (roughly 10 steps) [d3876ff74437c5f3a1a2f8d2a45b6fb91d51ea25] Merge tag 'm68knommu-for-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu testing commit d3876ff74437c5f3a1a2f8d2a45b6fb91d51ea25 with gcc (GCC) 8.1.0 kernel signature: 531afa9baea96935f0acdeef969612a27540216176a509b220ef1b40d96d721b all runs: OK # git bisect bad d3876ff74437c5f3a1a2f8d2a45b6fb91d51ea25 Bisecting: 379 revisions left to test after this (roughly 9 steps) [a1e16bc7d5f7ca3599d8a7f061841c93a563665e] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma testing commit a1e16bc7d5f7ca3599d8a7f061841c93a563665e with gcc (GCC) 8.1.0 kernel signature: a8fdf6695a66f72cfd4225950bf035cd9d3dd4a147eefa2a8324f68a80f957d2 all runs: OK # git bisect bad a1e16bc7d5f7ca3599d8a7f061841c93a563665e Bisecting: 279 revisions left to test after this (roughly 8 steps) [5a77b6a0131f7197e1a037f65fc7cbabcb4fe680] Merge tag 'thermal-v5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux testing commit 5a77b6a0131f7197e1a037f65fc7cbabcb4fe680 with gcc (GCC) 8.1.0 kernel signature: f9ca8576e1411f8fcb900d2df141e513690ceb298856b8f4245223ef9f74450c all runs: OK # git bisect bad 5a77b6a0131f7197e1a037f65fc7cbabcb4fe680 Bisecting: 168 revisions left to test after this (roughly 7 steps) [93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e] Merge tag 'trace-v5.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace testing commit 93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e with gcc (GCC) 8.1.0 kernel signature: f6786e1caf25dfd2f5bca0b7ffc12e4720153c792fe9c989768cd35d328141a7 run #0: crashed: WARNING: ODEBUG bug in __do_softirq run #1: crashed: WARNING: proc registration bug in afs_manage_cell run #2: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #4: crashed: WARNING: ODEBUG bug in __do_softirq run #5: crashed: WARNING: proc registration bug in afs_manage_cell run #6: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_request_key run #7: OK run #8: OK run #9: OK # git bisect good 93f3d8f54a22eaa5ae4ec269615729c4f9b1cf1e Bisecting: 92 revisions left to test after this (roughly 6 steps) [54a4c789ca8091ab8fcd70285caeee2c5bc62997] Merge tag 'docs/v5.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media testing commit 54a4c789ca8091ab8fcd70285caeee2c5bc62997 with gcc (GCC) 8.1.0 kernel signature: 834a16c5a922f2a9204e2241b78880ea44b3b1e22d684c3e86c45d534d5060b7 run #0: crashed: general protection fault in afs_proc_cell_setup run #1: crashed: WARNING: ODEBUG bug in __do_softirq run #2: crashed: BUG: unable to handle kernel paging request in afs_proc_cell_setup run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #4: crashed: general protection fault in afs_proc_cell_setup run #5: crashed: general protection fault in afs_proc_cell_setup run #6: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #7: crashed: WARNING: ODEBUG bug in __do_softirq run #8: crashed: WARNING: ODEBUG bug in __do_softirq run #9: crashed: WARNING: proc registration bug in afs_manage_cell # git bisect good 54a4c789ca8091ab8fcd70285caeee2c5bc62997 Bisecting: 46 revisions left to test after this (roughly 6 steps) [86f33603f8c51537265ff7ac0320638fd2cbdb1b] f2fs: handle errors of f2fs_get_meta_page_nofail testing commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b with gcc (GCC) 8.1.0 kernel signature: a9e1a9d463b10b5c0d48c3f40e95b00c2d291012521a9637e4f17af4b0573c07 run #0: crashed: WARNING: proc registration bug in afs_manage_cell run #1: crashed: WARNING: ODEBUG bug in __do_softirq run #2: crashed: WARNING: ODEBUG bug in __do_softirq run #3: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_manage_cell run #4: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_deactivate_cell run #5: crashed: WARNING: ODEBUG bug in __do_softirq run #6: crashed: BUG: unable to handle kernel NULL pointer dereference in afs_alloc_anon_key run #7: crashed: WARNING in __xlate_proc_name run #8: OK run #9: OK # git bisect good 86f33603f8c51537265ff7ac0320638fd2cbdb1b Bisecting: 19 revisions left to test after this (roughly 5 steps) [071a0578b0ce0b0e543d1e38ee6926b9cc21c198] Merge tag 'ovl-update-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs testing commit 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 with gcc (GCC) 8.1.0 kernel signature: c1e9c0621e1a74bdffe448bfd280787802c8ffbec37feeffaa2c683685bc6f62 all runs: OK # git bisect bad 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 Bisecting: 13 revisions left to test after this (roughly 4 steps) [fad70111d57e0b728b587eabc6f9f9b5240faa17] Merge tag 'afs-fixes-20201016' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs testing commit fad70111d57e0b728b587eabc6f9f9b5240faa17 with gcc (GCC) 8.1.0 kernel signature: eb8642d679daaf3a281aeb0db6c2bb006624b2a6daccee13af6a545918ec94e1 all runs: OK # git bisect bad fad70111d57e0b728b587eabc6f9f9b5240faa17 Bisecting: 6 revisions left to test after this (roughly 3 steps) [7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8] afs: Don't assert on unpurgeable server records testing commit 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8 with gcc (GCC) 8.1.0 kernel signature: 39913bd736b672b915c9563cfb348330db5c36235ca019d2b80fd13f521c78e1 all runs: OK # git bisect bad 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8 Bisecting: 2 revisions left to test after this (roughly 2 steps) [286377f6bdf71568a4cf07104fe44006ae0dba6d] afs: Fix cell purging with aliases testing commit 286377f6bdf71568a4cf07104fe44006ae0dba6d with gcc (GCC) 8.1.0 kernel signature: 8e622acbaeb3fcb49cafa78f52b40607d625ee8da97c8ea682602faf09a8adac run #0: crashed: WARNING: proc registration bug in afs_manage_cell_work run #1: crashed: WARNING: proc registration bug in afs_manage_cell_work run #2: crashed: INFO: task hung in synchronize_rcu run #3: crashed: WARNING: proc registration bug in afs_manage_cell_work run #4: crashed: BUG: workqueue lockup run #5: crashed: INFO: task hung in afs_lookup_cell run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 286377f6bdf71568a4cf07104fe44006ae0dba6d Bisecting: 0 revisions left to test after this (roughly 1 step) [dca54a7bbb8ca9148ae10d60c66c926e222a9c4b] afs: Add tracing for cell refcount and active user count testing commit dca54a7bbb8ca9148ae10d60c66c926e222a9c4b with gcc (GCC) 8.1.0 kernel signature: f9d14909555f6d1f4b4f30072bbc9595dad68bfab52213f9bc7c4f5a96b17aae all runs: OK # git bisect bad dca54a7bbb8ca9148ae10d60c66c926e222a9c4b Bisecting: 0 revisions left to test after this (roughly 0 steps) [1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6] afs: Fix cell removal testing commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 with gcc (GCC) 8.1.0 kernel signature: ec108f117e101c3d37d585e43bb3169898d06f9dfd11f70e10fc35472cc7d311 all runs: OK # git bisect bad 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 is the first bad commit commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 Author: David Howells Date: Fri Oct 16 13:21:14 2020 +0100 afs: Fix cell removal Fix cell removal by inserting a more final state than AFS_CELL_FAILED that indicates that the cell has been unpublished in case the manager is already requeued and will go through again. The new AFS_CELL_REMOVED state will just immediately leave the manager function. Going through a second time in the AFS_CELL_FAILED state will cause it to try to remove the cell again, potentially leading to the proc list being removed. Fixes: 989782dcdc91 ("afs: Overhaul cell database management") Reported-by: syzbot+b994ecf2b023f14832c1@syzkaller.appspotmail.com Reported-by: syzbot+0e0db88e1eb44a91ae8d@syzkaller.appspotmail.com Reported-by: syzbot+2d0585e5efcd43d113c2@syzkaller.appspotmail.com Reported-by: syzbot+1ecc2f9d3387f1d79d42@syzkaller.appspotmail.com Reported-by: syzbot+18d51774588492bf3f69@syzkaller.appspotmail.com Reported-by: syzbot+a5e4946b04d6ca8fa5f3@syzkaller.appspotmail.com Suggested-by: Hillf Danton Signed-off-by: David Howells cc: Hillf Danton fs/afs/cell.c | 16 ++++++++++------ fs/afs/internal.h | 1 + 2 files changed, 11 insertions(+), 6 deletions(-) culprit signature: ec108f117e101c3d37d585e43bb3169898d06f9dfd11f70e10fc35472cc7d311 parent signature: 8e622acbaeb3fcb49cafa78f52b40607d625ee8da97c8ea682602faf09a8adac revisions tested: 17, total time: 4h31m21.447387097s (build: 1h35m43.731416349s, test: 2h53m0.84824225s) first good commit: 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 afs: Fix cell removal recipients (to): ["dhowells@redhat.com" "dhowells@redhat.com" "linux-afs@lists.infradead.org"] recipients (cc): ["linux-kernel@vger.kernel.org"]