bisecting fixing commit since 252c765bd764a246a8bd516fabf6d6123df4a24f building syzkaller on be531bb42381b245eed805e49fd889d1c2118c76 testing commit 252c765bd764a246a8bd516fabf6d6123df4a24f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 543ba0a1ebee28ece5036b149a6ff8a18c85fa8e823417cf34eb13c1e489857f run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: BUG: corrupted list in netif_napi_add run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: crashed: WARNING in bpf_warn_invalid_xdp_action run #10: crashed: WARNING in bpf_warn_invalid_xdp_action run #11: crashed: WARNING in bpf_warn_invalid_xdp_action run #12: crashed: BUG: corrupted list in netif_napi_add run #13: crashed: WARNING in bpf_warn_invalid_xdp_action run #14: crashed: WARNING in bpf_warn_invalid_xdp_action run #15: crashed: WARNING in bpf_warn_invalid_xdp_action run #16: crashed: WARNING in bpf_warn_invalid_xdp_action run #17: crashed: WARNING in bpf_warn_invalid_xdp_action run #18: crashed: WARNING in bpf_warn_invalid_xdp_action run #19: crashed: BUG: corrupted list in netif_napi_add testing current HEAD 775a64e3845c20a2d83a9855767e5e93d291fe9d testing commit 775a64e3845c20a2d83a9855767e5e93d291fe9d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a96e4c46ebf27237fd5532637b40828de11b342ae9f22c457619498d291897a5 all runs: OK # git bisect start 775a64e3845c20a2d83a9855767e5e93d291fe9d 252c765bd764a246a8bd516fabf6d6123df4a24f Bisecting: 8923 revisions left to test after this (roughly 13 steps) [d461e96cd22b5aeb1df448536b92e8d8e88c4a05] Merge tag 'drivers-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc testing commit d461e96cd22b5aeb1df448536b92e8d8e88c4a05 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: cd912c415fa9e31a7c929ec985a7eacfa11751bc8b930eccc21fabd04ae6d86d run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: BUG: corrupted list in netif_napi_add run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: crashed: BUG: corrupted list in netif_napi_add # git bisect good d461e96cd22b5aeb1df448536b92e8d8e88c4a05 Bisecting: 4463 revisions left to test after this (roughly 12 steps) [02ccdd9ddc106ad8054c40340bbd66ad2c61530b] Merge branch 'xilinx-phylink' testing commit 02ccdd9ddc106ad8054c40340bbd66ad2c61530b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c49197ff1d9d85da1f21947e6debc3e6423e73a2b1d546fe4e8ee9c9772ded72 run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: OK # git bisect good 02ccdd9ddc106ad8054c40340bbd66ad2c61530b Bisecting: 2232 revisions left to test after this (roughly 11 steps) [e37e7b0b3bd52ec4f8ab71b027bcec08f57f1b3b] mm, hwpoison: fix condition in free hugetlb page path testing commit e37e7b0b3bd52ec4f8ab71b027bcec08f57f1b3b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0320c2209e95e6009a3624d5beae7f1b24323a925a6bf21189f59666d13cd479 all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good e37e7b0b3bd52ec4f8ab71b027bcec08f57f1b3b Bisecting: 1103 revisions left to test after this (roughly 10 steps) [f75c1d55ecbadce027fd650d3ca79e357afae0d9] Merge tag 'wireless-drivers-next-2021-12-17' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next testing commit f75c1d55ecbadce027fd650d3ca79e357afae0d9 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 03c9b6907313e885da2a66557e74c01a9f0db2949697139ddc11cb3d39c5d980 all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good f75c1d55ecbadce027fd650d3ca79e357afae0d9 Bisecting: 629 revisions left to test after this (roughly 9 steps) [49dc9013e34b205bae9d7a5f365a3da33c508c9d] net/smc: Use the bitmap API when applicable testing commit 49dc9013e34b205bae9d7a5f365a3da33c508c9d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 309024e6ebcb9ed3768885016749c2600b976dfe8d37c38fa6fefd2014eb77d2 all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good 49dc9013e34b205bae9d7a5f365a3da33c508c9d Bisecting: 314 revisions left to test after this (roughly 8 steps) [3d694552fd8fe502e7ffd22ffa0e085bfd73b19a] net: vxge: Use dma_set_mask_and_coherent() and simplify code testing commit 3d694552fd8fe502e7ffd22ffa0e085bfd73b19a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 80bfa18d926a4913f386dad751121c72357ddd771cbba321845e07d8e0fe8e74 all runs: OK # git bisect bad 3d694552fd8fe502e7ffd22ffa0e085bfd73b19a Bisecting: 140 revisions left to test after this (roughly 7 steps) [74c78b4291b4466b44a57b3b7c3b98ad02628686] Merge tag 'net-5.16-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 74c78b4291b4466b44a57b3b7c3b98ad02628686 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d5aa56d5c9fbf827ef8f13a0288b16fb5237bc061834a312a00a17b3c95c7920 all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good 74c78b4291b4466b44a57b3b7c3b98ad02628686 Bisecting: 70 revisions left to test after this (roughly 6 steps) [0fe4b381a59ebc53522fce579b281a67a9e1bee6] bpf: Allow bpf_local_storage to be used by sleepable programs testing commit 0fe4b381a59ebc53522fce579b281a67a9e1bee6 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3774638c9838bc6c73482a5cd278e4133d96efbff41263300ed797331ead128d all runs: OK # git bisect bad 0fe4b381a59ebc53522fce579b281a67a9e1bee6 Bisecting: 34 revisions left to test after this (roughly 5 steps) [bdadbb44c90aedaa74d46f1b113bd845774efa39] bpftool: Enable cross-building with clang testing commit bdadbb44c90aedaa74d46f1b113bd845774efa39 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: aa78e5d987f1720b8096139e57784890f8ba179676020d848eeb18ede6590d1b all runs: OK # git bisect bad bdadbb44c90aedaa74d46f1b113bd845774efa39 Bisecting: 17 revisions left to test after this (roughly 4 steps) [2cbad989033bff0256675c38f96f5faab852af4b] bpf: Do not WARN in bpf_warn_invalid_xdp_action() testing commit 2cbad989033bff0256675c38f96f5faab852af4b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ba6baed737d6f2511c70c6f9d7fc7ddc76273e3dc306092cf1fb1102c6ff93c3 all runs: OK # git bisect bad 2cbad989033bff0256675c38f96f5faab852af4b Bisecting: 8 revisions left to test after this (roughly 3 steps) [f18a499799dd0f0fdd98cf72d98d3866ce9ac60e] bpf: Silence coverity false positive warning. testing commit f18a499799dd0f0fdd98cf72d98d3866ce9ac60e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8caad83939792c5310b84cfc0a3667e47ce5a6bfa90a4eefd0b3ad3a02c824c1 all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good f18a499799dd0f0fdd98cf72d98d3866ce9ac60e Bisecting: 4 revisions left to test after this (roughly 2 steps) [2b070c2bc885977ca8fe76ba8f6b9d73d8d20e39] selftests/bpf: Add test to access int ptr argument in tracing program testing commit 2b070c2bc885977ca8fe76ba8f6b9d73d8d20e39 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e2617ebd19997ae1845056112de992eaca9e704d736026c6e20980af0e590b5b all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good 2b070c2bc885977ca8fe76ba8f6b9d73d8d20e39 Bisecting: 2 revisions left to test after this (roughly 1 step) [f92c1e183604c20ce00eb889315fdaa8f2d9e509] bpf: Add get_func_[arg|ret|arg_cnt] helpers testing commit f92c1e183604c20ce00eb889315fdaa8f2d9e509 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 107c5695b1f453f8bc0ecbed1637a270594ffc3a20dceafedd2101937e76cedd all runs: crashed: WARNING in bpf_warn_invalid_xdp_action # git bisect good f92c1e183604c20ce00eb889315fdaa8f2d9e509 Bisecting: 0 revisions left to test after this (roughly 1 step) [e94fac3829ddd3d9f21efa27d1512215b630782c] Merge branch 'bpf: Add helpers to access traced function arguments' testing commit e94fac3829ddd3d9f21efa27d1512215b630782c compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 107c5695b1f453f8bc0ecbed1637a270594ffc3a20dceafedd2101937e76cedd run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: OK # git bisect good e94fac3829ddd3d9f21efa27d1512215b630782c 2cbad989033bff0256675c38f96f5faab852af4b is the first bad commit commit 2cbad989033bff0256675c38f96f5faab852af4b Author: Paolo Abeni Date: Tue Nov 30 11:08:06 2021 +0100 bpf: Do not WARN in bpf_warn_invalid_xdp_action() The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by any bugged program, and even attaching a correct program to a NIC not supporting the given action. The resulting splat, beyond polluting the logs, fouls automated tools: e.g. a syzkaller reproducers using an XDP program returning an unsupported action will never pass validation. Replace the WARN_ONCE with a less intrusive pr_warn_once(). Signed-off-by: Paolo Abeni Signed-off-by: Daniel Borkmann Acked-by: Toke Høiland-Jørgensen Link: https://lore.kernel.org/bpf/016ceec56e4817ebb2a9e35ce794d5c917df572c.1638189075.git.pabeni@redhat.com net/core/filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) culprit signature: ba6baed737d6f2511c70c6f9d7fc7ddc76273e3dc306092cf1fb1102c6ff93c3 parent signature: 107c5695b1f453f8bc0ecbed1637a270594ffc3a20dceafedd2101937e76cedd revisions tested: 16, total time: 3h53m34.393175043s (build: 1h45m2.289622635s, test: 2h6m56.173299794s) first good commit: 2cbad989033bff0256675c38f96f5faab852af4b bpf: Do not WARN in bpf_warn_invalid_xdp_action() recipients (to): ["daniel@iogearbox.net" "pabeni@redhat.com" "toke@redhat.com"] recipients (cc): []