bisecting fixing commit since 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 building syzkaller on 4afdfa205b55633e7eb9db03a9d099d7aa324801 testing commit 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 with gcc (GCC) 8.1.0 kernel signature: f0f7dd7ac17b53fe9b442c6d0b663b28a5cd7e636ffacba9626b64be42f4b813 run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in corrupted run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in inc_nlink run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in corrupted testing current HEAD 015e94d0e37b6860e4354ce3cac56bd7c39c8992 testing commit 015e94d0e37b6860e4354ce3cac56bd7c39c8992 with gcc (GCC) 8.1.0 kernel signature: a38aa1981e07dc75e53530c40731d3d57fbfa7c97b7f39f1821f48f3189593b6 all runs: OK # git bisect start 015e94d0e37b6860e4354ce3cac56bd7c39c8992 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 Bisecting: 952 revisions left to test after this (roughly 10 steps) [f2117df663af08bac57d44a1816429f6e9d723f4] iio:magnetometer:ak8974: Fix alignment and data leak issues testing commit f2117df663af08bac57d44a1816429f6e9d723f4 with gcc (GCC) 8.1.0 kernel signature: 5f1e6eab9cdf28d284f8e774335d539725d358713741766108462feafbf4c374 all runs: crashed: WARNING in inc_nlink # git bisect good f2117df663af08bac57d44a1816429f6e9d723f4 Bisecting: 476 revisions left to test after this (roughly 9 steps) [5052b997592af482f29c5441b8bc39831015818c] NFS: Don't return layout segments that are in use testing commit 5052b997592af482f29c5441b8bc39831015818c with gcc (GCC) 8.1.0 kernel signature: 803da685442fdd5fdd6efab120960e4d043288d6782904406def50ef76d8e6b0 all runs: OK # git bisect bad 5052b997592af482f29c5441b8bc39831015818c Bisecting: 237 revisions left to test after this (roughly 8 steps) [3c1add359a3d30527f821729f4cfff591756c5d9] net: lan78xx: add missing endpoint sanity check testing commit 3c1add359a3d30527f821729f4cfff591756c5d9 with gcc (GCC) 8.1.0 kernel signature: 70536f4547c0a453e4e2dd42254cbece978af493ad273c3e2b9cb9d625105680 run #0: crashed: WARNING in corrupted run #1: crashed: WARNING in inc_nlink run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in corrupted run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in corrupted # git bisect good 3c1add359a3d30527f821729f4cfff591756c5d9 Bisecting: 118 revisions left to test after this (roughly 7 steps) [459863b756436b4f8f6bd806a38d09646e5b51f7] usb: mtu3: clear dual mode of u3port when disable device testing commit 459863b756436b4f8f6bd806a38d09646e5b51f7 with gcc (GCC) 8.1.0 kernel signature: f29a009a8c2836b509467ad7bf978d0f57310561e0c898e0948156f0de17d5e2 run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in inc_nlink run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in corrupted run #5: crashed: WARNING in corrupted run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in inc_nlink # git bisect good 459863b756436b4f8f6bd806a38d09646e5b51f7 Bisecting: 59 revisions left to test after this (roughly 6 steps) [fa7fd9ba18533e9aa5f718a06de3deb522a4b587] usb: dwc2: Fix error path in gadget registration testing commit fa7fd9ba18533e9aa5f718a06de3deb522a4b587 with gcc (GCC) 8.1.0 kernel signature: 55f3d150e54f93c2850a34df51f80b25c9446ea751901b02305e06f02e35471c run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in corrupted run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in corrupted run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in inc_nlink run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in inc_nlink # git bisect good fa7fd9ba18533e9aa5f718a06de3deb522a4b587 Bisecting: 29 revisions left to test after this (roughly 5 steps) [8bf3b460bf2fa14bb3e78b46594d0d52de366da9] pinctrl-single: fix pcs_parse_pinconf() return value testing commit 8bf3b460bf2fa14bb3e78b46594d0d52de366da9 with gcc (GCC) 8.1.0 kernel signature: a60b7ec0c26433f8c66e54f2b6506fa89d97a8a0bfaab0b3bd19c3fd2b70d088 all runs: crashed: WARNING in inc_nlink # git bisect good 8bf3b460bf2fa14bb3e78b46594d0d52de366da9 Bisecting: 14 revisions left to test after this (roughly 4 steps) [7f496a7224b1a70a07ed7ed0d5b329980730816e] ALSA: usb-audio: fix overeager device match for MacroSilicon MS2109 testing commit 7f496a7224b1a70a07ed7ed0d5b329980730816e with gcc (GCC) 8.1.0 kernel signature: 2b4514c5db11d6e004c2f2ffb228fc01e9fca84817121907a70dc4a33aa58969 run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in inc_nlink run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in corrupted run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in corrupted # git bisect good 7f496a7224b1a70a07ed7ed0d5b329980730816e Bisecting: 7 revisions left to test after this (roughly 3 steps) [2824988a204adf11c1d646a8ef4d192a2d30cff2] bitfield.h: don't compile-time validate _val in FIELD_FIT testing commit 2824988a204adf11c1d646a8ef4d192a2d30cff2 with gcc (GCC) 8.1.0 kernel signature: a3fdd437e0da41514a7c48133b295563a74f988d6558b39ede133dd9dcb6335d run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in inc_nlink run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in inc_nlink run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in corrupted # git bisect good 2824988a204adf11c1d646a8ef4d192a2d30cff2 Bisecting: 3 revisions left to test after this (roughly 2 steps) [d22c224704b720887e3fad683281a2cf97b679ea] ALSA: usb-audio: add quirk for Pioneer DDJ-RB testing commit d22c224704b720887e3fad683281a2cf97b679ea with gcc (GCC) 8.1.0 kernel signature: 6a2b6f79dcda872302898753756bbfb9ee256a29301bc89696c852e11c0d7df7 all runs: OK # git bisect bad d22c224704b720887e3fad683281a2cf97b679ea Bisecting: 1 revision left to test after this (roughly 1 step) [169f7f37bd6b0bb91242099cc261219791067d5c] fs/minix: don't allow getting deleted inodes testing commit 169f7f37bd6b0bb91242099cc261219791067d5c with gcc (GCC) 8.1.0 kernel signature: 200c42f582a2f05f7f6445395f67250a928a4697c5d3ca67dd0a1eb2ee64db86 all runs: OK # git bisect bad 169f7f37bd6b0bb91242099cc261219791067d5c Bisecting: 0 revisions left to test after this (roughly 0 steps) [b846b77fba7b62246a6538618498bf13f5c148a7] fs/minix: check return value of sb_getblk() testing commit b846b77fba7b62246a6538618498bf13f5c148a7 with gcc (GCC) 8.1.0 kernel signature: 647b16d09e32e1d95b220739cba875f7e152c17894b37306596b6d959a0b5a34 run #0: crashed: WARNING in inc_nlink run #1: crashed: WARNING in inc_nlink run #2: crashed: WARNING in inc_nlink run #3: crashed: WARNING in inc_nlink run #4: crashed: WARNING in inc_nlink run #5: crashed: WARNING in inc_nlink run #6: crashed: WARNING in inc_nlink run #7: crashed: WARNING in inc_nlink run #8: crashed: WARNING in inc_nlink run #9: crashed: WARNING in corrupted # git bisect good b846b77fba7b62246a6538618498bf13f5c148a7 169f7f37bd6b0bb91242099cc261219791067d5c is the first bad commit commit 169f7f37bd6b0bb91242099cc261219791067d5c Author: Eric Biggers Date: Tue Aug 11 18:35:27 2020 -0700 fs/minix: don't allow getting deleted inodes commit facb03dddec04e4aac1bb2139accdceb04deb1f3 upstream. If an inode has no links, we need to mark it bad rather than allowing it to be accessed. This avoids WARNINGs in inc_nlink() and drop_nlink() when doing directory operations on a fuzzed filesystem. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+a9ac3de1b5de5fb10efc@syzkaller.appspotmail.com Reported-by: syzbot+df958cf5688a96ad3287@syzkaller.appspotmail.com Signed-off-by: Eric Biggers Signed-off-by: Andrew Morton Cc: Alexander Viro Cc: Qiujun Huang Cc: Link: http://lkml.kernel.org/r/20200628060846.682158-3-ebiggers@kernel.org Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman fs/minix/inode.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) culprit signature: 200c42f582a2f05f7f6445395f67250a928a4697c5d3ca67dd0a1eb2ee64db86 parent signature: 647b16d09e32e1d95b220739cba875f7e152c17894b37306596b6d959a0b5a34 revisions tested: 13, total time: 2h57m10.546676894s (build: 1h50m5.028718726s, test: 1h5m50.534935175s) first good commit: 169f7f37bd6b0bb91242099cc261219791067d5c fs/minix: don't allow getting deleted inodes recipients (to): ["akpm@linux-foundation.org" "ebiggers@google.com" "gregkh@linuxfoundation.org" "torvalds@linux-foundation.org"] recipients (cc): []