bisecting fixing commit since 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb building syzkaller on a52ee10ae11c1342cfca60cf3957619bcf92bd1a testing commit 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb with gcc (GCC) 10.2.1 20210217 kernel signature: 617617e52d0be0b8aab50dc87eec954323d69788665a7cc31353af8ab31bd380 run #0: crashed: INFO: task hung in addrconf_dad_work run #1: crashed: INFO: task hung in addrconf_dad_work run #2: crashed: INFO: task hung in cfg80211_event_work run #3: crashed: INFO: task hung in addrconf_dad_work run #4: crashed: INFO: task hung in addrconf_dad_work run #5: crashed: INFO: task hung in addrconf_dad_work run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in linkwatch_event run #8: crashed: INFO: task hung in addrconf_dad_work run #9: crashed: INFO: task hung in cfg80211_event_work run #10: crashed: INFO: task hung in linkwatch_event run #11: crashed: INFO: task hung in linkwatch_event run #12: crashed: INFO: task hung in cfg80211_event_work run #13: crashed: INFO: task hung in addrconf_dad_work run #14: crashed: INFO: task hung in addrconf_dad_work run #15: crashed: INFO: task hung in addrconf_dad_work run #16: crashed: INFO: task hung in addrconf_dad_work run #17: crashed: INFO: task hung in tcindex_partial_destroy_work run #18: crashed: INFO: task hung in tcindex_partial_destroy_work run #19: crashed: INFO: task hung in tcindex_partial_destroy_work testing current HEAD f296bfd5cd04cbb49b8fc9585adc280ab2b58624 testing commit f296bfd5cd04cbb49b8fc9585adc280ab2b58624 with gcc (GCC) 10.2.1 20210217 kernel signature: 92d9d56899f7ad3da70f92a3f4ba7cf5d12ae46b166c96cdac4b7bd7e1300032 all runs: OK # git bisect start f296bfd5cd04cbb49b8fc9585adc280ab2b58624 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb Bisecting: 6541 revisions left to test after this (roughly 13 steps) [a864e8f159b13babf552aff14a5fbe11abc017e4] ALSA: hda: intel-nhlt: verify config type testing commit a864e8f159b13babf552aff14a5fbe11abc017e4 with gcc (GCC) 10.2.1 20210217 kernel signature: 3eaeb43200219d673d614bd452339463a119e26c84590d095a9db6c4710107ca all runs: OK # git bisect bad a864e8f159b13babf552aff14a5fbe11abc017e4 Bisecting: 2986 revisions left to test after this (roughly 12 steps) [3342ff2698e9720f4040cc458a2744b2b32f5c3a] tty: protect tty_write from odd low-level tty disciplines testing commit 3342ff2698e9720f4040cc458a2744b2b32f5c3a with gcc (GCC) 10.2.1 20210217 kernel signature: f8c26f53cf6b2eee46d354fd2313cb6f5de2f5596c17cb59802717c5bfa7f3e3 all runs: OK # git bisect bad 3342ff2698e9720f4040cc458a2744b2b32f5c3a Bisecting: 1390 revisions left to test after this (roughly 11 steps) [79201f358d64f3af5cc8a2bf01bde9dbe59b618e] Merge tag 'wireless-drivers-next-2021-02-12' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next testing commit 79201f358d64f3af5cc8a2bf01bde9dbe59b618e with gcc (GCC) 10.2.1 20210217 kernel signature: 22da39bf716f1f47afc8e2bfff49083e3d15af51c6605516aeb5d0b2adfff707 run #0: crashed: INFO: task hung in tcindex_partial_destroy_work run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in linkwatch_event run #3: crashed: INFO: task hung in tcindex_partial_destroy_work run #4: crashed: INFO: task hung in tcindex_partial_destroy_work run #5: crashed: INFO: task hung in linkwatch_event run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in tcindex_partial_destroy_work run #8: crashed: INFO: task hung in addrconf_dad_work run #9: crashed: INFO: task hung in tcindex_partial_destroy_work # git bisect good 79201f358d64f3af5cc8a2bf01bde9dbe59b618e Bisecting: 762 revisions left to test after this (roughly 10 steps) [14bd96946377148cb6e7dd7ce55ecc5128a92d7b] ARM: dts: aspeed: align GPIO hog names with dtschema testing commit 14bd96946377148cb6e7dd7ce55ecc5128a92d7b with gcc (GCC) 10.2.1 20210217 kernel signature: aa72b591125a57ee62243771eededa059fb6f20851d9ee629c294009979444cd run #0: crashed: INFO: task hung in addrconf_dad_work run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in addrconf_dad_work run #3: crashed: INFO: task hung in cfg80211_event_work run #4: crashed: INFO: task hung in tcindex_partial_destroy_work run #5: crashed: INFO: task hung in tcindex_partial_destroy_work run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in cfg80211_event_work run #8: crashed: INFO: task hung in addrconf_dad_work run #9: crashed: INFO: task hung in addrconf_dad_work # git bisect good 14bd96946377148cb6e7dd7ce55ecc5128a92d7b Bisecting: 381 revisions left to test after this (roughly 9 steps) [41f1a01bb6c678681147f52180a7c20b0e12e137] Merge branch 'ptp-ptp_clockmatrix-Fix-output-1-PPS-alignment' testing commit 41f1a01bb6c678681147f52180a7c20b0e12e137 with gcc (GCC) 10.2.1 20210217 kernel signature: 6e89069aa01b2f14a5e66e69586e9fd0c9ddf1cc9717ac4a4ce5a8985be2bdab all runs: OK # git bisect bad 41f1a01bb6c678681147f52180a7c20b0e12e137 Bisecting: 127 revisions left to test after this (roughly 8 steps) [b8af417e4d93caeefb89bbfbd56ec95dedd8dab5] Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next testing commit b8af417e4d93caeefb89bbfbd56ec95dedd8dab5 with gcc (GCC) 10.2.1 20210217 kernel signature: 1ffe99f660ed242e6e61419885593d04bb05f85babc52f8c93b585d51f000734 run #0: crashed: INFO: task hung in tcindex_partial_destroy_work run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in tcindex_partial_destroy_work run #3: crashed: INFO: task hung in tcindex_partial_destroy_work run #4: crashed: INFO: task hung in addrconf_dad_work run #5: crashed: INFO: task hung in addrconf_dad_work run #6: crashed: INFO: task hung in addrconf_dad_work run #7: crashed: INFO: task hung in linkwatch_event run #8: crashed: INFO: task hung in tcindex_partial_destroy_work run #9: crashed: INFO: task hung in tcindex_partial_destroy_work # git bisect good b8af417e4d93caeefb89bbfbd56ec95dedd8dab5 Bisecting: 68 revisions left to test after this (roughly 6 steps) [3af409ca278d4a8d50e91f9f7c4c33b175645cf3] net: enetc: fix destroyed phylink dereference during unbind testing commit 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 with gcc (GCC) 10.2.1 20210217 kernel signature: 7076010c455844a009be4fec7ef8374578efa5fadb7a42c643ad92637c3bff61 all runs: OK # git bisect bad 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 Bisecting: 29 revisions left to test after this (roughly 5 steps) [c70f8597fcc1399ef6d5b5ce648a31d887d5dba2] net/mlx5: Disallow RoCE on multi port slave device testing commit c70f8597fcc1399ef6d5b5ce648a31d887d5dba2 with gcc (GCC) 10.2.1 20210217 kernel signature: 5f6ccfb9a8d9afa46a16ce1037e0f40faaf8bfde0edf74e4002a8dfa7297b8a4 run #0: crashed: INFO: task hung in tcindex_partial_destroy_work run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in addrconf_dad_work run #3: crashed: INFO: task hung in addrconf_dad_work run #4: crashed: INFO: task hung in linkwatch_event run #5: crashed: INFO: task hung in addrconf_dad_work run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in linkwatch_event run #8: crashed: INFO: task hung in tcindex_partial_destroy_work run #9: crashed: INFO: task hung in tcindex_partial_destroy_work # git bisect good c70f8597fcc1399ef6d5b5ce648a31d887d5dba2 Bisecting: 14 revisions left to test after this (roughly 4 steps) [4773acf3d4b50768bf08e9e97a204819e9ea0895] b43: N-PHY: Fix the update of coef for the PHY revision >= 3case testing commit 4773acf3d4b50768bf08e9e97a204819e9ea0895 with gcc (GCC) 10.2.1 20210217 kernel signature: eac7069edbf54dd331d46fb29e52b34c8c389979281474c0360b3b83dddda863 run #0: crashed: INFO: task hung in tcindex_partial_destroy_work run #1: crashed: INFO: task hung in linkwatch_event run #2: crashed: INFO: task hung in tcindex_partial_destroy_work run #3: crashed: INFO: task hung in linkwatch_event run #4: crashed: INFO: task hung in linkwatch_event run #5: crashed: INFO: task hung in tcindex_partial_destroy_work run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in addrconf_dad_work run #8: crashed: INFO: task hung in linkwatch_event run #9: crashed: INFO: task hung in addrconf_dad_work # git bisect good 4773acf3d4b50768bf08e9e97a204819e9ea0895 Bisecting: 7 revisions left to test after this (roughly 3 steps) [4a41c421f3676fdeea91733cf434dcf319c4c351] ibmvnic: serialize access to work queue on remove testing commit 4a41c421f3676fdeea91733cf434dcf319c4c351 with gcc (GCC) 10.2.1 20210217 kernel signature: 069513226aaf2cfb011ca9cabd7ab9c175cb204fcabd703b2cae6895f9a21a86 run #0: crashed: INFO: task hung in addrconf_dad_work run #1: crashed: INFO: task hung in addrconf_dad_work run #2: crashed: INFO: task hung in addrconf_dad_work run #3: crashed: INFO: task hung in addrconf_dad_work run #4: crashed: INFO: task hung in linkwatch_event run #5: crashed: INFO: task hung in addrconf_dad_work run #6: crashed: INFO: task hung in addrconf_dad_work run #7: crashed: INFO: task hung in cfg80211_event_work run #8: crashed: INFO: task hung in addrconf_dad_work run #9: crashed: INFO: task hung in addrconf_dad_work # git bisect good 4a41c421f3676fdeea91733cf434dcf319c4c351 Bisecting: 3 revisions left to test after this (roughly 2 steps) [84fe68eb67f9499309cffd97c1ba269de125ff14] net: amd-xgbe: Reset link when the link never comes back testing commit 84fe68eb67f9499309cffd97c1ba269de125ff14 with gcc (GCC) 10.2.1 20210217 kernel signature: 069513226aaf2cfb011ca9cabd7ab9c175cb204fcabd703b2cae6895f9a21a86 run #0: crashed: INFO: task hung in linkwatch_event run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in cfg80211_event_work run #3: crashed: INFO: task hung in tcindex_partial_destroy_work run #4: crashed: INFO: task hung in addrconf_dad_work run #5: crashed: INFO: task hung in addrconf_dad_work run #6: crashed: INFO: task hung in linkwatch_event run #7: crashed: INFO: task hung in addrconf_dad_work run #8: crashed: INFO: task hung in cfg80211_event_work run #9: crashed: INFO: task hung in tcindex_partial_destroy_work # git bisect good 84fe68eb67f9499309cffd97c1ba269de125ff14 Bisecting: 1 revision left to test after this (roughly 1 step) [17aff5389d4f46a2ed2f0760922ae6c06dc438f1] Merge branch 'amd-xgbe-fixes' testing commit 17aff5389d4f46a2ed2f0760922ae6c06dc438f1 with gcc (GCC) 10.2.1 20210217 kernel signature: 069513226aaf2cfb011ca9cabd7ab9c175cb204fcabd703b2cae6895f9a21a86 run #0: crashed: INFO: task hung in addrconf_dad_work run #1: crashed: INFO: task hung in tcindex_partial_destroy_work run #2: crashed: INFO: task hung in addrconf_dad_work run #3: crashed: INFO: task hung in addrconf_dad_work run #4: crashed: INFO: task hung in tcindex_partial_destroy_work run #5: crashed: INFO: task hung in linkwatch_event run #6: crashed: INFO: task hung in tcindex_partial_destroy_work run #7: crashed: INFO: task hung in linkwatch_event run #8: crashed: INFO: task hung in addrconf_dad_work run #9: crashed: INFO: task hung in addrconf_dad_work # git bisect good 17aff5389d4f46a2ed2f0760922ae6c06dc438f1 Bisecting: 0 revisions left to test after this (roughly 0 steps) [396d7f23adf9e8c436dd81a69488b5b6a865acf8] net: sched: fix police ext initialization testing commit 396d7f23adf9e8c436dd81a69488b5b6a865acf8 with gcc (GCC) 10.2.1 20210217 kernel signature: 7076010c455844a009be4fec7ef8374578efa5fadb7a42c643ad92637c3bff61 run #0: crashed: WARNING: ODEBUG bug in netdev_run_todo run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good 396d7f23adf9e8c436dd81a69488b5b6a865acf8 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 is the first bad commit commit 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 Author: Vladimir Oltean Date: Tue Feb 16 12:16:28 2021 +0200 net: enetc: fix destroyed phylink dereference during unbind The following call path suggests that calling unregister_netdev on an interface that is up will first bring it down. enetc_pf_remove -> unregister_netdev -> unregister_netdevice_queue -> unregister_netdevice_many -> dev_close_many -> __dev_close_many -> enetc_close -> enetc_stop -> phylink_stop However, enetc first destroys the phylink instance, then calls unregister_netdev. This is already dissimilar to the setup (and error path teardown path) from enetc_pf_probe, but more than that, it is buggy because it is invalid to call phylink_stop after phylink_destroy. So let's first unregister the netdev (and let the .ndo_stop events consume themselves), then destroy the phylink instance, then free the netdev. Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller drivers/net/ethernet/freescale/enetc/enetc_pf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) culprit signature: 7076010c455844a009be4fec7ef8374578efa5fadb7a42c643ad92637c3bff61 parent signature: 7076010c455844a009be4fec7ef8374578efa5fadb7a42c643ad92637c3bff61 Reproducer flagged being flaky revisions tested: 15, total time: 3h40m53.602781862s (build: 1h37m1.532073766s, test: 2h2m31.746922017s) first good commit: 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 net: enetc: fix destroyed phylink dereference during unbind recipients (to): ["claudiu.manoil@nxp.com" "davem@davemloft.net" "davem@davemloft.net" "kuba@kernel.org" "linux@armlinux.org.uk" "netdev@vger.kernel.org" "vladimir.oltean@nxp.com"] recipients (cc): ["linux-kernel@vger.kernel.org"]