diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 1319986693fc..e265c443536e 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -1272,6 +1272,8 @@ static int fl_set_enc_opt(struct nlattr **tb, struct fl_flow_key *key, nla_opt_msk = nla_data(tb[TCA_FLOWER_KEY_ENC_OPTS_MASK]); msk_depth = nla_len(tb[TCA_FLOWER_KEY_ENC_OPTS_MASK]); + if (!nla_ok(nla_opt_msk, msk_depth)) + return -EINVAL; } nla_for_each_attr(nla_opt_key, nla_enc_key, @@ -1308,7 +1310,7 @@ static int fl_set_enc_opt(struct nlattr **tb, struct fl_flow_key *key, return -EINVAL; } - if (msk_depth) + if (nla_ok(nla_opt_msk, msk_depth)) nla_opt_msk = nla_next(nla_opt_msk, &msk_depth); break; case TCA_FLOWER_KEY_ENC_OPTS_VXLAN: @@ -1341,7 +1343,7 @@ static int fl_set_enc_opt(struct nlattr **tb, struct fl_flow_key *key, return -EINVAL; } - if (msk_depth) + if (nla_ok(nla_opt_msk, msk_depth)) nla_opt_msk = nla_next(nla_opt_msk, &msk_depth); break; case TCA_FLOWER_KEY_ENC_OPTS_ERSPAN: @@ -1374,7 +1376,7 @@ static int fl_set_enc_opt(struct nlattr **tb, struct fl_flow_key *key, return -EINVAL; } - if (msk_depth) + if (nla_ok(nla_opt_msk, msk_depth)) nla_opt_msk = nla_next(nla_opt_msk, &msk_depth); break; default: