diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 091a92338492..016b2999f219 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -4373,8 +4373,6 @@ static void hci_sync_conn_complete_evt(struct hci_dev *hdev, switch (ev->status) { case 0x00: - if (conn->state == BT_CONNECTED) - goto unlock; /* Already connected, event not valid */ conn->handle = __le16_to_cpu(ev->handle); conn->state = BT_CONNECTED; conn->type = ev->link_type; diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index 34f3419c3330..3bd41563f118 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -140,12 +140,10 @@ static void sco_chan_del(struct sock *sk, int err) BT_DBG("sk %p, conn %p, err %d", sk, conn, err); if (conn) { - local_bh_disable(); sco_conn_lock(conn); conn->sk = NULL; sco_pi(sk)->conn = NULL; sco_conn_unlock(conn); - local_bh_enable(); if (conn->hcon) hci_conn_drop(conn->hcon); @@ -169,22 +167,16 @@ static void sco_conn_del(struct hci_conn *hcon, int err) BT_DBG("hcon %p conn %p, err %d", hcon, conn, err); /* Kill socket */ - local_bh_disable(); sco_conn_lock(conn); sk = conn->sk; sco_conn_unlock(conn); - local_bh_enable(); if (sk) { sock_hold(sk); - - local_bh_disable(); bh_lock_sock(sk); sco_sock_clear_timer(sk); sco_chan_del(sk, err); bh_unlock_sock(sk); - local_bh_enable(); - sco_sock_kill(sk); sock_put(sk); } @@ -210,7 +202,6 @@ static int sco_chan_add(struct sco_conn *conn, struct sock *sk, { int err = 0; - local_bh_disable(); sco_conn_lock(conn); if (conn->sk) err = -EBUSY; @@ -218,7 +209,6 @@ static int sco_chan_add(struct sco_conn *conn, struct sock *sk, __sco_chan_add(conn, sk, parent); sco_conn_unlock(conn); - local_bh_enable(); return err; } @@ -313,11 +303,9 @@ static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb) { struct sock *sk; - local_bh_disable(); sco_conn_lock(conn); sk = conn->sk; sco_conn_unlock(conn); - local_bh_enable(); if (!sk) goto drop; @@ -432,12 +420,10 @@ static void __sco_sock_close(struct sock *sk) if (sco_pi(sk)->conn->hcon) { sk->sk_state = BT_DISCONN; sco_sock_set_timer(sk, SCO_DISCONN_TIMEOUT); - local_bh_disable(); sco_conn_lock(sco_pi(sk)->conn); hci_conn_drop(sco_pi(sk)->conn->hcon); sco_pi(sk)->conn->hcon = NULL; sco_conn_unlock(sco_pi(sk)->conn); - local_bh_enable(); } else sco_chan_del(sk, ECONNRESET); break; @@ -1098,26 +1084,21 @@ static void sco_conn_ready(struct sco_conn *conn) if (sk) { sco_sock_clear_timer(sk); - local_bh_disable(); bh_lock_sock(sk); sk->sk_state = BT_CONNECTED; sk->sk_state_change(sk); bh_unlock_sock(sk); - local_bh_enable(); } else { - local_bh_disable(); sco_conn_lock(conn); if (!conn->hcon) { sco_conn_unlock(conn); - local_bh_enable(); return; } parent = sco_get_sock_listen(&conn->hcon->src); if (!parent) { sco_conn_unlock(conn); - local_bh_enable(); return; } @@ -1128,7 +1109,6 @@ static void sco_conn_ready(struct sco_conn *conn) if (!sk) { bh_unlock_sock(parent); sco_conn_unlock(conn); - local_bh_enable(); return; } @@ -1151,7 +1131,6 @@ static void sco_conn_ready(struct sco_conn *conn) bh_unlock_sock(parent); sco_conn_unlock(conn); - local_bh_enable(); } }