diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index 41483e371f05..2eab8b1787d4 100644 --- a/drivers/net/netdevsim/bus.c +++ b/drivers/net/netdevsim/bus.c @@ -241,11 +241,12 @@ del_device_store(const struct bus_type *bus, const char *buf, size_t count) if (nsim_bus_dev->dev.id != id) continue; list_del(&nsim_bus_dev->list); - nsim_bus_dev_del(nsim_bus_dev); err = 0; break; } mutex_unlock(&nsim_bus_dev_list_lock); + if (!err) + nsim_bus_dev_del(nsim_bus_dev); return !err ? count : err; } static BUS_ATTR_WO(del_device); @@ -520,6 +521,7 @@ int nsim_bus_init(void) void nsim_bus_exit(void) { struct nsim_bus_dev *nsim_bus_dev, *tmp; + LIST_HEAD(del_list); /* Disallow using resources */ smp_store_release(&nsim_bus_enable, false); @@ -527,11 +529,13 @@ void nsim_bus_exit(void) complete(&nsim_bus_devs_released); mutex_lock(&nsim_bus_dev_list_lock); - list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) { + list_splice_init(&nsim_bus_dev_list, &del_list); + mutex_unlock(&nsim_bus_dev_list_lock); + + list_for_each_entry_safe(nsim_bus_dev, tmp, &del_list, list) { list_del(&nsim_bus_dev->list); nsim_bus_dev_del(nsim_bus_dev); } - mutex_unlock(&nsim_bus_dev_list_lock); wait_for_completion(&nsim_bus_devs_released);