bisecting fixing commit since 6fbc7275c7a9ba97877050335f290341a1fd8dbf building syzkaller on 907bf74686129436f81aa40336ee89f7cc01b0b4 testing commit 6fbc7275c7a9ba97877050335f290341a1fd8dbf with gcc (GCC) 8.1.0 kernel signature: d8316989acd9ef862a5b991e8661d2b6914d9dac all runs: crashed: WARNING in perf_group_attach testing current HEAD 4a3033ef6e6bb4c566bd1d556de69b494d76976c testing commit 4a3033ef6e6bb4c566bd1d556de69b494d76976c with gcc (GCC) 8.1.0 kernel signature: f0333e90256467ebfcca8bd8209a2042647bf57f all runs: OK # git bisect start 4a3033ef6e6bb4c566bd1d556de69b494d76976c 6fbc7275c7a9ba97877050335f290341a1fd8dbf Bisecting: 23136 revisions left to test after this (roughly 15 steps) [81160dda9a7aad13c04e78bb2cfd3c4630e3afab] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 81160dda9a7aad13c04e78bb2cfd3c4630e3afab with gcc (GCC) 8.1.0 kernel signature: 05730a536a651877c8527d8bf7d31f8556f20995 all runs: OK # git bisect bad 81160dda9a7aad13c04e78bb2cfd3c4630e3afab Bisecting: 11628 revisions left to test after this (roughly 14 steps) [7636b7589f81940c6d6518786f93de74495575fa] Merge tag 'rpmsg-v5.3' of git://github.com/andersson/remoteproc testing commit 7636b7589f81940c6d6518786f93de74495575fa with gcc (GCC) 8.1.0 kernel signature: ca346370889683dd9ee7a9b448142c9258de9ce5 all runs: OK # git bisect bad 7636b7589f81940c6d6518786f93de74495575fa Bisecting: 5811 revisions left to test after this (roughly 13 steps) [39656e83dab918861931ef96e5c41731b0899e56] mm: lift the x86_32 PAE version of gup_get_pte to common code testing commit 39656e83dab918861931ef96e5c41731b0899e56 with gcc (GCC) 8.1.0 kernel signature: 3a2678055c6340f9599bfe7cbdd4fa7c50f59d1c run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 39656e83dab918861931ef96e5c41731b0899e56 Bisecting: 3006 revisions left to test after this (roughly 12 steps) [168869492e7009b6861b615f1d030c99bc805e83] docs: kbuild: fix build with pdf and fix some minor issues testing commit 168869492e7009b6861b615f1d030c99bc805e83 with gcc (GCC) 8.1.0 kernel signature: 3eef5075583c71ab3f834943164060db35e8e574 all runs: OK # git bisect bad 168869492e7009b6861b615f1d030c99bc805e83 Bisecting: 1380 revisions left to test after this (roughly 11 steps) [d06e4156430e7c5eb4f04dabcaa0d9e2fba335e3] Merge tag 'devicetree-for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux testing commit d06e4156430e7c5eb4f04dabcaa0d9e2fba335e3 with gcc (GCC) 8.1.0 kernel signature: b78f2a2169525df007a0f6acdfad76c52955bebf run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good d06e4156430e7c5eb4f04dabcaa0d9e2fba335e3 Bisecting: 691 revisions left to test after this (roughly 10 steps) [073c916bc00571d8662b89a294eba265481b6fbb] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input testing commit 073c916bc00571d8662b89a294eba265481b6fbb with gcc (GCC) 8.1.0 kernel signature: b9c07f7309fd798318867783048e289aa0ba0f9f run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 073c916bc00571d8662b89a294eba265481b6fbb Bisecting: 281 revisions left to test after this (roughly 9 steps) [192f0f8e9db7efe4ac98d47f5fa4334e43c1204d] Merge tag 'powerpc-5.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux testing commit 192f0f8e9db7efe4ac98d47f5fa4334e43c1204d with gcc (GCC) 8.1.0 kernel signature: 2a81667027fc00f3f19222a457f6968e71828842 all runs: OK # git bisect bad 192f0f8e9db7efe4ac98d47f5fa4334e43c1204d Bisecting: 212 revisions left to test after this (roughly 8 steps) [1fa91854dcdf7829e2694873b19f96b65947112d] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide testing commit 1fa91854dcdf7829e2694873b19f96b65947112d with gcc (GCC) 8.1.0 kernel signature: 4551c99e58628f457855db527621dec3ef401276 run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 1fa91854dcdf7829e2694873b19f96b65947112d Bisecting: 106 revisions left to test after this (roughly 7 steps) [41732bdc9ccd26829cf647711c4b93384e03e529] powerpc/powernv-eeh: Consisely desribe what this file does testing commit 41732bdc9ccd26829cf647711c4b93384e03e529 with gcc (GCC) 8.1.0 kernel signature: 4121c8b00e3a9586a90aeba429775bd18fd454ca all runs: crashed: WARNING in perf_group_attach # git bisect good 41732bdc9ccd26829cf647711c4b93384e03e529 Bisecting: 53 revisions left to test after this (roughly 6 steps) [a2b6f26c264e510f1d76ce347e34a21fbda9d8b2] powerpc/module64: Use symbolic instructions names. testing commit a2b6f26c264e510f1d76ce347e34a21fbda9d8b2 with gcc (GCC) 8.1.0 kernel signature: a1441598b773e31aa6bc41e7ec8b019c8ddd2051 all runs: crashed: WARNING in perf_group_attach # git bisect good a2b6f26c264e510f1d76ce347e34a21fbda9d8b2 Bisecting: 26 revisions left to test after this (roughly 5 steps) [6b660c4177aaebdc73df7a3378f0e8b110aa4b51] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom testing commit 6b660c4177aaebdc73df7a3378f0e8b110aa4b51 with gcc (GCC) 8.1.0 kernel signature: 9f09e686406bd78db8bb8e2eb2a72270cf8aaa90 all runs: OK # git bisect bad 6b660c4177aaebdc73df7a3378f0e8b110aa4b51 Bisecting: 14 revisions left to test after this (roughly 4 steps) [08d14c49ac949b0e42f2aa36fb8d5c860cfe130d] Merge branch 'mlx5-build-fixes' testing commit 08d14c49ac949b0e42f2aa36fb8d5c860cfe130d with gcc (GCC) 8.1.0 kernel signature: ec4916b36b38f3ca99b1a1a21f8bca1e7b2296b0 all runs: OK # git bisect bad 08d14c49ac949b0e42f2aa36fb8d5c860cfe130d Bisecting: 5 revisions left to test after this (roughly 3 steps) [052e0690f1f62f76493ba996d73847c7ca9fd132] ipv6: tcp: fix flowlabels reflection for RST packets testing commit 052e0690f1f62f76493ba996d73847c7ca9fd132 with gcc (GCC) 8.1.0 kernel signature: bc67e408b803295b868eef9e4c5cc6b640e994cf all runs: OK # git bisect bad 052e0690f1f62f76493ba996d73847c7ca9fd132 Bisecting: 2 revisions left to test after this (roughly 2 steps) [aa4c0c9091b0bb4cb261bbe0718d17c2834c4690] net: stmmac: Fix misuses of GENMASK macro testing commit aa4c0c9091b0bb4cb261bbe0718d17c2834c4690 with gcc (GCC) 8.1.0 kernel signature: 5596c89b515ae7785aaad201e914f84b45d2def8 run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good aa4c0c9091b0bb4cb261bbe0718d17c2834c4690 Bisecting: 0 revisions left to test after this (roughly 1 step) [416e8126a2672f6e91e9e81c6f5c07cf46808b13] ipv6: Use ipv6_authlen for len testing commit 416e8126a2672f6e91e9e81c6f5c07cf46808b13 with gcc (GCC) 8.1.0 kernel signature: ad17c6fdd187ab7dd5e97e46d78433b435896920 all runs: OK # git bisect bad 416e8126a2672f6e91e9e81c6f5c07cf46808b13 Bisecting: 0 revisions left to test after this (roughly 0 steps) [311633b604063a8a5d3fbc74d0565b42df721f68] hsr: switch ->dellink() to ->ndo_uninit() testing commit 311633b604063a8a5d3fbc74d0565b42df721f68 with gcc (GCC) 8.1.0 kernel signature: 50ca52258c45ac23ae439c5fd6ac28ea15f6f0c8 all runs: OK # git bisect bad 311633b604063a8a5d3fbc74d0565b42df721f68 311633b604063a8a5d3fbc74d0565b42df721f68 is the first bad commit commit 311633b604063a8a5d3fbc74d0565b42df721f68 Author: Cong Wang Date: Tue Jul 9 23:24:54 2019 -0700 hsr: switch ->dellink() to ->ndo_uninit() Switching from ->priv_destructor to dellink() has an unexpected consequence: existing RCU readers, that is, hsr_port_get_hsr() callers, may still be able to read the port list. Instead of checking the return value of each hsr_port_get_hsr(), we can just move it to ->ndo_uninit() which is called after device unregister and synchronize_net(), and we still have RTNL lock there. Fixes: b9a1e627405d ("hsr: implement dellink to clean up resources") Fixes: edf070a0fb45 ("hsr: fix a NULL pointer deref in hsr_dev_xmit()") Reported-by: syzbot+097ef84cdc95843fbaa8@syzkaller.appspotmail.com Cc: Arvid Brodin Signed-off-by: Cong Wang Signed-off-by: David S. Miller net/hsr/hsr_device.c | 18 ++++++++---------- net/hsr/hsr_device.h | 1 - net/hsr/hsr_netlink.c | 7 ------- 3 files changed, 8 insertions(+), 18 deletions(-) culprit signature: 50ca52258c45ac23ae439c5fd6ac28ea15f6f0c8 parent signature: 5596c89b515ae7785aaad201e914f84b45d2def8 revisions tested: 18, total time: 4h44m50.382757276s (build: 1h43m46.541453403s, test: 2h59m36.197774498s) first good commit: 311633b604063a8a5d3fbc74d0565b42df721f68 hsr: switch ->dellink() to ->ndo_uninit() cc: ["arvid.brodin@alten.se" "davem@davemloft.net" "linux-kernel@vger.kernel.org" "netdev@vger.kernel.org" "xiyou.wangcong@gmail.com"]