bisecting fixing commit since f8ad8187c3b536ee2b10502a8340c014204a1af0 building syzkaller on 52e3731913ab2677be27c29ed8142b04e8f28521 testing commit f8ad8187c3b536ee2b10502a8340c014204a1af0 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 97449f8c0ded7b99bb816fac7fc1c229551a8b3bd19180634cfff8abdde969da run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: out-of-bounds Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK reproducer seems to be flaky testing current HEAD 6b1f86f8e9c7f9de7ca1cb987b2cf25e99b1ae3a testing commit 6b1f86f8e9c7f9de7ca1cb987b2cf25e99b1ae3a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: bb17884ce10fe0734d7e1cea0a1137390061f310b7eb833cf4d46f0953d28a3a run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect start 6b1f86f8e9c7f9de7ca1cb987b2cf25e99b1ae3a f8ad8187c3b536ee2b10502a8340c014204a1af0 Bisecting: 46654 revisions left to test after this (roughly 16 steps) [e7562a00c1f54116f5a058e7e3ddd500188f60b2] Merge tag 'sound-5.14-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound testing commit e7562a00c1f54116f5a058e7e3ddd500188f60b2 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 784a6b783ca8f5dadc6b32db371108c5a29e8eecbadad8fae1229d550c391d92 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good e7562a00c1f54116f5a058e7e3ddd500188f60b2 Bisecting: 23265 revisions left to test after this (roughly 15 steps) [d461e96cd22b5aeb1df448536b92e8d8e88c4a05] Merge tag 'drivers-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc testing commit d461e96cd22b5aeb1df448536b92e8d8e88c4a05 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 921947ddbea93af1ece870a2af4541f5cb0a128f1333adae0b7132a6220a24e7 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good d461e96cd22b5aeb1df448536b92e8d8e88c4a05 Bisecting: 11310 revisions left to test after this (roughly 14 steps) [8efd0d9c316af470377894a6a0f9ff63ce18c177] Merge tag '5.17-net-next' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 8efd0d9c316af470377894a6a0f9ff63ce18c177 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 14b3e4b89e412cbed2644acc8455099bba4f296036f1572e98a724de1b1bdfac run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #9: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 8efd0d9c316af470377894a6a0f9ff63ce18c177 Bisecting: 5692 revisions left to test after this (roughly 13 steps) [51620150ca2df62f8ea472ab8962be590c957288] cifs: update internal module number testing commit 51620150ca2df62f8ea472ab8962be590c957288 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 887b09da879a7a03e4cf0b285a179947ba131f5ea4badb2c83a80a26ac02563c all runs: OK # git bisect bad 51620150ca2df62f8ea472ab8962be590c957288 Bisecting: 2790 revisions left to test after this (roughly 12 steps) [4eb766f64d120f0b80ec24282df789b7db2ff838] Merge tag 'devicetree-for-5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux testing commit 4eb766f64d120f0b80ec24282df789b7db2ff838 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 754c2298e17148b5a1619b1b629acbb709816fe7c439b6b48c2824cf02ccce15 all runs: OK # git bisect bad 4eb766f64d120f0b80ec24282df789b7db2ff838 Bisecting: 1407 revisions left to test after this (roughly 11 steps) [3e3a138a46906641d95599040f2470a60740c399] Merge tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm testing commit 3e3a138a46906641d95599040f2470a60740c399 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9c73fa43516225280903c2849fac906f6ecc00e76eb81121aa2cf9f775e69223 all runs: OK # git bisect bad 3e3a138a46906641d95599040f2470a60740c399 Bisecting: 696 revisions left to test after this (roughly 10 steps) [347708875a2fac81dd99ec826248ec29ac28f441] Merge tag 'platform-drivers-x86-v5.17-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86 testing commit 347708875a2fac81dd99ec826248ec29ac28f441 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 573b136d0ba0d838ac1055102dc9ab7701f50726bd457ae4790ec4e179f60b9f run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: WARNING: ODEBUG bug in netdev_run_todo run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 347708875a2fac81dd99ec826248ec29ac28f441 Bisecting: 349 revisions left to test after this (roughly 9 steps) [dabd40ecaf693a18afd4c59c8d7280610d95b66e] Merge tag 'tpmdd-next-v5.17-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd testing commit dabd40ecaf693a18afd4c59c8d7280610d95b66e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: f35d962cbc9d0f89db6a031597a3060293ba69fcd483ef94e4b03624f810ac38 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #9: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good dabd40ecaf693a18afd4c59c8d7280610d95b66e Bisecting: 172 revisions left to test after this (roughly 8 steps) [11fc88c2e49ba8e3ca827dc9bdd7b7216be30a36] Merge tag 'xfs-5.17-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux testing commit 11fc88c2e49ba8e3ca827dc9bdd7b7216be30a36 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c1ab52cb3e37828af6dcb6d1c35bdaba53d3459671a921a40daf0ec73f546595 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #9: OK run #10: basic kernel testing failed: failed to copy test binary to VM: timedout after 1m0s ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "/tmp/syz-executor2870266886" "root@10.128.15.200:./syz-executor2870266886"] run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 11fc88c2e49ba8e3ca827dc9bdd7b7216be30a36 Bisecting: 84 revisions left to test after this (roughly 7 steps) [3f67eaed57dae339603441cf0c0a74ec77a9fc03] Merge tag 'dlm-5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm testing commit 3f67eaed57dae339603441cf0c0a74ec77a9fc03 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 02e8e835910ae47c433f721a2c4451330d717e1031955e85e3b8dfb91b06d6e4 all runs: OK # git bisect bad 3f67eaed57dae339603441cf0c0a74ec77a9fc03 Bisecting: 43 revisions left to test after this (roughly 6 steps) [ae6ec194b55273e52351ee70d694594dcabe405d] ext4: remove unnecessary 'offset' assignment testing commit ae6ec194b55273e52351ee70d694594dcabe405d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 937b92f54cc6ce56a5ec1cdbad619e3092f58cc2003230a49cd08e174a3dc259 all runs: OK # git bisect bad ae6ec194b55273e52351ee70d694594dcabe405d Bisecting: 21 revisions left to test after this (roughly 5 steps) [0b5b5a62b945a141e64011b2f90ee7e46f14be98] ext4: use ext4_ext_remove_space() for fast commit replay delete range testing commit 0b5b5a62b945a141e64011b2f90ee7e46f14be98 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 326bf8a601c5d7668b4236687ebd03561304ac6e3173b1b3827895fd54b382bc all runs: OK # git bisect bad 0b5b5a62b945a141e64011b2f90ee7e46f14be98 Bisecting: 10 revisions left to test after this (roughly 4 steps) [97d8a670b4531437d5b842cf68dafa6d1a932ddf] ext4: change token2str() to use ext4_param_specs testing commit 97d8a670b4531437d5b842cf68dafa6d1a932ddf compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 4ebd823333cf2c4b7d773d55f5c5c0b5c53438bed1d502026be9d81c4f0ba6c9 all runs: OK # git bisect bad 97d8a670b4531437d5b842cf68dafa6d1a932ddf Bisecting: 5 revisions left to test after this (roughly 3 steps) [da812f611934bef16fe02d667a76df77ae9cf99a] ext4: Allow sb to be NULL in ext4_msg() testing commit da812f611934bef16fe02d667a76df77ae9cf99a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: aa82aceb550192eba6dbedfcd66abd83cd942df942b395097f3fb9801f516ce5 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good da812f611934bef16fe02d667a76df77ae9cf99a Bisecting: 2 revisions left to test after this (roughly 2 steps) [6e47a3cc68fc525428297a00524833361ebbb0e9] ext4: get rid of super block and sbi from handle_mount_ops() testing commit 6e47a3cc68fc525428297a00524833361ebbb0e9 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3d9c1557c1c32e3a3d56ec3045617b89531a2d70815c9379f6bacdb44aad6194 all runs: OK # git bisect bad 6e47a3cc68fc525428297a00524833361ebbb0e9 Bisecting: 0 revisions left to test after this (roughly 1 step) [b6bd243500b6024d92eaaacf592ed8588c2c75ea] ext4: check ext2/3 compatibility outside handle_mount_opt() testing commit b6bd243500b6024d92eaaacf592ed8588c2c75ea compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c9dc1af2aa92591cd3df2a459e359a92df28147237be5a17ee8886257f81b1f9 run #0: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #1: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #2: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #3: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #4: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #5: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #6: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #7: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #8: OK run #9: OK run #10: crashed: KASAN: use-after-free Read in ext4_xattr_set_entry run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good b6bd243500b6024d92eaaacf592ed8588c2c75ea 6e47a3cc68fc525428297a00524833361ebbb0e9 is the first bad commit commit 6e47a3cc68fc525428297a00524833361ebbb0e9 Author: Lukas Czerner Date: Wed Oct 27 16:18:52 2021 +0200 ext4: get rid of super block and sbi from handle_mount_ops() At the parsing phase of mount in the new mount api sb will not be available. We've already removed some uses of sb and sbi, but now we need to get rid of the rest of it. Use ext4_fs_context to store all of the configuration specification so that it can be later applied to the super block and sbi. Signed-off-by: Lukas Czerner Reviewed-by: Carlos Maiolino Link: https://lore.kernel.org/r/20211027141857.33657-9-lczerner@redhat.com Signed-off-by: Theodore Ts'o fs/ext4/super.c | 541 ++++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 368 insertions(+), 173 deletions(-) culprit signature: 3d9c1557c1c32e3a3d56ec3045617b89531a2d70815c9379f6bacdb44aad6194 parent signature: c9dc1af2aa92591cd3df2a459e359a92df28147237be5a17ee8886257f81b1f9 Reproducer flagged being flaky revisions tested: 18, total time: 5h2m13.472204808s (build: 1h34m2.455306241s, test: 3h25m54.259436563s) first good commit: 6e47a3cc68fc525428297a00524833361ebbb0e9 ext4: get rid of super block and sbi from handle_mount_ops() recipients (to): ["cmaiolino@redhat.com" "lczerner@redhat.com" "tytso@mit.edu"] recipients (cc): []