bisecting fixing commit since 1da38549dd64c7f5dd22427f12dfa8db3d8a722b building syzkaller on efe0f24dd913d90b2c6a2dbe7b8dac779c266144 testing commit 1da38549dd64c7f5dd22427f12dfa8db3d8a722b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 16571038d9d234ce42860268debfdc8b545176b58f76710c9c4ade5703b9c5a9 all runs: crashed: WARNING in inc_nlink testing current HEAD 8ab774587903771821b59471cc723bba6d893942 testing commit 8ab774587903771821b59471cc723bba6d893942 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6d2e1b00e9ed063b00cc44233b6276e12588da5d7c4ee41f3f558d03b8a4d670 all runs: OK # git bisect start 8ab774587903771821b59471cc723bba6d893942 1da38549dd64c7f5dd22427f12dfa8db3d8a722b Bisecting: 6719 revisions left to test after this (roughly 13 steps) [56d33754481fe0dc7436dc4ee4fbd44b3039361d] Merge tag 'drm-next-2021-11-03' of git://anongit.freedesktop.org/drm/drm testing commit 56d33754481fe0dc7436dc4ee4fbd44b3039361d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 27db6fcf43f7ef71a19bd9f7898c47768221793559a8d605ef49114ea9e548c8 all runs: crashed: WARNING in inc_nlink # git bisect good 56d33754481fe0dc7436dc4ee4fbd44b3039361d Bisecting: 3270 revisions left to test after this (roughly 12 steps) [5c904c66ed4e86c31ac7c033b64274cebed04e0e] Merge tag 'char-misc-5.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit 5c904c66ed4e86c31ac7c033b64274cebed04e0e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d587710fe8af6456b3f4f8b85bd975896eb4069325c37ba7deab5da755628091 all runs: crashed: WARNING in inc_nlink # git bisect good 5c904c66ed4e86c31ac7c033b64274cebed04e0e Bisecting: 1652 revisions left to test after this (roughly 11 steps) [dab334c98bf3563f57dc694242192f9e1cc95f96] Merge branch 'i2c/for-mergewindow' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux testing commit dab334c98bf3563f57dc694242192f9e1cc95f96 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: da93e4331273eb152d029d4c6bac503d34e07398eeedc03a484ac2209d9a8154 all runs: crashed: WARNING in inc_nlink # git bisect good dab334c98bf3563f57dc694242192f9e1cc95f96 Bisecting: 834 revisions left to test after this (roughly 10 steps) [84886c262ebcfa40751ed508268457af8a20c1aa] Merge tag 'kvmarm-fixes-5.16-1' of git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into kvm-master testing commit 84886c262ebcfa40751ed508268457af8a20c1aa compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: b9d3a2209f988f9c284f7caa1ac5538da096799f131d3bfede9a7ee1f812de93 all runs: OK # git bisect bad 84886c262ebcfa40751ed508268457af8a20c1aa Bisecting: 391 revisions left to test after this (roughly 9 steps) [bd485d274be3935da61c349dc82cb7471bac0a9a] Merge tag 'rproc-v5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux testing commit bd485d274be3935da61c349dc82cb7471bac0a9a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ca1db1500613ea950a2e94b61ca445000972a405443157955b255c6befd68558 all runs: OK # git bisect bad bd485d274be3935da61c349dc82cb7471bac0a9a Bisecting: 179 revisions left to test after this (roughly 8 steps) [59a2ceeef6d6bb8f68550fdbd84246b74a99f06b] Merge branch 'akpm' (patches from Andrew) testing commit 59a2ceeef6d6bb8f68550fdbd84246b74a99f06b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9563306c94b859b0bc4ea12c5b78c5ca96bfcdab86757e3416bd77315251a22b all runs: crashed: WARNING in inc_nlink # git bisect good 59a2ceeef6d6bb8f68550fdbd84246b74a99f06b Bisecting: 85 revisions left to test after this (roughly 7 steps) [3e28850cbd359bed841b832200f9fc208a9ef040] Merge tag 'for-5.16/block-2021-11-09' of git://git.kernel.dk/linux-block testing commit 3e28850cbd359bed841b832200f9fc208a9ef040 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7232bedeb61b0102c0cc058677096976dbb3df3d30d2a02d5ca8f435f8c4b6e6 all runs: OK # git bisect bad 3e28850cbd359bed841b832200f9fc208a9ef040 Bisecting: 47 revisions left to test after this (roughly 6 steps) [1bdd629e5aa0e335504304be4208935948692549] Merge tag 'ovl-update-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs testing commit 1bdd629e5aa0e335504304be4208935948692549 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0342fe7c444439e48e4219b7a7e18dbeeff7535d7737fa3f736d3f35394dce01 all runs: OK # git bisect bad 1bdd629e5aa0e335504304be4208935948692549 Bisecting: 22 revisions left to test after this (roughly 5 steps) [712a951025c0667ff00b25afc360f74e639dfabe] fuse: fix page stealing testing commit 712a951025c0667ff00b25afc360f74e639dfabe compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 873ad6caf717809b8e8b8a566d5c9e08e41417ce11d4409da016f3bf53bfd669 all runs: OK # git bisect bad 712a951025c0667ff00b25afc360f74e639dfabe Bisecting: 11 revisions left to test after this (roughly 4 steps) [8c56e03d2e08d83776c89e4b6563ca8cfdf7da54] fuse: don't bump attr_version in cached write testing commit 8c56e03d2e08d83776c89e4b6563ca8cfdf7da54 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8cb49c2e719b6a952764a1fa3e8f8dec2d396023b5f6b21f83e77e9028b90a72 all runs: OK # git bisect bad 8c56e03d2e08d83776c89e4b6563ca8cfdf7da54 Bisecting: 5 revisions left to test after this (roughly 3 steps) [b5d9758297858288f1d8cd9b24a4e2f899f169e0] fuse: delete redundant code testing commit b5d9758297858288f1d8cd9b24a4e2f899f169e0 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 067d3551191249b960797fd8dd8ed82c9decf3665cac85eae6276949e1f5025b all runs: crashed: WARNING in inc_nlink # git bisect good b5d9758297858288f1d8cd9b24a4e2f899f169e0 Bisecting: 2 revisions left to test after this (roughly 2 steps) [cefd1b83275d4c587bdeb2fe7aed07908642f875] fuse: decrement nlink on overwriting rename testing commit cefd1b83275d4c587bdeb2fe7aed07908642f875 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8649fb67d867c76b06432821544c509ffbc77213889c7b22687d103a8ab6d4b3 all runs: crashed: WARNING in inc_nlink # git bisect good cefd1b83275d4c587bdeb2fe7aed07908642f875 Bisecting: 0 revisions left to test after this (roughly 1 step) [fa5eee57e33e79b71b40e6950c29cc46f5cc5cb7] fuse: selective attribute invalidation testing commit fa5eee57e33e79b71b40e6950c29cc46f5cc5cb7 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2b2d7897f6c1a3b5b28fa4e120c23cc7c7ba62979f8327422f5c7ab92f7a5317 all runs: OK # git bisect bad fa5eee57e33e79b71b40e6950c29cc46f5cc5cb7 Bisecting: 0 revisions left to test after this (roughly 0 steps) [97f044f690bac2b094bfb7fb2d177ef946c85880] fuse: don't increment nlink in link() testing commit 97f044f690bac2b094bfb7fb2d177ef946c85880 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 60877d7e2b0786229bbd36aca0c75f9e283631e5a3d7575270023f64142fc811 all runs: OK # git bisect bad 97f044f690bac2b094bfb7fb2d177ef946c85880 97f044f690bac2b094bfb7fb2d177ef946c85880 is the first bad commit commit 97f044f690bac2b094bfb7fb2d177ef946c85880 Author: Miklos Szeredi Date: Fri Oct 22 17:03:02 2021 +0200 fuse: don't increment nlink in link() The fuse_iget() call in create_new_entry() already updated the inode with all the new attributes and incremented the attribute version. Incrementing the nlink will result in the wrong count. This wasn't noticed because the attributes were invalidated right after this. Updating ctime is still needed for the writeback case when the ctime is not refreshed. Signed-off-by: Miklos Szeredi fs/fuse/dir.c | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-) culprit signature: 60877d7e2b0786229bbd36aca0c75f9e283631e5a3d7575270023f64142fc811 parent signature: 8649fb67d867c76b06432821544c509ffbc77213889c7b22687d103a8ab6d4b3 revisions tested: 16, total time: 3h27m27.570806333s (build: 1h41m58.481145588s, test: 1h43m45.847213504s) first good commit: 97f044f690bac2b094bfb7fb2d177ef946c85880 fuse: don't increment nlink in link() recipients (to): ["linux-fsdevel@vger.kernel.org" "miklos@szeredi.hu" "mszeredi@redhat.com"] recipients (cc): ["linux-kernel@vger.kernel.org"]