bisecting fixing commit since c98ff1d013d2d53911c4b3e8ba14c7cd141cf1ed building syzkaller on 7e2b734bac96c22086fedd1b18135da06d5e4054 testing commit c98ff1d013d2d53911c4b3e8ba14c7cd141cf1ed compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: ad41b43ac0f6c9952d6b9aa45064b69ad6b5678999e8b02b8683ccbf4f0ee77a run #0: crashed: WARNING in __percpu_ref_exit run #1: crashed: WARNING in __percpu_ref_exit run #2: crashed: WARNING in __percpu_ref_exit run #3: crashed: WARNING in __percpu_ref_exit run #4: crashed: WARNING in __percpu_ref_exit run #5: crashed: WARNING in __percpu_ref_exit run #6: crashed: WARNING in __percpu_ref_exit run #7: OK run #8: crashed: WARNING in __percpu_ref_exit run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK reproducer seems to be flaky testing current HEAD 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f testing commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 05cc24f0d19deb65ea9a71c927fcdd34791d4201183276a3576ee473777cc79b all runs: OK # git bisect start 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f c98ff1d013d2d53911c4b3e8ba14c7cd141cf1ed Bisecting: 21737 revisions left to test after this (roughly 15 steps) [dbe69e43372212527abf48609aba7fc39a6daa27] Merge tag 'net-next-5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit dbe69e43372212527abf48609aba7fc39a6daa27 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 3c83cfe6538f5c4c9e4a8ce0ac6307ffc3129339c40ca48eff55ca1236743fe6 all runs: OK # git bisect bad dbe69e43372212527abf48609aba7fc39a6daa27 Bisecting: 11311 revisions left to test after this (roughly 14 steps) [b99a342d4f11a5455d999b12f5fee42ab6acaf8c] NUMA balancing: reduce TLB flush via delaying mapping on hint page fault testing commit b99a342d4f11a5455d999b12f5fee42ab6acaf8c compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: b1d9c53e71a1d06890c6deaf9e682834154618a13f6ae3f27cec4216fe966251 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: crashed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: crashed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: crashed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #15: crashed: WARNING in __nf_unregister_net_hook run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good b99a342d4f11a5455d999b12f5fee42ab6acaf8c Bisecting: 5655 revisions left to test after this (roughly 13 steps) [ae1be3fad5695fcb5ad1053b4847f89431f7b922] net: farsync: remove redundant parentheses testing commit ae1be3fad5695fcb5ad1053b4847f89431f7b922 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 1fd45dc754789006579771ae016ab71c6069db381c8eeea507fd19a67176a330 all runs: OK # git bisect bad ae1be3fad5695fcb5ad1053b4847f89431f7b922 Bisecting: 2845 revisions left to test after this (roughly 12 steps) [7b9df264f0ab6595eabe367b04c81824a06d9227] Merge tag 'pwm/for-5.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm testing commit 7b9df264f0ab6595eabe367b04c81824a06d9227 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 1d37d5772e057c48a3ed38ee3f0926776eddd1e501c42d2b303e5906919831db run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: crashed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good 7b9df264f0ab6595eabe367b04c81824a06d9227 Bisecting: 1418 revisions left to test after this (roughly 11 steps) [50f09a3dd5877bda888fc25c3d98937dcfb85539] Merge tag 'char-misc-5.13-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit 50f09a3dd5877bda888fc25c3d98937dcfb85539 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: cf77d0d1c46f1fc1423e424fbaea4ae404a8ef575a6fa90d9e6683616fae18f6 all runs: OK # git bisect bad 50f09a3dd5877bda888fc25c3d98937dcfb85539 Bisecting: 752 revisions left to test after this (roughly 10 steps) [115726c5d312b462c9d9931ea42becdfa838a076] habanalabs/gaudi: Fix a potential use after free in gaudi_memset_device_memory testing commit 115726c5d312b462c9d9931ea42becdfa838a076 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 8312b5a5111eb5afb7767bb7e6daca97c82535d2af240163b0ab648f0cbb1701 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: crashed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: crashed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: crashed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: crashed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: crashed: WARNING in __nf_unregister_net_hook run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #15: crashed: WARNING in __nf_unregister_net_hook run #16: crashed: WARNING in __nf_unregister_net_hook run #17: crashed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good 115726c5d312b462c9d9931ea42becdfa838a076 Bisecting: 376 revisions left to test after this (roughly 9 steps) [a60a34366e0d09ca002c966dd7c43a68c28b1f82] usb: fotg210-hcd: Fix an error message testing commit a60a34366e0d09ca002c966dd7c43a68c28b1f82 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: a8f58350e85e9abf091f52f5da6d373dcb659db3ced72cc3217e0d7c6d923887 all runs: OK # git bisect bad a60a34366e0d09ca002c966dd7c43a68c28b1f82 Bisecting: 210 revisions left to test after this (roughly 8 steps) [f96271cefe6dfd1cb04195b76f4a33e185cd7f92] Merge branch 'master' into next testing commit f96271cefe6dfd1cb04195b76f4a33e185cd7f92 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 6028395e7a540800c9c51f87bd723adbd74e0a20434d0e46431902ec8a30affd run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: crashed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: crashed: WARNING in __nf_unregister_net_hook run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #15: crashed: WARNING in __nf_unregister_net_hook run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good f96271cefe6dfd1cb04195b76f4a33e185cd7f92 Bisecting: 99 revisions left to test after this (roughly 7 steps) [0f979d815cd52084b99e9f6b367e79488850df2e] Merge tag 'kbuild-v5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild testing commit 0f979d815cd52084b99e9f6b367e79488850df2e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: e59e7d2691e2cfe0e4cbe7be83e90c33c206c7c13cfedbd36471eb88c81b9177 all runs: OK # git bisect bad 0f979d815cd52084b99e9f6b367e79488850df2e Bisecting: 55 revisions left to test after this (roughly 6 steps) [52bfcdd87e83d9e69d22da5f26b1512ffc81deed] net:CXGB4: fix leak if sk_buff is not used testing commit 52bfcdd87e83d9e69d22da5f26b1512ffc81deed compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: d9512d4765da252926698970e604aafcbf8a947cadcd406e04c3617cf2deb19d run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: crashed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: crashed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #14: crashed: WARNING in __nf_unregister_net_hook run #15: crashed: WARNING in __nf_unregister_net_hook run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #17: crashed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good 52bfcdd87e83d9e69d22da5f26b1512ffc81deed Bisecting: 27 revisions left to test after this (roughly 5 steps) [55bc1af3d9115d669570aa633e5428d6e2302e8f] Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf testing commit 55bc1af3d9115d669570aa633e5428d6e2302e8f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 3bd1ca66ba2ced5d6ce1534bb64516428fea13fced4151f69bf220f35f2d6693 all runs: OK # git bisect bad 55bc1af3d9115d669570aa633e5428d6e2302e8f Bisecting: 13 revisions left to test after this (roughly 4 steps) [15395ec4685bd45a43d1b54b8fd9846b87e2c621] i40e: Fix PHY type identifiers for 2.5G and 5G adapters testing commit 15395ec4685bd45a43d1b54b8fd9846b87e2c621 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 77eb9a5b465004576d255afc250f6bc9ac8ff0f5472c011eed87bd8d0a96b656 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: crashed: kernel panic: panic_on_warn set run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: crashed: WARNING in __nf_unregister_net_hook run #11: crashed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: crashed: WARNING in __nf_unregister_net_hook run #14: crashed: WARNING in __nf_unregister_net_hook run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #16: crashed: WARNING in __nf_unregister_net_hook run #17: crashed: WARNING in __nf_unregister_net_hook run #18: crashed: WARNING in __nf_unregister_net_hook run #19: crashed: WARNING in __nf_unregister_net_hook # git bisect good 15395ec4685bd45a43d1b54b8fd9846b87e2c621 Bisecting: 6 revisions left to test after this (roughly 3 steps) [a54754ec9891830ba548e2010c889e3c8146e449] netfilter: nftables: avoid overflows in nft_hash_buckets() testing commit a54754ec9891830ba548e2010c889e3c8146e449 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: b6ac8ecde24c48b760b61ecb9f32263acab2515c4e845e7dd31da83b12f8c8d0 all runs: OK # git bisect bad a54754ec9891830ba548e2010c889e3c8146e449 Bisecting: 3 revisions left to test after this (roughly 2 steps) [7072a355ba191c08b0579f0f66e3eba0e28bf818] netfilter: nfnetlink: add a missing rcu_read_unlock() testing commit 7072a355ba191c08b0579f0f66e3eba0e28bf818 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: f36b01d740992b8f04f18e77891d131a81f97fde5c31d647c60ee24257831c82 all runs: OK # git bisect bad 7072a355ba191c08b0579f0f66e3eba0e28bf818 Bisecting: 0 revisions left to test after this (roughly 1 step) [43016d02cf6e46edfc4696452251d34bba0c0435] netfilter: arptables: use pernet ops struct during unregister testing commit 43016d02cf6e46edfc4696452251d34bba0c0435 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: cc8ab54c92b945456166b29b2026a4bb8a43924835d7e171788a0a2d175f9e93 all runs: OK # git bisect bad 43016d02cf6e46edfc4696452251d34bba0c0435 Bisecting: 0 revisions left to test after this (roughly 0 steps) [c7d13358b6a2f49f81a34aa323a2d0878a0532a2] netfilter: xt_SECMARK: add new revision to fix structure layout testing commit c7d13358b6a2f49f81a34aa323a2d0878a0532a2 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.1 kernel signature: 36ddda7a795521a8658e266ef74295774d5b00976af0c813d1006c6114db3273 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: crashed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #16: crashed: WARNING in __nf_unregister_net_hook run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #18: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #19: basic kernel testing failed: WARNING in __nf_unregister_net_hook # git bisect good c7d13358b6a2f49f81a34aa323a2d0878a0532a2 43016d02cf6e46edfc4696452251d34bba0c0435 is the first bad commit commit 43016d02cf6e46edfc4696452251d34bba0c0435 Author: Florian Westphal Date: Mon May 3 13:51:15 2021 +0200 netfilter: arptables: use pernet ops struct during unregister Like with iptables and ebtables, hook unregistration has to use the pernet ops struct, not the template. This triggered following splat: hook not found, pf 3 num 0 WARNING: CPU: 0 PID: 224 at net/netfilter/core.c:480 __nf_unregister_net_hook+0x1eb/0x610 net/netfilter/core.c:480 [..] nf_unregister_net_hook net/netfilter/core.c:502 [inline] nf_unregister_net_hooks+0x117/0x160 net/netfilter/core.c:576 arpt_unregister_table_pre_exit+0x67/0x80 net/ipv4/netfilter/arp_tables.c:1565 Fixes: f9006acc8dfe5 ("netfilter: arp_tables: pass table pointer via nf_hook_ops") Reported-by: syzbot+dcccba8a1e41a38cb9df@syzkaller.appspotmail.com Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso include/linux/netfilter_arp/arp_tables.h | 3 +-- net/ipv4/netfilter/arp_tables.c | 5 ++--- net/ipv4/netfilter/arptable_filter.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) culprit signature: cc8ab54c92b945456166b29b2026a4bb8a43924835d7e171788a0a2d175f9e93 parent signature: 36ddda7a795521a8658e266ef74295774d5b00976af0c813d1006c6114db3273 Reproducer flagged being flaky revisions tested: 18, total time: 4h37m34.583641164s (build: 1h57m30.527820975s, test: 2h37m40.677835093s) first good commit: 43016d02cf6e46edfc4696452251d34bba0c0435 netfilter: arptables: use pernet ops struct during unregister recipients (to): ["coreteam@netfilter.org" "davem@davemloft.net" "dsahern@kernel.org" "fw@strlen.de" "fw@strlen.de" "kadlec@netfilter.org" "kuba@kernel.org" "netdev@vger.kernel.org" "netfilter-devel@vger.kernel.org" "pablo@netfilter.org" "pablo@netfilter.org" "yoshfuji@linux-ipv6.org"] recipients (cc): ["linux-kernel@vger.kernel.org"]