bisecting fixing commit since 152036d1379ffd6985262743dcf6b0f9c75f83a4 building syzkaller on 160c7698277b071db0da01116b9ff94e51ebfd8a testing commit 152036d1379ffd6985262743dcf6b0f9c75f83a4 with gcc (GCC) 8.1.0 kernel signature: b6d9da744e4432c2af7d0debb53977a548d264ce169f79d9b9c256352b4f6d4e all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy testing current HEAD 7575fdda569b2a2e8be32c1a64ecb05d6f96a500 testing commit 7575fdda569b2a2e8be32c1a64ecb05d6f96a500 with gcc (GCC) 8.1.0 kernel signature: 612c00ea5eb5edaf85a4066b8aab6daf3ab28256d94536f7f5f754d3f1ed2248 all runs: OK # git bisect start 7575fdda569b2a2e8be32c1a64ecb05d6f96a500 152036d1379ffd6985262743dcf6b0f9c75f83a4 Bisecting: 17208 revisions left to test after this (roughly 14 steps) [e6187b3444e88ed9aa5f3843603e1f024b6d0309] xfs: rename xfs_iflush_int() testing commit e6187b3444e88ed9aa5f3843603e1f024b6d0309 with gcc (GCC) 8.1.0 kernel signature: ee9082ca360d78d784abe053c7c2b8532d9e0b22885559afe4744bc93dde35a2 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good e6187b3444e88ed9aa5f3843603e1f024b6d0309 Bisecting: 7696 revisions left to test after this (roughly 13 steps) [47ec5303d73ea344e84f46660fff693c57641386] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 47ec5303d73ea344e84f46660fff693c57641386 with gcc (GCC) 8.1.0 kernel signature: dfbf18439cca76c22d30b77dec72eba16e2782026ef79db8e7bc4312255fd252 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 47ec5303d73ea344e84f46660fff693c57641386 Bisecting: 3844 revisions left to test after this (roughly 12 steps) [086ba2ec163b638abd2a90ef3e8bab0238d02e56] Merge tag 'f2fs-for-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs testing commit 086ba2ec163b638abd2a90ef3e8bab0238d02e56 with gcc (GCC) 8.1.0 kernel signature: 8a00a3de3db7101c02cce396ac4a3d972c488658f578a5f4f52a282f96056f84 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 086ba2ec163b638abd2a90ef3e8bab0238d02e56 Bisecting: 1943 revisions left to test after this (roughly 11 steps) [f320ac6e131669345c7f4abefbb228b570eb9199] Merge branch 'work.epoll' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs testing commit f320ac6e131669345c7f4abefbb228b570eb9199 with gcc (GCC) 8.1.0 kernel signature: 2534c8656067d53ecdc21900fc6af3b5c2a37c9b6c00735bf265101bb8338dab all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good f320ac6e131669345c7f4abefbb228b570eb9199 Bisecting: 977 revisions left to test after this (roughly 10 steps) [b952e974300be3184049a125e7cba112fe659017] Merge tag 'for-linus' of git://github.com/openrisc/linux testing commit b952e974300be3184049a125e7cba112fe659017 with gcc (GCC) 8.1.0 kernel signature: a2883852efdf3098d2ac5292fcd76d623fab8a41fe77a066cb5ca3eb4323e31c all runs: OK # git bisect bad b952e974300be3184049a125e7cba112fe659017 Bisecting: 482 revisions left to test after this (roughly 9 steps) [662a0221893a3d58aa72719671844264306f6e4b] x86/entry: Fix AC assertion testing commit 662a0221893a3d58aa72719671844264306f6e4b with gcc (GCC) 8.1.0 kernel signature: 77e5d94cfb2664fc160fba7d07ab2afcd986e761a54f6b74d68d7fb44ef3f906 all runs: OK # git bisect bad 662a0221893a3d58aa72719671844264306f6e4b Bisecting: 242 revisions left to test after this (roughly 8 steps) [40129b8cb41704c98901e08c3edf8224b8af1b31] Merge tag 'gfs2-v5.9-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 testing commit 40129b8cb41704c98901e08c3edf8224b8af1b31 with gcc (GCC) 8.1.0 kernel signature: dc726133099843b876ce8e461d42bb730e1eaff6314df748f532e2c8c301580f all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 40129b8cb41704c98901e08c3edf8224b8af1b31 Bisecting: 124 revisions left to test after this (roughly 7 steps) [3edd8db2d53fe6c96ad66248bb1479ae62807268] Merge tag '5.9-rc2-smb-fix' of git://git.samba.org/sfrench/cifs-2.6 testing commit 3edd8db2d53fe6c96ad66248bb1479ae62807268 with gcc (GCC) 8.1.0 kernel signature: 12f4ff7b3696311e1ca4bd3d75dddd437f254cead84ecc4ab731ec993ebff3ad all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 3edd8db2d53fe6c96ad66248bb1479ae62807268 Bisecting: 65 revisions left to test after this (roughly 6 steps) [59815d6d1c773f3609ef9da50881a47e9cba9c25] Merge tag 'mmc-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc testing commit 59815d6d1c773f3609ef9da50881a47e9cba9c25 with gcc (GCC) 8.1.0 kernel signature: 1cf22d6dee98a6a62478666abdefdc7ff5bc32f86640249cb17a7e980dd46bad all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 59815d6d1c773f3609ef9da50881a47e9cba9c25 Bisecting: 25 revisions left to test after this (roughly 5 steps) [9c7d619be5a002ea29c172df5e3c1227c22cbb41] Merge tag 'perf-tools-fixes-for-v5.9-2020-09-01' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux testing commit 9c7d619be5a002ea29c172df5e3c1227c22cbb41 with gcc (GCC) 8.1.0 kernel signature: feee7dd7299fb6458be02718fcf4c4699acfc3e595c4ec193e4d71740feed0f1 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 9c7d619be5a002ea29c172df5e3c1227c22cbb41 Bisecting: 10 revisions left to test after this (roughly 4 steps) [c3a1309564d3834bad6547a50e58bd195ee85fb6] Merge tag 'for-5.9/dm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm testing commit c3a1309564d3834bad6547a50e58bd195ee85fb6 with gcc (GCC) 8.1.0 kernel signature: 4b4cb0da133741dfa4e752d749968fd0dd03341accad8bbaf32a546f5813fe43 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good c3a1309564d3834bad6547a50e58bd195ee85fb6 Bisecting: 5 revisions left to test after this (roughly 3 steps) [35556bed836f8dc07ac55f69c8d17dce3e7f0e25] HID: core: Sanitize event code and type when mapping input testing commit 35556bed836f8dc07ac55f69c8d17dce3e7f0e25 with gcc (GCC) 8.1.0 kernel signature: 439956fae7072cdc86d5be6675f9ffaaa1cc240677cb3dd60642e648b7a0b618 all runs: OK # git bisect bad 35556bed836f8dc07ac55f69c8d17dce3e7f0e25 Bisecting: 2 revisions left to test after this (roughly 1 step) [724a419ea28f7514a391e80040230f69cf626707] HID: microsoft: Add rumble support for the 8bitdo SN30 Pro+ controller testing commit 724a419ea28f7514a391e80040230f69cf626707 with gcc (GCC) 8.1.0 kernel signature: acd12d3a7cfb230863044e44343c9e2a9c75461d18c47fa696f610273f7713f6 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 724a419ea28f7514a391e80040230f69cf626707 Bisecting: 0 revisions left to test after this (roughly 1 step) [bce1305c0ece3dc549663605e567655dd701752c] HID: core: Correctly handle ReportSize being zero testing commit bce1305c0ece3dc549663605e567655dd701752c with gcc (GCC) 8.1.0 kernel signature: b9974ca5af2a5af7d637ab7792a09b266f7aa5b0ea1abc4fdce5793decf9fe12 all runs: OK # git bisect bad bce1305c0ece3dc549663605e567655dd701752c Bisecting: 0 revisions left to test after this (roughly 0 steps) [b7429ea53d6c0936a0f10a5d64164f0aea440143] HID: elan: Fix memleak in elan_input_configured testing commit b7429ea53d6c0936a0f10a5d64164f0aea440143 with gcc (GCC) 8.1.0 kernel signature: db02914d6bdf74b16dfd473e680492ee600a8202d6749fed075d72207f631aab all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good b7429ea53d6c0936a0f10a5d64164f0aea440143 bce1305c0ece3dc549663605e567655dd701752c is the first bad commit commit bce1305c0ece3dc549663605e567655dd701752c Author: Marc Zyngier Date: Sat Aug 29 12:26:01 2020 +0100 HID: core: Correctly handle ReportSize being zero It appears that a ReportSize value of zero is legal, even if a bit non-sensical. Most of the HID code seems to handle that gracefully, except when computing the total size in bytes. When fed as input to memset, this leads to some funky outcomes. Detect the corner case and correctly compute the size. Cc: stable@vger.kernel.org Signed-off-by: Marc Zyngier Signed-off-by: Benjamin Tissoires drivers/hid/hid-core.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) culprit signature: b9974ca5af2a5af7d637ab7792a09b266f7aa5b0ea1abc4fdce5793decf9fe12 parent signature: db02914d6bdf74b16dfd473e680492ee600a8202d6749fed075d72207f631aab revisions tested: 17, total time: 3h5m7.058546022s (build: 1h25m59.933110693s, test: 1h37m9.360965061s) first good commit: bce1305c0ece3dc549663605e567655dd701752c HID: core: Correctly handle ReportSize being zero recipients (to): ["benjamin.tissoires@gmail.com" "benjamin.tissoires@redhat.com" "jikos@kernel.org" "linux-input@vger.kernel.org" "maz@kernel.org"] recipients (cc): ["linux-kernel@vger.kernel.org"]