bisecting fixing commit since c03c21ba6f4e95e406a1a7b4c34ef334b977c194 building syzkaller on fcc6d71be2c3ce7d9305c04fc2e87af554571bac testing commit c03c21ba6f4e95e406a1a7b4c34ef334b977c194 with gcc (GCC) 10.2.1 20210217 kernel signature: 92002eb41e9bc9d27e38ab291753e5405d501ec857e2fccbe5e6474dabd6927c all runs: crashed: general protection fault in drm_client_buffer_vunmap testing current HEAD 52e44129fba5cfc4e351fdb5e45849afc74d9a53 testing commit 52e44129fba5cfc4e351fdb5e45849afc74d9a53 with gcc (GCC) 10.2.1 20210217 kernel signature: e5c5dda0d43ec87e4e892dcbff981ea68b0ab8f2054868b9cbb057949386356a all runs: OK # git bisect start 52e44129fba5cfc4e351fdb5e45849afc74d9a53 c03c21ba6f4e95e406a1a7b4c34ef334b977c194 Bisecting: 1878 revisions left to test after this (roughly 11 steps) [c8426b2700b57d2760ff335840a02f66a64b6044] ALSA: hda/realtek: Fix speaker amp setup on Acer Aspire E1 testing commit c8426b2700b57d2760ff335840a02f66a64b6044 with gcc (GCC) 10.2.1 20210217 kernel signature: 1996b86ed0f3cf9bebc893a2837746034bef84f12eeb2cc08dfc67ec5b24cd6c all runs: crashed: general protection fault in drm_client_buffer_vunmap # git bisect good c8426b2700b57d2760ff335840a02f66a64b6044 Bisecting: 943 revisions left to test after this (roughly 10 steps) [4ee998b0ef8b6d7b1267cd4d953182224929abba] Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux testing commit 4ee998b0ef8b6d7b1267cd4d953182224929abba with gcc (GCC) 10.2.1 20210217 kernel signature: a8eff2e6fe31e09979ab838bfb91242b581024a228a030a1291abbffa01f77ec all runs: OK # git bisect bad 4ee998b0ef8b6d7b1267cd4d953182224929abba Bisecting: 472 revisions left to test after this (roughly 9 steps) [b6b8aa27a3c64a958c8cc57ce3d37d3fbddfa3d6] Merge branch 'for-v5.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace testing commit b6b8aa27a3c64a958c8cc57ce3d37d3fbddfa3d6 with gcc (GCC) 10.2.1 20210217 kernel signature: 6e4c62019c14ecf5548c428b36247de7805776514be635ab43d7c003ced9bee9 all runs: OK # git bisect bad b6b8aa27a3c64a958c8cc57ce3d37d3fbddfa3d6 Bisecting: 190 revisions left to test after this (roughly 8 steps) [05a59d79793d482f628a31753c671f2e92178a21] Merge git://git.kernel.org:/pub/scm/linux/kernel/git/netdev/net testing commit 05a59d79793d482f628a31753c671f2e92178a21 with gcc (GCC) 10.2.1 20210217 kernel signature: 8d256fe0233b307d1b453cb9d4e643d684f8eb8fec4a96d9063311efe86bb2ad all runs: crashed: general protection fault in drm_client_buffer_vunmap # git bisect good 05a59d79793d482f628a31753c671f2e92178a21 Bisecting: 95 revisions left to test after this (roughly 7 steps) [b77b5fdd052e7ee61b35164abb10e8433d3160e8] Merge tag 'gfs2-v5.12-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 testing commit b77b5fdd052e7ee61b35164abb10e8433d3160e8 with gcc (GCC) 10.2.1 20210217 kernel signature: 56a0d51fdd9726f50c0d0444695fcbd306aa6d9f7c5299f4bef8f2934241ef61 all runs: OK # git bisect bad b77b5fdd052e7ee61b35164abb10e8433d3160e8 Bisecting: 59 revisions left to test after this (roughly 6 steps) [4042160c2e5433e0759782c402292a90b5bf458d] drm/nouveau: fix dma syncing for loops (v2) testing commit 4042160c2e5433e0759782c402292a90b5bf458d with gcc (GCC) 10.2.1 20210217 kernel signature: ffaa83d34ec742a3e13a6feaf5c982abb918811da4b28a1f3eacbc59e75b5628 all runs: OK # git bisect bad 4042160c2e5433e0759782c402292a90b5bf458d Bisecting: 18 revisions left to test after this (roughly 4 steps) [a5cb3c1a36376c25cd25fd3e99918dc48ac420bb] drm/amdgpu: fix S0ix handling when the CONFIG_AMD_PMC=m testing commit a5cb3c1a36376c25cd25fd3e99918dc48ac420bb with gcc (GCC) 10.2.1 20210217 kernel signature: 17e106c268fbb0ba035ff2ca1dc4989100bc8c78b9703e71541a80bd5d9fe30a all runs: crashed: general protection fault in drm_client_buffer_vunmap # git bisect good a5cb3c1a36376c25cd25fd3e99918dc48ac420bb Bisecting: 9 revisions left to test after this (roughly 3 steps) [ca63d76fd2319db984f2875992643f900caf2c72] drm/ttm: Fix TTM page pool accounting testing commit ca63d76fd2319db984f2875992643f900caf2c72 with gcc (GCC) 10.2.1 20210217 kernel signature: 47c290ec3f41c8965f390bed8eac571a9ffa47cb1a3cab5a05d0ecd82079f8fc all runs: OK # git bisect bad ca63d76fd2319db984f2875992643f900caf2c72 Bisecting: 4 revisions left to test after this (roughly 2 steps) [39a3898abf4dfb8702929832836b1f785b1c2bc4] fbdev: atyfb: always declare aty_{ld,st}_lcd() testing commit 39a3898abf4dfb8702929832836b1f785b1c2bc4 with gcc (GCC) 10.2.1 20210217 kernel signature: d264b80ad3008adfaf72c0e7d000f54c5ea94e58f702eddf88286b8a4cbfb15c all runs: OK # git bisect bad 39a3898abf4dfb8702929832836b1f785b1c2bc4 Bisecting: 1 revision left to test after this (roughly 1 step) [e8dd3506dcf380d4cbe983422dfed1909011b02a] drm/qxl: unpin release objects testing commit e8dd3506dcf380d4cbe983422dfed1909011b02a with gcc (GCC) 10.2.1 20210217 kernel signature: d264b80ad3008adfaf72c0e7d000f54c5ea94e58f702eddf88286b8a4cbfb15c all runs: OK # git bisect bad e8dd3506dcf380d4cbe983422dfed1909011b02a Bisecting: 0 revisions left to test after this (roughly 0 steps) [874a52f9b693ed8bf7a92b3592a547ce8a684e6f] drm/fb-helper: only unmap if buffer not null testing commit 874a52f9b693ed8bf7a92b3592a547ce8a684e6f with gcc (GCC) 10.2.1 20210217 kernel signature: d264b80ad3008adfaf72c0e7d000f54c5ea94e58f702eddf88286b8a4cbfb15c all runs: OK # git bisect bad 874a52f9b693ed8bf7a92b3592a547ce8a684e6f 874a52f9b693ed8bf7a92b3592a547ce8a684e6f is the first bad commit commit 874a52f9b693ed8bf7a92b3592a547ce8a684e6f Author: Tong Zhang Date: Sat Feb 27 23:46:25 2021 -0500 drm/fb-helper: only unmap if buffer not null drm_fbdev_cleanup() can be called when fb_helper->buffer is null, hence fb_helper->buffer should be checked before calling drm_client_buffer_vunmap(). This buffer is also checked in drm_client_framebuffer_delete(), so we should also do the same thing for drm_client_buffer_vunmap(). [ 199.128742] RIP: 0010:drm_client_buffer_vunmap+0xd/0x20 [ 199.129031] Code: 43 18 48 8b 53 20 49 89 45 00 49 89 55 08 5b 44 89 e0 41 5c 41 5d 41 5e 5d c3 0f 1f 00 53 48 89 fb 48 8d 7f 10 e8 73 7d a1 ff <48> 8b 7b 10 48 8d 73 18 5b e9 75 53 fc ff 0 f 1f 44 00 00 48 b8 00 [ 199.130041] RSP: 0018:ffff888103f3fc88 EFLAGS: 00010282 [ 199.130329] RAX: 0000000000000001 RBX: 0000000000000000 RCX: ffffffff8214d46d [ 199.130733] RDX: 1ffffffff079c6b9 RSI: 0000000000000246 RDI: ffffffff83ce35c8 [ 199.131119] RBP: ffff888103d25458 R08: 0000000000000001 R09: fffffbfff0791761 [ 199.131505] R10: ffffffff83c8bb07 R11: fffffbfff0791760 R12: 0000000000000000 [ 199.131891] R13: ffff888103d25468 R14: ffff888103d25418 R15: ffff888103f18120 [ 199.132277] FS: 00007f36fdcbb6a0(0000) GS:ffff88815b400000(0000) knlGS:0000000000000000 [ 199.132721] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 199.133033] CR2: 0000000000000010 CR3: 0000000103d26000 CR4: 00000000000006f0 [ 199.133420] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 199.133807] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 199.134195] Call Trace: [ 199.134333] drm_fbdev_cleanup+0x179/0x1a0 [ 199.134562] drm_fbdev_client_unregister+0x2b/0x40 [ 199.134828] drm_client_dev_unregister+0xa8/0x180 [ 199.135088] drm_dev_unregister+0x61/0x110 [ 199.135315] mgag200_pci_remove+0x38/0x52 [mgag200] [ 199.135586] pci_device_remove+0x62/0xe0 [ 199.135806] device_release_driver_internal+0x148/0x270 [ 199.136094] driver_detach+0x76/0xe0 [ 199.136294] bus_remove_driver+0x7e/0x100 [ 199.136521] pci_unregister_driver+0x28/0xf0 [ 199.136759] __x64_sys_delete_module+0x268/0x300 [ 199.137016] ? __ia32_sys_delete_module+0x300/0x300 [ 199.137285] ? call_rcu+0x3e4/0x580 [ 199.137481] ? fpregs_assert_state_consistent+0x4d/0x60 [ 199.137767] ? exit_to_user_mode_prepare+0x2f/0x130 [ 199.138037] do_syscall_64+0x33/0x40 [ 199.138237] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 199.138517] RIP: 0033:0x7f36fdc3dcf7 Signed-off-by: Tong Zhang Fixes: 763aea17bf57 ("drm/fb-helper: Unmap client buffer during shutdown") Cc: Thomas Zimmermann Cc: Sam Ravnborg Cc: Maxime Ripard Cc: Maarten Lankhorst Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: # v5.11+ Signed-off-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/20210228044625.171151-1-ztong0001@gmail.com Signed-off-by: Maarten Lankhorst drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) parent commit a38fd8748464831584a19438cbb3082b5a2dab15 wasn't tested testing commit a38fd8748464831584a19438cbb3082b5a2dab15 with gcc (GCC) 10.2.1 20210217 kernel signature: 97b9420495657e8d4cea0a26501ac458f5047da6a84954cfbb8a6e83bb2ac57d culprit signature: d264b80ad3008adfaf72c0e7d000f54c5ea94e58f702eddf88286b8a4cbfb15c parent signature: 97b9420495657e8d4cea0a26501ac458f5047da6a84954cfbb8a6e83bb2ac57d revisions tested: 13, total time: 3h8m54.320551192s (build: 1h31m49.561316389s, test: 1h35m22.288750328s) first good commit: 874a52f9b693ed8bf7a92b3592a547ce8a684e6f drm/fb-helper: only unmap if buffer not null recipients (to): ["maarten.lankhorst@linux.intel.com" "tzimmermann@suse.de" "ztong0001@gmail.com"] recipients (cc): []