bisecting fixing commit since b3c8e0de473e8c316ba32fa63c01e0ef497ed609 building syzkaller on 6acc789ad3f6c04319764f414ebb1a08e6145332 testing commit b3c8e0de473e8c316ba32fa63c01e0ef497ed609 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a87c5625de1a356d125b3bbb9bed0de696fe1a2a1d0e64351b7bd7c4610e461c run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: exit status NUM run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: crashed: WARNING in bpf_warn_invalid_xdp_action run #10: crashed: WARNING in bpf_warn_invalid_xdp_action run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK testing current HEAD 4e9120cbaca118f35a31a5e9986063e722614378 testing commit 4e9120cbaca118f35a31a5e9986063e722614378 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a345de89bcf2970e6ce42d787dc25e512c3e4d57e108518c1e4bbaf1413973fe all runs: OK # git bisect start 4e9120cbaca118f35a31a5e9986063e722614378 b3c8e0de473e8c316ba32fa63c01e0ef497ed609 Bisecting: 6304 revisions left to test after this (roughly 13 steps) [9149fe8ba7ff798ea1c6b1fa05eeb59f95f9a94a] Merge tag 'erofs-for-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs testing commit 9149fe8ba7ff798ea1c6b1fa05eeb59f95f9a94a compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3ec980a0bfd5efa0962fa4cab070e0b94200d32610444a5015a8dca6f230dc03 all runs: OK # git bisect bad 9149fe8ba7ff798ea1c6b1fa05eeb59f95f9a94a Bisecting: 3357 revisions left to test after this (roughly 12 steps) [9bcbf894b6872216ef61faf17248ec234e3db6bc] Merge tag 'media/v5.17-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media testing commit 9bcbf894b6872216ef61faf17248ec234e3db6bc compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6a01d53d512fd75e44151043ef1a5c2a1c53f2d9427c4b3bd88b9208023f4e09 run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 9bcbf894b6872216ef61faf17248ec234e3db6bc Bisecting: 1655 revisions left to test after this (roughly 11 steps) [e2dfb94f27f778e18e47b0c7ff8679099981073d] Merge tag 'for-net-next-2021-12-29' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next testing commit e2dfb94f27f778e18e47b0c7ff8679099981073d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5debcdb4bdb33a34d9f4c81c1a9461d15f7dbf8f97fed0001fe28c33e6d72b21 run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good e2dfb94f27f778e18e47b0c7ff8679099981073d Bisecting: 827 revisions left to test after this (roughly 10 steps) [1c824bf768d69fce36de748c60c7197a2b838944] Merge tag 'lkmm.2022.01.09a' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu testing commit 1c824bf768d69fce36de748c60c7197a2b838944 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7b870a32b867a1e19da1be314795b1fe1b59d9575596c04a6327c31fddf618d4 run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: exit status NUM run #1: basic kernel testing failed: BUG: program execution failed: executor NUM: exit status NUM run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect bad 1c824bf768d69fce36de748c60c7197a2b838944 Bisecting: 413 revisions left to test after this (roughly 9 steps) [32db1660ee01acebd18fc5759254930c874368af] docs: networking: device drivers: add can sub-folder testing commit 32db1660ee01acebd18fc5759254930c874368af compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 711c4b52617d5fe191ad6e09208b464976078469769acd48a37564e53f870227 run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect bad 32db1660ee01acebd18fc5759254930c874368af Bisecting: 206 revisions left to test after this (roughly 8 steps) [43710bfebf235112a2c640f43bda0408e2f9fce4] net: hns3: create new common cmd code for PF and VF modules testing commit 43710bfebf235112a2c640f43bda0408e2f9fce4 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8747891f64fa0b10177d7a8e2750dcfb62337f193bc7e24d5270fee44bcd9b7a all runs: OK # git bisect bad 43710bfebf235112a2c640f43bda0408e2f9fce4 Bisecting: 126 revisions left to test after this (roughly 7 steps) [9e6b19a66d9b6b94395478fe79c5a3ccba181ad3] bpf: Fix typo in a comment in bpf lpm_trie. testing commit 9e6b19a66d9b6b94395478fe79c5a3ccba181ad3 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: be83b8ff14db3371ab3c4d13f263d65df40ee186fcce622c970c39cd86c20cde all runs: OK # git bisect bad 9e6b19a66d9b6b94395478fe79c5a3ccba181ad3 Bisecting: 39 revisions left to test after this (roughly 5 steps) [aef2feda97b840ec38e9fa53d0065188453304e8] add missing bpf-cgroup.h includes testing commit aef2feda97b840ec38e9fa53d0065188453304e8 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 850441f3dcd96207ff241ec7b58d9e1e7c076becb5bd3f8e147ac9fc512a7378 all runs: OK # git bisect bad aef2feda97b840ec38e9fa53d0065188453304e8 Bisecting: 19 revisions left to test after this (roughly 4 steps) [f742fc68ac0da76d96e5713210b0aef771c1dd0f] libbpf: Add doc comments for bpf_program__(un)pin() testing commit f742fc68ac0da76d96e5713210b0aef771c1dd0f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: eb584d6d822abb57b77d04aa216a0682000d843a6c60ee00165f55ba0c4cd67c all runs: OK # git bisect bad f742fc68ac0da76d96e5713210b0aef771c1dd0f Bisecting: 9 revisions left to test after this (roughly 3 steps) [4b443bc1785f28df56fdbd6a107dc68ef7d5aa8e] libbpf: Don't validate TYPE_ID relo's original imm value testing commit 4b443bc1785f28df56fdbd6a107dc68ef7d5aa8e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e823ec388f49eb2c795855c248d59c20976f1849603caf36161a958d6b6b77fd run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: exit status NUM run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: crashed: WARNING in bpf_warn_invalid_xdp_action run #10: crashed: WARNING in bpf_warn_invalid_xdp_action run #11: crashed: WARNING in bpf_warn_invalid_xdp_action run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 4b443bc1785f28df56fdbd6a107dc68ef7d5aa8e Bisecting: 4 revisions left to test after this (roughly 2 steps) [006004b715569f742535f70f3f06b41d8135486c] selftests/bpf: Add tests for get_func_[arg|ret|arg_cnt] helpers testing commit 006004b715569f742535f70f3f06b41d8135486c compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8d5fa90784a240f5c6ea417b8cf7774fef8de8bd41f6292cf707030767b9e69a run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: OK run #9: OK run #10: crashed: WARNING in bpf_warn_invalid_xdp_action run #11: OK run #12: crashed: WARNING in bpf_warn_invalid_xdp_action run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 006004b715569f742535f70f3f06b41d8135486c Bisecting: 2 revisions left to test after this (roughly 1 step) [2cbad989033bff0256675c38f96f5faab852af4b] bpf: Do not WARN in bpf_warn_invalid_xdp_action() testing commit 2cbad989033bff0256675c38f96f5faab852af4b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e734bbf2256faef3c16e151967645b95668e0848ee50533a7c811f5fa72c080d run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect bad 2cbad989033bff0256675c38f96f5faab852af4b Bisecting: 0 revisions left to test after this (roughly 0 steps) [e94fac3829ddd3d9f21efa27d1512215b630782c] Merge branch 'bpf: Add helpers to access traced function arguments' testing commit e94fac3829ddd3d9f21efa27d1512215b630782c compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8d5fa90784a240f5c6ea417b8cf7774fef8de8bd41f6292cf707030767b9e69a run #0: crashed: WARNING in bpf_warn_invalid_xdp_action run #1: crashed: WARNING in bpf_warn_invalid_xdp_action run #2: crashed: WARNING in bpf_warn_invalid_xdp_action run #3: crashed: WARNING in bpf_warn_invalid_xdp_action run #4: crashed: WARNING in bpf_warn_invalid_xdp_action run #5: crashed: WARNING in bpf_warn_invalid_xdp_action run #6: crashed: WARNING in bpf_warn_invalid_xdp_action run #7: crashed: WARNING in bpf_warn_invalid_xdp_action run #8: crashed: WARNING in bpf_warn_invalid_xdp_action run #9: crashed: WARNING in bpf_warn_invalid_xdp_action run #10: crashed: WARNING in bpf_warn_invalid_xdp_action run #11: crashed: WARNING in bpf_warn_invalid_xdp_action run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good e94fac3829ddd3d9f21efa27d1512215b630782c 2cbad989033bff0256675c38f96f5faab852af4b is the first bad commit commit 2cbad989033bff0256675c38f96f5faab852af4b Author: Paolo Abeni Date: Tue Nov 30 11:08:06 2021 +0100 bpf: Do not WARN in bpf_warn_invalid_xdp_action() The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by any bugged program, and even attaching a correct program to a NIC not supporting the given action. The resulting splat, beyond polluting the logs, fouls automated tools: e.g. a syzkaller reproducers using an XDP program returning an unsupported action will never pass validation. Replace the WARN_ONCE with a less intrusive pr_warn_once(). Signed-off-by: Paolo Abeni Signed-off-by: Daniel Borkmann Acked-by: Toke Høiland-Jørgensen Link: https://lore.kernel.org/bpf/016ceec56e4817ebb2a9e35ce794d5c917df572c.1638189075.git.pabeni@redhat.com net/core/filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) culprit signature: e734bbf2256faef3c16e151967645b95668e0848ee50533a7c811f5fa72c080d parent signature: 8d5fa90784a240f5c6ea417b8cf7774fef8de8bd41f6292cf707030767b9e69a Reproducer flagged being flaky revisions tested: 15, total time: 3h7m37.891193157s (build: 1h44m13.57146682s, test: 1h21m51.685844228s) first good commit: 2cbad989033bff0256675c38f96f5faab852af4b bpf: Do not WARN in bpf_warn_invalid_xdp_action() recipients (to): ["daniel@iogearbox.net" "pabeni@redhat.com" "toke@redhat.com"] recipients (cc): []