ci2 starts bisection 2023-04-09 08:23:33.610537209 +0000 UTC m=+127544.618877698 bisecting fixing commit since 42616e0f09fb4e9a6c59892a227f7bdefbd2d6d3 building syzkaller on f08b59ac0d8759f409d594ddca4f08c920e23237 ensuring issue is reproducible on original commit 42616e0f09fb4e9a6c59892a227f7bdefbd2d6d3 testing commit 42616e0f09fb4e9a6c59892a227f7bdefbd2d6d3 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 1c7a9e97cc9256ad12fad808fc4d5704cfcb7039a9f2810d47cfb0f181ffcef0 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc00288c690] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0007ae320] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbd680] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #3: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbd720] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #4: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbd810] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #5: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbd8b0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #6: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0007ae460] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #7: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc00288c910] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #8: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc00288c9b0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #9: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbc0a0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #10: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0011040f0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #11: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbc410] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #12: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc006cbc5f0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #13: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc00288c500] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #14: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0011042d0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #15: crashed: possible deadlock in l2tp_tunnel_register run #16: crashed: possible deadlock in l2tp_tunnel_register run #17: crashed: possible deadlock in l2tp_tunnel_register run #18: crashed: possible deadlock in l2tp_tunnel_register run #19: crashed: possible deadlock in l2tp_tunnel_register testing current HEAD 543aff194ab6286af7791c5a138978ee7da4c93f testing commit 543aff194ab6286af7791c5a138978ee7da4c93f gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: de259e5f373e12e98157ed3967aa3f130fea3293f040de3f0b264c923f566b86 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc001104eb0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0014fccd0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect start 543aff194ab6286af7791c5a138978ee7da4c93f 42616e0f09fb4e9a6c59892a227f7bdefbd2d6d3 Bisecting: 919 revisions left to test after this (roughly 10 steps) [b08071c68b586b82c20bb972ed32dd1a8979b12f] ubifs: Fix wrong dirty space budget for dirty inode testing commit b08071c68b586b82c20bb972ed32dd1a8979b12f gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5e62b31d6d9e34607e40575d468b8db83f6d88ec2f282fed64bef4d6a4b67c82 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc003310c30] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc001104e60] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad b08071c68b586b82c20bb972ed32dd1a8979b12f Bisecting: 459 revisions left to test after this (roughly 9 steps) [bc6405bca8686c6159946be5625637f6de158865] power: supply: remove faulty cooling logic testing commit bc6405bca8686c6159946be5625637f6de158865 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0cdb9ab4aaf866da84f04430e3d6da0439f5d52e98bb4724932d1c909bc0c9b7 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0014fc8c0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000647950] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad bc6405bca8686c6159946be5625637f6de158865 Bisecting: 229 revisions left to test after this (roughly 8 steps) [332213a34e0aae778ae53f477dd3c2e5bf6dc09f] selftests/bpf: Fix out-of-srctree build testing commit 332213a34e0aae778ae53f477dd3c2e5bf6dc09f gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 46fa1ee08cc451b2a58c01fe9c3bf76c20997fa9d6c98fb8fca26c1465c26142 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000825c20] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000825cc0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: crashed: possible deadlock in l2tp_tunnel_register run #3: crashed: possible deadlock in l2tp_tunnel_register run #4: crashed: possible deadlock in l2tp_tunnel_register run #5: crashed: possible deadlock in l2tp_tunnel_register run #6: crashed: possible deadlock in l2tp_tunnel_register run #7: crashed: possible deadlock in l2tp_tunnel_register run #8: crashed: possible deadlock in l2tp_tunnel_register run #9: crashed: possible deadlock in l2tp_tunnel_register # git bisect good 332213a34e0aae778ae53f477dd3c2e5bf6dc09f Bisecting: 114 revisions left to test after this (roughly 7 steps) [f716ca292a7d1808d4135273bbdca093da195831] ALSA: hda: Fix the control element identification for multiple codecs testing commit f716ca292a7d1808d4135273bbdca093da195831 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d6478ae8c6f766c8d156de3d66dccb4acfd62bd8abe78fdec771bc40d86f1458 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000647a40] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc001104820] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad f716ca292a7d1808d4135273bbdca093da195831 Bisecting: 57 revisions left to test after this (roughly 6 steps) [ee8d6231ad072014f03885b089f4e29e20a3f29c] drm/panel-edp: fix name for IVO product id 854b testing commit ee8d6231ad072014f03885b089f4e29e20a3f29c gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6c8a6710ee082ebed7fb415ef101fe172eed56e06098156f5b6750cc56238a28 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000b3aeb0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000b3b0e0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad ee8d6231ad072014f03885b089f4e29e20a3f29c Bisecting: 28 revisions left to test after this (roughly 5 steps) [2e0b1754dd821d39e37e5db1a20aab6a488ed772] net: bcmgenet: fix MoCA LED control testing commit 2e0b1754dd821d39e37e5db1a20aab6a488ed772 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7561176e05b8bc8370a8179abf2374253d4ba42a4db4e66a95f3ad2473a7cd76 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc001206690] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0025cce10] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad 2e0b1754dd821d39e37e5db1a20aab6a488ed772 Bisecting: 13 revisions left to test after this (roughly 4 steps) [8c46157426022380f29534350dc85e7ed76e2c7b] wifi: mac80211: pass 'sta' to ieee80211_rx_data_set_sta() testing commit 8c46157426022380f29534350dc85e7ed76e2c7b gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: aaa4df6babdf9d5372cc0cdab5db9db69fc51d095afd5ad1d8f1e3641d2fe4c3 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0025ccaf0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc001749040] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: crashed: possible deadlock in l2tp_tunnel_register run #3: crashed: possible deadlock in l2tp_tunnel_register run #4: crashed: possible deadlock in l2tp_tunnel_register run #5: crashed: possible deadlock in l2tp_tunnel_register run #6: crashed: possible deadlock in l2tp_tunnel_register run #7: crashed: possible deadlock in l2tp_tunnel_register run #8: crashed: possible deadlock in l2tp_tunnel_register run #9: crashed: possible deadlock in l2tp_tunnel_register # git bisect good 8c46157426022380f29534350dc85e7ed76e2c7b Bisecting: 6 revisions left to test after this (roughly 3 steps) [bb1cc7fc3e1da20d456f978a8fea4f72535f8159] bpf: Fix global subprog context argument resolution logic testing commit bb1cc7fc3e1da20d456f978a8fea4f72535f8159 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ad63a824cd07407f80c4d62111a6b1e164275d86cb984050c4ef4ef3b4f5a073 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc00074aeb0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000825d60] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: crashed: possible deadlock in l2tp_tunnel_register run #3: crashed: possible deadlock in l2tp_tunnel_register run #4: crashed: possible deadlock in l2tp_tunnel_register run #5: crashed: possible deadlock in l2tp_tunnel_register run #6: crashed: possible deadlock in l2tp_tunnel_register run #7: crashed: possible deadlock in l2tp_tunnel_register run #8: crashed: possible deadlock in l2tp_tunnel_register run #9: crashed: possible deadlock in l2tp_tunnel_register # git bisect good bb1cc7fc3e1da20d456f978a8fea4f72535f8159 Bisecting: 3 revisions left to test after this (roughly 2 steps) [f2f46de98c11d41ac8d22765f47ba54ce5480a5b] net/smc: fix potential panic dues to unprotected smc_llc_srv_add_link() testing commit f2f46de98c11d41ac8d22765f47ba54ce5480a5b gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 219492bb1d0fb42b0a02f752dd406ad374635b52ba29ddba955977d63876437c run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0048d87d0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0009d11d0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: crashed: possible deadlock in l2tp_tunnel_register run #3: crashed: possible deadlock in l2tp_tunnel_register run #4: crashed: possible deadlock in l2tp_tunnel_register run #5: crashed: possible deadlock in l2tp_tunnel_register run #6: crashed: possible deadlock in l2tp_tunnel_register run #7: crashed: possible deadlock in l2tp_tunnel_register run #8: crashed: possible deadlock in l2tp_tunnel_register run #9: crashed: possible deadlock in l2tp_tunnel_register # git bisect good f2f46de98c11d41ac8d22765f47ba54ce5480a5b Bisecting: 1 revision left to test after this (roughly 1 step) [5982e3f4886ed8f2725fc69e425cafc4a67e8740] selftests/net: Interpret UDP_GRO cmsg data as an int value testing commit 5982e3f4886ed8f2725fc69e425cafc4a67e8740 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 1e71c4b20cb29b289bfa066181e9ef9b00ca6c6e645401dc67d66aee375d9090 run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc000bbae60] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0007ae0f0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: crashed: possible deadlock in l2tp_tunnel_register run #3: crashed: possible deadlock in l2tp_tunnel_register run #4: crashed: possible deadlock in l2tp_tunnel_register run #5: crashed: possible deadlock in l2tp_tunnel_register run #6: crashed: possible deadlock in l2tp_tunnel_register run #7: crashed: possible deadlock in l2tp_tunnel_register run #8: crashed: possible deadlock in l2tp_tunnel_register run #9: crashed: possible deadlock in l2tp_tunnel_register # git bisect good 5982e3f4886ed8f2725fc69e425cafc4a67e8740 Bisecting: 0 revisions left to test after this (roughly 0 steps) [4bb736b40475528ac1aa8c98b368563618488a70] l2tp: Avoid possible recursive deadlock in l2tp_tunnel_register() testing commit 4bb736b40475528ac1aa8c98b368563618488a70 gcc compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 45c3576e0eebca9f809d33d8eba3bc3edfac85391a12c3e06c5f88f50ce2537d run #0: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0009d1ea0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #1: boot failed: create image operation failed: &{Code:QUOTA_EXCEEDED ErrorDetails:[0xc0000c61e0] Location: Message:Quota 'T2A_CPUS' exceeded. Limit: 64.0 in region us-central1. ForceSendFields:[] NullFields:[]}. run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad 4bb736b40475528ac1aa8c98b368563618488a70 4bb736b40475528ac1aa8c98b368563618488a70 is the first bad commit commit 4bb736b40475528ac1aa8c98b368563618488a70 Author: Shigeru Yoshida Date: Fri Feb 17 01:37:10 2023 +0900 l2tp: Avoid possible recursive deadlock in l2tp_tunnel_register() [ Upstream commit 9ca5e7ecab064f1f47da07f7c1ddf40e4bc0e5ac ] When a file descriptor of pppol2tp socket is passed as file descriptor of UDP socket, a recursive deadlock occurs in l2tp_tunnel_register(). This situation is reproduced by the following program: int main(void) { int sock; struct sockaddr_pppol2tp addr; sock = socket(AF_PPPOX, SOCK_DGRAM, PX_PROTO_OL2TP); if (sock < 0) { perror("socket"); return 1; } addr.sa_family = AF_PPPOX; addr.sa_protocol = PX_PROTO_OL2TP; addr.pppol2tp.pid = 0; addr.pppol2tp.fd = sock; addr.pppol2tp.addr.sin_family = PF_INET; addr.pppol2tp.addr.sin_port = htons(0); addr.pppol2tp.addr.sin_addr.s_addr = inet_addr("192.168.0.1"); addr.pppol2tp.s_tunnel = 1; addr.pppol2tp.s_session = 0; addr.pppol2tp.d_tunnel = 0; addr.pppol2tp.d_session = 0; if (connect(sock, (const struct sockaddr *)&addr, sizeof(addr)) < 0) { perror("connect"); return 1; } return 0; } This program causes the following lockdep warning: ============================================ WARNING: possible recursive locking detected 6.2.0-rc5-00205-gc96618275234 #56 Not tainted -------------------------------------------- repro/8607 is trying to acquire lock: ffff8880213c8130 (sk_lock-AF_PPPOX){+.+.}-{0:0}, at: l2tp_tunnel_register+0x2b7/0x11c0 but task is already holding lock: ffff8880213c8130 (sk_lock-AF_PPPOX){+.+.}-{0:0}, at: pppol2tp_connect+0xa82/0x1a30 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(sk_lock-AF_PPPOX); lock(sk_lock-AF_PPPOX); *** DEADLOCK *** May be due to missing lock nesting notation 1 lock held by repro/8607: #0: ffff8880213c8130 (sk_lock-AF_PPPOX){+.+.}-{0:0}, at: pppol2tp_connect+0xa82/0x1a30 stack backtrace: CPU: 0 PID: 8607 Comm: repro Not tainted 6.2.0-rc5-00205-gc96618275234 #56 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.1-2.fc37 04/01/2014 Call Trace: dump_stack_lvl+0x100/0x178 __lock_acquire.cold+0x119/0x3b9 ? lockdep_hardirqs_on_prepare+0x410/0x410 lock_acquire+0x1e0/0x610 ? l2tp_tunnel_register+0x2b7/0x11c0 ? lock_downgrade+0x710/0x710 ? __fget_files+0x283/0x3e0 lock_sock_nested+0x3a/0xf0 ? l2tp_tunnel_register+0x2b7/0x11c0 l2tp_tunnel_register+0x2b7/0x11c0 ? sprintf+0xc4/0x100 ? l2tp_tunnel_del_work+0x6b0/0x6b0 ? debug_object_deactivate+0x320/0x320 ? lockdep_init_map_type+0x16d/0x7a0 ? lockdep_init_map_type+0x16d/0x7a0 ? l2tp_tunnel_create+0x2bf/0x4b0 ? l2tp_tunnel_create+0x3c6/0x4b0 pppol2tp_connect+0x14e1/0x1a30 ? pppol2tp_put_sk+0xd0/0xd0 ? aa_sk_perm+0x2b7/0xa80 ? aa_af_perm+0x260/0x260 ? bpf_lsm_socket_connect+0x9/0x10 ? pppol2tp_put_sk+0xd0/0xd0 __sys_connect_file+0x14f/0x190 __sys_connect+0x133/0x160 ? __sys_connect_file+0x190/0x190 ? lockdep_hardirqs_on+0x7d/0x100 ? ktime_get_coarse_real_ts64+0x1b7/0x200 ? ktime_get_coarse_real_ts64+0x147/0x200 ? __audit_syscall_entry+0x396/0x500 __x64_sys_connect+0x72/0xb0 do_syscall_64+0x38/0xb0 entry_SYSCALL_64_after_hwframe+0x63/0xcd This patch fixes the issue by getting/creating the tunnel before locking the pppol2tp socket. Fixes: 0b2c59720e65 ("l2tp: close all race conditions in l2tp_tunnel_register()") Cc: Cong Wang Signed-off-by: Shigeru Yoshida Reviewed-by: Guillaume Nault Signed-off-by: David S. Miller Signed-off-by: Sasha Levin net/l2tp/l2tp_ppp.c | 125 ++++++++++++++++++++++++++++------------------------ 1 file changed, 67 insertions(+), 58 deletions(-) culprit signature: 45c3576e0eebca9f809d33d8eba3bc3edfac85391a12c3e06c5f88f50ce2537d parent signature: 1e71c4b20cb29b289bfa066181e9ef9b00ca6c6e645401dc67d66aee375d9090 revisions tested: 13, total time: 7h7m48.234840229s (build: 5h36m54.849735081s, test: 1h18m0.197335099s) first good commit: 4bb736b40475528ac1aa8c98b368563618488a70 l2tp: Avoid possible recursive deadlock in l2tp_tunnel_register() recipients (to): ["davem@davemloft.net" "gnault@redhat.com" "sashal@kernel.org" "syoshida@redhat.com"] recipients (cc): []