ci starts bisection 2023-01-29 12:15:13.040012781 +0000 UTC m=+579826.986074848 bisecting fixing commit since 296a7b7eb79246912de31ee799cb85220931231a building syzkaller on 67be1ae742603edad9c97d30b6ed69f9bbe2ffa8 ensuring issue is reproducible on original commit 296a7b7eb79246912de31ee799cb85220931231a testing commit 296a7b7eb79246912de31ee799cb85220931231a gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8ad4bba0d28879c9c9fe1c44024b0657e5541e4b040b73ebd15533edc9c3ebfc all runs: crashed: WARNING in arp_ioctl testing current HEAD 6d796c50f84ca79f1722bb131799e5a5710c4700 testing commit 6d796c50f84ca79f1722bb131799e5a5710c4700 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5e421d360c4345318fe5dbbaedb5d991cd7284e474ef2a2872122e939a9fc34a all runs: OK # git bisect start 6d796c50f84ca79f1722bb131799e5a5710c4700 296a7b7eb79246912de31ee799cb85220931231a Bisecting: 8704 revisions left to test after this (roughly 13 steps) [1ca06f1c1acecbe02124f14a37cce347b8c1a90c] Merge tag 'xtensa-20221213' of https://github.com/jcmvbkbc/linux-xtensa testing commit 1ca06f1c1acecbe02124f14a37cce347b8c1a90c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9fb6efc1707e2037602a66119b04fd5c859febb783d186833acf55860a098bd7 all runs: crashed: WARNING in arp_ioctl # git bisect good 1ca06f1c1acecbe02124f14a37cce347b8c1a90c Bisecting: 4281 revisions left to test after this (roughly 12 steps) [58bcac11fd94f950abc7b8466c5ceac7be07a00e] Merge tag 'usb-6.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb testing commit 58bcac11fd94f950abc7b8466c5ceac7be07a00e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0ec660454f040dcde04b126cac4b5ce2da2c6d56da5af4299e6fceb59b457755 all runs: OK # git bisect bad 58bcac11fd94f950abc7b8466c5ceac7be07a00e Bisecting: 2210 revisions left to test after this (roughly 11 steps) [b11919e1bb7f6f6273f5a33947b8496da2769eb8] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit b11919e1bb7f6f6273f5a33947b8496da2769eb8 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 923bf923bc6492eff78147096437de311ab49e52245dae3d05be89e98194b5eb all runs: OK # git bisect bad b11919e1bb7f6f6273f5a33947b8496da2769eb8 Bisecting: 1100 revisions left to test after this (roughly 10 steps) [c609d739947894d7370eae4cf04eb2c49e910bcf] Merge tag 'wireless-next-2022-11-18' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next testing commit c609d739947894d7370eae4cf04eb2c49e910bcf gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: fe3db7b5c83a6b45bfa8b81718d06fcb42d0d11ac5ee404777703f787467b83b run #0: failed: failed to run binary in VM: broken console: Permission denied (publickey) run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad c609d739947894d7370eae4cf04eb2c49e910bcf Bisecting: 554 revisions left to test after this (roughly 9 steps) [d3a4706339da26633316357efe7ab9a92ff29b2a] Merge branch 'rocker-two-small-changes' testing commit d3a4706339da26633316357efe7ab9a92ff29b2a gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e58227421319b40ea149cc8d29cf1c44a87844b7aa71552208cabc5c5754182f all runs: boot failed: WARNING in genl_register_family # git bisect skip d3a4706339da26633316357efe7ab9a92ff29b2a Bisecting: 555 revisions left to test after this (roughly 9 steps) [386b4174827ce0c7ecc789a6c8bf98e994dc2dee] rocker: Explicitly mark learned FDB entries as offloaded testing commit 386b4174827ce0c7ecc789a6c8bf98e994dc2dee gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 98b57e2bd084dd5965338d47d4b413db0d141be7db06b655e062ecfbd4b28c71 all runs: boot failed: WARNING in genl_register_family # git bisect skip 386b4174827ce0c7ecc789a6c8bf98e994dc2dee Bisecting: 555 revisions left to test after this (roughly 9 steps) [5c624a1d77d3eb2e314b59282b1213fa760d192c] Merge branch 'netlink-formatted-extacks' testing commit 5c624a1d77d3eb2e314b59282b1213fa760d192c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5a0fc207749a2e97efda12a897b3f9eb659e9ed4a0b8a9ed07af8e14c99f8daf all runs: boot failed: WARNING in cpumask_next_wrap # git bisect skip 5c624a1d77d3eb2e314b59282b1213fa760d192c Bisecting: 555 revisions left to test after this (roughly 9 steps) [95170a46b7dddbc3ac31b20ef2e8fa9d556d783d] wifi: iwlwifi: mei: don't send SAP commands if AMT is disabled testing commit 95170a46b7dddbc3ac31b20ef2e8fa9d556d783d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: fe927c9b0c18383fe774b0cebf9058377eb4a90b8262db870cb84e732ce65e11 all runs: boot failed: WARNING in genl_register_family # git bisect skip 95170a46b7dddbc3ac31b20ef2e8fa9d556d783d Bisecting: 555 revisions left to test after this (roughly 9 steps) [8f88474ce3eca2dd8fb4e08d4b6ab71e76312e3e] wifi: rtw89: 8852b: add chip_ops to get thermal testing commit 8f88474ce3eca2dd8fb4e08d4b6ab71e76312e3e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 98dd88946d0fb40770cceca367651de3b5becd44b52c20dcf9932607129eb55d all runs: crashed: WARNING in arp_ioctl # git bisect good 8f88474ce3eca2dd8fb4e08d4b6ab71e76312e3e Bisecting: 516 revisions left to test after this (roughly 9 steps) [07d90c72efbef9767042b1b110420b9a41b6b978] Merge branch 'BPF verifier precision tracking improvements' testing commit 07d90c72efbef9767042b1b110420b9a41b6b978 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ac9845dbe59b122b5078d7136ec0aa01af46d5f37d2af4e4f721f9d150a50625 all runs: OK # git bisect bad 07d90c72efbef9767042b1b110420b9a41b6b978 Bisecting: 257 revisions left to test after this (roughly 8 steps) [4519fc45beebcb05a052ea631d22c85e3ab5665d] net/mlx5: DR, Keep track of hot ICM chunks in an array instead of list testing commit 4519fc45beebcb05a052ea631d22c85e3ab5665d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c68b6767d365851a2d0a59ec6583566a81126ddc1e2e96a2eb05903e71fefc0a all runs: OK # git bisect bad 4519fc45beebcb05a052ea631d22c85e3ab5665d Bisecting: 128 revisions left to test after this (roughly 7 steps) [45034224623a5634e4ccc57b497ac825c260170f] bnxt_en: check and resize NVRAM UPDATE entry before flashing testing commit 45034224623a5634e4ccc57b497ac825c260170f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9b3c74f46bacca44d9d1b513fff614e62118a18a9e5a1dd484385be0084a5e9b all runs: crashed: WARNING in arp_ioctl # git bisect good 45034224623a5634e4ccc57b497ac825c260170f Bisecting: 60 revisions left to test after this (roughly 6 steps) [9c8dddab2a3c30a8c1d410c906afbcacb46f8a3f] Merge git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next testing commit 9c8dddab2a3c30a8c1d410c906afbcacb46f8a3f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a0f21beb4d7462309b9795283c9077c4f97747e0318f804d77c7bdc0b9661510 all runs: OK # git bisect bad 9c8dddab2a3c30a8c1d410c906afbcacb46f8a3f Bisecting: 33 revisions left to test after this (roughly 5 steps) [022f19cf361bdbc72b51e684573c847c4f37478d] net: hinic: Set max_mtu/min_mtu directly to simplify the code. testing commit 022f19cf361bdbc72b51e684573c847c4f37478d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: bb9cd8ef7fbf35cb082b32db543c9fb3b6f0a96d8e95cb01667557dc57bc9d11 all runs: OK # git bisect bad 022f19cf361bdbc72b51e684573c847c4f37478d Bisecting: 16 revisions left to test after this (roughly 4 steps) [5444b0ea9915132b8a202c2c664630cb99daa969] net: ipa: verify table sizes fit in commands early testing commit 5444b0ea9915132b8a202c2c664630cb99daa969 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d93a3e920d140dbffdd070da477b1ee9fc98d42fbd0ac262b6a8e12a043ec30c all runs: crashed: WARNING in arp_ioctl # git bisect good 5444b0ea9915132b8a202c2c664630cb99daa969 Bisecting: 8 revisions left to test after this (roughly 3 steps) [d3d429047cc66ff49780c93e4fccd9527723d385] mptcp: sockopt: make 'tcp_fastopen_connect' generic testing commit d3d429047cc66ff49780c93e4fccd9527723d385 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 49b7569ca663686da754a17e763d5f2adfbbf6fc824dd304c582682083224ff5 all runs: crashed: WARNING in arp_ioctl # git bisect good d3d429047cc66ff49780c93e4fccd9527723d385 Bisecting: 3 revisions left to test after this (roughly 2 steps) [b5f0de6df6dce8d641ef58ef7012f3304dffb9a1] net: dev: Convert sa_data to flexible array in struct sockaddr testing commit b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 13f416391a51a4917f393095915793ba16d34e433f0f83d9f5f928ba8d8a7498 all runs: OK # git bisect bad b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 Bisecting: 1 revision left to test after this (roughly 1 step) [6459838af0c08ea2b38fad6e153576549ca3b92f] Merge branch 'mptcp-socket-option-updates' testing commit 6459838af0c08ea2b38fad6e153576549ca3b92f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c964fd91b4d64f6911cf2568c4ede1e4bdedc7f3b66a51df2e5b520ec6ee8ad7 all runs: crashed: WARNING in arp_ioctl # git bisect good 6459838af0c08ea2b38fad6e153576549ca3b92f Bisecting: 0 revisions left to test after this (roughly 0 steps) [d6dd508080a3cdc0ab34ebf66c3734f2dff907ad] bnx2: Use kmalloc_size_roundup() to match ksize() usage testing commit d6dd508080a3cdc0ab34ebf66c3734f2dff907ad gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 854fa920fa4e8556cadd229445126c06c420f6200913afdd046d6ea704f0bd98 all runs: crashed: WARNING in arp_ioctl # git bisect good d6dd508080a3cdc0ab34ebf66c3734f2dff907ad b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 is the first bad commit commit b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 Author: Kees Cook Date: Tue Oct 18 02:56:03 2022 -0700 net: dev: Convert sa_data to flexible array in struct sockaddr One of the worst offenders of "fake flexible arrays" is struct sockaddr, as it is the classic example of why GCC and Clang have been traditionally forced to treat all trailing arrays as fake flexible arrays: in the distant misty past, sa_data became too small, and code started just treating it as a flexible array, even though it was fixed-size. The special case by the compiler is specifically that sizeof(sa->sa_data) and FORTIFY_SOURCE (which uses __builtin_object_size(sa->sa_data, 1)) do not agree (14 and -1 respectively), which makes FORTIFY_SOURCE treat it as a flexible array. However, the coming -fstrict-flex-arrays compiler flag will remove these special cases so that FORTIFY_SOURCE can gain coverage over all the trailing arrays in the kernel that are _not_ supposed to be treated as a flexible array. To deal with this change, convert sa_data to a true flexible array. To keep the structure size the same, move sa_data into a union with a newly introduced sa_data_min with the original size. The result is that FORTIFY_SOURCE can continue to have no idea how large sa_data may actually be, but anything using sizeof(sa->sa_data) must switch to sizeof(sa->sa_data_min). Cc: Jens Axboe Cc: Pavel Begunkov Cc: David Ahern Cc: Dylan Yudaken Cc: Yajun Deng Cc: Petr Machata Cc: Hangbin Liu Cc: Leon Romanovsky Cc: syzbot Cc: Willem de Bruijn Cc: Pablo Neira Ayuso Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20221018095503.never.671-kees@kernel.org Signed-off-by: Jakub Kicinski include/linux/socket.h | 5 ++++- net/core/dev.c | 2 +- net/core/dev_ioctl.c | 2 +- net/packet/af_packet.c | 10 +++++----- 4 files changed, 11 insertions(+), 8 deletions(-) culprit signature: 13f416391a51a4917f393095915793ba16d34e433f0f83d9f5f928ba8d8a7498 parent signature: 854fa920fa4e8556cadd229445126c06c420f6200913afdd046d6ea704f0bd98 revisions tested: 21, total time: 7h4m26.398147576s (build: 4h36m25.261034593s, test: 2h23m19.034672782s) first good commit: b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 net: dev: Convert sa_data to flexible array in struct sockaddr recipients (to): ["davem@davemloft.net" "edumazet@google.com" "keescook@chromium.org" "kuba@kernel.org" "kuba@kernel.org" "llvm@lists.linux.dev" "nathan@kernel.org" "ndesaulniers@google.com" "netdev@vger.kernel.org" "pabeni@redhat.com" "willemdebruijn.kernel@gmail.com"] recipients (cc): ["asml.silence@gmail.com" "axboe@kernel.dk" "bigeasy@linutronix.de" "dsahern@kernel.org" "dylany@fb.com" "keescook@chromium.org" "linux-kernel@vger.kernel.org" "petrm@nvidia.com" "trix@redhat.com" "yajun.deng@linux.dev"]