bisecting fixing commit since 4d469ec8ec05e1fa4792415de1a95b28871ff2fa building syzkaller on 23a562dfb3a9986a066a1341c2cfc9e87a8fa164 testing commit 4d469ec8ec05e1fa4792415de1a95b28871ff2fa with gcc (GCC) 10.2.1 20210217 kernel signature: 0d67919be8adb0b1a0273a1f47153fd5f3deb930cedb7c885fa2bf686b4cebf4 run #0: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: crashed: WARNING: ODEBUG bug in slave_kobj_release run #3: crashed: WARNING: ODEBUG bug in slave_kobj_release run #4: crashed: WARNING: ODEBUG bug in slave_kobj_release run #5: crashed: WARNING: ODEBUG bug in slave_kobj_release run #6: crashed: WARNING: ODEBUG bug in slave_kobj_release run #7: crashed: WARNING: ODEBUG bug in slave_kobj_release run #8: crashed: WARNING: ODEBUG bug in slave_kobj_release run #9: crashed: WARNING: ODEBUG bug in slave_kobj_release run #10: crashed: WARNING: ODEBUG bug in slave_kobj_release run #11: crashed: WARNING: ODEBUG bug in slave_kobj_release run #12: crashed: WARNING: ODEBUG bug in slave_kobj_release run #13: crashed: WARNING: ODEBUG bug in slave_kobj_release run #14: crashed: WARNING: ODEBUG bug in slave_kobj_release run #15: crashed: WARNING: ODEBUG bug in slave_kobj_release run #16: crashed: WARNING: ODEBUG bug in slave_kobj_release run #17: crashed: WARNING: ODEBUG bug in slave_kobj_release run #18: crashed: WARNING: ODEBUG bug in slave_kobj_release run #19: crashed: WARNING: ODEBUG bug in slave_kobj_release testing current HEAD a432c771e2d9bc059ffe3028faf040c08b6a9f98 testing commit a432c771e2d9bc059ffe3028faf040c08b6a9f98 with gcc (GCC) 10.2.1 20210217 kernel signature: 18deaa2d03a927cfcbbd923aa8247f02829727967bdfcc8d9a43d97353637fa2 all runs: OK # git bisect start a432c771e2d9bc059ffe3028faf040c08b6a9f98 4d469ec8ec05e1fa4792415de1a95b28871ff2fa Bisecting: 16221 revisions left to test after this (roughly 14 steps) [ad542fb7f2e2bb30c06381e77d4b29e895576ddc] mpls: Remove redundant assignment to err testing commit ad542fb7f2e2bb30c06381e77d4b29e895576ddc with gcc (GCC) 10.2.1 20210217 kernel signature: 474a54aa03e72b5bf7b7a920ac5b75dcb6e31d0a17b7978affb1a123026a91c1 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #9: crashed: WARNING in __nf_unregister_net_hook # git bisect good ad542fb7f2e2bb30c06381e77d4b29e895576ddc Bisecting: 7994 revisions left to test after this (roughly 13 steps) [d72cd4ad4174cfd2257c426ad51e4f53bcfde9c9] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi testing commit d72cd4ad4174cfd2257c426ad51e4f53bcfde9c9 with gcc (GCC) 10.2.1 20210217 kernel signature: c6e78194b769026be9e217843513632226836680d1b41cb1863d1f9a648c892d run #0: crashed: WARNING: ODEBUG bug in slave_kobj_release run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #3: crashed: WARNING: ODEBUG bug in slave_kobj_release run #4: crashed: WARNING: ODEBUG bug in slave_kobj_release run #5: crashed: WARNING: ODEBUG bug in slave_kobj_release run #6: crashed: WARNING: ODEBUG bug in slave_kobj_release run #7: crashed: WARNING: ODEBUG bug in slave_kobj_release run #8: crashed: WARNING: ODEBUG bug in slave_kobj_release run #9: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good d72cd4ad4174cfd2257c426ad51e4f53bcfde9c9 Bisecting: 3976 revisions left to test after this (roughly 12 steps) [a647034fe26b92702d5084b518c061e3cebefbaf] Merge tag 'nfs-for-5.13-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs testing commit a647034fe26b92702d5084b518c061e3cebefbaf with gcc (GCC) 10.2.1 20210217 kernel signature: 9166c364cf6a6b890dee6125f8f5b8861b759e31efb23b66f939097c8f6e0561 run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook run #8: crashed: WARNING in __nf_unregister_net_hook run #9: crashed: WARNING in __nf_unregister_net_hook # git bisect good a647034fe26b92702d5084b518c061e3cebefbaf Bisecting: 1988 revisions left to test after this (roughly 11 steps) [009c9aa5be652675a06d5211e1640e02bbb1c33d] Linux 5.13-rc6 testing commit 009c9aa5be652675a06d5211e1640e02bbb1c33d with gcc (GCC) 10.2.1 20210217 kernel signature: 61b82675cdc0d651067cc5103079760d3e2dbfc253b94b2ec1c3e963233f0b2c run #0: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good 009c9aa5be652675a06d5211e1640e02bbb1c33d Bisecting: 994 revisions left to test after this (roughly 10 steps) [d8ea89fe8a49bfa18b009b16b66c137dba263f87] mvpp2: prefetch right address testing commit d8ea89fe8a49bfa18b009b16b66c137dba263f87 with gcc (GCC) 10.2.1 20210217 kernel signature: d179fd64f781a9be1afe70e9453493e810b8842dd133db2c96f194d22e1030ab run #0: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good d8ea89fe8a49bfa18b009b16b66c137dba263f87 Bisecting: 497 revisions left to test after this (roughly 9 steps) [4de772511fd13aa5e7b9bf485ce26f87e6de2bb8] Merge branch 'gianfar-64-bit-stats' testing commit 4de772511fd13aa5e7b9bf485ce26f87e6de2bb8 with gcc (GCC) 10.2.1 20210217 kernel signature: 8383da429fb71b7af3bacfd1c5a47cbd8615dacf16864eb13c8b486c6620f9c0 run #0: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 4de772511fd13aa5e7b9bf485ce26f87e6de2bb8 Bisecting: 248 revisions left to test after this (roughly 8 steps) [9ed13a17e38e0537e24d9b507645002bf8d0201f] Merge tag 'net-5.13-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 9ed13a17e38e0537e24d9b507645002bf8d0201f with gcc (GCC) 10.2.1 20210217 kernel signature: 871e3b64b031e641e393ca8233f14d01646009bec46feb34b03f7e74db4ed332 all runs: OK # git bisect bad 9ed13a17e38e0537e24d9b507645002bf8d0201f Bisecting: 124 revisions left to test after this (roughly 7 steps) [224004fbb033600715dbd626bceec10bfd9c58bc] sh_eth: Avoid memcpy() over-reading of ETH_SS_STATS testing commit 224004fbb033600715dbd626bceec10bfd9c58bc with gcc (GCC) 10.2.1 20210217 kernel signature: f0608fe3811539525c5af4ee58b21cb10ea1b58b1e36fdd577fdcd8cf6f7172e all runs: OK # git bisect bad 224004fbb033600715dbd626bceec10bfd9c58bc Bisecting: 61 revisions left to test after this (roughly 6 steps) [07718be265680dcf496347d475ce1a5442f55ad7] mptcp: Fix out of bounds when parsing TCP options testing commit 07718be265680dcf496347d475ce1a5442f55ad7 with gcc (GCC) 10.2.1 20210217 kernel signature: 0db45b8941d2a209f109c78f41c3aabbd0a946ba58672956f0bd74834eed2895 all runs: OK # git bisect bad 07718be265680dcf496347d475ce1a5442f55ad7 Bisecting: 27 revisions left to test after this (roughly 5 steps) [93124d4a90ba6ef05cabb3b8430d51f2764345c6] Merge tag 'mac80211-for-net-2021-06-09' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 testing commit 93124d4a90ba6ef05cabb3b8430d51f2764345c6 with gcc (GCC) 10.2.1 20210217 kernel signature: 6d508e7cf705569002196acd77459d3467ef7ed89579331d596536e35e989856 all runs: OK # git bisect bad 93124d4a90ba6ef05cabb3b8430d51f2764345c6 Bisecting: 16 revisions left to test after this (roughly 4 steps) [f2386cf7c5f4ff5d7b584f5d92014edd7df6c676] net: lantiq: disable interrupt before sheduling NAPI testing commit f2386cf7c5f4ff5d7b584f5d92014edd7df6c676 with gcc (GCC) 10.2.1 20210217 kernel signature: 9cee48173ad17f6291ba87febcb9c3739c9c1193edcd04661891e4f193ab6ebd all runs: OK # git bisect bad f2386cf7c5f4ff5d7b584f5d92014edd7df6c676 Bisecting: 8 revisions left to test after this (roughly 3 steps) [d612c3f3fae221e7ea736d196581c2217304bbbc] net: ipv4: fix memory leak in netlbl_cipsov4_add_std testing commit d612c3f3fae221e7ea736d196581c2217304bbbc with gcc (GCC) 10.2.1 20210217 kernel signature: 59d646c76136dc64a168170e7fb00b4457ff1a880d93545d2df9d877dc04da30 run #0: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #1: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #2: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #3: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #4: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #5: crashed: WARNING in batadv_iv_send_outstanding_bat_ogm_packet run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good d612c3f3fae221e7ea736d196581c2217304bbbc Bisecting: 3 revisions left to test after this (roughly 2 steps) [df693f13a18f6eee0355741988f30c7c1e40ed9f] Merge tag 'batadv-net-pullrequest-20210608' of git://git.open-mesh.org/linux-merge testing commit df693f13a18f6eee0355741988f30c7c1e40ed9f with gcc (GCC) 10.2.1 20210217 kernel signature: 1e950122543535b235d190f1fe98a2d2d6f8ea336026175b34630eb4559a13ee run #0: crashed: BUG: sleeping function called from invalid context in lock_sock_nested run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good df693f13a18f6eee0355741988f30c7c1e40ed9f Bisecting: 1 revision left to test after this (roughly 1 step) [1650bdb1c516c248fb06f6d076559ff6437a5853] net: dsa: felix: re-enable TX flow control in ocelot_port_flush() testing commit 1650bdb1c516c248fb06f6d076559ff6437a5853 with gcc (GCC) 10.2.1 20210217 kernel signature: 9cee48173ad17f6291ba87febcb9c3739c9c1193edcd04661891e4f193ab6ebd run #0: crashed: BUG: sleeping function called from invalid context in lock_sock_nested run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect good 1650bdb1c516c248fb06f6d076559ff6437a5853 Bisecting: 0 revisions left to test after this (roughly 0 steps) [504fd6a5390c30b1b7670768e314dd5d473da06a] net: ena: fix DMA mapping function issues in XDP testing commit 504fd6a5390c30b1b7670768e314dd5d473da06a with gcc (GCC) 10.2.1 20210217 kernel signature: 9cee48173ad17f6291ba87febcb9c3739c9c1193edcd04661891e4f193ab6ebd all runs: OK # git bisect bad 504fd6a5390c30b1b7670768e314dd5d473da06a 504fd6a5390c30b1b7670768e314dd5d473da06a is the first bad commit commit 504fd6a5390c30b1b7670768e314dd5d473da06a Author: Shay Agroskin Date: Tue Jun 8 19:42:54 2021 +0300 net: ena: fix DMA mapping function issues in XDP This patch fixes several bugs found when (DMA/LLQ) mapping a packet for transmission. The mapping procedure makes the transmitted packet accessible by the device. When using LLQ, this requires copying the packet's header to push header (which would be passed to LLQ) and creating DMA mapping for the payload (if the packet doesn't fit the maximum push length). When not using LLQ, we map the whole packet with DMA. The following bugs are fixed in the code: 1. Add support for non-LLQ machines: The ena_xdp_tx_map_frame() function assumed that LLQ is supported, and never mapped the whole packet using DMA. On some instances, which don't support LLQ, this causes loss of traffic. 2. Wrong DMA buffer length passed to device: When using LLQ, the first 'tx_max_header_size' bytes of the packet would be copied to push header. The rest of the packet would be copied to a DMA'd buffer. 3. Freeing the XDP buffer twice in case of a mapping error: In case a buffer DMA mapping fails, the function uses xdp_return_frame_rx_napi() to free the RX buffer and returns from the function with an error. XDP frames that fail to xmit get freed by the kernel and so there is no need for this call. Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action") Signed-off-by: Shay Agroskin Signed-off-by: David S. Miller drivers/net/ethernet/amazon/ena/ena_netdev.c | 54 ++++++++++++++-------------- 1 file changed, 28 insertions(+), 26 deletions(-) culprit signature: 9cee48173ad17f6291ba87febcb9c3739c9c1193edcd04661891e4f193ab6ebd parent signature: 9cee48173ad17f6291ba87febcb9c3739c9c1193edcd04661891e4f193ab6ebd Reproducer flagged being flaky revisions tested: 17, total time: 5h0m44.919803239s (build: 1h58m32.447206765s, test: 2h59m48.263303338s) first good commit: 504fd6a5390c30b1b7670768e314dd5d473da06a net: ena: fix DMA mapping function issues in XDP recipients (to): ["akiyano@amazon.com" "davem@davemloft.net" "davem@davemloft.net" "kuba@kernel.org" "netanel@amazon.com" "netdev@vger.kernel.org" "shayagr@amazon.com"] recipients (cc): ["ast@kernel.org" "bpf@vger.kernel.org" "daniel@iogearbox.net" "gtzalik@amazon.com" "hawk@kernel.org" "john.fastabend@gmail.com" "linux-kernel@vger.kernel.org" "saeedb@amazon.com" "shayagr@amazon.com"]