bisecting fixing commit since 13d2ce42de8cb98ff952f8de6307f896203854c2 building syzkaller on 8f160dd5d603e9cd86705baad260794afa3e5cb3 testing commit 13d2ce42de8cb98ff952f8de6307f896203854c2 with gcc (GCC) 8.4.1 20210217 kernel signature: d3ad8c209e42eb29248417201fc4287613aec588afeb35cc1027af0d7b3e8eeb all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release testing current HEAD 9f84340f012ee60c12aacc03662bcdd67419a31a testing commit 9f84340f012ee60c12aacc03662bcdd67419a31a with gcc (GCC) 8.4.1 20210217 kernel signature: 44fe269dbb24a8875916fc46199ea34c720cb08dd32886ed7f6fcdc937070fc6 all runs: OK # git bisect start 9f84340f012ee60c12aacc03662bcdd67419a31a 13d2ce42de8cb98ff952f8de6307f896203854c2 Bisecting: 1237 revisions left to test after this (roughly 10 steps) [bccaf335ea17b491947ec3e9b451760a23be40d8] s390/dasd: fix hanging DASD driver unbind testing commit bccaf335ea17b491947ec3e9b451760a23be40d8 with gcc (GCC) 8.4.1 20210217 kernel signature: fd917ce9264f322964ac0c7b10be7e33f6ec117f0242efc7223321237505a262 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good bccaf335ea17b491947ec3e9b451760a23be40d8 Bisecting: 618 revisions left to test after this (roughly 9 steps) [fe4f49dc91270a2d5e32929c35d628001da2c2b5] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock testing commit fe4f49dc91270a2d5e32929c35d628001da2c2b5 with gcc (GCC) 8.4.1 20210217 kernel signature: a332ec4705c80b9288e0e4672d5eb7d30768a391149df84e759c5fe69b400685 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good fe4f49dc91270a2d5e32929c35d628001da2c2b5 Bisecting: 309 revisions left to test after this (roughly 8 steps) [1982f436a9a990e338ac4d7ed80a9fb40e0a1885] bpf, selftests: Fix up some test_verifier cases for unprivileged testing commit 1982f436a9a990e338ac4d7ed80a9fb40e0a1885 with gcc (GCC) 8.4.1 20210217 kernel signature: 1d26cee0aca7a2b3939bb40076f8552e49d4a3dc0c5555632f235f26f9736509 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good 1982f436a9a990e338ac4d7ed80a9fb40e0a1885 Bisecting: 154 revisions left to test after this (roughly 7 steps) [a7743f3294d6d11761ac8f0f2b65d2ff77aed88a] bnx2x: Fix missing error code in bnx2x_iov_init_one() testing commit a7743f3294d6d11761ac8f0f2b65d2ff77aed88a with gcc (GCC) 8.4.1 20210217 kernel signature: fa723c03fd835ff2617a8ba30faa769cb71c46184d1efdda3542d1154cd98eb5 all runs: OK # git bisect bad a7743f3294d6d11761ac8f0f2b65d2ff77aed88a Bisecting: 77 revisions left to test after this (roughly 6 steps) [3f9186ee7a306d7f974e759b084245155e5e709a] ALSA: usb: update old-style static const declaration testing commit 3f9186ee7a306d7f974e759b084245155e5e709a with gcc (GCC) 8.4.1 20210217 kernel signature: 8186e177535782000cc2cd1ff22a75eee71165d1ce4858d649d7f15b00ca463a all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good 3f9186ee7a306d7f974e759b084245155e5e709a Bisecting: 38 revisions left to test after this (roughly 5 steps) [b6c9e3b46c3a4c78799ac550176856e7ff5e313c] selftests/bpf: Generalize dummy program types testing commit b6c9e3b46c3a4c78799ac550176856e7ff5e313c with gcc (GCC) 8.4.1 20210217 kernel signature: 7197ee2e0dd6e07c0160605449b36e9ba73b55942b6090eaf0b770f1f291fef0 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good b6c9e3b46c3a4c78799ac550176856e7ff5e313c Bisecting: 19 revisions left to test after this (roughly 4 steps) [1f41b8f9577907fba56684231c7be89c8243d960] proc: Track /proc/$pid/attr/ opener mm_struct testing commit 1f41b8f9577907fba56684231c7be89c8243d960 with gcc (GCC) 8.4.1 20210217 kernel signature: d5352dec02bc0a559733d0f9dc7ebe6b6ef29d3ee732351168f3e81fe5c50ac3 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good 1f41b8f9577907fba56684231c7be89c8243d960 Bisecting: 9 revisions left to test after this (roughly 3 steps) [50316635e644a0b9e62d3263fb4e8be2104605b6] wq: handle VM suspension in stall detection testing commit 50316635e644a0b9e62d3263fb4e8be2104605b6 with gcc (GCC) 8.4.1 20210217 kernel signature: 6d4d57df810bee5a8a8c583e724a2ac943b09a1b58b1dac92fd4ef190210b845 all runs: OK # git bisect bad 50316635e644a0b9e62d3263fb4e8be2104605b6 Bisecting: 4 revisions left to test after this (roughly 2 steps) [bf78e25bd3f487208e042c67c8a31706c2dba265] isdn: mISDN: netjet: Fix crash in nj_probe: testing commit bf78e25bd3f487208e042c67c8a31706c2dba265 with gcc (GCC) 8.4.1 20210217 kernel signature: 95407597138f411491a4375a6ae6cf49356517d60d358dc0a11d7f9fa96da5a8 all runs: crashed: WARNING: ODEBUG bug in slave_kobj_release # git bisect good bf78e25bd3f487208e042c67c8a31706c2dba265 Bisecting: 2 revisions left to test after this (roughly 1 step) [59fba11d649854134c75ad88c8adafa9304ac419] netlink: disable IRQs for netlink_lock_table() testing commit 59fba11d649854134c75ad88c8adafa9304ac419 with gcc (GCC) 8.4.1 20210217 kernel signature: 3a569d2ed8061ae4b9e1325ea4b7c8e8bf19e5e17e21b2ec2e610e421f7c524b all runs: OK # git bisect bad 59fba11d649854134c75ad88c8adafa9304ac419 Bisecting: 0 revisions left to test after this (roughly 0 steps) [f583748c2a4a1dc731812ae2c12cadca5c1a88b5] bonding: init notify_work earlier to avoid uninitialized use testing commit f583748c2a4a1dc731812ae2c12cadca5c1a88b5 with gcc (GCC) 8.4.1 20210217 kernel signature: f7c01ec81f900afc94f5a7d74f396e76263668e19c3f56d3a3f1b02066fea1aa all runs: OK # git bisect bad f583748c2a4a1dc731812ae2c12cadca5c1a88b5 f583748c2a4a1dc731812ae2c12cadca5c1a88b5 is the first bad commit commit f583748c2a4a1dc731812ae2c12cadca5c1a88b5 Author: Johannes Berg Date: Mon May 17 16:13:35 2021 +0200 bonding: init notify_work earlier to avoid uninitialized use [ Upstream commit 35d96e631860226d5dc4de0fad0a415362ec2457 ] If bond_kobj_init() or later kzalloc() in bond_alloc_slave() fail, then we call kobject_put() on the slave->kobj. This in turn calls the release function slave_kobj_release() which will always try to cancel_delayed_work_sync(&slave->notify_work), which shouldn't be done on an uninitialized work struct. Always initialize the work struct earlier to avoid problems here. Syzbot bisected this down to a completely pointless commit, some fault injection may have been at work here that caused the alloc failure in the first place, which may interact badly with bisect. Reported-by: syzbot+bfda097c12a00c8cae67@syzkaller.appspotmail.com Signed-off-by: Johannes Berg Acked-by: Jay Vosburgh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) culprit signature: f7c01ec81f900afc94f5a7d74f396e76263668e19c3f56d3a3f1b02066fea1aa parent signature: 95407597138f411491a4375a6ae6cf49356517d60d358dc0a11d7f9fa96da5a8 revisions tested: 13, total time: 2h51m31.615493281s (build: 1h40m56.86061471s, test: 1h9m27.137148472s) first good commit: f583748c2a4a1dc731812ae2c12cadca5c1a88b5 bonding: init notify_work earlier to avoid uninitialized use recipients (to): ["davem@davemloft.net" "jay.vosburgh@canonical.com" "johannes.berg@intel.com" "sashal@kernel.org"] recipients (cc): []