ci starts bisection 2023-06-23 06:55:36.673443352 +0000 UTC m=+260002.334929767 bisecting cause commit starting from 692b7dc87ca6d55ab254f8259e6f970171dc9d01 building syzkaller on 09ffe269727719aad37ea8145eb57fefb0097165 ensuring issue is reproducible on original commit 692b7dc87ca6d55ab254f8259e6f970171dc9d01 testing commit 692b7dc87ca6d55ab254f8259e6f970171dc9d01 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: cfd467958dd4ebe434d255fcb07c684eff384ad49e88056adcf8c8f36d3a5329 all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb testing release v6.3 testing commit 457391b0380335d5e9a5babdec90ac53928b23b4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 52eacb108ac613ac2c053cce47fa411dd61fcead63c3f6452b8e8f21afffe007 all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb testing release v6.2 testing commit c9c3395d5e3dcc6daee66c6908354d47bf98cb0c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 03142ce4c6bac4f05c618e62c4fe5d81c492041668a57a5f492b5960b73b5da2 all runs: OK too many neither good nor bad results, skipping this commit # git bisect start 457391b0380335d5e9a5babdec90ac53928b23b4 c9c3395d5e3dcc6daee66c6908354d47bf98cb0c Bisecting: 7399 revisions left to test after this (roughly 13 steps) [a5c95ca18a98d742d0a4a04063c32556b5b66378] Merge tag 'drm-next-2023-02-23' of git://anongit.freedesktop.org/drm/drm testing commit a5c95ca18a98d742d0a4a04063c32556b5b66378 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7786f0246f26861b17f6350d7d03743bae3ad9f75e3c6d822e44b3092f593051 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good a5c95ca18a98d742d0a4a04063c32556b5b66378 Bisecting: 3619 revisions left to test after this (roughly 12 steps) [1ec35eadc3b448c91a6b763371a7073444e95f9d] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux testing commit 1ec35eadc3b448c91a6b763371a7073444e95f9d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 60b705598407f2fc3e9a10e896532a881c18bd529ed539c034845074200f1c4c all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 1ec35eadc3b448c91a6b763371a7073444e95f9d Bisecting: 1926 revisions left to test after this (roughly 11 steps) [693fed981eb9bf6e70bfda66bb872e2bb8155671] Merge tag 'char-misc-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit 693fed981eb9bf6e70bfda66bb872e2bb8155671 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5723984d23fe58a2fafa79fed095f7fb65e8c810546a0065963cec6f6debb8bd all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 693fed981eb9bf6e70bfda66bb872e2bb8155671 Bisecting: 913 revisions left to test after this (roughly 10 steps) [3822a7c40997dc86b1458766a3f146d62393f084] Merge tag 'mm-stable-2023-02-20-13-37' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm testing commit 3822a7c40997dc86b1458766a3f146d62393f084 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 12186565fae307c7286016a5aa41e89288289d5178e9ae76a48c8c5214054f1f all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 3822a7c40997dc86b1458766a3f146d62393f084 Bisecting: 459 revisions left to test after this (roughly 9 steps) [17cd4d6f05087ea1ae5c1416ef260e5b7fc5d5c9] Merge tag 'tty-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty testing commit 17cd4d6f05087ea1ae5c1416ef260e5b7fc5d5c9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 915f64bf5356f2fbef152c58c188d53ea6308298578c593f4891a8aecbb131a4 all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 17cd4d6f05087ea1ae5c1416ef260e5b7fc5d5c9 Bisecting: 226 revisions left to test after this (roughly 8 steps) [88e054e8df1db32cea4ccb911b67dba22f1ddfa2] Merge tag 'thunderbolt-for-v6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt into usb-next testing commit 88e054e8df1db32cea4ccb911b67dba22f1ddfa2 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: fe9f309c201321ebfb7f7882455dfa6d27ae6cd62ca527b78197c82dfa87a69e all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 88e054e8df1db32cea4ccb911b67dba22f1ddfa2 Bisecting: 99 revisions left to test after this (roughly 7 steps) [745656a39ee40e2888ffb1a108511be296e267e9] Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into usb-next testing commit 745656a39ee40e2888ffb1a108511be296e267e9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6bd45848a0f0e133e14ccfd099b7520180062e8f99cef08686fe31a42218d5db all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 745656a39ee40e2888ffb1a108511be296e267e9 Bisecting: 49 revisions left to test after this (roughly 6 steps) [fb6211f1584aad12c267c3333273f42f69438ced] usb: gadget: add doc to struct usb_composite_dev testing commit fb6211f1584aad12c267c3333273f42f69438ced gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: df742a7951006005bbc2c2f8b75e5b9a002dffe2a5b6f6ed01f44d343165162f all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad fb6211f1584aad12c267c3333273f42f69438ced Bisecting: 24 revisions left to test after this (roughly 5 steps) [56774e274574af8396d7b16618363aabe3a5582d] dt-bindings: usb: sunxi-musb: add F1C100s MUSB compatible string testing commit 56774e274574af8396d7b16618363aabe3a5582d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0b0f3acf9d8cfdc8f8d00aba825a58ddfe25470b06ee3744e13cae81eb8d1c04 all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 56774e274574af8396d7b16618363aabe3a5582d Bisecting: 12 revisions left to test after this (roughly 4 steps) [21ef9c91f0ab4f11d31fddbdc6d886fed114be74] usb: fotg210: fix return value check in fotg210_probe() testing commit 21ef9c91f0ab4f11d31fddbdc6d886fed114be74 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 57f19f6137f0d70d91c82298d2d8b6ce2ddee1bb392e9460a024087026e3700e all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 21ef9c91f0ab4f11d31fddbdc6d886fed114be74 Bisecting: 6 revisions left to test after this (roughly 3 steps) [33bb1a9459989ef501bda9b127b38173fb2224c9] dt-bindings: usb: mediatek,mtk-xhci: add MT8365 SoC bindings testing commit 33bb1a9459989ef501bda9b127b38173fb2224c9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e58169c425d3c30ebfaeee1ccb855f56ca2b3708528c5ce4ffc576d75a4b30aa all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 33bb1a9459989ef501bda9b127b38173fb2224c9 Bisecting: 3 revisions left to test after this (roughly 2 steps) [49814e2c9c5776c7dc7cfd151aba15bd91804c3c] usb: early: xhci-dbc: Use memcpy_and_pad() testing commit 49814e2c9c5776c7dc7cfd151aba15bd91804c3c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: b01bdbb1b573e92623d7deac0948119c59cb4d8d5985d16b901a581c727df0c9 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 49814e2c9c5776c7dc7cfd151aba15bd91804c3c Bisecting: 1 revision left to test after this (roughly 1 step) [ba883de971d1ad018f3083d9195b8abe54d87407] usb: musb: mediatek: don't unregister something that wasn't registered testing commit ba883de971d1ad018f3083d9195b8abe54d87407 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 48a0ee3cb257b3df7d8247873a26bbd1a8b3a9407ab574f2bf57c0b4ef90597a all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad ba883de971d1ad018f3083d9195b8abe54d87407 Bisecting: 0 revisions left to test after this (roughly 0 steps) [45bf39f8df7f05efb83b302c65ae3b9bc92b7065] USB: core: Don't hold device lock while reading the "descriptors" sysfs file testing commit 45bf39f8df7f05efb83b302c65ae3b9bc92b7065 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e30db96ebee3b5921cd162521ddacc31afe6a111902b6d73b5853085e8e57dd1 all runs: crashed: WARNING in usbnet_start_xmit/usb_submit_urb # git bisect bad 45bf39f8df7f05efb83b302c65ae3b9bc92b7065 45bf39f8df7f05efb83b302c65ae3b9bc92b7065 is the first bad commit commit 45bf39f8df7f05efb83b302c65ae3b9bc92b7065 Author: Alan Stern Date: Tue Jan 31 15:49:04 2023 -0500 USB: core: Don't hold device lock while reading the "descriptors" sysfs file Ever since commit 83e83ecb79a8 ("usb: core: get config and string descriptors for unauthorized devices") was merged in 2013, there has been no mechanism for reallocating the rawdescriptors buffers in struct usb_device after the initial enumeration. Before that commit, the buffers would be deallocated when a device was deauthorized and reallocated when it was authorized and enumerated. This means that the locking in the read_descriptors() routine is not needed, since the buffers it reads will never be reallocated while the routine is running. This locking can interfere with user programs trying to read a hub's descriptors via sysfs while new child devices of the hub are being initialized, since the hub is locked during this procedure. Since the locking in read_descriptors() hasn't been needed for over nine years, we can remove it. Reported-and-tested-by: Troels Liebe Bentsen Signed-off-by: Alan Stern CC: stable@vger.kernel.org Link: https://lore.kernel.org/r/Y9l+wDTRbuZABzsE@rowland.harvard.edu Signed-off-by: Greg Kroah-Hartman drivers/usb/core/hub.c | 5 ++--- drivers/usb/core/sysfs.c | 5 ----- 2 files changed, 2 insertions(+), 8 deletions(-) culprit signature: e30db96ebee3b5921cd162521ddacc31afe6a111902b6d73b5853085e8e57dd1 parent signature: b01bdbb1b573e92623d7deac0948119c59cb4d8d5985d16b901a581c727df0c9 revisions tested: 17, total time: 6h36m11.597116435s (build: 4h40m50.233321881s, test: 1h48m39.847752494s) first bad commit: 45bf39f8df7f05efb83b302c65ae3b9bc92b7065 USB: core: Don't hold device lock while reading the "descriptors" sysfs file recipients (to): ["gregkh@linuxfoundation.org" "stern@rowland.harvard.edu" "troels@connectedcars.dk"] recipients (cc): [] crash: WARNING in usbnet_start_xmit/usb_submit_urb ------------[ cut here ]------------ usb 1-1: BOGUS urb xfer, pipe 3 != type 1 WARNING: CPU: 0 PID: 5004 at drivers/usb/core/urb.c:504 usb_submit_urb+0xb0b/0x1690 drivers/usb/core/urb.c:504 Modules linked in: CPU: 0 PID: 5004 Comm: kworker/0:4 Not tainted 6.2.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Workqueue: mld mld_ifc_work RIP: 0010:usb_submit_urb+0xb0b/0x1690 drivers/usb/core/urb.c:504 Code: 4c 24 18 89 4c 24 08 44 89 04 24 e8 9f 60 17 ff 44 8b 04 24 4c 89 e2 48 c7 c7 40 1f 13 8a 8b 4c 24 08 48 89 c6 e8 7b d1 65 03 <0f> 0b 4c 8b 4c 24 18 e9 c0 fa ff ff 48 8d 7b 1c 48 ba 00 00 00 00 RSP: 0018:ffffc9000398f668 EFLAGS: 00010086 RAX: 0000000000000000 RBX: ffff888020697000 RCX: 0000000000000000 RDX: 0000000000000404 RSI: 0000000000000004 RDI: fffff52000731ebf RBP: ffff888028d33d00 R08: 0000000000000001 R09: ffff8880b9a2894b R10: ffffed1017345129 R11: 0000000000000000 R12: ffff888020505168 R13: 0000000000000003 R14: 0000000000000003 R15: 0000000000000001 FS: 0000000000000000(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000560ed1050a18 CR3: 000000000b48e000 CR4: 0000000000350ef0 Call Trace: usbnet_start_xmit+0xd27/0x1dd0 drivers/net/usb/usbnet.c:1455 __netdev_start_xmit include/linux/netdevice.h:4865 [inline] netdev_start_xmit include/linux/netdevice.h:4879 [inline] xmit_one net/core/dev.c:3583 [inline] dev_hard_start_xmit+0x175/0x760 net/core/dev.c:3599 sch_direct_xmit+0x130/0x10b0 net/sched/sch_generic.c:342 __dev_xmit_skb net/core/dev.c:3810 [inline] __dev_queue_xmit+0x1287/0x31f0 net/core/dev.c:4215 neigh_output include/net/neighbour.h:546 [inline] ip6_finish_output2+0x447/0x1220 net/ipv6/ip6_output.c:134 __ip6_finish_output net/ipv6/ip6_output.c:195 [inline] ip6_finish_output+0x4f7/0xf00 net/ipv6/ip6_output.c:206 dst_output include/net/dst.h:444 [inline] NF_HOOK include/linux/netfilter.h:302 [inline] NF_HOOK include/linux/netfilter.h:296 [inline] mld_sendpack+0x926/0xcf0 net/ipv6/mcast.c:1820 mld_send_cr net/ipv6/mcast.c:2121 [inline] mld_ifc_work+0x569/0xa90 net/ipv6/mcast.c:2653 process_one_work+0x8ba/0x14c0 kernel/workqueue.c:2289 worker_thread+0x59c/0xec0 kernel/workqueue.c:2436 kthread+0x29e/0x340 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308