bisecting fixing commit since a1b977b49b66c75e6c51a515f6700371ae720217 building syzkaller on fc7735a27949755327024847e12dcc1b868bcb99 testing commit a1b977b49b66c75e6c51a515f6700371ae720217 with gcc (GCC) 8.1.0 kernel signature: a0d89ae2b52f8a840ed95e34c9312348aed0746d1e277c10997454df445e27e3 all runs: crashed: general protection fault in qp_release_pages testing current HEAD 31acccdc877486a649a86d37725a15175fcd5ed6 testing commit 31acccdc877486a649a86d37725a15175fcd5ed6 with gcc (GCC) 8.1.0 kernel signature: 54fe8f69035fe33056754de88feecbdefef752057a345158be7957110439184f all runs: OK # git bisect start 31acccdc877486a649a86d37725a15175fcd5ed6 a1b977b49b66c75e6c51a515f6700371ae720217 Bisecting: 301 revisions left to test after this (roughly 8 steps) [7a78bc1a4a854fe97a31ac064ddded899c70c898] scsi: mvumi: Fix error return in mvumi_io_attach() testing commit 7a78bc1a4a854fe97a31ac064ddded899c70c898 with gcc (GCC) 8.1.0 kernel signature: f746d7b282c778209d8a9ea7373b58f3db366773661b04539dec48d19f844d01 all runs: OK # git bisect bad 7a78bc1a4a854fe97a31ac064ddded899c70c898 Bisecting: 150 revisions left to test after this (roughly 7 steps) [bff92c28da64d1561930638b58a3cbdada965bf2] scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()' testing commit bff92c28da64d1561930638b58a3cbdada965bf2 with gcc (GCC) 8.1.0 kernel signature: 39cdd70db837e32f7050f17c69bcecd65b6a8a6ad6c998f74592fd084d5bda3d all runs: crashed: general protection fault in qp_release_pages # git bisect good bff92c28da64d1561930638b58a3cbdada965bf2 Bisecting: 75 revisions left to test after this (roughly 6 steps) [b0b57d37f26231e7980c11f2a61f81fe46750188] RDMA/hns: Set the unsupported wr opcode testing commit b0b57d37f26231e7980c11f2a61f81fe46750188 with gcc (GCC) 8.1.0 kernel signature: a6cccd56215ffb37899cdfe80536b4076520dfd0745398f3f5fd0e34d6f364d7 all runs: OK # git bisect bad b0b57d37f26231e7980c11f2a61f81fe46750188 Bisecting: 37 revisions left to test after this (roughly 5 steps) [f36c8ddaea41830ce53984dce111138097e7d62d] usb: gadget: f_ncm: fix ncm_bitrate for SuperSpeed and above. testing commit f36c8ddaea41830ce53984dce111138097e7d62d with gcc (GCC) 8.1.0 kernel signature: d0d0913f64c07f12a23523c34fbce861eaaa4a0b6cbf539410723b019f64ff5b all runs: OK # git bisect bad f36c8ddaea41830ce53984dce111138097e7d62d Bisecting: 18 revisions left to test after this (roughly 4 steps) [f2b54e0fc5ef13135a801c030aa166d32a247527] net: stmmac: use netif_tx_start|stop_all_queues() function testing commit f2b54e0fc5ef13135a801c030aa166d32a247527 with gcc (GCC) 8.1.0 kernel signature: 5cb042a8872a7301df0ef45abb98e554f393df2968380c0c863c9fcf2ebbe9a3 all runs: OK # git bisect bad f2b54e0fc5ef13135a801c030aa166d32a247527 Bisecting: 8 revisions left to test after this (roughly 3 steps) [02f420c5fd2047117312ab77e823184f63fc9568] pwm: lpss: Add range limit check for the base_unit register value testing commit 02f420c5fd2047117312ab77e823184f63fc9568 with gcc (GCC) 8.1.0 kernel signature: 86a894e22cecf21d5237bb68711a7fd5a9064d26bac9fdf52ba0c83e45add529 all runs: OK # git bisect bad 02f420c5fd2047117312ab77e823184f63fc9568 Bisecting: 4 revisions left to test after this (roughly 2 steps) [0b02a43257805da6f670c1a1fe40d19499d9c741] VMCI: check return value of get_user_pages_fast() for errors testing commit 0b02a43257805da6f670c1a1fe40d19499d9c741 with gcc (GCC) 8.1.0 kernel signature: dc8da7eecc7b567b3820858393b03c50e8012a8b857f1bb37d043cbeb24f0a80 all runs: OK # git bisect bad 0b02a43257805da6f670c1a1fe40d19499d9c741 Bisecting: 1 revision left to test after this (roughly 1 step) [157a5d49c07cebc227f8e91cc7ab5573e756ff59] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw() testing commit 157a5d49c07cebc227f8e91cc7ab5573e756ff59 with gcc (GCC) 8.1.0 kernel signature: 39cdd70db837e32f7050f17c69bcecd65b6a8a6ad6c998f74592fd084d5bda3d all runs: crashed: general protection fault in qp_release_pages # git bisect good 157a5d49c07cebc227f8e91cc7ab5573e756ff59 Bisecting: 0 revisions left to test after this (roughly 0 steps) [6621e5beab45ad7c2569fcfd1259c5b80d2a7f9e] backlight: sky81452-backlight: Fix refcount imbalance on error testing commit 6621e5beab45ad7c2569fcfd1259c5b80d2a7f9e with gcc (GCC) 8.1.0 kernel signature: 39cdd70db837e32f7050f17c69bcecd65b6a8a6ad6c998f74592fd084d5bda3d all runs: crashed: general protection fault in qp_release_pages # git bisect good 6621e5beab45ad7c2569fcfd1259c5b80d2a7f9e 0b02a43257805da6f670c1a1fe40d19499d9c741 is the first bad commit commit 0b02a43257805da6f670c1a1fe40d19499d9c741 Author: Alex Dewar Date: Tue Aug 25 17:45:18 2020 +0100 VMCI: check return value of get_user_pages_fast() for errors [ Upstream commit 90ca6333fd65f318c47bff425e1ea36c0a5539f6 ] In a couple of places in qp_host_get_user_memory(), get_user_pages_fast() is called without properly checking for errors. If e.g. -EFAULT is returned, this negative value will then be passed on to qp_release_pages(), which expects a u64 as input. Fix this by only calling qp_release_pages() when we have a positive number returned. Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.") Signed-off-by: Alex Dewar Link: https://lore.kernel.org/r/20200825164522.412392-1-alex.dewar90@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin drivers/misc/vmw_vmci/vmci_queue_pair.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) culprit signature: dc8da7eecc7b567b3820858393b03c50e8012a8b857f1bb37d043cbeb24f0a80 parent signature: 39cdd70db837e32f7050f17c69bcecd65b6a8a6ad6c998f74592fd084d5bda3d revisions tested: 11, total time: 2h54m25.527966149s (build: 1h36m28.048371141s, test: 1h16m45.584073891s) first good commit: 0b02a43257805da6f670c1a1fe40d19499d9c741 VMCI: check return value of get_user_pages_fast() for errors recipients (to): ["alex.dewar90@gmail.com" "gregkh@linuxfoundation.org" "sashal@kernel.org"] recipients (cc): []