bisecting fixing commit since 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 building syzkaller on 3e5ed8b45e7a561d6344a4d3d7bf3bfb8f24a7b3 testing commit 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 with gcc (GCC) 10.2.1 20210217 kernel signature: 20c455d8a58ab564b3d2acb25c1b998aa7a1929f4ff4fed292c78b6985cb6102 run #0: crashed: KASAN: use-after-free Write in nbd_release run #1: crashed: WARNING: refcount bug in nbd_config_put run #2: crashed: KASAN: use-after-free Read in nbd_genl_connect run #3: crashed: KASAN: use-after-free Read in nbd_genl_connect run #4: crashed: KASAN: use-after-free Read in nbd_genl_connect run #5: crashed: WARNING: refcount bug in nbd_config_put run #6: crashed: KASAN: use-after-free Read in nbd_genl_connect run #7: crashed: KASAN: use-after-free Read in nbd_genl_connect run #8: crashed: WARNING: refcount bug in nbd_config_put run #9: crashed: KASAN: use-after-free Read in nbd_genl_connect run #10: crashed: KASAN: use-after-free Read in nbd_release run #11: crashed: KASAN: use-after-free Read in nbd_release run #12: crashed: WARNING: refcount bug in nbd_config_put run #13: crashed: KASAN: use-after-free Read in nbd_genl_connect run #14: crashed: KASAN: use-after-free Read in nbd_release run #15: crashed: KASAN: use-after-free Read in nbd_genl_connect run #16: crashed: KASAN: use-after-free Write in nbd_release run #17: crashed: KASAN: use-after-free Read in nbd_genl_connect run #18: crashed: KASAN: use-after-free Read in nbd_genl_connect run #19: crashed: KASAN: use-after-free Read in nbd_genl_connect testing current HEAD 849fd444dd7383c437699997dcbca8d49d27b836 testing commit 849fd444dd7383c437699997dcbca8d49d27b836 with gcc (GCC) 10.2.1 20210217 kernel signature: 2acf015773c1b26fe18341d4c807d8bbe56f5de5acfc01083964f7e3e3ce72c7 all runs: crashed: possible deadlock in del_gendisk revisions tested: 2, total time: 23m7.527893593s (build: 15m15.78982173s, test: 7m3.909679321s) the crash still happens on HEAD commit msg: Merge branch 'mptcp-Connection-and-accounting-fixes' crash: possible deadlock in del_gendisk netlink: 4 bytes leftover after parsing attributes in process `syz-executor.2'. ====================================================== WARNING: possible circular locking dependency detected 5.13.0-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/10184 is trying to acquire lock: ffff8880192acd18 (&disk->open_mutex){+.+.}-{3:3}, at: del_gendisk+0x81/0x720 block/genhd.c:587 but task is already holding lock: ffffffff8b3ff748 (nbd_index_mutex){+.+.}-{3:3}, at: refcount_dec_and_mutex_lock lib/refcount.c:118 [inline] ffffffff8b3ff748 (nbd_index_mutex){+.+.}-{3:3}, at: refcount_dec_and_mutex_lock+0x2b/0xd0 lib/refcount.c:113 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (nbd_index_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 nbd_open+0x6f/0x630 drivers/block/nbd.c:1456 blkdev_get_whole+0x92/0x360 fs/block_dev.c:1251 blkdev_get_by_dev.part.0+0x25d/0xdd0 fs/block_dev.c:1415 blkdev_get_by_dev fs/block_dev.c:1504 [inline] blkdev_open+0x1fa/0x250 fs/block_dev.c:1510 do_dentry_open+0x42a/0xfb0 fs/open.c:826 do_open fs/namei.c:3361 [inline] path_openat+0x9ee/0x22b0 fs/namei.c:3494 do_filp_open+0x17f/0x3a0 fs/namei.c:3521 do_sys_openat2+0x11e/0x360 fs/open.c:1195 do_sys_open fs/open.c:1211 [inline] __do_sys_open fs/open.c:1219 [inline] __se_sys_open fs/open.c:1215 [inline] __x64_sys_open+0xfd/0x1a0 fs/open.c:1215 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #0 (&disk->open_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2985/0x5410 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x4f0 kernel/locking/lockdep.c:5590 __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 del_gendisk+0x81/0x720 block/genhd.c:587 nbd_dev_remove drivers/block/nbd.c:224 [inline] nbd_put.part.0+0x77/0x130 drivers/block/nbd.c:246 nbd_put drivers/block/nbd.c:1917 [inline] nbd_genl_connect+0xeee/0x1290 drivers/block/nbd.c:1957 genl_family_rcv_msg_doit+0x1e4/0x2f0 net/netlink/genetlink.c:739 genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] genl_rcv_msg+0x27a/0x4a0 net/netlink/genetlink.c:800 netlink_rcv_skb+0x118/0x370 net/netlink/af_netlink.c:2504 genl_rcv+0x1f/0x30 net/netlink/genetlink.c:811 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] netlink_unicast+0x42e/0x700 net/netlink/af_netlink.c:1340 netlink_sendmsg+0x70e/0xbe0 net/netlink/af_netlink.c:1929 sock_sendmsg_nosec net/socket.c:703 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:723 ____sys_sendmsg+0x5bf/0x7a0 net/socket.c:2392 ___sys_sendmsg+0xd3/0x150 net/socket.c:2446 __sys_sendmsg+0xb2/0x140 net/socket.c:2475 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(nbd_index_mutex); lock(&disk->open_mutex); lock(nbd_index_mutex); lock(&disk->open_mutex); *** DEADLOCK *** 3 locks held by syz-executor.2/10184: #0: ffffffff8c06b5f0 (cb_lock){++++}-{3:3}, at: genl_rcv+0x10/0x30 net/netlink/genetlink.c:810 #1: ffffffff8c06b6a8 (genl_mutex){+.+.}-{3:3}, at: genl_lock net/netlink/genetlink.c:33 [inline] #1: ffffffff8c06b6a8 (genl_mutex){+.+.}-{3:3}, at: genl_rcv_msg+0x315/0x4a0 net/netlink/genetlink.c:798 #2: ffffffff8b3ff748 (nbd_index_mutex){+.+.}-{3:3}, at: refcount_dec_and_mutex_lock lib/refcount.c:118 [inline] #2: ffffffff8b3ff748 (nbd_index_mutex){+.+.}-{3:3}, at: refcount_dec_and_mutex_lock+0x2b/0xd0 lib/refcount.c:113 stack backtrace: CPU: 0 PID: 10184 Comm: syz-executor.2 Not tainted 5.13.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack_lvl+0x45/0x59 lib/dump_stack.c:96 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2131 check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2985/0x5410 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x4f0 kernel/locking/lockdep.c:5590 __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 del_gendisk+0x81/0x720 block/genhd.c:587 nbd_dev_remove drivers/block/nbd.c:224 [inline] nbd_put.part.0+0x77/0x130 drivers/block/nbd.c:246 nbd_put drivers/block/nbd.c:1917 [inline] nbd_genl_connect+0xeee/0x1290 drivers/block/nbd.c:1957 genl_family_rcv_msg_doit+0x1e4/0x2f0 net/netlink/genetlink.c:739 genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] genl_rcv_msg+0x27a/0x4a0 net/netlink/genetlink.c:800 netlink_rcv_skb+0x118/0x370 net/netlink/af_netlink.c:2504 genl_rcv+0x1f/0x30 net/netlink/genetlink.c:811 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] netlink_unicast+0x42e/0x700 net/netlink/af_netlink.c:1340 netlink_sendmsg+0x70e/0xbe0 net/netlink/af_netlink.c:1929 sock_sendmsg_nosec net/socket.c:703 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:723 ____sys_sendmsg+0x5bf/0x7a0 net/socket.c:2392 ___sys_sendmsg+0xd3/0x150 net/socket.c:2446 __sys_sendmsg+0xb2/0x140 net/socket.c:2475 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x466019 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd1e830c188 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 000000000056bf60 RCX: 0000000000466019 RDX: 0000000002000800 RSI: 0000000020002580 RDI: 0000000000000004 RBP: 00000000004bd067 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf60 R13: 00007fffe1fe63ff R14: 00007fd1e830c300 R15: 0000000000022000