ci starts bisection 2023-03-21 16:32:07.884527577 +0000 UTC m=+29175.926420390 bisecting fixing commit since 033c40a89f55525139fd5b6342281b09b97d05bf building syzkaller on 7338e3c48713281869426c4e29a02a63ab16331a ensuring issue is reproducible on original commit 033c40a89f55525139fd5b6342281b09b97d05bf testing commit 033c40a89f55525139fd5b6342281b09b97d05bf gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 07a78de00473bd76726c00650f0ef580c65f0e37dbeb05c06a4db02dbe8f6917 all runs: crashed: INFO: trying to register non-static key in net_free testing current HEAD 17214b70a159c6547df9ae204a6275d983146f6b testing commit 17214b70a159c6547df9ae204a6275d983146f6b gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 872d7b3210a62d47e2be121a0c739da5e6bb9e3652f8bf0b6a95db71714ddf69 all runs: OK # git bisect start 17214b70a159c6547df9ae204a6275d983146f6b 033c40a89f55525139fd5b6342281b09b97d05bf Bisecting: 7588 revisions left to test after this (roughly 13 steps) [307e14c039063f0c9bd7a18a7add8f940580dcc9] Merge tag '6.3-rc-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 testing commit 307e14c039063f0c9bd7a18a7add8f940580dcc9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: b384849199b5d8419e89f07efa4828fbd4d08ac8d426950c14d3faec9e61a1f9 all runs: OK # git bisect bad 307e14c039063f0c9bd7a18a7add8f940580dcc9 Bisecting: 3558 revisions left to test after this (roughly 12 steps) [36289a03bcd3aabdf66de75cb6d1b4ee15726438] Merge tag 'v6.3-p1' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 testing commit 36289a03bcd3aabdf66de75cb6d1b4ee15726438 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 904aebcccd06cefb436e581bbcf0aef6018bcd9fed2cd2b17988d4925ad0df28 all runs: OK # git bisect bad 36289a03bcd3aabdf66de75cb6d1b4ee15726438 Bisecting: 1339 revisions left to test after this (roughly 11 steps) [950b6662e26e381cf8834b9b78b08261890ee697] Merge tag 'soc-dt-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc testing commit 950b6662e26e381cf8834b9b78b08261890ee697 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: aa7eb306cd5c81a9a1accf8fd9c3ed3f99ff31438dc823087245aba85b37296d all runs: OK # git bisect bad 950b6662e26e381cf8834b9b78b08261890ee697 Bisecting: 981 revisions left to test after this (roughly 10 steps) [fc54e13d712501cd2ad99ac015c5ff8a0c6ae184] Merge tag 'qcom-dts-for-6.3-2' of https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into arm/dt testing commit fc54e13d712501cd2ad99ac015c5ff8a0c6ae184 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 50f801017fe75d1b522146da326535726eb03be7f793ca71c4db823fd7cf2c50 run #0: crashed: kernel BUG in do_journal_begin_r run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good fc54e13d712501cd2ad99ac015c5ff8a0c6ae184 Bisecting: 516 revisions left to test after this (roughly 9 steps) [eca3a04f140a7380d8a7b4cd89d681706a69380c] Merge tag 'dlm-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm testing commit eca3a04f140a7380d8a7b4cd89d681706a69380c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a9621f36165bda423574e68933556fe1baa68965f60704739bfe934a49fae7c3 all runs: OK # git bisect bad eca3a04f140a7380d8a7b4cd89d681706a69380c Bisecting: 230 revisions left to test after this (roughly 8 steps) [f18f9845f2f10d3d1fc63e4ad16ee52d2d9292fa] Merge tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/linux testing commit f18f9845f2f10d3d1fc63e4ad16ee52d2d9292fa gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2829d834a79ecddd34c6ac6bf59ca9027930046125feb282ecff7b12e183279b all runs: OK # git bisect bad f18f9845f2f10d3d1fc63e4ad16ee52d2d9292fa Bisecting: 115 revisions left to test after this (roughly 7 steps) [5e725d112e1a54c2611d5dffd124a79415d0f0de] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm testing commit 5e725d112e1a54c2611d5dffd124a79415d0f0de gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 41131cdd2afe4e78daff35a182fcdd493ff4b6074c7d522d8931c8feb7bbebe1 all runs: OK # git bisect bad 5e725d112e1a54c2611d5dffd124a79415d0f0de Bisecting: 61 revisions left to test after this (roughly 6 steps) [3ac88fa4605ec98e545fb3ad0154f575fda2de5f] Merge tag 'net-6.2-final' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 3ac88fa4605ec98e545fb3ad0154f575fda2de5f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ac44be4ea8c8693a90f0a05fde91fcfc36888fd29c70578b3bf30d7a88be3905 all runs: OK # git bisect bad 3ac88fa4605ec98e545fb3ad0154f575fda2de5f Bisecting: 27 revisions left to test after this (roughly 5 steps) [ce45ffb815e8e238f05de1630be3969b6bb15e4e] i40e: add double of VLAN header when computing the max MTU testing commit ce45ffb815e8e238f05de1630be3969b6bb15e4e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e60f306fe91f42f14063ff21ac40e779fbd33ebbcf64c4a2212118deaa56176d all runs: crashed: unregister_netdevice: waiting for DEV to become free # git bisect good ce45ffb815e8e238f05de1630be3969b6bb15e4e Bisecting: 12 revisions left to test after this (roughly 4 steps) [d3d6f0eb086d3d68960ded479e846e7dcfcec2bb] Merge tag 'block-6.2-2023-02-16' of git://git.kernel.dk/linux testing commit d3d6f0eb086d3d68960ded479e846e7dcfcec2bb gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 801c6f3f20e6eb65322ff71af6a516794487bbed22b422f3e5f90c6f5a2c567d all runs: crashed: INFO: trying to register non-static key in net_free # git bisect good d3d6f0eb086d3d68960ded479e846e7dcfcec2bb Bisecting: 6 revisions left to test after this (roughly 3 steps) [11a4d6f67cf55883dc78e31c247d1903ed7feccc] tipc: fix kernel warning when sending SYN message testing commit 11a4d6f67cf55883dc78e31c247d1903ed7feccc gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7521a19f2e0d873261c63a6bc47f9976de53580f95a3c053679433e66e836c31 all runs: crashed: unregister_netdevice: waiting for DEV to become free # git bisect good 11a4d6f67cf55883dc78e31c247d1903ed7feccc Bisecting: 2 revisions left to test after this (roughly 2 steps) [dee4bf7167cfcae642e0cf04bef81dca49cc286f] Merge branch '10GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue testing commit dee4bf7167cfcae642e0cf04bef81dca49cc286f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: afe75b1e92cad3d3958dd69d07a90bd1094bb7aef8bd2c199614f5bd490e7b67 all runs: crashed: unregister_netdevice: waiting for DEV to become free # git bisect good dee4bf7167cfcae642e0cf04bef81dca49cc286f Bisecting: 0 revisions left to test after this (roughly 1 step) [b20b8aec6ffc07bb547966b356780cd344f20f5b] devlink: Fix netdev notifier chain corruption testing commit b20b8aec6ffc07bb547966b356780cd344f20f5b gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3969708beb9f7acc8b8293b6926a651c8dc1f3a589695ecefb82564f7b84555d all runs: OK # git bisect bad b20b8aec6ffc07bb547966b356780cd344f20f5b Bisecting: 0 revisions left to test after this (roughly 0 steps) [5d54cb1767e06025819daa6769e0f18dcbc60936] igb: conditionalize I2C bit banging on external thermal sensor support testing commit 5d54cb1767e06025819daa6769e0f18dcbc60936 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 507b1ace44e2c356f20e299d7df39c7e3aa3e8669b40bf19ef3a2db473006c1e all runs: crashed: unregister_netdevice: waiting for DEV to become free # git bisect good 5d54cb1767e06025819daa6769e0f18dcbc60936 b20b8aec6ffc07bb547966b356780cd344f20f5b is the first bad commit commit b20b8aec6ffc07bb547966b356780cd344f20f5b Author: Ido Schimmel Date: Wed Feb 15 09:31:39 2023 +0200 devlink: Fix netdev notifier chain corruption Cited commit changed devlink to register its netdev notifier block on the global netdev notifier chain instead of on the per network namespace one. However, when changing the network namespace of the devlink instance, devlink still tries to unregister its notifier block from the chain of the old namespace and register it on the chain of the new namespace. This results in corruption of the notifier chains, as the same notifier block is registered on two different chains: The global one and the per network namespace one. In turn, this causes other problems such as the inability to dismantle namespaces due to netdev reference count issues. Fix by preventing devlink from moving its notifier block between namespaces. Reproducer: # echo "10 1" > /sys/bus/netdevsim/new_device # ip netns add test123 # devlink dev reload netdevsim/netdevsim10 netns test123 # ip netns del test123 [ 71.935619] unregister_netdevice: waiting for lo to become free. Usage count = 2 [ 71.938348] leaked reference. Fixes: 565b4824c39f ("devlink: change port event netdev notifier from per-net to global") Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller Reviewed-by: Jakub Kicinski Link: https://lore.kernel.org/r/20230215073139.1360108-1-idosch@nvidia.com Signed-off-by: Paolo Abeni include/linux/netdevice.h | 2 -- net/core/dev.c | 8 -------- net/core/devlink.c | 5 +---- 3 files changed, 1 insertion(+), 14 deletions(-) culprit signature: 3969708beb9f7acc8b8293b6926a651c8dc1f3a589695ecefb82564f7b84555d parent signature: 507b1ace44e2c356f20e299d7df39c7e3aa3e8669b40bf19ef3a2db473006c1e Reproducer flagged being flaky revisions tested: 16, total time: 4h53m17.67906692s (build: 2h49m25.764133242s, test: 2h1m2.631851295s) first good commit: b20b8aec6ffc07bb547966b356780cd344f20f5b devlink: Fix netdev notifier chain corruption recipients (to): ["idosch@nvidia.com" "jacob.e.keller@intel.com" "jiri@nvidia.com" "kuba@kernel.org" "pabeni@redhat.com"] recipients (cc): []