bisecting fixing commit since 7edd66cf61670d2d0c31f89cb3a247016e489a8a building syzkaller on 03d97a1bcdd0542ca2240cf468d9be585cfc06b7 testing commit 7edd66cf61670d2d0c31f89cb3a247016e489a8a with gcc (GCC) 8.1.0 kernel signature: 739653e2b43c44eaca161681728bfd139f5a573e5325b4947303e8b014c69d44 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy testing current HEAD 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 testing commit 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 with gcc (GCC) 8.1.0 kernel signature: 7257f75a26ca472a811d782091aa985a631dd87a1871f41bb4ac9555f9980b16 run #0: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #1: crashed: INFO: trying to register non-static key in corrupted run #2: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #3: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #4: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #5: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #6: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #7: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #8: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #9: crashed: INFO: trying to register non-static key in uhid_dev_destroy revisions tested: 2, total time: 25m11.922641409s (build: 16m45.95839694s, test: 7m55.813938775s) the crash still happens on HEAD commit msg: Linux 4.19.124 crash: INFO: trying to register non-static key in uhid_dev_destroy hid-generic 0000:4000:0000.0AD3: hidraw0: HID v0.00 Device [syz1] on sz1 hid-generic 0000:4000:0000.0AD2: hidraw3: HID v0.00 Device [syz1] on sz1 hid-generic 0000:4000:0000.0AD4: ignoring exceeding usage max hid-generic 0000:4000:0000.0AD4: hidraw0: HID v0.00 Device [syz1] on sz1 INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 9574 Comm: syz-executor.5 Not tainted 4.19.124-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x123/0x177 lib/dump_stack.c:118 assign_lock_key kernel/locking/lockdep.c:727 [inline] register_lock_class+0x207f/0x2350 kernel/locking/lockdep.c:753 __lock_acquire+0x160/0x4980 kernel/locking/lockdep.c:3303 lock_acquire+0x173/0x3d0 kernel/locking/lockdep.c:3907 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x99/0xd0 kernel/locking/spinlock.c:152 __wake_up_common_lock+0xba/0x180 kernel/sched/wait.c:120 __wake_up+0xe/0x10 kernel/sched/wait.c:145 uhid_dev_destroy+0x57/0xe0 drivers/hid/uhid.c:566 uhid_char_release+0x4d/0xb0 drivers/hid/uhid.c:645 __fput+0x249/0x7f0 fs/file_table.c:278 ____fput+0x9/0x10 fs/file_table.c:309 task_work_run+0x108/0x180 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:193 [inline] exit_to_usermode_loop+0x1a9/0x200 arch/x86/entry/common.c:167 prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline] syscall_return_slowpath arch/x86/entry/common.c:271 [inline] do_syscall_64+0x413/0x4e0 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x416421 Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 1b 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:00007ffc7da68730 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000416421 RDX: 0000000000000001 RSI: 0000000000790460 RDI: 0000000000000003 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 00007ffc7da68820 R11: 0000000000000293 R12: 0000000000790560 R13: 0000000000022650 R14: ffffffffffffffff R15: 000000000078bfac kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 9574 Comm: syz-executor.5 Not tainted 4.19.124-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__wake_up_common+0xdb/0x600 kernel/sched/wait.c:85 Code: 05 00 00 4c 8b 43 38 49 83 e8 18 49 8d 78 18 48 39 7d d0 0f 84 54 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 f9 48 c1 e9 03 <80> 3c 01 00 0f 85 f9 04 00 00 49 8b 40 18 89 55 b8 31 db 49 be 00 RSP: 0018:ffff88808994fc90 EFLAGS: 00010046 RAX: dffffc0000000000 RBX: ffff888072b84908 RCX: 0000000000000000 RDX: 0000000000000001 RSI: 0000000000000001 RDI: 0000000000000000 RBP: ffff88808994fce0 R08: ffffffffffffffe8 R09: ffff88808994fd20 R10: ffffed100e570921 R11: ffff888072b8490b R12: 0000000000000001 R13: ffff88808994fd20 R14: 0000000000000000 R15: ffff8880a48a8020 FS: 000000000104e940(0000) GS:ffff8880aea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000b90004 CR3: 00000000a8e1a000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __wake_up_common_lock+0xde/0x180 kernel/sched/wait.c:121 __wake_up+0xe/0x10 kernel/sched/wait.c:145 uhid_dev_destroy+0x57/0xe0 drivers/hid/uhid.c:566 uhid_char_release+0x4d/0xb0 drivers/hid/uhid.c:645 __fput+0x249/0x7f0 fs/file_table.c:278 ____fput+0x9/0x10 fs/file_table.c:309 task_work_run+0x108/0x180 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:193 [inline] exit_to_usermode_loop+0x1a9/0x200 arch/x86/entry/common.c:167 prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline] syscall_return_slowpath arch/x86/entry/common.c:271 [inline] do_syscall_64+0x413/0x4e0 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x416421 Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 1b 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:00007ffc7da68730 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000416421 RDX: 0000000000000001 RSI: 0000000000790460 RDI: 0000000000000003 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 00007ffc7da68820 R11: 0000000000000293 R12: 0000000000790560 R13: 0000000000022650 R14: ffffffffffffffff R15: 000000000078bfac Modules linked in: ---[ end trace 96436a4498aeea9d ]--- RIP: 0010:__wake_up_common+0xdb/0x600 kernel/sched/wait.c:85 Code: 05 00 00 4c 8b 43 38 49 83 e8 18 49 8d 78 18 48 39 7d d0 0f 84 54 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 f9 48 c1 e9 03 <80> 3c 01 00 0f 85 f9 04 00 00 49 8b 40 18 89 55 b8 31 db 49 be 00 RSP: 0018:ffff88808994fc90 EFLAGS: 00010046 RAX: dffffc0000000000 RBX: ffff888072b84908 RCX: 0000000000000000 RDX: 0000000000000001 RSI: 0000000000000001 RDI: 0000000000000000 RBP: ffff88808994fce0 R08: ffffffffffffffe8 R09: ffff88808994fd20 R10: ffffed100e570921 R11: ffff888072b8490b R12: 0000000000000001 R13: ffff88808994fd20 R14: 0000000000000000 R15: ffff8880a48a8020 FS: 000000000104e940(0000) GS:ffff8880aea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000b90004 CR3: 00000000a8e1a000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400