bisecting fixing commit since e01e060fe00dca46959bbf055b75d9f57ba6e7be building syzkaller on 442206d76b974cca2d83ec763d4cf5ee829eb7d6 testing commit e01e060fe00dca46959bbf055b75d9f57ba6e7be with gcc (GCC) 8.1.0 kernel signature: da9dc3610c6ba864dbe3bb15f5033ea316926a13 all runs: crashed: WARNING in perf_reg_value testing current HEAD 94e89b40235476a83a53a47b9ffb0cb91a4c335e testing commit 94e89b40235476a83a53a47b9ffb0cb91a4c335e with gcc (GCC) 8.1.0 kernel signature: 69842faa9a9191efc318fc0a0f6b3b9aecb32d21 all runs: OK # git bisect start 94e89b40235476a83a53a47b9ffb0cb91a4c335e e01e060fe00dca46959bbf055b75d9f57ba6e7be Bisecting: 23672 revisions left to test after this (roughly 15 steps) [8b53c76533aa4356602aea98f98a2f3b4051464c] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 testing commit 8b53c76533aa4356602aea98f98a2f3b4051464c with gcc (GCC) 8.1.0 kernel signature: fc9867aeaa563d29c0506b61118dbc045da751c4 all runs: OK # git bisect bad 8b53c76533aa4356602aea98f98a2f3b4051464c Bisecting: 10748 revisions left to test after this (roughly 13 steps) [be8454afc50f43016ca8b6130d9673bdd0bd56ec] Merge tag 'drm-next-2019-07-16' of git://anongit.freedesktop.org/drm/drm testing commit be8454afc50f43016ca8b6130d9673bdd0bd56ec with gcc (GCC) 8.1.0 kernel signature: 2d780139d2f85663a96b6c7d3728787642921603 all runs: OK # git bisect bad be8454afc50f43016ca8b6130d9673bdd0bd56ec Bisecting: 4680 revisions left to test after this (roughly 13 steps) [237f83dfbe668443b5e31c3c7576125871cca674] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next testing commit 237f83dfbe668443b5e31c3c7576125871cca674 with gcc (GCC) 8.1.0 kernel signature: 61e178a9723ab9cbb06633c3b1f33a1b91c78f57 run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 237f83dfbe668443b5e31c3c7576125871cca674 Bisecting: 2345 revisions left to test after this (roughly 11 steps) [92adeb616c9172dea9678f53ea6e5501fc4f4338] Merge tag 'for-linus-5.3' of git://github.com/cminyard/linux-ipmi testing commit 92adeb616c9172dea9678f53ea6e5501fc4f4338 with gcc (GCC) 8.1.0 kernel signature: b7422ca6c9c0ff268edbfa69439cca4c3d61d0ce run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 92adeb616c9172dea9678f53ea6e5501fc4f4338 Bisecting: 1172 revisions left to test after this (roughly 10 steps) [4850ce697f9892df083bd7b3ec7c715404dd4279] drm/amd/display: Add hubp_init entry to hubp vtable testing commit 4850ce697f9892df083bd7b3ec7c715404dd4279 with gcc (GCC) 8.1.0 kernel signature: c4e58528ee9c9923bea712ea4db5743d39b972c9 all runs: crashed: WARNING in perf_reg_value # git bisect good 4850ce697f9892df083bd7b3ec7c715404dd4279 Bisecting: 587 revisions left to test after this (roughly 9 steps) [53e155f2bbd42df7e8bea87be78f0d60fe9fa122] Merge tag 'drm-msm-next-2019-06-25' of https://gitlab.freedesktop.org/drm/msm into drm-next testing commit 53e155f2bbd42df7e8bea87be78f0d60fe9fa122 with gcc (GCC) 8.1.0 kernel signature: 5fc442c1f9407d659afb0f997756ba295647068e all runs: crashed: WARNING in perf_reg_value # git bisect good 53e155f2bbd42df7e8bea87be78f0d60fe9fa122 Bisecting: 294 revisions left to test after this (roughly 8 steps) [50ec18819cade37cccc914ffc71a8b0a2783c345] Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip testing commit 50ec18819cade37cccc914ffc71a8b0a2783c345 with gcc (GCC) 8.1.0 kernel signature: 30d6684dd31144eb8c15f4c85bc8402ca966b7e7 all runs: OK # git bisect bad 50ec18819cade37cccc914ffc71a8b0a2783c345 Bisecting: 146 revisions left to test after this (roughly 7 steps) [372fba9c76af11f1c7d162d22cff94e46f467bfb] powerpc/8xx: refactor writing of CPM microcode arrays testing commit 372fba9c76af11f1c7d162d22cff94e46f467bfb with gcc (GCC) 8.1.0 kernel signature: 7c8615868443f6e41451248986b202aea08282f0 all runs: crashed: WARNING in perf_reg_value # git bisect good 372fba9c76af11f1c7d162d22cff94e46f467bfb Bisecting: 70 revisions left to test after this (roughly 6 steps) [3f06962273e73c5f7a651726b191d531cadef788] Merge tag 'mtd/for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux testing commit 3f06962273e73c5f7a651726b191d531cadef788 with gcc (GCC) 8.1.0 kernel signature: c1b312cc35223bcad34890747eaf6d175e37310d run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: crashed: general protection fault in send_hsr_supervision_frame run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 3f06962273e73c5f7a651726b191d531cadef788 Bisecting: 35 revisions left to test after this (roughly 5 steps) [100c4043b808739d808bb5c9f6868d3808f062ea] tc-tests: updated skbedit tests testing commit 100c4043b808739d808bb5c9f6868d3808f062ea with gcc (GCC) 8.1.0 kernel signature: 3817da7f10bf71a14d426e1b5b9c45579ccb6d15 all runs: OK # git bisect bad 100c4043b808739d808bb5c9f6868d3808f062ea Bisecting: 15 revisions left to test after this (roughly 4 steps) [114a5c3240155fdb01bf821c9d326d7bb05bd464] Merge tag 'mlx5-fixes-2019-07-11' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux testing commit 114a5c3240155fdb01bf821c9d326d7bb05bd464 with gcc (GCC) 8.1.0 kernel signature: 61956e32095f9648dba03e3fefefb83ceb4f00d6 all runs: OK # git bisect bad 114a5c3240155fdb01bf821c9d326d7bb05bd464 Bisecting: 9 revisions left to test after this (roughly 3 steps) [c93dfec10f1d693a897bfd0d6e3a58a5ea7edc91] net/mlx5e: Fix compilation error in TLS code testing commit c93dfec10f1d693a897bfd0d6e3a58a5ea7edc91 with gcc (GCC) 8.1.0 kernel signature: d466f87fd3250f1671d83efc7266908065706172 all runs: OK # git bisect bad c93dfec10f1d693a897bfd0d6e3a58a5ea7edc91 Bisecting: 4 revisions left to test after this (roughly 2 steps) [311633b604063a8a5d3fbc74d0565b42df721f68] hsr: switch ->dellink() to ->ndo_uninit() testing commit 311633b604063a8a5d3fbc74d0565b42df721f68 with gcc (GCC) 8.1.0 kernel signature: 42ab052af2850f87b087f0f326753ae332a9b849 all runs: OK # git bisect bad 311633b604063a8a5d3fbc74d0565b42df721f68 Bisecting: 1 revision left to test after this (roughly 1 step) [937a944090cca2f19458fd037a8aff61c546f0cd] net: ethernet: mediatek: Fix misuses of GENMASK macro testing commit 937a944090cca2f19458fd037a8aff61c546f0cd with gcc (GCC) 8.1.0 kernel signature: 27952dcd81f3e3ce5eb25f5998839bc3a6dbd628 run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: crashed: general protection fault in send_hsr_supervision_frame run #5: crashed: general protection fault in send_hsr_supervision_frame run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 937a944090cca2f19458fd037a8aff61c546f0cd Bisecting: 0 revisions left to test after this (roughly 0 steps) [aa4c0c9091b0bb4cb261bbe0718d17c2834c4690] net: stmmac: Fix misuses of GENMASK macro testing commit aa4c0c9091b0bb4cb261bbe0718d17c2834c4690 with gcc (GCC) 8.1.0 kernel signature: dcb46f1993f2f5836d6c3a746b327f7498e58dd8 run #0: crashed: general protection fault in send_hsr_supervision_frame run #1: crashed: general protection fault in send_hsr_supervision_frame run #2: crashed: general protection fault in send_hsr_supervision_frame run #3: crashed: general protection fault in send_hsr_supervision_frame run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good aa4c0c9091b0bb4cb261bbe0718d17c2834c4690 311633b604063a8a5d3fbc74d0565b42df721f68 is the first bad commit commit 311633b604063a8a5d3fbc74d0565b42df721f68 Author: Cong Wang Date: Tue Jul 9 23:24:54 2019 -0700 hsr: switch ->dellink() to ->ndo_uninit() Switching from ->priv_destructor to dellink() has an unexpected consequence: existing RCU readers, that is, hsr_port_get_hsr() callers, may still be able to read the port list. Instead of checking the return value of each hsr_port_get_hsr(), we can just move it to ->ndo_uninit() which is called after device unregister and synchronize_net(), and we still have RTNL lock there. Fixes: b9a1e627405d ("hsr: implement dellink to clean up resources") Fixes: edf070a0fb45 ("hsr: fix a NULL pointer deref in hsr_dev_xmit()") Reported-by: syzbot+097ef84cdc95843fbaa8@syzkaller.appspotmail.com Cc: Arvid Brodin Signed-off-by: Cong Wang Signed-off-by: David S. Miller net/hsr/hsr_device.c | 18 ++++++++---------- net/hsr/hsr_device.h | 1 - net/hsr/hsr_netlink.c | 7 ------- 3 files changed, 8 insertions(+), 18 deletions(-) kernel signature: 42ab052af2850f87b087f0f326753ae332a9b849 previous signature: dcb46f1993f2f5836d6c3a746b327f7498e58dd8 revisions tested: 17, total time: 4h22m36.516133929s (build: 1h43m26.421989997s, test: 2h36m59.69727973s) first good commit: 311633b604063a8a5d3fbc74d0565b42df721f68 hsr: switch ->dellink() to ->ndo_uninit() cc: ["arvid.brodin@alten.se" "davem@davemloft.net" "linux-kernel@vger.kernel.org" "netdev@vger.kernel.org" "xiyou.wangcong@gmail.com"]