ci starts bisection 2022-12-28 15:16:02.069809306 +0000 UTC m=+81312.612514868 bisecting fixing commit since 0840a7914caa14315a3191178a9f72c742477860 building syzkaller on a371c43c33b6f901421f93b655442363c072d251 ensuring issue is reproducible on original commit 0840a7914caa14315a3191178a9f72c742477860 testing commit 0840a7914caa14315a3191178a9f72c742477860 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e63845defbdbc73d48146ada4edcd6449083351a79864b213d00a3b9680f9edf all runs: crashed: possible deadlock in rds_wake_sk_sleep testing current HEAD 1b929c02afd37871d5afb9d498426f83432e71c2 testing commit 1b929c02afd37871d5afb9d498426f83432e71c2 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 566fb73adfda471864d7dcba134d7b3f2915e983734411108b1215aa7dbf66e0 run #0: crashed: possible deadlock in rds_wake_sk_sleep run #1: crashed: possible deadlock in rds_wake_sk_sleep run #2: crashed: possible deadlock in rds_wake_sk_sleep run #3: crashed: possible deadlock in rds_wake_sk_sleep run #4: crashed: possible deadlock in rds_wake_sk_sleep run #5: crashed: possible deadlock in rds_wake_sk_sleep run #6: crashed: possible deadlock in rds_wake_sk_sleep run #7: crashed: possible deadlock in rds_wake_sk_sleep run #8: OK run #9: crashed: possible deadlock in rds_wake_sk_sleep revisions tested: 2, total time: 38m8.8193044s (build: 14m46.167462659s, test: 22m16.858976685s) the crash still happens on HEAD commit msg: Linux 6.2-rc1 crash: possible deadlock in rds_wake_sk_sleep ====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc1-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor422/8641 is trying to acquire lock: ffff88807a8e8e30 (&rs->rs_recv_lock){...-}-{2:2}, at: rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 but task is already holding lock: ffff88807a63f900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e7/0x9a0 net/rds/send.c:628 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rm->m_rs_lock){..-.}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:162 rds_message_purge net/rds/message.c:138 [inline] rds_message_put+0x16d/0xad0 net/rds/message.c:180 rds_clear_recv_queue+0x1c5/0x350 net/rds/recv.c:767 rds_release+0xca/0x350 net/rds/af_rds.c:73 __sock_release+0xbb/0x270 net/socket.c:650 sock_close+0xf/0x20 net/socket.c:1365 __fput+0x1fa/0x9a0 fs/file_table.c:320 task_work_run+0x12b/0x220 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:171 [inline] exit_to_user_mode_prepare+0x23c/0x250 kernel/entry/common.c:203 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline] syscall_exit_to_user_mode+0x19/0x50 kernel/entry/common.c:296 do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&rs->rs_recv_lock){...-}-{2:2}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x45/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x256/0x9a0 net/rds/send.c:634 rds_send_path_drop_acked+0x276/0x360 net/rds/send.c:710 rds_tcp_write_space+0x196/0x5a0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0xde/0x730 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0x7b5/0x2250 net/ipv4/tcp_input.c:6019 tcp_v4_do_rcv+0x540/0x7f0 net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x113/0x360 net/core/sock.c:2928 release_sock+0x4a/0x170 net/core/sock.c:3485 rds_send_xmit+0x87e/0x2360 net/rds/send.c:422 rds_sendmsg+0x1d90/0x28d0 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:734 __sys_sendto+0x1bb/0x290 net/socket.c:2117 __do_sys_sendto net/socket.c:2129 [inline] __se_sys_sendto net/socket.c:2125 [inline] __x64_sys_sendto+0xd8/0x1b0 net/socket.c:2125 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); *** DEADLOCK *** 3 locks held by syz-executor422/8641: #0: ffff88807e4dcff0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1725 [inline] #0: ffff88807e4dcff0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sock_set_cork+0xe/0x70 net/ipv4/tcp.c:3339 #1: ffff88807e4dd278 (k-clock-AF_INET){++.-}-{2:2}, at: rds_tcp_write_space+0x20/0x5a0 net/rds/tcp_send.c:184 #2: ffff88807a63f900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e7/0x9a0 net/rds/send.c:628 stack backtrace: CPU: 0 PID: 8641 Comm: syz-executor422 Not tainted 6.2.0-rc1-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x57/0x7d lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x45/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x256/0x9a0 net/rds/send.c:634 rds_send_path_drop_acked+0x276/0x360 net/rds/send.c:710 rds_tcp_write_space+0x196/0x5a0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0xde/0x730 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0x7b5/0x2250 net/ipv4/tcp_input.c:6019 tcp_v4_do_rcv+0x540/0x7f0 net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x113/0x360 net/core/sock.c:2928 release_sock+0x4a/0x170 net/core/sock.c:3485 rds_send_xmit+0x87e/0x2360 net/rds/send.c:422 rds_sendmsg+0x1d90/0x28d0 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:734 __sys_sendto+0x1bb/0x290 net/socket.c:2117 __do_sys_sendto net/socket.c:2129 [inline] __se_sys_sendto net/socket.c:2125 [inline] __x64_sys_sendto+0xd8/0x1b0 net/socket.c:2125 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f2b67794139 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2b67741308 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 00007f2b6781d4c8 RCX: 00007f2b67794139 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00007f2b6781d4c0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f2b677ea5d0 R13: 00007ffcbc233aaf R14: 00007f2b67741400 R15: 0000000000022000