ci starts bisection 2023-04-14 22:20:14.092269712 +0000 UTC m=+123102.116470635 bisecting fixing commit since c183e6c3ec342624c43269c099050d01eeb67e63 building syzkaller on ab32d50881df9f96f2af301aadca62ad00b7e099 ensuring issue is reproducible on original commit c183e6c3ec342624c43269c099050d01eeb67e63 testing commit c183e6c3ec342624c43269c099050d01eeb67e63 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: b67fc976745d7b683c32c4cf124c93386d0ad040c7c3a0e355bc91922ea3e306 run #0: crashed: possible deadlock in rds_message_put run #1: crashed: possible deadlock in rds_wake_sk_sleep run #2: crashed: possible deadlock in rds_wake_sk_sleep run #3: crashed: possible deadlock in rds_wake_sk_sleep run #4: crashed: possible deadlock in rds_wake_sk_sleep run #5: crashed: possible deadlock in rds_wake_sk_sleep run #6: crashed: possible deadlock in rds_wake_sk_sleep run #7: crashed: possible deadlock in rds_wake_sk_sleep run #8: crashed: possible deadlock in rds_wake_sk_sleep run #9: crashed: possible deadlock in rds_wake_sk_sleep run #10: crashed: possible deadlock in rds_wake_sk_sleep run #11: crashed: possible deadlock in rds_wake_sk_sleep run #12: crashed: possible deadlock in rds_wake_sk_sleep run #13: crashed: possible deadlock in rds_wake_sk_sleep run #14: crashed: possible deadlock in rds_wake_sk_sleep run #15: crashed: possible deadlock in rds_wake_sk_sleep run #16: crashed: possible deadlock in rds_wake_sk_sleep run #17: crashed: possible deadlock in rds_wake_sk_sleep run #18: crashed: possible deadlock in rds_wake_sk_sleep run #19: crashed: possible deadlock in rds_wake_sk_sleep testing current HEAD c11d2e718c792468e67389b506451eddf26c2dac testing commit c11d2e718c792468e67389b506451eddf26c2dac gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 79c0c9799e7d1b00c17edc31278ca40bfd7156d8493686b76f9f0d880e044012 all runs: crashed: possible deadlock in rds_wake_sk_sleep revisions tested: 2, total time: 24m58.674821242s (build: 18m0.077930347s, test: 6m16.487763491s) the crash still happens on HEAD commit msg: Merge branch 'msg_control-split' crash: possible deadlock in rds_wake_sk_sleep ====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc6-syzkaller #0 Not tainted ------------------------------------------------------ kworker/u4:4/928 is trying to acquire lock: ffff8880786f8df0 (&rs->rs_recv_lock){...-}-{2:2}, at: rds_wake_sk_sleep+0x1e/0xc0 net/rds/af_rds.c:109 but task is already holding lock: ffff888146a53900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e7/0x9a0 net/rds/send.c:628 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rm->m_rs_lock){..-.}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3d/0x60 kernel/locking/spinlock.c:162 rds_message_purge net/rds/message.c:138 [inline] rds_message_put+0x171/0xab0 net/rds/message.c:180 rds_clear_recv_queue+0x1c9/0x350 net/rds/recv.c:768 rds_release+0xce/0x360 net/rds/af_rds.c:73 __sock_release+0xbb/0x280 net/socket.c:653 sock_close+0x13/0x20 net/socket.c:1395 __fput+0x1fa/0x9a0 fs/file_table.c:321 task_work_run+0x12f/0x220 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:171 [inline] exit_to_user_mode_prepare+0x210/0x240 kernel/entry/common.c:204 __syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline] syscall_exit_to_user_mode+0x1d/0x50 kernel/entry/common.c:297 do_syscall_64+0x46/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&rs->rs_recv_lock){...-}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x49/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x1e/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x256/0x9a0 net/rds/send.c:634 rds_send_path_drop_acked+0x27a/0x360 net/rds/send.c:710 rds_tcp_write_space+0x19a/0x5c0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0xe2/0x730 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0x763/0x2030 net/ipv4/tcp_input.c:6021 tcp_v4_do_rcv+0x53b/0x800 net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x117/0x360 net/core/sock.c:2917 release_sock+0x4e/0x170 net/core/sock.c:3484 rds_send_xmit+0x882/0x2380 net/rds/send.c:422 rds_send_worker+0x7b/0x270 net/rds/threads.c:200 process_one_work+0x865/0x1400 kernel/workqueue.c:2390 worker_thread+0x59c/0xec0 kernel/workqueue.c:2537 kthread+0x298/0x340 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); *** DEADLOCK *** 5 locks held by kworker/u4:4/928: #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: arch_atomic_long_set include/linux/atomic/atomic-long.h:41 [inline] #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: atomic_long_set include/linux/atomic/atomic-instrumented.h:1324 [inline] #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:639 [inline] #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:666 [inline] #0: ffff888026b9c138 ((wq_completion)krdsd){+.+.}-{0:0}, at: process_one_work+0x78a/0x1400 kernel/workqueue.c:2361 #1: ffffc90004bbfdb8 ((work_completion)(&(&cp->cp_send_w)->work)){+.+.}-{0:0}, at: process_one_work+0x7b7/0x1400 kernel/workqueue.c:2365 #2: ffff888028d219b0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1697 [inline] #2: ffff888028d219b0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sock_set_cork+0x12/0x70 net/ipv4/tcp.c:3343 #3: ffff888028d21c38 (k-clock-AF_INET){++.-}-{2:2}, at: rds_tcp_write_space+0x24/0x5c0 net/rds/tcp_send.c:184 #4: ffff888146a53900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e7/0x9a0 net/rds/send.c:628 stack backtrace: CPU: 1 PID: 928 Comm: kworker/u4:4 Not tainted 6.3.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 Workqueue: krdsd rds_send_worker Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x64/0xb0 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x49/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x1e/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x256/0x9a0 net/rds/send.c:634 rds_send_path_drop_acked+0x27a/0x360 net/rds/send.c:710 rds_tcp_write_space+0x19a/0x5c0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0xe2/0x730 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0x763/0x2030 net/ipv4/tcp_input.c:6021 tcp_v4_do_rcv+0x53b/0x800 net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x117/0x360 net/core/sock.c:2917 release_sock+0x4e/0x170 net/core/sock.c:3484 rds_send_xmit+0x882/0x2380 net/rds/send.c:422 rds_send_worker+0x7b/0x270 net/rds/threads.c:200 process_one_work+0x865/0x1400 kernel/workqueue.c:2390 worker_thread+0x59c/0xec0 kernel/workqueue.c:2537 kthread+0x298/0x340 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308