ci starts bisection 2023-06-10 12:18:13.376970126 +0000 UTC m=+269605.665397008 bisecting cause commit starting from e7c5433c5aaab52ddd5448967a9a5db94a3939cc building syzkaller on 7086cdb95114c57c35cee9db87b80d4225d8795d ensuring issue is reproducible on original commit e7c5433c5aaab52ddd5448967a9a5db94a3939cc testing commit e7c5433c5aaab52ddd5448967a9a5db94a3939cc gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 617d5c1c9258f46c5bd52bf61dc4e842ed0107b43da1fd0a7676ffd297691aa5 all runs: crashed: KASAN: stack-out-of-bounds Read in skb_splice_from_iter testing release v6.3 testing commit 457391b0380335d5e9a5babdec90ac53928b23b4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8e335c8c4502f75f2c145bbad88d0d874638dfdd471bf71d4003cc92136e89b7 all runs: OK # git bisect start e7c5433c5aaab52ddd5448967a9a5db94a3939cc 457391b0380335d5e9a5babdec90ac53928b23b4 Bisecting: 8059 revisions left to test after this (roughly 13 steps) [cb6fe2ceb667eb78f252d473b03deb23999ab1cf] Merge tag 'devicetree-for-6.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux testing commit cb6fe2ceb667eb78f252d473b03deb23999ab1cf gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: eb2b50f27e1c4f1c5489fe9529d8c6e91b28f7689b9b244df81876d6cce14835 all runs: OK # git bisect good cb6fe2ceb667eb78f252d473b03deb23999ab1cf Bisecting: 4031 revisions left to test after this (roughly 12 steps) [26c009dffca89b0f8fe7facc41d1ccf88a66825a] Merge tag '6.4-rc-smb3-client-fixes-part1' of git://git.samba.org/sfrench/cifs-2.6 testing commit 26c009dffca89b0f8fe7facc41d1ccf88a66825a gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 23164849375732ed807da3dbe00f177786ee7bece2fefc418e56810d0d6d178b all runs: OK # git bisect good 26c009dffca89b0f8fe7facc41d1ccf88a66825a Bisecting: 2015 revisions left to test after this (roughly 11 steps) [cba582631ee40772c6dbe24e945b9173572dfca0] Merge tag 'tpmdd-v6.4-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd testing commit cba582631ee40772c6dbe24e945b9173572dfca0 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 246b28f8d8304300c5e56d4682ec3b855d5e5b08d977b6e21b97260dbd0255b0 all runs: OK # git bisect good cba582631ee40772c6dbe24e945b9173572dfca0 Bisecting: 1006 revisions left to test after this (roughly 10 steps) [9455b4b6db1e9b11d242595cc968332ecdd3cc91] Merge tag 'powerpc-6.4-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux testing commit 9455b4b6db1e9b11d242595cc968332ecdd3cc91 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2a19397dec13db29359fbec1be0506cb1d073cf02c9840b74d2d089add031269 all runs: OK # git bisect good 9455b4b6db1e9b11d242595cc968332ecdd3cc91 Bisecting: 503 revisions left to test after this (roughly 9 steps) [ca33db4a86023f1158dc2b3587ca3c90d2a0705e] net: phy: microchip_t1s: modify driver description to be more generic testing commit ca33db4a86023f1158dc2b3587ca3c90d2a0705e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 13c792fcb8e264b90178eaf8e1f422eeff89f2af573c9f4fd29f7211a61bb58e all runs: OK # git bisect good ca33db4a86023f1158dc2b3587ca3c90d2a0705e Bisecting: 278 revisions left to test after this (roughly 8 steps) [25041a4c02c7cf774d8b6ed60586fd64f1cdaa81] Merge tag 'net-6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 25041a4c02c7cf774d8b6ed60586fd64f1cdaa81 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e2f4953edda9e4a61f561e36038b6607234bcab659ea09d02c45af731030a342 all runs: OK # git bisect good 25041a4c02c7cf774d8b6ed60586fd64f1cdaa81 Bisecting: 143 revisions left to test after this (roughly 7 steps) [c422ac94e6daa3607319a08be89f133cb48aa42b] Merge branch 'drm-i915-use-ref_tracker-library-for-tracking-wakerefs' testing commit c422ac94e6daa3607319a08be89f133cb48aa42b gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 09bf332526178f7acd00d0d3f32718593af616094488dcf436011e259441ccc5 all runs: OK # git bisect good c422ac94e6daa3607319a08be89f133cb48aa42b Bisecting: 71 revisions left to test after this (roughly 6 steps) [fb800fa4c1f5aee1238267252e88a7837e645c02] crypto: af_alg: Convert af_alg_sendpage() to use MSG_SPLICE_PAGES testing commit fb800fa4c1f5aee1238267252e88a7837e645c02 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5de409f33f9f78709325786170c8d39cfc46b7e695087e1f82242e889a0b753f all runs: OK # git bisect good fb800fa4c1f5aee1238267252e88a7837e645c02 Bisecting: 41 revisions left to test after this (roughly 5 steps) [55b24334c0f2db55ca059848121939f59133bdb6] ethtool: ioctl: improve error checking for set_wol testing commit 55b24334c0f2db55ca059848121939f59133bdb6 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6f2da5f3301be5d04ac6e96cb74a571638516c18b81399e80cbf4615e5fdbe86 all runs: OK # git bisect good 55b24334c0f2db55ca059848121939f59133bdb6 Bisecting: 20 revisions left to test after this (roughly 4 steps) [df720d288dbb1793e82b6ccbfc670ec871e9def4] tls/sw: Use splice_eof() to flush testing commit df720d288dbb1793e82b6ccbfc670ec871e9def4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 699ae5556e00266e69ed8b397c150b8420b08de1f477a8e5ff06cff7b70cb002 all runs: crashed: KASAN: stack-out-of-bounds Read in skb_splice_from_iter # git bisect bad df720d288dbb1793e82b6ccbfc670ec871e9def4 Bisecting: 10 revisions left to test after this (roughly 3 steps) [f4692ab13a1f7ad2c2098b838c2820c113ce8a07] net/mlx5e: Remove RX page cache leftovers testing commit f4692ab13a1f7ad2c2098b838c2820c113ce8a07 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8e2d6a92eb17463826e93493e99bcc07f8830594dd355abcf8b7ba87f05ab1ff all runs: OK # git bisect good f4692ab13a1f7ad2c2098b838c2820c113ce8a07 Bisecting: 5 revisions left to test after this (roughly 3 steps) [f84ad5cffd889226e820a727211c0d0264fe7f34] Merge tag 'mlx5-updates-2023-06-06' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux testing commit f84ad5cffd889226e820a727211c0d0264fe7f34 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 236a0df6c3ebe39ca7e482adeed2460c9bdb7f27f1bb02fa45ab2e1f4c7f4afb all runs: OK # git bisect good f84ad5cffd889226e820a727211c0d0264fe7f34 Bisecting: 2 revisions left to test after this (roughly 2 steps) [81840b3b91aad06053ad2712f3da5d0448eeb0e8] tls: Allow MSG_SPLICE_PAGES but treat it as normal sendmsg testing commit 81840b3b91aad06053ad2712f3da5d0448eeb0e8 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 46324ca718c1eacbbcb976e213602d83857e9ae7117118fd2fe3c03fb08730ac all runs: OK # git bisect good 81840b3b91aad06053ad2712f3da5d0448eeb0e8 Bisecting: 0 revisions left to test after this (roughly 1 step) [2bfc66850952b6921b2033b09729ec59eabbc81d] splice, net: Add a splice_eof op to file-ops and socket-ops testing commit 2bfc66850952b6921b2033b09729ec59eabbc81d gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8c02f33c5f7d960bd2651705a0fb96f5f9113f6b9572af862373da91dcf241f7 all runs: crashed: KASAN: stack-out-of-bounds Read in skb_splice_from_iter # git bisect bad 2bfc66850952b6921b2033b09729ec59eabbc81d Bisecting: 0 revisions left to test after this (roughly 0 steps) [2dc334f1a63a8839b88483a3e73c0f27c9c1791c] splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage() testing commit 2dc334f1a63a8839b88483a3e73c0f27c9c1791c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7325b371bfd8ca22b5e4b54c9168c855b0637c9f2dc912c8ec9304baa0a51f58 all runs: crashed: KASAN: stack-out-of-bounds Read in skb_splice_from_iter # git bisect bad 2dc334f1a63a8839b88483a3e73c0f27c9c1791c 2dc334f1a63a8839b88483a3e73c0f27c9c1791c is the first bad commit commit 2dc334f1a63a8839b88483a3e73c0f27c9c1791c Author: David Howells Date: Wed Jun 7 19:19:09 2023 +0100 splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage() Replace generic_splice_sendpage() + splice_from_pipe + pipe_to_sendpage() with a net-specific handler, splice_to_socket(), that calls sendmsg() with MSG_SPLICE_PAGES set instead of calling ->sendpage(). MSG_MORE is used to indicate if the sendmsg() is expected to be followed with more data. This allows multiple pipe-buffer pages to be passed in a single call in a BVEC iterator, allowing the processing to be pushed down to a loop in the protocol driver. This helps pave the way for passing multipage folios down too. Protocols that haven't been converted to handle MSG_SPLICE_PAGES yet should just ignore it and do a normal sendmsg() for now - although that may be a bit slower as it may copy everything. Signed-off-by: David Howells Reviewed-by: Jakub Kicinski cc: Jens Axboe cc: Matthew Wilcox Signed-off-by: Jakub Kicinski fs/splice.c | 158 +++++++++++++++++++++++++++++++++++++++---------- include/linux/fs.h | 2 - include/linux/splice.h | 2 + net/socket.c | 26 +------- 4 files changed, 131 insertions(+), 57 deletions(-) culprit signature: 7325b371bfd8ca22b5e4b54c9168c855b0637c9f2dc912c8ec9304baa0a51f58 parent signature: 46324ca718c1eacbbcb976e213602d83857e9ae7117118fd2fe3c03fb08730ac revisions tested: 17, total time: 4h49m50.669998962s (build: 2h35m37.675800416s, test: 2h11m2.892814887s) first bad commit: 2dc334f1a63a8839b88483a3e73c0f27c9c1791c splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage() recipients (to): ["dhowells@redhat.com" "kuba@kernel.org"] recipients (cc): [] crash: KASAN: stack-out-of-bounds Read in skb_splice_from_iter ================================================================== BUG: KASAN: stack-out-of-bounds in skb_splice_from_iter+0x919/0x9d0 net/core/skbuff.c:6933 Read of size 8 at addr ffffc900049ef930 by task syz-executor.0/5444 CPU: 1 PID: 5444 Comm: syz-executor.0 Not tainted 6.4.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x64/0xb0 lib/dump_stack.c:106 print_address_description.constprop.0+0x2c/0x3c0 mm/kasan/report.c:351 print_report mm/kasan/report.c:462 [inline] kasan_report+0x11c/0x130 mm/kasan/report.c:572 skb_splice_from_iter+0x919/0x9d0 net/core/skbuff.c:6933 __ip_append_data+0xf53/0x3560 net/ipv4/ip_output.c:1210 ip_append_data net/ipv4/ip_output.c:1350 [inline] ip_append_data+0xc2/0x170 net/ipv4/ip_output.c:1329 raw_sendmsg+0x8b9/0x2950 net/ipv4/raw.c:641 sock_sendmsg_nosec net/socket.c:722 [inline] sock_sendmsg+0xc0/0x150 net/socket.c:745 splice_to_socket+0x738/0xd70 fs/splice.c:917 do_splice_from fs/splice.c:969 [inline] do_splice+0x9e1/0x1f00 fs/splice.c:1278 __do_splice+0x117/0x1f0 fs/splice.c:1356 __do_sys_splice fs/splice.c:1567 [inline] __se_sys_splice fs/splice.c:1549 [inline] __x64_sys_splice+0x14e/0x200 fs/splice.c:1549 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f7deb28c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f7debf57168 EFLAGS: 00000246 ORIG_RAX: 0000000000000113 RAX: ffffffffffffffda RBX: 00007f7deb3abf80 RCX: 00007f7deb28c169 RDX: 0000000000000005 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 00007f7deb2e7ca1 R08: 000000000004ffdd R09: 000000000000000d R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffda84dd78f R14: 00007f7debf57300 R15: 0000000000022000 The buggy address belongs to stack of task syz-executor.0/5444 and is located at offset 408 in frame: raw_sendmsg+0x0/0x2950 include/net/sock.h:2732 This frame has 8 objects: [48, 52) 'hdrincl' [64, 68) 'err' [80, 88) 'rt' [112, 152) 'ipc' [192, 240) 'state' [272, 336) 'fl4' [368, 392) 'rfv' [432, 504) 'opt_copy' The buggy address belongs to the virtual mapping at [ffffc900049e8000, ffffc900049f1000) created by: kernel_clone+0xbc/0x640 kernel/fork.c:2915 The buggy address belongs to the physical page: page:ffffea0001dc9b80 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x7726e memcg:ffff888028a0b002 flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff) page_type: 0xffffffff() raw: 00fff00000000000 0000000000000000 dead000000000122 0000000000000000 raw: 0000000000000000 0000000000000000 00000001ffffffff ffff888028a0b002 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 0, migratetype Unmovable, gfp_mask 0x102dc2(GFP_HIGHUSER|__GFP_NOWARN|__GFP_ZERO), pid 5425, tgid 5425 (dhcpcd-run-hook), ts 71002012495, free_ts 71000533390 set_page_owner include/linux/page_owner.h:31 [inline] post_alloc_hook+0x2db/0x350 mm/page_alloc.c:1731 prep_new_page mm/page_alloc.c:1738 [inline] get_page_from_freelist+0xf41/0x2c00 mm/page_alloc.c:3502 __alloc_pages+0x1cb/0x4a0 mm/page_alloc.c:4768 vm_area_alloc_pages mm/vmalloc.c:3009 [inline] __vmalloc_area_node mm/vmalloc.c:3085 [inline] __vmalloc_node_range+0x7ff/0x1070 mm/vmalloc.c:3257 alloc_thread_stack_node kernel/fork.c:313 [inline] dup_task_struct kernel/fork.c:1116 [inline] copy_process+0x1181/0x6bf0 kernel/fork.c:2333 kernel_clone+0xbc/0x640 kernel/fork.c:2915 __do_sys_clone+0xa1/0xe0 kernel/fork.c:3058 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1302 [inline] free_unref_page_prepare+0x62e/0xcb0 mm/page_alloc.c:2564 free_unref_page_list+0xe3/0xa70 mm/page_alloc.c:2705 release_pages+0x321/0x10e0 mm/swap.c:1042 tlb_batch_pages_flush+0x85/0x160 mm/mmu_gather.c:97 tlb_flush_mmu_free mm/mmu_gather.c:292 [inline] tlb_flush_mmu mm/mmu_gather.c:299 [inline] tlb_finish_mmu+0x114/0x6c0 mm/mmu_gather.c:391 exit_mmap+0x23d/0x750 mm/mmap.c:3123 __mmput+0xf3/0x440 kernel/fork.c:1351 exit_mm kernel/exit.c:567 [inline] do_exit+0x85d/0x24d0 kernel/exit.c:861 do_group_exit+0xb4/0x250 kernel/exit.c:1024 __do_sys_exit_group kernel/exit.c:1035 [inline] __se_sys_exit_group kernel/exit.c:1033 [inline] __x64_sys_exit_group+0x39/0x40 kernel/exit.c:1033 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Memory state around the buggy address: ffffc900049ef800: f2 00 00 00 00 00 f2 f2 f2 f2 f2 00 00 00 00 00 ffffc900049ef880: 00 f2 f2 f2 f2 00 00 00 00 00 00 00 00 f2 f2 f2 >ffffc900049ef900: f2 00 00 00 f2 f2 f2 f2 f2 00 00 00 00 00 00 00 ^ ffffc900049ef980: 00 00 f3 f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 ffffc900049efa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ==================================================================