ci2 starts bisection 2022-11-04 17:18:34.737750218 +0000 UTC m=+73656.094178180 bisecting fixing commit since 4fe89d07dcc2804c8b562f6c7896a45643d34b2f building syzkaller on feb5635181eb12a6e3516172a3f5af06a3bc93e1 ensuring issue is reproducible on original commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f testing commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6269a428eda8d905965eb5a8f356addef3e3ddbe26754ac3268adaed99bf0010 run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: crashed: kernel BUG in ext4_mb_use_inode_pa run #2: crashed: kernel BUG in ext4_mb_use_inode_pa run #3: crashed: kernel BUG in ext4_mb_use_inode_pa run #4: crashed: kernel BUG in ext4_mb_use_inode_pa run #5: crashed: kernel BUG in ext4_mb_use_inode_pa run #6: crashed: kernel BUG in ext4_mb_use_inode_pa run #7: crashed: kernel BUG in ext4_mb_use_inode_pa run #8: crashed: kernel BUG in ext4_mb_use_inode_pa run #9: crashed: kernel BUG in ext4_mb_use_inode_pa run #10: crashed: kernel BUG in ext4_mb_use_inode_pa run #11: crashed: kernel BUG in ext4_mb_use_inode_pa run #12: crashed: kernel BUG in ext4_mb_use_inode_pa run #13: crashed: kernel BUG in ext4_mb_use_inode_pa run #14: crashed: kernel BUG in ext4_mb_use_inode_pa run #15: crashed: kernel BUG in ext4_mb_use_inode_pa run #16: crashed: kernel BUG in ext4_mb_use_inode_pa run #17: crashed: kernel BUG in ext4_mb_use_inode_pa run #18: crashed: kernel BUG in ext4_mb_use_inode_pa run #19: crashed: kernel BUG in ext4_mb_use_inode_pa testing current HEAD ee6050c8af96bba2f81e8b0793a1fc2f998fcd20 testing commit ee6050c8af96bba2f81e8b0793a1fc2f998fcd20 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 088c48c03f901da27989808d44c42477806ea6857dda4fb867063cc52440eb19 all runs: OK # git bisect start ee6050c8af96bba2f81e8b0793a1fc2f998fcd20 4fe89d07dcc2804c8b562f6c7896a45643d34b2f Bisecting: 6671 revisions left to test after this (roughly 13 steps) [513389809e138ae903b6ef43c1d5d2ffaf4dca17] Merge tag 'for-6.1/block-2022-10-03' of git://git.kernel.dk/linux testing commit 513389809e138ae903b6ef43c1d5d2ffaf4dca17 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e0bec49dec6ef39b3af3cfd90258d96915daf20affdaa0bec921a806e5031de8 all runs: OK # git bisect bad 513389809e138ae903b6ef43c1d5d2ffaf4dca17 Bisecting: 3496 revisions left to test after this (roughly 12 steps) [a47e60729d9624e931f988709ab76e043e2ee8b9] Merge tag 'backlight-next-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight testing commit a47e60729d9624e931f988709ab76e043e2ee8b9 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e35778039de882d8482b9ba81093e766d42a45ec7aa26218e7d0cef49ac3768c all runs: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good a47e60729d9624e931f988709ab76e043e2ee8b9 Bisecting: 1617 revisions left to test after this (roughly 11 steps) [833477fce7a14d43ae4c07f8ddc32fa5119471a2] Merge tag 'sound-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound testing commit 833477fce7a14d43ae4c07f8ddc32fa5119471a2 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e536c78d9142fa232e5c8fb8950691cd06a8e8217d4260d464a27ca6f12eb3c1 all runs: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good 833477fce7a14d43ae4c07f8ddc32fa5119471a2 Bisecting: 730 revisions left to test after this (roughly 10 steps) [7171a8da00035e7913c3013ca5fb5beb5b8b22f0] Merge tag 'arm-dt-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc testing commit 7171a8da00035e7913c3013ca5fb5beb5b8b22f0 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 0b993e50d7fe523a72addc974d4a3516d5c1f2855e3eb89c0205290efa9242b3 all runs: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good 7171a8da00035e7913c3013ca5fb5beb5b8b22f0 Bisecting: 319 revisions left to test after this (roughly 9 steps) [76e45035348c247a70ed50eb29a9906657e4444f] Merge tag 'for-6.1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux testing commit 76e45035348c247a70ed50eb29a9906657e4444f gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e2d413a908aa18bd89a02a8214acb1fd55cb9787e8c4d87943ab6ecb15876f8b all runs: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good 76e45035348c247a70ed50eb29a9906657e4444f Bisecting: 161 revisions left to test after this (roughly 7 steps) [84fe64f898913ef69f70a8d91aea613b5722b63b] nvmet: don't look at the request_queue in nvmet_bdev_set_limits testing commit 84fe64f898913ef69f70a8d91aea613b5722b63b gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ffa8bf84fde4aeda1d9bb4a9b52e60180d0d2430aff2c9d408947d833015aa6f run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: exit status NUM run #1: crashed: kernel BUG in ext4_mb_use_inode_pa run #2: crashed: kernel BUG in ext4_mb_use_inode_pa run #3: crashed: kernel BUG in ext4_mb_use_inode_pa run #4: crashed: kernel BUG in ext4_mb_use_inode_pa run #5: crashed: kernel BUG in ext4_mb_use_inode_pa run #6: crashed: kernel BUG in ext4_mb_use_inode_pa run #7: crashed: kernel BUG in ext4_mb_use_inode_pa run #8: crashed: kernel BUG in ext4_mb_use_inode_pa run #9: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good 84fe64f898913ef69f70a8d91aea613b5722b63b Bisecting: 77 revisions left to test after this (roughly 6 steps) [9f4b9beeb9cf46c4b172fca06de5bd6831108641] Merge tag '6.1-rc-ksmbd-fixes' of git://git.samba.org/ksmbd testing commit 9f4b9beeb9cf46c4b172fca06de5bd6831108641 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 1361906e0776cd41f7f245d883f4b0bc9a27dbb953fe32419a15b88ce8ce3600 all runs: OK # git bisect bad 9f4b9beeb9cf46c4b172fca06de5bd6831108641 Bisecting: 41 revisions left to test after this (roughly 5 steps) [c8267c51425abd4f75d0ad07c4d3ee748908e2f8] ext4: remove useless local variable 'blocksize' testing commit c8267c51425abd4f75d0ad07c4d3ee748908e2f8 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9e4ac0fc133cbdb619b7193843f6c1194e680e0b184d986c4d8384d998024f81 run #0: boot failed: failed to create instance: googleapi: Error 503: Internal error. Please try again or contact Google Support. (Code: '5ECAAF01D160F.A65ABB4.3901401E'), backendError run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect bad c8267c51425abd4f75d0ad07c4d3ee748908e2f8 Bisecting: 20 revisions left to test after this (roughly 4 steps) [ebd5d23e88b7fc84cbbb7a002aa35bfd5bfadb10] ext4: remove ext4_inline_data_fiemap() declaration testing commit ebd5d23e88b7fc84cbbb7a002aa35bfd5bfadb10 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6495928135f81cf2459d039d995dec8f4f6128f03b982a068a000981a15d292a all runs: OK # git bisect bad ebd5d23e88b7fc84cbbb7a002aa35bfd5bfadb10 Bisecting: 10 revisions left to test after this (roughly 3 steps) [ab620620bf426af110093c5921888c0a4bf86ab4] fs/buffer: drop useless return value of submit_bh testing commit ab620620bf426af110093c5921888c0a4bf86ab4 gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 929d737c3e464f94238b64e3b630f8b7cd9cc80799751c4aad93c6e531f051d6 all runs: OK # git bisect bad ab620620bf426af110093c5921888c0a4bf86ab4 Bisecting: 4 revisions left to test after this (roughly 2 steps) [426d15ad11419066f7042ffa8fbf1b5c21a1ecbe] ext4: don't run ext4lazyinit for read-only filesystems testing commit 426d15ad11419066f7042ffa8fbf1b5c21a1ecbe gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c489ffc04e2ce59f682d9902eb0968a162e32a103404c3b61cce3acc1c40ca1c all runs: OK # git bisect bad 426d15ad11419066f7042ffa8fbf1b5c21a1ecbe Bisecting: 2 revisions left to test after this (roughly 1 step) [d412df530f77d0f61c41b83f925997452fc3944c] ext4: minor defrag code improvements testing commit d412df530f77d0f61c41b83f925997452fc3944c gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c2f986f6c68b1a6f586c7bedd2a2ad8b913aea4958bf377e7820876ac3f92222 all runs: crashed: kernel BUG in ext4_mb_use_inode_pa # git bisect good d412df530f77d0f61c41b83f925997452fc3944c Bisecting: 0 revisions left to test after this (roughly 1 step) [2d544ec923dbe5fbed64a7f43dccf527218380bc] ext4: remove deprecated noacl/nouser_xattr options testing commit 2d544ec923dbe5fbed64a7f43dccf527218380bc gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9f034086c09d1b18e3295b8c513b89ef9dddfa173f1fca89e712098cf9f3ae1e all runs: OK # git bisect bad 2d544ec923dbe5fbed64a7f43dccf527218380bc Bisecting: 0 revisions left to test after this (roughly 0 steps) [4bb26f2885ac6930984ee451b952c5a6042f2c0e] ext4: avoid crash when inline data creation follows DIO write testing commit 4bb26f2885ac6930984ee451b952c5a6042f2c0e gcc compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 72393977178dabab729fbf7f3aa08f4937b9b3be3c70edcc5e3f2e20dee6261a all runs: OK # git bisect bad 4bb26f2885ac6930984ee451b952c5a6042f2c0e 4bb26f2885ac6930984ee451b952c5a6042f2c0e is the first bad commit commit 4bb26f2885ac6930984ee451b952c5a6042f2c0e Author: Jan Kara Date: Wed Jul 27 17:57:53 2022 +0200 ext4: avoid crash when inline data creation follows DIO write When inode is created and written to using direct IO, there is nothing to clear the EXT4_STATE_MAY_INLINE_DATA flag. Thus when inode gets truncated later to say 1 byte and written using normal write, we will try to store the data as inline data. This confuses the code later because the inode now has both normal block and inline data allocated and the confusion manifests for example as: kernel BUG at fs/ext4/inode.c:2721! invalid opcode: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 359 Comm: repro Not tainted 5.19.0-rc8-00001-g31ba1e3b8305-dirty #15 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-1.fc36 04/01/2014 RIP: 0010:ext4_writepages+0x363d/0x3660 RSP: 0018:ffffc90000ccf260 EFLAGS: 00010293 RAX: ffffffff81e1abcd RBX: 0000008000000000 RCX: ffff88810842a180 RDX: 0000000000000000 RSI: 0000008000000000 RDI: 0000000000000000 RBP: ffffc90000ccf650 R08: ffffffff81e17d58 R09: ffffed10222c680b R10: dfffe910222c680c R11: 1ffff110222c680a R12: ffff888111634128 R13: ffffc90000ccf880 R14: 0000008410000000 R15: 0000000000000001 FS: 00007f72635d2640(0000) GS:ffff88811b000000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000565243379180 CR3: 000000010aa74000 CR4: 0000000000150eb0 Call Trace: do_writepages+0x397/0x640 filemap_fdatawrite_wbc+0x151/0x1b0 file_write_and_wait_range+0x1c9/0x2b0 ext4_sync_file+0x19e/0xa00 vfs_fsync_range+0x17b/0x190 ext4_buffered_write_iter+0x488/0x530 ext4_file_write_iter+0x449/0x1b90 vfs_write+0xbcd/0xf40 ksys_write+0x198/0x2c0 __x64_sys_write+0x7b/0x90 do_syscall_64+0x3d/0x90 entry_SYSCALL_64_after_hwframe+0x63/0xcd Fix the problem by clearing EXT4_STATE_MAY_INLINE_DATA when we are doing direct IO write to a file. Cc: stable@kernel.org Reported-by: Tadeusz Struk Reported-by: syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=a1e89d09bbbcbd5c4cb45db230ee28c822953984 Signed-off-by: Jan Kara Reviewed-by: Lukas Czerner Tested-by: Tadeusz Struk Link: https://lore.kernel.org/r/20220727155753.13969-1-jack@suse.cz Signed-off-by: Theodore Ts'o fs/ext4/file.c | 6 ++++++ 1 file changed, 6 insertions(+) culprit signature: 72393977178dabab729fbf7f3aa08f4937b9b3be3c70edcc5e3f2e20dee6261a parent signature: c2f986f6c68b1a6f586c7bedd2a2ad8b913aea4958bf377e7820876ac3f92222 revisions tested: 16, total time: 5h55m38.124117849s (build: 3h26m51.018150147s, test: 2h27m7.823344835s) first good commit: 4bb26f2885ac6930984ee451b952c5a6042f2c0e ext4: avoid crash when inline data creation follows DIO write recipients (to): ["jack@suse.cz" "lczerner@redhat.com" "tadeusz.struk@linaro.org" "tytso@mit.edu"] recipients (cc): []