ci2 starts bisection 2024-03-16 22:20:39.199324977 +0000 UTC m=+172177.322473395 bisecting fixing commit since f1bb70486c9c11d7e2d55240d4557f9fc575fbac building syzkaller on d902085f716b92f42bb867eca2975c7da711b78d ensuring issue is reproducible on original commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: ffc9912cdde9f4b0b0dad859ed1c9cda86639a5063f78dea3744c18352706680 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] check whether we can drop unnecessary instrumentation disabling configs for [UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP HANG LEAK], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 1805618cb0d42f2bb9c3184f647ba658d3a67214c02859b68695e3a7145ff9d2 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] the bug reproduces without the instrumentation disabling configs for [LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP HANG], they are not needed kconfig minimization: base=3820 full=7455 leaves diff=1990 split chunks (needed=false): <1990> split chunk #0 of len 1990 into 5 parts testing without sub-chunk 1/5 disabling configs for [HANG LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 8bc96a762b3cff6a67890304f1f26977bf811851f15f38a3a4693f212dd2aa18 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] the chunk can be dropped testing without sub-chunk 2/5 disabling configs for [LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP HANG], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: d3a36135952107d3d6638091089be5f26fca5f98627e0d5d7121b9449e82a587 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] the chunk can be dropped testing without sub-chunk 3/5 disabling configs for [HANG LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 71d9db0d20028154ae1823ace0ec9496522200a45ae988a8886669c69280dba7 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] the chunk can be dropped testing without sub-chunk 4/5 disabling configs for [LOCKDEP ATOMIC_SLEEP HANG LEAK UBSAN BUG KASAN], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 3d0d5a605adf4055b514cfd5cc1742de3808d23f5841794b2bde1c8abe9b6507 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] the chunk can be dropped testing without sub-chunk 5/5 disabling configs for [LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP HANG], they are not needed testing commit f1bb70486c9c11d7e2d55240d4557f9fc575fbac gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 1d4a5d38dab0a3d450e855e073498bb5e574f8038f9fb99ce47d0bcafe94fc6b all runs: OK false negative chance: 0.000 minimized to 398 configs; suspects: [ARCH_ENABLE_MEMORY_HOTREMOVE ATM BCMA BLK_DEV_ZONED BPF_SYSCALL CARDBUS CFG80211 CFG80211_WEXT CMA COMMON_CLK CONTIG_ALLOC CRYPTO_842 CRYPTO_LZ4 CRYPTO_LZ4HC CRYPTO_LZO CRYPTO_ZSTD DVB_CORE EXTCON FB GPIOLIB HID_ZEROPLUS I2C_MUX IIO IRQ_REMAP KVM KVM_INTEL LIBNVDIMM MEDIA_ANALOG_TV_SUPPORT MEDIA_CAMERA_SUPPORT MEDIA_CEC_SUPPORT MEDIA_CONTROLLER MEDIA_DIGITAL_TV_SUPPORT MEDIA_RADIO_SUPPORT MEDIA_SDR_SUPPORT MEDIA_SUPPORT MEDIA_TEST_SUPPORT MEDIA_USB_SUPPORT MEMORY_HOTPLUG MEMORY_HOTREMOVE MFD_VIPERBOARD PARPORT PCCARD PCMCIA PHONET RADIO_ADAPTERS RADIO_SI470X RADIO_SI4713 RC_CORE RFKILL SND SOUND SPI SSB TAP TARGET_CORE TUN USB_AMD5536UDC USB_ATM USB_CONFIGFS USB_CONFIGFS_F_MIDI USB_CONFIGFS_F_PRINTER USB_CONFIGFS_F_TCM USB_CONFIGFS_F_UAC1 USB_CONFIGFS_F_UAC1_LEGACY USB_CONFIGFS_F_UAC2 USB_CONFIGFS_F_UVC USB_CONFIGFS_MASS_STORAGE USB_CONFIGFS_NCM USB_CONFIGFS_OBEX USB_CONFIGFS_PHONET USB_CONFIGFS_RNDIS USB_CONFIGFS_SERIAL USB_CXACRU USB_CYPRESS_CY7C63 USB_CYTHERM USB_DSBR USB_DUMMY_HCD USB_DWC2 USB_DWC2_HOST USB_DWC2_PCI USB_DWC3 USB_DWC3_GADGET USB_DWC3_OF_SIMPLE USB_DWC3_PCI USB_DWC3_ULPI USB_DYNAMIC_MINORS USB_EG20T USB_EHCI_HCD_PLATFORM USB_EHCI_ROOT_HUB_TT USB_EHSET_TEST_FIXTURE USB_EMI26 USB_EMI62 USB_EPSON2888 USB_EZUSB_FX2 USB_FEW_INIT_RETRIES USB_FOTG210_HCD USB_FOTG210_UDC USB_FTDI_ELAN USB_F_ACM USB_F_ECM USB_F_EEM USB_F_FS USB_F_HID USB_F_MASS_STORAGE USB_F_MIDI USB_F_NCM USB_F_OBEX USB_F_PHONET USB_F_PRINTER USB_F_RNDIS USB_F_SERIAL USB_F_SS_LB USB_F_SUBSET USB_F_TCM USB_F_UAC1 USB_F_UAC1_LEGACY USB_F_UAC2 USB_F_UVC USB_GADGET USB_GADGETFS USB_GADGET_DEBUG_FILES USB_GADGET_DEBUG_FS USB_GL860 USB_GOKU USB_GPIO_VBUS USB_GR_UDC USB_GSPCA USB_GSPCA_BENQ USB_GSPCA_CONEX USB_GSPCA_CPIA1 USB_GSPCA_DTCS033 USB_GSPCA_ETOMS USB_GSPCA_FINEPIX USB_GSPCA_JEILINJ USB_GSPCA_JL2005BCD USB_GSPCA_KINECT USB_GSPCA_KONICA USB_GSPCA_MARS USB_GSPCA_MR97310A USB_GSPCA_NW80X USB_GSPCA_OV519 USB_GSPCA_OV534 USB_GSPCA_OV534_9 USB_GSPCA_PAC207 USB_GSPCA_PAC7302 USB_GSPCA_PAC7311 USB_GSPCA_SE401 USB_GSPCA_SN9C2028 USB_GSPCA_SN9C20X USB_GSPCA_SONIXB USB_GSPCA_SONIXJ USB_GSPCA_SPCA1528 USB_GSPCA_SPCA500 USB_GSPCA_SPCA501 USB_GSPCA_SPCA505 USB_GSPCA_SPCA506 USB_GSPCA_SPCA508 USB_GSPCA_SPCA561 USB_GSPCA_SQ905 USB_GSPCA_SQ905C USB_GSPCA_SQ930X USB_GSPCA_STK014 USB_GSPCA_STK1135 USB_GSPCA_STV0680 USB_GSPCA_SUNPLUS USB_GSPCA_T613 USB_GSPCA_TOPRO USB_GSPCA_TOUPTEK USB_GSPCA_TV8532 USB_GSPCA_VC032X USB_GSPCA_VICAM USB_GSPCA_XIRLINK_CIT USB_GSPCA_ZC3XX USB_HACKRF USB_HCD_BCMA USB_HCD_SSB USB_HSIC_USB3503 USB_HSIC_USB4604 USB_HSO USB_HUB_USB251XB USB_IDMOUSE USB_IOWARRIOR USB_IPHETH USB_ISIGHTFW USB_ISP116X_HCD USB_ISP1301 USB_ISP1760 USB_ISP1760_DUAL_ROLE USB_ISP1760_HCD USB_ISP1761_UDC USB_KAWETH USB_KC2190 USB_KEENE USB_LAN78XX USB_LCD USB_LD USB_LEDS_TRIGGER_USBPORT USB_LED_TRIG USB_LEGOTOWER USB_LIBCOMPOSITE USB_LINK_LAYER_TEST USB_M5602 USB_MA901 USB_MAX3421_HCD USB_MDC800 USB_MICROTEK USB_MR800 USB_MSI2500 USB_MUSB_DUAL_ROLE USB_MUSB_HDRC USB_MV_U3D USB_MV_UDC USB_NET2272 USB_NET2272_DMA USB_NET2280 USB_NET_AX88179_178A USB_NET_AX8817X USB_NET_CDCETHER USB_NET_CDC_EEM USB_NET_CDC_MBIM USB_NET_CDC_NCM USB_NET_CDC_SUBSET USB_NET_CDC_SUBSET_ENABLE USB_NET_CH9200 USB_NET_CX82310_ETH USB_NET_DM9601 USB_NET_GL620A USB_NET_HUAWEI_CDC_NCM USB_NET_INT51X1 USB_NET_KALMIA USB_NET_MCS7830 USB_NET_NET1080 USB_NET_PLUSB USB_NET_QMI_WWAN USB_NET_RNDIS_HOST USB_NET_RNDIS_WLAN USB_NET_SMSC75XX USB_NET_SMSC95XX USB_NET_SR9700 USB_NET_SR9800 USB_NET_ZAURUS USB_OHCI_HCD_PLATFORM USB_OTG USB_OTG_FSM USB_OXU210HP_HCD USB_PEGASUS USB_PULSE8_CEC USB_PWC USB_PWC_INPUT_EVDEV USB_PXA27X USB_R8A66597 USB_R8A66597_HCD USB_RAINSHADOW_CEC USB_RAREMONO USB_RAW_GADGET USB_RTL8150 USB_RTL8152 USB_RTL8153_ECM USB_S2255 USB_SERIAL USB_SERIAL_AIRCABLE USB_SERIAL_ARK3116 USB_SERIAL_BELKIN USB_SERIAL_CH341 USB_SERIAL_CONSOLE USB_SERIAL_CP210X USB_SERIAL_CYBERJACK USB_SERIAL_CYPRESS_M8 USB_SERIAL_DEBUG USB_SERIAL_DIGI_ACCELEPORT USB_SERIAL_EDGEPORT USB_SERIAL_EDGEPORT_TI USB_SERIAL_EMPEG USB_SERIAL_F81232 USB_SERIAL_F8153X USB_SERIAL_FTDI_SIO USB_SERIAL_GARMIN USB_SERIAL_GENERIC USB_SERIAL_IPAQ USB_SERIAL_IPW USB_SERIAL_IR USB_SERIAL_IUU USB_SERIAL_KEYSPAN USB_SERIAL_KEYSPAN_PDA USB_SERIAL_KLSI USB_SERIAL_KOBIL_SCT USB_SERIAL_MCT_U232 USB_SERIAL_METRO USB_SERIAL_MOS7715_PARPORT USB_SERIAL_MOS7720 USB_SERIAL_MOS7840 USB_SERIAL_MXUPORT USB_SERIAL_NAVMAN USB_SERIAL_OMNINET USB_SERIAL_OPTICON USB_SERIAL_OPTION USB_SERIAL_OTI6858 USB_SERIAL_PL2303 USB_SERIAL_QCAUX USB_SERIAL_QT2 USB_SERIAL_QUALCOMM USB_SERIAL_SAFE USB_SERIAL_SIERRAWIRELESS USB_SERIAL_SIMPLE USB_SERIAL_SPCP8X5 USB_SERIAL_SSU100 USB_SERIAL_SYMBOL USB_SERIAL_TI USB_SERIAL_UPD78F0730 USB_SERIAL_VISOR USB_SERIAL_WHITEHEAT USB_SERIAL_WISHBONE USB_SERIAL_WWAN USB_SERIAL_XR USB_SERIAL_XSENS_MT USB_SEVSEG USB_SI470X USB_SI4713 USB_SIERRA_NET USB_SISUSBVGA USB_SL811_CS USB_SL811_HCD USB_SL811_HCD_ISO USB_SNP_CORE USB_SPEEDTOUCH USB_STORAGE_ALAUDA USB_STORAGE_CYPRESS_ATACB USB_STORAGE_DATAFAB USB_STORAGE_ENE_UB6250 USB_STORAGE_FREECOM USB_STORAGE_ISD200 USB_STORAGE_JUMPSHOT USB_STORAGE_KARMA USB_STORAGE_ONETOUCH USB_STORAGE_SDDR09 USB_STORAGE_SDDR55 USB_STORAGE_USBAT USB_STV06XX USB_TEST USB_TMC USB_TRANCEVIBRATOR USB_U132_HCD USB_UAS USB_UEAGLEATM USB_ULPI_BUS USB_USBNET USB_USS720 USB_U_AUDIO USB_U_ETHER USB_U_SERIAL USB_VIDEO_CLASS USB_VIDEO_CLASS_INPUT_EVDEV USB_VL600 USB_WDM USB_XHCI_DBGCAP USB_XHCI_PLATFORM USB_XUSBATM USB_YUREX USERFAULTFD USERIO USERMODE_DRIVER USER_RETURN_NOTIFIER U_SERIAL_CONSOLE V4L2_MEM2MEM_DEV V4L_TEST_DRIVERS VALIDATE_FS_PARSER VDPA VDPA_SIM VDPA_SIM_BLOCK VDPA_SIM_NET VDPA_USER VETH VFIO VFIO_IOMMU_TYPE1 VFIO_PCI VFIO_PCI_CORE VFIO_PCI_INTX VFIO_PCI_MMAP VFIO_VIRQFD VGASTATE VHOST VHOST_CROSS_ENDIAN_LEGACY VHOST_IOTLB VHOST_NET VHOST_RING VHOST_VDPA VHOST_VSOCK VIDEOBUF2_CORE VIDEOBUF2_DMA_CONTIG VIDEOBUF2_DMA_SG VIDEOBUF2_MEMOPS VIDEOBUF2_V4L2 VIDEOBUF2_VMALLOC VIDEOMODE_HELPERS VIDEO_AU0828 VIDEO_AU0828_RC VIDEO_AU0828_V4L2 VIDEO_CS53L32A VIDEO_CX231XX VIDEO_CX231XX_ALSA VIDEO_CX231XX_DVB VIDEO_CX231XX_RC VIDEO_CX2341X VIDEO_CX25840 VIDEO_DEV VIDEO_EM28XX VIDEO_EM28XX_ALSA VIDEO_EM28XX_DVB VIDEO_EM28XX_RC VIDEO_EM28XX_V4L2 VIDEO_GO7007 VIDEO_GO7007_LOADER VIDEO_GO7007_USB VIDEO_GO7007_USB_S2250_BOARD VIDEO_HDPVR VIDEO_MSP3400 VIDEO_PVRUSB2 VIDEO_PVRUSB2_DVB VIDEO_PVRUSB2_SYSFS VIDEO_SAA711X VIDEO_STK1160 VIDEO_STK1160_COMMON VIDEO_TUNER VIDEO_TVEEPROM VIDEO_USBTV VIDEO_V4L2_I2C VIDEO_V4L2_SUBDEV_API VIDEO_V4L2_TPG VIDEO_VICODEC VIDEO_VIM2M VIDEO_VIMC VIDEO_VIVID VIDEO_VIVID_CEC VIDEO_WM8775 VIPERBOARD_ADC VIRTIO_BALLOON VIRTIO_DMA_SHARED_BUFFER VIRTIO_MEM VIRTIO_MMIO VIRTIO_MMIO_CMDLINE_DEVICES VIRTIO_PMEM VIRTIO_VDPA VIRTIO_VSOCKETS VIRTIO_VSOCKETS_COMMON VIRT_WIFI VLAN_8021Q VLAN_8021Q_GVRP VLAN_8021Q_MVRP VMAP_PFN VMWARE_VMCI VMXNET3 VP_VDPA VSOCKETS VSOCKETS_DIAG VSOCKETS_LOOPBACK VSOCKMON VT_HW_CONSOLE_BINDING VXFS_FS WANT_DEV_COREDUMP WEXT_CORE WEXT_PRIV WEXT_PROC WIREGUARD WIRELESS WIRELESS_EXT WLAN WLAN_VENDOR_ADMTEK WLAN_VENDOR_PURELIFI WLAN_VENDOR_SILABS X86_SGX X86_SGX_KVM X86_X2APIC X86_X32_ABI XARRAY_MULTI XDP_SOCKETS XDP_SOCKETS_DIAG XFRM_ESPINTCP XFRM_INTERFACE XFRM_IPCOMP XFRM_MIGRATE XFRM_OFFLOAD XFRM_STATISTICS XFRM_SUB_POLICY XFRM_USER_COMPAT XFS_FS XFS_POSIX_ACL XFS_QUOTA XFS_RT XOR_BLOCKS YENTA YENTA_ENE_TUNE YENTA_O2 YENTA_RICOH YENTA_TI YENTA_TOSHIBA ZBUD ZEROPLUS_FF ZLIB_DEFLATE ZONEFS_FS ZPOOL ZRAM ZRAM_DEF_COMP_LZORLE ZSMALLOC ZSTD_COMPRESS ZSWAP ZSWAP_COMPRESSOR_DEFAULT_LZO ZSWAP_DEFAULT_ON ZSWAP_ZPOOL_DEFAULT_ZBUD] disabling configs for [HANG LEAK UBSAN BUG KASAN LOCKDEP ATOMIC_SLEEP], they are not needed testing current HEAD d7543167affd372819a94879b8b1e8b9b12547d9 testing commit d7543167affd372819a94879b8b1e8b9b12547d9 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 3b0ee65879c2cfbd489e5d9dc37e7aff18c98e96522fc6bd4cf4f40c4f295067 all runs: OK false negative chance: 0.000 # git bisect start d7543167affd372819a94879b8b1e8b9b12547d9 f1bb70486c9c11d7e2d55240d4557f9fc575fbac Bisecting: 370 revisions left to test after this (roughly 9 steps) [2dedda77d4493f3e92e414b272bfa60f1f51ed95] mm/swap: fix race when skipping swapcache determine whether the revision contains the guilty commit revision f1bb70486c9c11d7e2d55240d4557f9fc575fbac crashed and is reachable testing commit 2dedda77d4493f3e92e414b272bfa60f1f51ed95 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 11090e68e5624f4126903c701868ca704bf3f9c7e3f8f3a9bf4fc0e6ace1769e all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good 2dedda77d4493f3e92e414b272bfa60f1f51ed95 Bisecting: 185 revisions left to test after this (roughly 8 steps) [300111cd9042d133d1edd0255f50556211125ce9] dmaengine: ptdma: use consistent DMA masks determine whether the revision contains the guilty commit revision 2dedda77d4493f3e92e414b272bfa60f1f51ed95 crashed and is reachable testing commit 300111cd9042d133d1edd0255f50556211125ce9 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 60fd774a745c232f96c4c3b1bfed1c81abf8030084dc29debad4c4e5e6d77d45 all runs: OK false negative chance: 0.000 # git bisect bad 300111cd9042d133d1edd0255f50556211125ce9 Bisecting: 92 revisions left to test after this (roughly 7 steps) [14f1992430ef9e647b02aa8ca12c5bcb9a1dffea] mm: zswap: fix missing folio cleanup in writeback race path determine whether the revision contains the guilty commit revision f1bb70486c9c11d7e2d55240d4557f9fc575fbac crashed and is reachable testing commit 14f1992430ef9e647b02aa8ca12c5bcb9a1dffea gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 1f5651a2b378bf9ba75b9efe5a7df3459b3a5d87fc8add3a13e7149a0728a1f1 all runs: OK false negative chance: 0.000 # git bisect bad 14f1992430ef9e647b02aa8ca12c5bcb9a1dffea Bisecting: 45 revisions left to test after this (roughly 6 steps) [a9409d33af61c8c7f58540aaca8abf12c0c99589] RDMA/srpt: fix function pointer cast warnings determine whether the revision contains the guilty commit revision f1bb70486c9c11d7e2d55240d4557f9fc575fbac crashed and is reachable testing commit a9409d33af61c8c7f58540aaca8abf12c0c99589 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: e8bd4f9172b72a84d7540279134086bd6d428e6ecab4c9a84d348ca00bc82237 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good a9409d33af61c8c7f58540aaca8abf12c0c99589 Bisecting: 22 revisions left to test after this (roughly 5 steps) [ca89b4f5034d5c775956cd3830e9e7930d7053ff] tls: break out of main loop when PEEK gets a non-data record determine whether the revision contains the guilty commit revision a9409d33af61c8c7f58540aaca8abf12c0c99589 crashed and is reachable testing commit ca89b4f5034d5c775956cd3830e9e7930d7053ff gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: f46652b4724f9c91f5a897c392dcc80474c96dbdb479272b22545668e3a10c33 all runs: OK false negative chance: 0.000 # git bisect bad ca89b4f5034d5c775956cd3830e9e7930d7053ff Bisecting: 11 revisions left to test after this (roughly 4 steps) [b43a4fb42fefa69b00a4bc697c59b8107d9293cb] ipv4: properly combine dev_base_seq and ipv4.dev_addr_genid determine whether the revision contains the guilty commit revision a9409d33af61c8c7f58540aaca8abf12c0c99589 crashed and is reachable testing commit b43a4fb42fefa69b00a4bc697c59b8107d9293cb gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: e60fed592adb9923527ddff8e44bdf88fd8fc53d390b40ccd1b3b584ecbff757 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good b43a4fb42fefa69b00a4bc697c59b8107d9293cb Bisecting: 5 revisions left to test after this (roughly 3 steps) [fd84a5fae03c0a6ca66d6d7eb9f473b2c7957c21] net: dev: Convert sa_data to flexible array in struct sockaddr determine whether the revision contains the guilty commit revision b43a4fb42fefa69b00a4bc697c59b8107d9293cb crashed and is reachable testing commit fd84a5fae03c0a6ca66d6d7eb9f473b2c7957c21 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 06d8860838d1432d8b08cc498bebc936831b98d6080b16c7fba3cb789aa894d7 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good fd84a5fae03c0a6ca66d6d7eb9f473b2c7957c21 Bisecting: 2 revisions left to test after this (roughly 2 steps) [18580e48e624f04bcd1ed854ccc2d8f2e2225e02] octeontx2-af: Consider the action set by PF determine whether the revision contains the guilty commit revision b43a4fb42fefa69b00a4bc697c59b8107d9293cb crashed and is reachable testing commit 18580e48e624f04bcd1ed854ccc2d8f2e2225e02 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: bb5a2659b4d8e98ba96806fddd6c1ad52ef8129ed1f66a3dd81e065be055102e all runs: boot failed: can't ssh into the instance unable to determine the verdict: 0 good runs (wanted 5), for bad wanted 5 in total, got 0 # git bisect skip 18580e48e624f04bcd1ed854ccc2d8f2e2225e02 Bisecting: 2 revisions left to test after this (roughly 2 steps) [6216509a2e11d6600aa24b92ba2735f820be4eae] platform/x86: thinkpad_acpi: Only update profile if successfully converted determine whether the revision contains the guilty commit revision 2dedda77d4493f3e92e414b272bfa60f1f51ed95 crashed and is reachable testing commit 6216509a2e11d6600aa24b92ba2735f820be4eae gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 97cc0460e63060a4b1e3113f00ca81bfa4c427e051fe11824cd454c6f4e8757a all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good 6216509a2e11d6600aa24b92ba2735f820be4eae Bisecting: 1 revision left to test after this (roughly 1 step) [11277d18926717a3c00ef745714b16f82b8f8504] s390: use the correct count for __iowrite64_copy() determine whether the revision contains the guilty commit revision 2dedda77d4493f3e92e414b272bfa60f1f51ed95 crashed and is reachable testing commit 11277d18926717a3c00ef745714b16f82b8f8504 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: 01d990cb73055b2220589ee00f4019095a3a69f154e8f4ccd7f8f8b0a1ad62d0 all runs: crashed: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready representative crash: BUG: unable to handle kernel NULL pointer dereference in sk_psock_verdict_data_ready, types: [UNKNOWN] # git bisect good 11277d18926717a3c00ef745714b16f82b8f8504 Bisecting: 0 revisions left to test after this (roughly 0 steps) [4588b13abcbd561ec67f5b3c1cb2eff690990a54] bpf, sockmap: Fix NULL pointer dereference in sk_psock_verdict_data_ready() determine whether the revision contains the guilty commit revision b43a4fb42fefa69b00a4bc697c59b8107d9293cb crashed and is reachable testing commit 4588b13abcbd561ec67f5b3c1cb2eff690990a54 gcc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 kernel signature: fbecab3d0c9d1d9184b45d975a7a011e8b34329741d01ec3481aa6638a3046e4 all runs: OK false negative chance: 0.000 # git bisect bad 4588b13abcbd561ec67f5b3c1cb2eff690990a54 4588b13abcbd561ec67f5b3c1cb2eff690990a54 is the first bad commit commit 4588b13abcbd561ec67f5b3c1cb2eff690990a54 Author: Shigeru Yoshida Date: Mon Feb 19 00:09:33 2024 +0900 bpf, sockmap: Fix NULL pointer dereference in sk_psock_verdict_data_ready() [ Upstream commit 4cd12c6065dfcdeba10f49949bffcf383b3952d8 ] syzbot reported the following NULL pointer dereference issue [1]: BUG: kernel NULL pointer dereference, address: 0000000000000000 [...] RIP: 0010:0x0 [...] Call Trace: sk_psock_verdict_data_ready+0x232/0x340 net/core/skmsg.c:1230 unix_stream_sendmsg+0x9b4/0x1230 net/unix/af_unix.c:2293 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x221/0x270 net/socket.c:745 ____sys_sendmsg+0x525/0x7d0 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x2b0/0x3a0 net/socket.c:2667 do_syscall_64+0xf9/0x240 entry_SYSCALL_64_after_hwframe+0x6f/0x77 If sk_psock_verdict_data_ready() and sk_psock_stop_verdict() are called concurrently, psock->saved_data_ready can be NULL, causing the above issue. This patch fixes this issue by calling the appropriate data ready function using the sk_psock_data_ready() helper and protecting it from concurrency with sk->sk_callback_lock. Fixes: 6df7f764cd3c ("bpf, sockmap: Wake up polling after data copy") Reported-by: syzbot+fd7b34375c1c8ce29c93@syzkaller.appspotmail.com Signed-off-by: Shigeru Yoshida Signed-off-by: Daniel Borkmann Tested-by: syzbot+fd7b34375c1c8ce29c93@syzkaller.appspotmail.com Acked-by: John Fastabend Closes: https://syzkaller.appspot.com/bug?extid=fd7b34375c1c8ce29c93 [1] Link: https://lore.kernel.org/bpf/20240218150933.6004-1-syoshida@redhat.com Signed-off-by: Sasha Levin net/core/skmsg.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) accumulated error probability: 0.00 culprit signature: fbecab3d0c9d1d9184b45d975a7a011e8b34329741d01ec3481aa6638a3046e4 parent signature: 01d990cb73055b2220589ee00f4019095a3a69f154e8f4ccd7f8f8b0a1ad62d0 revisions tested: 19, total time: 5h0m13.263247415s (build: 2h8m48.951433439s, test: 2h40m39.601212509s) first good commit: 4588b13abcbd561ec67f5b3c1cb2eff690990a54 bpf, sockmap: Fix NULL pointer dereference in sk_psock_verdict_data_ready() recipients (to): ["daniel@iogearbox.net" "john.fastabend@gmail.com" "sashal@kernel.org" "syoshida@redhat.com" "syzbot+fd7b34375c1c8ce29c93@syzkaller.appspotmail.com"] recipients (cc): []