bisecting fixing commit since 0da0a8a0a0e1845f495431c3d8d733d2bbf9e9e5 building syzkaller on 65a7a8540d29e72622fca06522587f7e66539fd3 testing commit 0da0a8a0a0e1845f495431c3d8d733d2bbf9e9e5 with gcc (GCC) 10.2.1 20210217 kernel signature: 82c27357751416b77ac501313e384f6f882479a9c2d5cadea0abe296e7424792 all runs: crashed: UBSAN: shift-out-of-bounds in qdisc_get_rtab testing current HEAD 7a7fd0de4a9804299793e564a555a49c1fc924cb testing commit 7a7fd0de4a9804299793e564a555a49c1fc924cb with gcc (GCC) 10.2.1 20210217 kernel signature: d37af49db567193b332521b4d49f290f6179a603aa5d7429e7891fb00dd79009 all runs: OK # git bisect start 7a7fd0de4a9804299793e564a555a49c1fc924cb 0da0a8a0a0e1845f495431c3d8d733d2bbf9e9e5 Bisecting: 6618 revisions left to test after this (roughly 13 steps) [66f73fb3facd42d0a7c899d7f4c712332b28499a] Merge tag 'for-linus-5.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs testing commit 66f73fb3facd42d0a7c899d7f4c712332b28499a with gcc (GCC) 10.2.1 20210217 kernel signature: 3f10dc265fbe31d0ed862bf7b8c694b6f3661b0751eec7c31787661dab518a0d all runs: OK # git bisect bad 66f73fb3facd42d0a7c899d7f4c712332b28499a Bisecting: 3186 revisions left to test after this (roughly 12 steps) [51e6d17809c85e1934600ec4cdb85552e9bda254] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 51e6d17809c85e1934600ec4cdb85552e9bda254 with gcc (GCC) 10.2.1 20210217 kernel signature: 45602b0fb2951bfc3544d6c60e86ad22591876d850b2dc11ebe4c3385ec15ddd all runs: OK # git bisect bad 51e6d17809c85e1934600ec4cdb85552e9bda254 Bisecting: 1603 revisions left to test after this (roughly 11 steps) [097b9146c0e26aabaa6ff3e5ea536a53f5254a79] net: fix up truesize of cloned skb in skb_prepare_for_shift() testing commit 097b9146c0e26aabaa6ff3e5ea536a53f5254a79 with gcc (GCC) 10.2.1 20210217 kernel signature: ba06a4e508d0abecb3de971ea91dce2974647b4c106bc4a818aa75dec0eb4d67 all runs: OK # git bisect bad 097b9146c0e26aabaa6ff3e5ea536a53f5254a79 Bisecting: 782 revisions left to test after this (roughly 10 steps) [a9925628727bbbfbd7263cf7c7791709af84296e] Merge tag 'net-5.11-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit a9925628727bbbfbd7263cf7c7791709af84296e with gcc (GCC) 10.2.1 20210217 kernel signature: c7d66a554c9dd5acb55eb069b1bc4e243957a4e8e013a8228cb4b2d98e184deb all runs: OK # git bisect bad a9925628727bbbfbd7263cf7c7791709af84296e Bisecting: 415 revisions left to test after this (roughly 9 steps) [ef7b1a0ea857af076ea64d131e95b59166ab6163] Merge tag 'io_uring-5.11-2021-01-24' of git://git.kernel.dk/linux-block testing commit ef7b1a0ea857af076ea64d131e95b59166ab6163 with gcc (GCC) 10.2.1 20210217 kernel signature: 5b6419087137250e38ee3f3a392baf791e3750a5b2457e3dacce3f3401f1b494 all runs: OK # git bisect bad ef7b1a0ea857af076ea64d131e95b59166ab6163 Bisecting: 200 revisions left to test after this (roughly 8 steps) [59a4560e855798f9764b77777aeab796de1a171d] Merge tag 'mmc-v5.11-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc testing commit 59a4560e855798f9764b77777aeab796de1a171d with gcc (GCC) 10.2.1 20210217 kernel signature: bb1186bae526531596f4a4589e84c185b8a5d63c2f3115566c82a29ff0cbe530 all runs: OK # git bisect bad 59a4560e855798f9764b77777aeab796de1a171d Bisecting: 103 revisions left to test after this (roughly 7 steps) [75439bc439e0f02903b48efce84876ca92da97bd] Merge tag 'net-5.11-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net testing commit 75439bc439e0f02903b48efce84876ca92da97bd with gcc (GCC) 10.2.1 20210217 kernel signature: 8d046789c15a5b03e2ceb2caaf8361a7321663f47fccaf6709f196a1cee8aede all runs: OK # git bisect bad 75439bc439e0f02903b48efce84876ca92da97bd Bisecting: 49 revisions left to test after this (roughly 6 steps) [50aca891d7a554db0901b245167cd653d73aaa71] can: peak_usb: fix use after free bugs testing commit 50aca891d7a554db0901b245167cd653d73aaa71 with gcc (GCC) 10.2.1 20210217 kernel signature: b05a3eb5ca5c0d43ef001318a227eefd499eb3bfdf973b2c843779887f65f833 all runs: OK # git bisect bad 50aca891d7a554db0901b245167cd653d73aaa71 Bisecting: 20 revisions left to test after this (roughly 5 steps) [bde2c0af6141702580a2ccebc396041660d127ef] Merge tag 'mac80211-for-net-2021-01-18.2' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 testing commit bde2c0af6141702580a2ccebc396041660d127ef with gcc (GCC) 10.2.1 20210217 kernel signature: 89472f7dedea0a6eeebb16729915c2708acdb8b5fa46297514d960541d115bf5 all runs: OK # git bisect bad bde2c0af6141702580a2ccebc396041660d127ef Bisecting: 14 revisions left to test after this (roughly 4 steps) [e23a8d00219818ba74f97f6a4cbe071dbbd5b5f1] Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf testing commit e23a8d00219818ba74f97f6a4cbe071dbbd5b5f1 with gcc (GCC) 10.2.1 20210217 kernel signature: 38114bda27a561198ae935a72315e9d59f32e3ff6aa6352ba486fe1718b2fb56 all runs: crashed: UBSAN: shift-out-of-bounds in qdisc_get_rtab # git bisect good e23a8d00219818ba74f97f6a4cbe071dbbd5b5f1 Bisecting: 7 revisions left to test after this (roughly 3 steps) [2463ec86cd0338a2c2edbfb0b9d50c52ff76ff43] mac80211: do not drop tx nulldata packets on encrypted links testing commit 2463ec86cd0338a2c2edbfb0b9d50c52ff76ff43 with gcc (GCC) 10.2.1 20210217 kernel signature: eba2771e065cdbc261d55081a502fffa7fd3fd9499b15a3408edb0e1619a03d5 all runs: crashed: UBSAN: shift-out-of-bounds in qdisc_get_rtab # git bisect good 2463ec86cd0338a2c2edbfb0b9d50c52ff76ff43 Bisecting: 3 revisions left to test after this (roughly 2 steps) [66c556025d687dbdd0f748c5e1df89c977b6c02a] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too testing commit 66c556025d687dbdd0f748c5e1df89c977b6c02a with gcc (GCC) 10.2.1 20210217 kernel signature: d663ef048089a045ef5b9dad210bc958566697f5b6b5d2c6acab42d9772eb79e all runs: OK # git bisect bad 66c556025d687dbdd0f748c5e1df89c977b6c02a Bisecting: 1 revision left to test after this (roughly 1 step) [dd5e073381f2ada3630f36be42833c6e9c78b75e] net_sched: gen_estimator: support large ewma log testing commit dd5e073381f2ada3630f36be42833c6e9c78b75e with gcc (GCC) 10.2.1 20210217 kernel signature: 748e18d1fee28700ef644470fd82738d7d695a49f8e03d9852d51cc5b24df8de all runs: OK # git bisect bad dd5e073381f2ada3630f36be42833c6e9c78b75e Bisecting: 0 revisions left to test after this (roughly 0 steps) [e4bedf48aaa5552bc1f49703abd17606e7e6e82a] net_sched: reject silly cell_log in qdisc_get_rtab() testing commit e4bedf48aaa5552bc1f49703abd17606e7e6e82a with gcc (GCC) 10.2.1 20210217 kernel signature: 1a01f43922205ff9162c77e67afdef3c65e95b468063d02115d859825c96aef3 all runs: OK # git bisect bad e4bedf48aaa5552bc1f49703abd17606e7e6e82a e4bedf48aaa5552bc1f49703abd17606e7e6e82a is the first bad commit commit e4bedf48aaa5552bc1f49703abd17606e7e6e82a Author: Eric Dumazet Date: Thu Jan 14 08:06:37 2021 -0800 net_sched: reject silly cell_log in qdisc_get_rtab() iproute2 probably never goes beyond 8 for the cell exponent, but stick to the max shift exponent for signed 32bit. UBSAN reported: UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22 shift exponent 130 is too large for 32-bit type 'int' CPU: 1 PID: 8450 Comm: syz-executor586 Not tainted 5.11.0-rc3-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack+0x183/0x22e lib/dump_stack.c:120 ubsan_epilogue lib/ubsan.c:148 [inline] __ubsan_handle_shift_out_of_bounds+0x432/0x4d0 lib/ubsan.c:395 __detect_linklayer+0x2a9/0x330 net/sched/sch_api.c:389 qdisc_get_rtab+0x2b5/0x410 net/sched/sch_api.c:435 cbq_init+0x28f/0x12c0 net/sched/sch_cbq.c:1180 qdisc_create+0x801/0x1470 net/sched/sch_api.c:1246 tc_modify_qdisc+0x9e3/0x1fc0 net/sched/sch_api.c:1662 rtnetlink_rcv_msg+0xb1d/0xe60 net/core/rtnetlink.c:5564 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2494 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline] netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1330 netlink_sendmsg+0xaa6/0xe90 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg net/socket.c:672 [inline] ____sys_sendmsg+0x5a2/0x900 net/socket.c:2345 ___sys_sendmsg net/socket.c:2399 [inline] __sys_sendmsg+0x319/0x400 net/socket.c:2432 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet Reported-by: syzbot Acked-by: Cong Wang Link: https://lore.kernel.org/r/20210114160637.1660597-1-eric.dumazet@gmail.com Signed-off-by: Jakub Kicinski net/sched/sch_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) culprit signature: 1a01f43922205ff9162c77e67afdef3c65e95b468063d02115d859825c96aef3 parent signature: 38114bda27a561198ae935a72315e9d59f32e3ff6aa6352ba486fe1718b2fb56 revisions tested: 16, total time: 3h40m36.846361447s (build: 1h32m41.150032017s, test: 2h6m19.987811659s) first good commit: e4bedf48aaa5552bc1f49703abd17606e7e6e82a net_sched: reject silly cell_log in qdisc_get_rtab() recipients (to): ["cong.wang@bytedance.com" "edumazet@google.com" "kuba@kernel.org"] recipients (cc): []