bisecting fixing commit since ae085d7f9365de7da27ab5c0d16b12d51ea7fca9 building syzkaller on ee339263ba6b1a08006ea3e8e1862e15181a640d testing commit ae085d7f9365de7da27ab5c0d16b12d51ea7fca9 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3a459bf77b07c4cfc471e2f359120069210572c0e6dacf44ae2ea93ad89a7e08 all runs: crashed: WARNING in j1939_session_deactivate_activate_next testing current HEAD 9d004b2f4fea97cde123e7f1939b80e77bf2e695 testing commit 9d004b2f4fea97cde123e7f1939b80e77bf2e695 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 15e913d46d1840b83b4bc498ca84b3812c20e4a56a2defd778161b2b4c1b3049 all runs: OK # git bisect start 9d004b2f4fea97cde123e7f1939b80e77bf2e695 ae085d7f9365de7da27ab5c0d16b12d51ea7fca9 Bisecting: 7715 revisions left to test after this (roughly 13 steps) [64e34b50d7aeee7082287ec39f9d34d4e60f3a04] Merge tag 'linux-kselftest-kunit-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest testing commit 64e34b50d7aeee7082287ec39f9d34d4e60f3a04 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: b7bf82bbd3d61af71eb08f66f052b237059b1dc2bc9f172fb845bfb7e97c5aa7 all runs: OK # git bisect bad 64e34b50d7aeee7082287ec39f9d34d4e60f3a04 Bisecting: 3867 revisions left to test after this (roughly 12 steps) [0e7579ca732a39cc377e17509dda9bfc4f6ba78e] io_uring: fix incorrect __kernel_rwf_t cast testing commit 0e7579ca732a39cc377e17509dda9bfc4f6ba78e compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 44704597c38ac2f3a200f9f8afd0f60ea686f79e384a1cdb2e020002359b28f3 run #0: crashed: WARNING in j1939_session_deactivate_activate_next run #1: crashed: WARNING in j1939_session_deactivate_activate_next run #2: crashed: WARNING in j1939_session_deactivate_activate_next run #3: crashed: WARNING in j1939_session_deactivate_activate_next run #4: crashed: WARNING in j1939_session_deactivate_activate_next run #5: crashed: WARNING in j1939_session_deactivate_activate_next run #6: crashed: WARNING in j1939_session_deactivate_activate_next run #7: crashed: WARNING in j1939_session_deactivate_activate_next run #8: crashed: KASAN: use-after-free Read in j1939_xtp_rx_dat_one run #9: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 0e7579ca732a39cc377e17509dda9bfc4f6ba78e Bisecting: 1931 revisions left to test after this (roughly 11 steps) [95fbef17e8253775876a08ec2011d3665b86a55f] Merge tag 's390-5.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux testing commit 95fbef17e8253775876a08ec2011d3665b86a55f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 05e78681202d076f8cba32e90d75541d36b690a91a0e8ac9969cc895e08a728d all runs: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 95fbef17e8253775876a08ec2011d3665b86a55f Bisecting: 927 revisions left to test after this (roughly 10 steps) [09583dfed2cb9723da31601cb7080490c2e2e2d7] Merge tag 'pm-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm testing commit 09583dfed2cb9723da31601cb7080490c2e2e2d7 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c16b112426a7552a2b7557ac3e3319720d1c01ff8c44a565e21639f357861664 run #0: crashed: WARNING in j1939_session_deactivate_activate_next run #1: crashed: WARNING in j1939_session_deactivate_activate_next run #2: crashed: WARNING in j1939_session_deactivate_activate_next run #3: crashed: INFO: rcu detected stall in corrupted run #4: crashed: WARNING in j1939_session_deactivate_activate_next run #5: crashed: WARNING in j1939_session_deactivate_activate_next run #6: crashed: INFO: rcu detected stall in corrupted run #7: crashed: WARNING in j1939_session_deactivate_activate_next run #8: crashed: WARNING in j1939_session_deactivate_activate_next run #9: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 09583dfed2cb9723da31601cb7080490c2e2e2d7 Bisecting: 522 revisions left to test after this (roughly 9 steps) [3842007b1a33589d57f67eac479b132b77767514] Merge tag 'zonefs-5.19-rc1-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs testing commit 3842007b1a33589d57f67eac479b132b77767514 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: d90dadca81767c570e4f960e44324e1d65a41603a44fcc78c1060053a0ee7522 run #0: crashed: WARNING in j1939_session_deactivate_activate_next run #1: crashed: WARNING in j1939_session_deactivate_activate_next run #2: crashed: WARNING in j1939_session_deactivate_activate_next run #3: crashed: WARNING in j1939_session_deactivate_activate_next run #4: crashed: WARNING in j1939_session_deactivate_activate_next run #5: crashed: KASAN: use-after-free Read in j1939_xtp_rx_dat_one run #6: crashed: WARNING in j1939_session_deactivate_activate_next run #7: crashed: WARNING in j1939_session_deactivate_activate_next run #8: crashed: WARNING in j1939_session_deactivate_activate_next run #9: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 3842007b1a33589d57f67eac479b132b77767514 Bisecting: 282 revisions left to test after this (roughly 8 steps) [8642174b52214dde4d8113f28fb4c9be5a432126] Merge tag 'iomap-5.19-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux testing commit 8642174b52214dde4d8113f28fb4c9be5a432126 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2fe65060f53c711bf1b3d737ef88bdf7634bf4c43bdf6c2ba9df516dfb07c648 run #0: crashed: WARNING in j1939_session_deactivate_activate_next run #1: crashed: KASAN: use-after-free Read in j1939_xtp_rx_dat_one run #2: crashed: WARNING in j1939_session_deactivate_activate_next run #3: crashed: WARNING in j1939_session_deactivate_activate_next run #4: crashed: WARNING in j1939_session_deactivate_activate_next run #5: crashed: INFO: rcu detected stall in corrupted run #6: crashed: WARNING in j1939_session_deactivate_activate_next run #7: crashed: WARNING in j1939_session_deactivate_activate_next run #8: crashed: WARNING in j1939_session_deactivate_activate_next run #9: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 8642174b52214dde4d8113f28fb4c9be5a432126 Bisecting: 132 revisions left to test after this (roughly 7 steps) [537e62c865dcb9b91d07ed83f8615b71fa0b51bb] Merge tag 'printk-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux testing commit 537e62c865dcb9b91d07ed83f8615b71fa0b51bb compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 23ccd902888c6c8d7a6f9347cc8b651e3ab244edc176b94dadb0a404fb777076 all runs: OK # git bisect bad 537e62c865dcb9b91d07ed83f8615b71fa0b51bb Bisecting: 74 revisions left to test after this (roughly 6 steps) [fa29000b6b2603ec2bfdc4c73249fcb00cd54f85] fs: Add aops->release_folio testing commit fa29000b6b2603ec2bfdc4c73249fcb00cd54f85 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5a4b95a4bdc98c1a45eb4418299c581ec3144f6fd1ec93f42fe5630610266a4a all runs: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good fa29000b6b2603ec2bfdc4c73249fcb00cd54f85 Bisecting: 39 revisions left to test after this (roughly 5 steps) [caa28984163cb63ea0be4cb8dbf05defdc7303f9] linux/types.h: reinstate "__bitwise__" macro for user space use testing commit caa28984163cb63ea0be4cb8dbf05defdc7303f9 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 355c3d9c6404c007e6c93305aafee852143e6e11882d83aa29f03cba1c6e034c run #0: crashed: INFO: rcu detected stall in corrupted run #1: crashed: WARNING in j1939_session_deactivate_activate_next run #2: crashed: WARNING in j1939_session_deactivate_activate_next run #3: crashed: WARNING in j1939_session_deactivate_activate_next run #4: crashed: WARNING in j1939_session_deactivate_activate_next run #5: crashed: WARNING in j1939_session_deactivate_activate_next run #6: crashed: WARNING in j1939_session_deactivate_activate_next run #7: crashed: WARNING in j1939_session_deactivate_activate_next run #8: crashed: WARNING in j1939_session_deactivate_activate_next run #9: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good caa28984163cb63ea0be4cb8dbf05defdc7303f9 Bisecting: 19 revisions left to test after this (roughly 4 steps) [2e17ce1106e04a7f3a83796ec623881487f75dd3] Merge tag 'slab-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab testing commit 2e17ce1106e04a7f3a83796ec623881487f75dd3 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: dd0a1104fa8a67f0c2672adff238db7c8cdad100724e38282230d6187273d9e4 all runs: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 2e17ce1106e04a7f3a83796ec623881487f75dd3 Bisecting: 9 revisions left to test after this (roughly 3 steps) [03a749e628fdbc665d7f9712637f880a79da8b78] printk: move buffer definitions into console_emit_next_record() caller testing commit 03a749e628fdbc665d7f9712637f880a79da8b78 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8662738aaa595bcd552a822b3523bea70574bedc247c2a29fed2e6871852f404 all runs: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good 03a749e628fdbc665d7f9712637f880a79da8b78 Bisecting: 4 revisions left to test after this (roughly 2 steps) [ab406816fca009349b89cbde885daf68a8c77e33] printk: remove @console_locked testing commit ab406816fca009349b89cbde885daf68a8c77e33 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 9782fb9e041b3e908c0d91c2ae143698751dd2926f1c09d7605200f772364767 run #0: crashed: WARNING in j1939_session_deactivate_activate_next run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK reproducer seems to be flaky # git bisect good ab406816fca009349b89cbde885daf68a8c77e33 Bisecting: 2 revisions left to test after this (roughly 1 step) [a5c7a39f508ae1fd3288493b96dd26079bae41bf] printk/index: Printk index feature documentation testing commit a5c7a39f508ae1fd3288493b96dd26079bae41bf compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8834879fbc144017865ecc002339d533c24d7c28253713771e26e4053ad58aa6 all runs: crashed: WARNING in j1939_session_deactivate_activate_next # git bisect good a5c7a39f508ae1fd3288493b96dd26079bae41bf Bisecting: 0 revisions left to test after this (roughly 1 step) [1c6fd59943a630f087b4b3089aefdcb0bf43cca0] Merge branch 'rework/kthreads' into for-linus testing commit 1c6fd59943a630f087b4b3089aefdcb0bf43cca0 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 14a1ff1caaefaee9abf73bbff4a23ca848efc97ce6438c0b27cea1c2484f22f1 run #0: boot failed: WARNING in blk_release_queue run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect bad 1c6fd59943a630f087b4b3089aefdcb0bf43cca0 Bisecting: 0 revisions left to test after this (roughly 0 steps) [701850dc0c31bfadf75a0a74af7d2c97859945ec] printk, tracing: fix console tracepoint testing commit 701850dc0c31bfadf75a0a74af7d2c97859945ec compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2c891368cd5d5ab2964b36d1c1ee3f20c51ef7da4dbf3bad714f99efa0f39a21 run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: boot failed: WARNING in blk_release_queue run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK run #10: OK run #11: OK run #12: OK run #13: OK run #14: OK run #15: OK run #16: OK run #17: OK run #18: OK run #19: OK # git bisect bad 701850dc0c31bfadf75a0a74af7d2c97859945ec 701850dc0c31bfadf75a0a74af7d2c97859945ec is the first bad commit commit 701850dc0c31bfadf75a0a74af7d2c97859945ec Author: Marco Elver Date: Tue May 3 09:38:44 2022 +0200 printk, tracing: fix console tracepoint The original intent of the 'console' tracepoint per the commit 95100358491a ("printk/tracing: Add console output tracing") had been to "[...] record any printk messages into the trace, regardless of the current console loglevel. This can help correlate (existing) printk debugging with other tracing." Petr points out [1] that calling trace_console_rcuidle() in call_console_driver() had been the wrong thing for a while, because "printk() always used console_trylock() and the message was flushed to the console only when the trylock succeeded. And it was always deferred in NMI or when printed via printk_deferred()." With the commit 09c5ba0aa2fc ("printk: add kthread console printers"), things only got worse, and calls to call_console_driver() no longer happen with typical printk() calls but always appear deferred [2]. As such, the tracepoint can no longer serve its purpose to clearly correlate printk() calls and other tracing, as well as breaks usecases that expect every printk() call to result in a callback of the console tracepoint. Notably, the KFENCE and KCSAN test suites, which want to capture console output and assume a printk() immediately gives us a callback to the console tracepoint. Fix the console tracepoint by moving it into printk_sprint() [3]. One notable difference is that by moving tracing into printk_sprint(), the 'text' will no longer include the "header" (loglevel and timestamp), but only the raw message. Arguably this is less of a problem now that the console tracepoint happens on the printk() call and isn't delayed. Link: https://lore.kernel.org/all/Ym+WqKStCg%2FEHfh3@alley/ [1] Link: https://lore.kernel.org/all/CA+G9fYu2kS0wR4WqMRsj2rePKV9XLgOU1PiXnMvpT+Z=c2ucHA@mail.gmail.com/ [2] Link: https://lore.kernel.org/all/87fslup9dx.fsf@jogness.linutronix.de/ [3] Reported-by: Linux Kernel Functional Testing Signed-off-by: Marco Elver Cc: John Ogness Cc: Petr Mladek Reviewed-by: Petr Mladek Acked-by: John Ogness Acked-by: Steven Rostedt (Google) Signed-off-by: Petr Mladek Link: https://lore.kernel.org/r/20220503073844.4148944-1-elver@google.com kernel/printk/printk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) culprit signature: 2c891368cd5d5ab2964b36d1c1ee3f20c51ef7da4dbf3bad714f99efa0f39a21 parent signature: 9782fb9e041b3e908c0d91c2ae143698751dd2926f1c09d7605200f772364767 Reproducer flagged being flaky revisions tested: 17, total time: 3h35m7.973935529s (build: 1h54m36.781459313s, test: 1h38m48.737920152s) first good commit: 701850dc0c31bfadf75a0a74af7d2c97859945ec printk, tracing: fix console tracepoint recipients (to): ["elver@google.com" "john.ogness@linutronix.de" "pmladek@suse.com" "rostedt@goodmis.org"] recipients (cc): []