ci starts bisection 2023-05-10 23:51:17.021661248 +0000 UTC m=+36574.196495736 bisecting cause commit starting from 578215f3e21c472c08d70b8796edf1ac58f88578 building syzkaller on 0fbd49f48637cff2f7cf1ab0150e2c4ce8d97527 ensuring issue is reproducible on original commit 578215f3e21c472c08d70b8796edf1ac58f88578 testing commit 578215f3e21c472c08d70b8796edf1ac58f88578 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 743db4677b1ab61e1ccd0843d49e2cee175c6415754de8fa4b3df322cb749b78 all runs: crashed: WARNING in __ext4fs_dirhash testing release v6.3 testing commit 457391b0380335d5e9a5babdec90ac53928b23b4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 02e926bfb576f0d7151f5440a5ece61dcfe31119d5179f4c27c3797aecc08c53 all runs: OK # git bisect start 578215f3e21c472c08d70b8796edf1ac58f88578 457391b0380335d5e9a5babdec90ac53928b23b4 Bisecting: 7636 revisions left to test after this (roughly 13 steps) [6e98b09da931a00bf4e0477d0fa52748bf28fcce] Merge tag 'net-next-6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next testing commit 6e98b09da931a00bf4e0477d0fa52748bf28fcce gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 891858356be80a901ea210ff1777fceddf5873b183479badf2ae3d76b219b6e3 all runs: OK # git bisect good 6e98b09da931a00bf4e0477d0fa52748bf28fcce Bisecting: 3820 revisions left to test after this (roughly 12 steps) [c770657bd2611b077ec1e7b1fe6aa92f249399bd] i2c: omap: Fix standard mode false ACK readings testing commit c770657bd2611b077ec1e7b1fe6aa92f249399bd gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6022f074d01150a5a85da0cf88945a5c64adb6784e7d1af1048a8f696c532aec all runs: OK # git bisect good c770657bd2611b077ec1e7b1fe6aa92f249399bd Bisecting: 2052 revisions left to test after this (roughly 11 steps) [17784de648be93b4eef0ef8fe28a16ff04feecc7] Merge tag 'core-debugobjects-2023-05-06' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip testing commit 17784de648be93b4eef0ef8fe28a16ff04feecc7 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: eb077ce354610b42c284661edaac17f15892549ec411815e5046a159817ecca4 all runs: OK # git bisect good 17784de648be93b4eef0ef8fe28a16ff04feecc7 Bisecting: 1039 revisions left to test after this (roughly 10 steps) [898f38c6b6db65be3bb39c9dc72d8ef5f73ca626] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git testing commit 898f38c6b6db65be3bb39c9dc72d8ef5f73ca626 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e492ad66ab1c1786c99e01c8d1d9571d4e1cfa675b308b6df5812afe1ddec991 all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad 898f38c6b6db65be3bb39c9dc72d8ef5f73ca626 Bisecting: 507 revisions left to test after this (roughly 9 steps) [8ead44443ab3e861e5549094941588c202c92ec4] Merge branch 'nfsd-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux testing commit 8ead44443ab3e861e5549094941588c202c92ec4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2354dd9e54c366f4f1a9ecde998187abf8339fea664f5272bdeb5a4eaca8ae25 run #0: boot failed: can't ssh into the instance run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 8ead44443ab3e861e5549094941588c202c92ec4 Bisecting: 258 revisions left to test after this (roughly 8 steps) [1c29b33c3e0856a5048f855f043e7f5e40887fe7] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git testing commit 1c29b33c3e0856a5048f855f043e7f5e40887fe7 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 1dfcd0ef23b3055faaa6f37d1bfd8ab70a879196134d5913df2e96baf0ad8213 all runs: OK # git bisect good 1c29b33c3e0856a5048f855f043e7f5e40887fe7 Bisecting: 124 revisions left to test after this (roughly 7 steps) [aaf2f67e5a3032bc074d0c19a6b9015d989091d7] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git testing commit aaf2f67e5a3032bc074d0c19a6b9015d989091d7 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: e90d34d42f221cd19f783707b69f4d29063aaf8f35de80010ae1743b293aa293 all runs: OK # git bisect good aaf2f67e5a3032bc074d0c19a6b9015d989091d7 Bisecting: 56 revisions left to test after this (roughly 6 steps) [ef43dd12405c231fe0ab00adfd13a9d3533bfa55] Merge branch 'master' of https://github.com/Paragon-Software-Group/linux-ntfs3.git testing commit ef43dd12405c231fe0ab00adfd13a9d3533bfa55 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 72ade47cfbbbf680dceeafdaeae604a95752952a32021adb87eeb66ad595f4ba all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad ef43dd12405c231fe0ab00adfd13a9d3533bfa55 Bisecting: 32 revisions left to test after this (roughly 5 steps) [7360718da829b1896e32c6a2d6fc7f018baea991] Merge branch 'dev' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git testing commit 7360718da829b1896e32c6a2d6fc7f018baea991 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 22dfa18dd87b3c30fbb557db1e3f7cdafa2884e53636c94c368b30d2b487cd8b all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad 7360718da829b1896e32c6a2d6fc7f018baea991 Bisecting: 21 revisions left to test after this (roughly 4 steps) [d5630ce59dedc76fc18784335edec42d4b59d7af] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git testing commit d5630ce59dedc76fc18784335edec42d4b59d7af gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 348c6a9ed7a036f62af3b80f1c8c08ac61ce4099b2f6c8391088d07604b06dc3 all runs: OK # git bisect good d5630ce59dedc76fc18784335edec42d4b59d7af Bisecting: 10 revisions left to test after this (roughly 4 steps) [b5f9cca1feade4c1910e79731536e022da38c9d9] ext4: fix deadlock when converting an inline directory in nojournal mode testing commit b5f9cca1feade4c1910e79731536e022da38c9d9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8f6891a003b2ac0073e0705dd1c95d84600cda2e84b42bf7e9ea93bedb46aa6e all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad b5f9cca1feade4c1910e79731536e022da38c9d9 Bisecting: 5 revisions left to test after this (roughly 3 steps) [293e592c9b5cdbac1ca698f80125e4ad844c421e] ext4: fix invalid free tracking in ext4_xattr_move_to_block() testing commit 293e592c9b5cdbac1ca698f80125e4ad844c421e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 17c0497c6c1e29610ef42cc50adfc0c5615a6b3d594a712cb6552feeaafc8c9c all runs: OK # git bisect good 293e592c9b5cdbac1ca698f80125e4ad844c421e Bisecting: 2 revisions left to test after this (roughly 2 steps) [ae226862df718fb8764dc40faec0669cc695bfad] ext4: don't clear SB_RDONLY when remounting r/w until quota is re-enabled testing commit ae226862df718fb8764dc40faec0669cc695bfad gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: fb7284ac81623177bcd69ebe73a5d3918f1a7260d555f4d55a95ec1766472512 all runs: OK # git bisect good ae226862df718fb8764dc40faec0669cc695bfad Bisecting: 0 revisions left to test after this (roughly 1 step) [11f34af7d72abc693d169a0954845a52456fdc2f] ext4: improve error recovery code paths in __ext4_remount() testing commit 11f34af7d72abc693d169a0954845a52456fdc2f gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 4d27f8dbc780ff97a376b889012ccea6eb653a436f5d2048f121e714b45f08b7 all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad 11f34af7d72abc693d169a0954845a52456fdc2f Bisecting: 0 revisions left to test after this (roughly 0 steps) [08dd966cfd2bef467acd1835ae10c32356037bc3] ext4: improve error handling from ext4_dirhash() testing commit 08dd966cfd2bef467acd1835ae10c32356037bc3 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: f73b07037c0f1fb563af94dfa0df392be26ccd3d68fda9b9677507179fc01177 all runs: crashed: WARNING in __ext4fs_dirhash # git bisect bad 08dd966cfd2bef467acd1835ae10c32356037bc3 08dd966cfd2bef467acd1835ae10c32356037bc3 is the first bad commit commit 08dd966cfd2bef467acd1835ae10c32356037bc3 Author: Theodore Ts'o Date: Sat May 6 11:59:13 2023 -0400 ext4: improve error handling from ext4_dirhash() The ext4_dirhash() will *almost* never fail, especially when the hash tree feature was first introduced. However, with the addition of support of encrypted, casefolded file names, that function can most certainly fail today. So make sure the callers of ext4_dirhash() properly check for failures, and reflect the errors back up to their callers. Cc: stable@kernel.org Link: https://lore.kernel.org/r/20230506142419.984260-1-tytso@mit.edu Reported-by: syzbot+394aa8a792cb99dbc837@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=db56459ea4ac4a676ae4b4678f633e55da005a9b Signed-off-by: Theodore Ts'o fs/ext4/hash.c | 7 ++++++- fs/ext4/namei.c | 53 +++++++++++++++++++++++++++++++++++++---------------- 2 files changed, 43 insertions(+), 17 deletions(-) culprit signature: f73b07037c0f1fb563af94dfa0df392be26ccd3d68fda9b9677507179fc01177 parent signature: fb7284ac81623177bcd69ebe73a5d3918f1a7260d555f4d55a95ec1766472512 revisions tested: 17, total time: 6h23m10.483005107s (build: 4h13m0.933341975s, test: 2h7m28.089264633s) first bad commit: 08dd966cfd2bef467acd1835ae10c32356037bc3 ext4: improve error handling from ext4_dirhash() recipients (to): ["tytso@mit.edu"] recipients (cc): [] crash: WARNING in __ext4fs_dirhash EXT4-fs error (device loop0): ext4_orphan_get:1397: comm syz-executor.0: couldn't read orphan inode 15 (err -117) EXT4-fs (loop0): mounted filesystem 00000000-0000-0000-0000-000000000000 without journal. Quota mode: writeback. EXT4-fs warning (device loop0): __ext4fs_dirhash:281: invalid/unsupported hash tree version 135 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 5432 at fs/ext4/hash.c:284 __ext4fs_dirhash+0x85a/0x950 fs/ext4/hash.c:281 Modules linked in: CPU: 0 PID: 5432 Comm: syz-executor.0 Not tainted 6.4.0-rc1-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 RIP: 0010:__ext4fs_dirhash+0x85a/0x950 fs/ext4/hash.c:284 Code: 80 3c 02 00 0f 85 ff 00 00 00 49 8b 7c 24 28 45 89 e8 48 c7 c1 a0 c7 80 89 ba 19 01 00 00 48 c7 c6 40 c8 80 89 e8 c6 be 10 00 <0f> 0b 41 b8 ea ff ff ff e9 d9 fd ff ff 8b 54 24 78 44 8b 64 24 7c RSP: 0018:ffffc900044cf780 EFLAGS: 00010286 RAX: 0000000000000000 RBX: ffff888027e900c8 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff89c2b860 RDI: 0000000000000001 RBP: 0000000000000001 R08: 0000000000000001 R09: ffffc900044cf48f R10: fffff52000899e91 R11: 0000000000000001 R12: ffff88807664dcb0 R13: 0000000000000087 R14: ffff88802a497408 R15: ffff888027e900d4 FS: 00007fbfa4c0e700(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fbfa3fa80c0 CR3: 000000002acf6000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: ext4fs_dirhash+0x1e6/0x260 fs/ext4/hash.c:323 htree_dirblock_to_tree+0x6a5/0xae0 fs/ext4/namei.c:1122 ext4_htree_fill_tree+0x2b0/0xa70 fs/ext4/namei.c:1217 ext4_dx_readdir fs/ext4/dir.c:597 [inline] ext4_readdir+0x18d8/0x3470 fs/ext4/dir.c:142 iterate_dir+0x47f/0x6c0 fs/readdir.c:65 __do_sys_getdents64 fs/readdir.c:369 [inline] __se_sys_getdents64 fs/readdir.c:354 [inline] __x64_sys_getdents64+0x128/0x240 fs/readdir.c:354 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fbfa3e8c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbfa4c0e168 EFLAGS: 00000246 ORIG_RAX: 00000000000000d9 RAX: ffffffffffffffda RBX: 00007fbfa3fabf80 RCX: 00007fbfa3e8c169 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 00007fbfa3ee7ca1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe4dae91df R14: 00007fbfa4c0e300 R15: 0000000000022000