bisecting fixing commit since 5b7a52cd2eef952cee8a72512ef370bcdef46636 building syzkaller on 4e740c00a474b578896830c7d27d90d9474364bb testing commit 5b7a52cd2eef952cee8a72512ef370bcdef46636 with gcc (GCC) 8.1.0 kernel signature: 1c20e9f6eb0197f088ad438a84f625947fdb0075da904d21dda20b32c494a89d all runs: crashed: general protection fault in qp_release_pages testing current HEAD 3f2ecb86cb909da0b9157fd2952ad79924cbe5ae testing commit 3f2ecb86cb909da0b9157fd2952ad79924cbe5ae with gcc (GCC) 8.1.0 kernel signature: 202c40e7c4a3f52fd4af77549aa779b67425c922ca5485666fa3f321562b2e24 all runs: OK # git bisect start 3f2ecb86cb909da0b9157fd2952ad79924cbe5ae 5b7a52cd2eef952cee8a72512ef370bcdef46636 Bisecting: 317 revisions left to test after this (roughly 8 steps) [6b6446efedb27c2766745a04f9b5d4449f51391d] Linux 4.14.204 testing commit 6b6446efedb27c2766745a04f9b5d4449f51391d with gcc (GCC) 8.1.0 kernel signature: 96238c7e644db4f79e82154699f95a7847c594097c792db2d4ca9ff782d2161f all runs: OK # git bisect bad 6b6446efedb27c2766745a04f9b5d4449f51391d Bisecting: 158 revisions left to test after this (roughly 7 steps) [a07e3351c42d43612f39645e3739980233fb35bb] scsi: target: core: Add CONTROL field for trace events testing commit a07e3351c42d43612f39645e3739980233fb35bb with gcc (GCC) 8.1.0 kernel signature: cf6ca449183fb72fae01628b262f9e1ab27356d556ffa09b8e85ee977ed06ed5 all runs: OK # git bisect bad a07e3351c42d43612f39645e3739980233fb35bb Bisecting: 78 revisions left to test after this (roughly 6 steps) [4abb2c64ae02368e7bc5dac7b7c9facb64ca3fb7] usb: dwc2: Fix INTR OUT transfers in DDMA mode. testing commit 4abb2c64ae02368e7bc5dac7b7c9facb64ca3fb7 with gcc (GCC) 8.1.0 kernel signature: 37b4712c3eb00e1eae2d54824f42668a9b2bf0256eeabb63537a740e3d9ae74d all runs: OK # git bisect bad 4abb2c64ae02368e7bc5dac7b7c9facb64ca3fb7 Bisecting: 39 revisions left to test after this (roughly 5 steps) [0cb5c9607f1642e0c29d1cff72fef6ed9a8efe9c] media: ti-vpe: Fix a missing check and reference count leak testing commit 0cb5c9607f1642e0c29d1cff72fef6ed9a8efe9c with gcc (GCC) 8.1.0 kernel signature: f0506f676e0ce0fda7baa6b76afefd58ec5b344c0b09ab975ceb4e2b2c5910d2 all runs: crashed: general protection fault in qp_release_pages # git bisect good 0cb5c9607f1642e0c29d1cff72fef6ed9a8efe9c Bisecting: 19 revisions left to test after this (roughly 4 steps) [de01ce3e40e5b1eab1cead0c90b73c166cacce6a] pwm: lpss: Add range limit check for the base_unit register value testing commit de01ce3e40e5b1eab1cead0c90b73c166cacce6a with gcc (GCC) 8.1.0 kernel signature: 148d6c13f7d912e363bf10b40994fb7f6d8081aa6a797ea19b714e71b6e13c15 all runs: OK # git bisect bad de01ce3e40e5b1eab1cead0c90b73c166cacce6a Bisecting: 9 revisions left to test after this (roughly 3 steps) [b14731f6054cf1a6778115b17ff91944ec4b30fb] mwifiex: Do not use GFP_KERNEL in atomic context testing commit b14731f6054cf1a6778115b17ff91944ec4b30fb with gcc (GCC) 8.1.0 kernel signature: 1deea57015ff7337ac24ae5853282f0dfe64658bf84975ec576e49ef9da86735 all runs: crashed: general protection fault in qp_release_pages # git bisect good b14731f6054cf1a6778115b17ff91944ec4b30fb Bisecting: 4 revisions left to test after this (roughly 2 steps) [2b8c7395d275caa8bd2bcda282ba889c727095dc] VMCI: check return value of get_user_pages_fast() for errors testing commit 2b8c7395d275caa8bd2bcda282ba889c727095dc with gcc (GCC) 8.1.0 kernel signature: 76896cfd9d76039bc20bda8eeddc9846b5eec374b580fda9dc40cc055692b752 all runs: OK # git bisect bad 2b8c7395d275caa8bd2bcda282ba889c727095dc Bisecting: 2 revisions left to test after this (roughly 1 step) [17b50b33f64f3895d58fb496360428684f5c105d] scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()' testing commit 17b50b33f64f3895d58fb496360428684f5c105d with gcc (GCC) 8.1.0 kernel signature: 1deea57015ff7337ac24ae5853282f0dfe64658bf84975ec576e49ef9da86735 all runs: crashed: general protection fault in qp_release_pages # git bisect good 17b50b33f64f3895d58fb496360428684f5c105d Bisecting: 0 revisions left to test after this (roughly 1 step) [6630474d70c0c3cb80ad480b4bf0c813dbc4e9db] backlight: sky81452-backlight: Fix refcount imbalance on error testing commit 6630474d70c0c3cb80ad480b4bf0c813dbc4e9db with gcc (GCC) 8.1.0 kernel signature: 1deea57015ff7337ac24ae5853282f0dfe64658bf84975ec576e49ef9da86735 all runs: crashed: general protection fault in qp_release_pages # git bisect good 6630474d70c0c3cb80ad480b4bf0c813dbc4e9db 2b8c7395d275caa8bd2bcda282ba889c727095dc is the first bad commit commit 2b8c7395d275caa8bd2bcda282ba889c727095dc Author: Alex Dewar Date: Tue Aug 25 17:45:18 2020 +0100 VMCI: check return value of get_user_pages_fast() for errors [ Upstream commit 90ca6333fd65f318c47bff425e1ea36c0a5539f6 ] In a couple of places in qp_host_get_user_memory(), get_user_pages_fast() is called without properly checking for errors. If e.g. -EFAULT is returned, this negative value will then be passed on to qp_release_pages(), which expects a u64 as input. Fix this by only calling qp_release_pages() when we have a positive number returned. Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.") Signed-off-by: Alex Dewar Link: https://lore.kernel.org/r/20200825164522.412392-1-alex.dewar90@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin drivers/misc/vmw_vmci/vmci_queue_pair.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) culprit signature: 76896cfd9d76039bc20bda8eeddc9846b5eec374b580fda9dc40cc055692b752 parent signature: 1deea57015ff7337ac24ae5853282f0dfe64658bf84975ec576e49ef9da86735 revisions tested: 11, total time: 2h43m13.022822915s (build: 1h30m17.916134219s, test: 1h11m40.304024804s) first good commit: 2b8c7395d275caa8bd2bcda282ba889c727095dc VMCI: check return value of get_user_pages_fast() for errors recipients (to): ["alex.dewar90@gmail.com" "gregkh@linuxfoundation.org" "sashal@kernel.org"] recipients (cc): []