bisecting fixing commit since d2b6f8a179194de0ffc4886ffc2c4358d86047b8
building syzkaller on bc5434be1a615eca6d901c20b026712bd9697fd4
testing commit d2b6f8a179194de0ffc4886ffc2c4358d86047b8 with gcc (GCC) 10.2.1 20210217
kernel signature: 3c04afd770a2f1f821894d330f2526e57d5fac52539e0a87b640264acd6602bf
run #0: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #1: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #2: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #3: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #4: OK
run #5: OK
run #6: OK
run #7: OK
run #8: OK
run #9: OK
run #10: OK
run #11: OK
run #12: OK
run #13: OK
run #14: OK
run #15: OK
run #16: OK
run #17: OK
run #18: OK
run #19: OK
reproducer seems to be flaky
testing current HEAD 368094df48e680fa51cedb68537408cfa64b788e
testing commit 368094df48e680fa51cedb68537408cfa64b788e with gcc (GCC) 10.2.1 20210217
kernel signature: 3a201c3c05a412a387402d14bbc4c94c3831c29943a3146b27f1b6282c6f81f6
all runs: OK
# git bisect start 368094df48e680fa51cedb68537408cfa64b788e d2b6f8a179194de0ffc4886ffc2c4358d86047b8
Bisecting: 4189 revisions left to test after this (roughly 12 steps)
[592fa9532d4e4a7590ca383fd537eb4d53fa585a] Merge branch 'i2c/for-5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
testing commit 592fa9532d4e4a7590ca383fd537eb4d53fa585a with gcc (GCC) 10.2.1 20210217
kernel signature: 384cb859aa0b2695e1b527292254d84548b797d727071c9ee2667121857b2b96
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #5: crashed: WARNING in __nf_unregister_net_hook
run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #10: crashed: WARNING in __nf_unregister_net_hook
run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: crashed: WARNING in __nf_unregister_net_hook
run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #18: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #19: crashed: WARNING in __nf_unregister_net_hook
# git bisect good 592fa9532d4e4a7590ca383fd537eb4d53fa585a
Bisecting: 2097 revisions left to test after this (roughly 11 steps)
[2423e142b37e2fcce61ea6d3c2f103384ae05f92] Merge tag 'devicetree-fixes-for-5.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
testing commit 2423e142b37e2fcce61ea6d3c2f103384ae05f92 with gcc (GCC) 10.2.1 20210217
kernel signature: 15a5a4a52c7b26e3c46264d403655afd458f8621ff2d55627350eaada5f822ef
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #11: crashed: WARNING in __nf_unregister_net_hook
run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #13: crashed: WARNING in __nf_unregister_net_hook
run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #17: crashed: kernel panic: panic_on_warn set
run #18: crashed: WARNING in __nf_unregister_net_hook
run #19: crashed: WARNING in __nf_unregister_net_hook
# git bisect good 2423e142b37e2fcce61ea6d3c2f103384ae05f92
Bisecting: 1050 revisions left to test after this (roughly 10 steps)
[f01da525b3de8e59b2656b55d40c60462098651f] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
testing commit f01da525b3de8e59b2656b55d40c60462098651f with gcc (GCC) 10.2.1 20210217
kernel signature: b263668ee3c737dd8d5d394e0d043db3dd6fb699821c66a30e82dec31f572123
all runs: OK
# git bisect bad f01da525b3de8e59b2656b55d40c60462098651f
Bisecting: 527 revisions left to test after this (roughly 9 steps)
[0f979d815cd52084b99e9f6b367e79488850df2e] Merge tag 'kbuild-v5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
testing commit 0f979d815cd52084b99e9f6b367e79488850df2e with gcc (GCC) 10.2.1 20210217
kernel signature: 43ae5d812d999a2abf9cbcb7eb85f3cab93c65b3ee1db90d8b91ab1262bc9d14
all runs: OK
# git bisect bad 0f979d815cd52084b99e9f6b367e79488850df2e
Bisecting: 272 revisions left to test after this (roughly 8 steps)
[e22e9832798df81393d09d40fa34b01aea53cf39] Merge tag '9p-for-5.13-rc1' of git://github.com/martinetd/linux
testing commit e22e9832798df81393d09d40fa34b01aea53cf39 with gcc (GCC) 10.2.1 20210217
kernel signature: 1a742356b7616cf4fabf4e994905a239c415d10ce7a796f05903224fd48777aa
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #14: crashed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #18: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #19: basic kernel testing failed: WARNING in __nf_unregister_net_hook
# git bisect good e22e9832798df81393d09d40fa34b01aea53cf39
Bisecting: 132 revisions left to test after this (roughly 7 steps)
[51595e3b4943b0079638b2657f603cf5c8ea3a66] Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
testing commit 51595e3b4943b0079638b2657f603cf5c8ea3a66 with gcc (GCC) 10.2.1 20210217
kernel signature: 443a050d638b35f67595661a3adee0f1ed2ea2b97d1eda51a5585926b043b899
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: crashed: WARNING in __nf_unregister_net_hook
run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #7: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #11: crashed: WARNING in __nf_unregister_net_hook
run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #17: crashed: WARNING in __nf_unregister_net_hook
run #18: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #19: crashed: WARNING in __nf_unregister_net_hook
# git bisect good 51595e3b4943b0079638b2657f603cf5c8ea3a66
Bisecting: 66 revisions left to test after this (roughly 6 steps)
[ae4393dfd472b194c90d75d2123105fb5ed59b04] i40e: fix broken XDP support
testing commit ae4393dfd472b194c90d75d2123105fb5ed59b04 with gcc (GCC) 10.2.1 20210217
kernel signature: f60a4b5dc16b8de00b3cf2e68737bdd8854e536c8185a8db4792e8488aae4657
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: crashed: WARNING in __nf_unregister_net_hook
run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #6: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #7: crashed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: crashed: WARNING in __nf_unregister_net_hook
run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #12: crashed: WARNING in __nf_unregister_net_hook
run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #14: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: crashed: kernel panic: panic_on_warn set
run #17: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #18: crashed: WARNING in __nf_unregister_net_hook
run #19: basic kernel testing failed: WARNING in __nf_unregister_net_hook
# git bisect good ae4393dfd472b194c90d75d2123105fb5ed59b04
Bisecting: 34 revisions left to test after this (roughly 5 steps)
[fc858a5231089b972076642a86cf62481d95d82e] Merge tag 'net-5.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
testing commit fc858a5231089b972076642a86cf62481d95d82e with gcc (GCC) 10.2.1 20210217
kernel signature: 43ae5d812d999a2abf9cbcb7eb85f3cab93c65b3ee1db90d8b91ab1262bc9d14
all runs: OK
# git bisect bad fc858a5231089b972076642a86cf62481d95d82e
Bisecting: 14 revisions left to test after this (roughly 4 steps)
[55bc1af3d9115d669570aa633e5428d6e2302e8f] Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf
testing commit 55bc1af3d9115d669570aa633e5428d6e2302e8f with gcc (GCC) 10.2.1 20210217
kernel signature: 04a6ae510b5eb87fc42363beaea3faa67e23d7f0935ae78886d2bda74ac38cea
all runs: OK
# git bisect bad 55bc1af3d9115d669570aa633e5428d6e2302e8f
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[e4d4a27220a3afdfacf7fbcdc895b08d754f0de1] Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue
testing commit e4d4a27220a3afdfacf7fbcdc895b08d754f0de1 with gcc (GCC) 10.2.1 20210217
kernel signature: 6d18d17fa680f5bc60d5fce45781d12ff9b71bbc1c864a3005c57ea17eeaa5f0
run #0: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #1: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #2: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #3: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #4: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #5: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #6: crashed: WARNING in __nf_unregister_net_hook
run #7: crashed: WARNING in __nf_unregister_net_hook
run #8: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #9: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #10: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #11: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #12: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #13: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #14: crashed: WARNING in __nf_unregister_net_hook
run #15: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #16: basic kernel testing failed: WARNING in __nf_unregister_net_hook
run #17: crashed: WARNING in __nf_unregister_net_hook
run #18: crashed: WARNING in __nf_unregister_net_hook
run #19: crashed: WARNING in __nf_unregister_net_hook
# git bisect good e4d4a27220a3afdfacf7fbcdc895b08d754f0de1
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[5e024c325406470d1165a09c6feaf8ec897936be] netfilter: nfnetlink_osf: Fix a missing skb_header_pointer() NULL check
testing commit 5e024c325406470d1165a09c6feaf8ec897936be with gcc (GCC) 10.2.1 20210217
kernel signature: e87701a507a940920a3a75e3463f80840ffbf45bc2516f9ccc3a6bf217d991ec
run #0: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #1: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #2: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #3: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #4: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #5: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #6: OK
run #7: OK
run #8: OK
run #9: OK
run #10: OK
run #11: OK
run #12: OK
run #13: OK
run #14: OK
run #15: OK
run #16: OK
run #17: OK
run #18: OK
run #19: OK
# git bisect good 5e024c325406470d1165a09c6feaf8ec897936be
Bisecting: 2 revisions left to test after this (roughly 1 step)
[85dfd816fabfc16e71786eda0a33a7046688b5b0] netfilter: nftables: Fix a memleak from userdata error path in new objects
testing commit 85dfd816fabfc16e71786eda0a33a7046688b5b0 with gcc (GCC) 10.2.1 20210217
kernel signature: fc01d96a8b445ea5d91781e6b20ed27f542b55c77c19ea1dea7e178b2f4126f7
run #0: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #1: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #2: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #3: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #4: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #5: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #6: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #7: OK
run #8: OK
run #9: OK
run #10: OK
run #11: OK
run #12: OK
run #13: OK
run #14: OK
run #15: OK
run #16: OK
run #17: OK
run #18: OK
run #19: OK
# git bisect good 85dfd816fabfc16e71786eda0a33a7046688b5b0
Bisecting: 0 revisions left to test after this (roughly 1 step)
[6c8774a94e6ad26f29ef103c8671f55c255c6201] netfilter: nftables: avoid potential overflows on 32bit arches
testing commit 6c8774a94e6ad26f29ef103c8671f55c255c6201 with gcc (GCC) 10.2.1 20210217
kernel signature: 12c9bb3c53d05e75076e304d45435712f2ca1343ecc40b1f788658c843aec64a
run #0: crashed: WARNING: refcount bug in nfc_llcp_local_put
run #1: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #2: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #3: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #4: crashed: KASAN: use-after-free Read in nfc_llcp_put_ssap
run #5: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #6: crashed: KASAN: use-after-free Read in nfc_llcp_sock_unlink
run #7: OK
run #8: OK
run #9: OK
run #10: OK
run #11: OK
run #12: OK
run #13: OK
run #14: OK
run #15: OK
run #16: OK
run #17: OK
run #18: OK
run #19: OK
# git bisect good 6c8774a94e6ad26f29ef103c8671f55c255c6201
55bc1af3d9115d669570aa633e5428d6e2302e8f is the first bad commit
commit 55bc1af3d9115d669570aa633e5428d6e2302e8f
Merge: e4d4a27220a3 6c8774a94e6a
Author: Jakub Kicinski <kuba@kernel.org>
Date: Fri May 7 16:10:12 2021 -0700
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf
Pablo Neira Ayuso says:
====================
Netfilter fixes for net
1) Add SECMARK revision 1 to fix incorrect layout that prevents
from remove rule with this target, from Phil Sutter.
2) Fix pernet exit path spat in arptables, from Florian Westphal.
3) Missing rcu_read_unlock() for unknown nfnetlink callbacks,
reported by syzbot, from Eric Dumazet.
4) Missing check for skb_header_pointer() NULL pointer in
nfnetlink_osf.
5) Remove BUG_ON() after skb_header_pointer() from packet path
in several conntrack helper and the TCP tracker.
6) Fix memleak in the new object error path of userdata.
7) Avoid overflows in nft_hash_buckets(), reported by syzbot,
also from Eric.
8) Avoid overflows in 32bit arches, from Eric.
* git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf:
netfilter: nftables: avoid potential overflows on 32bit arches
netfilter: nftables: avoid overflows in nft_hash_buckets()
netfilter: nftables: Fix a memleak from userdata error path in new objects
netfilter: remove BUG_ON() after skb_header_pointer()
netfilter: nfnetlink_osf: Fix a missing skb_header_pointer() NULL check
netfilter: nfnetlink: add a missing rcu_read_unlock()
netfilter: arptables: use pernet ops struct during unregister
netfilter: xt_SECMARK: add new revision to fix structure layout
====================
Link: https://lore.kernel.org/r/20210507174739.1850-1-pablo@netfilter.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netfilter_arp/arp_tables.h | 3 +-
include/uapi/linux/netfilter/xt_SECMARK.h | 6 +++
net/ipv4/netfilter/arp_tables.c | 5 +-
net/ipv4/netfilter/arptable_filter.c | 2 +-
net/netfilter/nf_conntrack_ftp.c | 5 +-
net/netfilter/nf_conntrack_h323_main.c | 3 +-
net/netfilter/nf_conntrack_irc.c | 5 +-
net/netfilter/nf_conntrack_pptp.c | 4 +-
net/netfilter/nf_conntrack_proto_tcp.c | 6 ++-
net/netfilter/nf_conntrack_sane.c | 5 +-
net/netfilter/nf_tables_api.c | 11 ++--
net/netfilter/nfnetlink.c | 1 +
net/netfilter/nfnetlink_osf.c | 2 +
net/netfilter/nft_set_hash.c | 20 ++++---
net/netfilter/xt_SECMARK.c | 88 ++++++++++++++++++++++++-------
15 files changed, 124 insertions(+), 42 deletions(-)
Reproducer flagged being flaky
revisions tested: 15, total time: 3h36m14.645492343s (build: 1h49m56.176342523s, test: 1h44m39.024632187s)
first good commit: 55bc1af3d9115d669570aa633e5428d6e2302e8f Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf
recipients (to): ["kuba@kernel.org"]
recipients (cc): []