ci starts bisection 2023-06-18 14:17:31.250375985 +0000 UTC m=+207435.213215356 bisecting cause commit starting from f7efed9f38f886edb450041b82a6f15d663c98f8 building syzkaller on f3921d4d63f97d1f1fb49a69ea85744bb7ef184b ensuring issue is reproducible on original commit f7efed9f38f886edb450041b82a6f15d663c98f8 testing commit f7efed9f38f886edb450041b82a6f15d663c98f8 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: a8fb7d4e22b921d70ba0abeb8f6630b253f9a3b1174990e637aaa33a91744e81 all runs: crashed: WARNING in blkdev_put testing release v6.3 testing commit 457391b0380335d5e9a5babdec90ac53928b23b4 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 989af6cb13f0077dcd3b27f913178b8fb40ffa6116b70bccaf0082816fae6afd all runs: OK too many neither good nor bad results, skipping this commit # git bisect start f7efed9f38f886edb450041b82a6f15d663c98f8 457391b0380335d5e9a5babdec90ac53928b23b4 Bisecting: 13025 revisions left to test after this (roughly 14 steps) [342528ff00e8a7dd31c1ea0c0093c2289d769b39] Merge tag 'uml-for-linus-6.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux testing commit 342528ff00e8a7dd31c1ea0c0093c2289d769b39 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 45403e03ab98ca91377c510fc1240d09ca80050f211151a9935cebf947ece802 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 342528ff00e8a7dd31c1ea0c0093c2289d769b39 Bisecting: 6534 revisions left to test after this (roughly 13 steps) [1b651de77e939285b18517faf237e49e0a9b9625] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git testing commit 1b651de77e939285b18517faf237e49e0a9b9625 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ae13876c47ca07ae5bdbcdbd32afb099455217740a39e4b20d90a1690902d929 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 1b651de77e939285b18517faf237e49e0a9b9625 Bisecting: 3345 revisions left to test after this (roughly 12 steps) [08b06901654447b4c4a15c1f6439cae47a695859] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git testing commit 08b06901654447b4c4a15c1f6439cae47a695859 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 3696999a6e2a8f3677e2e27b9a6d770986695c6af9d61efb1dcbf64f0bec5355 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 08b06901654447b4c4a15c1f6439cae47a695859 Bisecting: 1612 revisions left to test after this (roughly 11 steps) [d3ae78bfb193fb60b3bd25f5ae8980648efde2f9] Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git testing commit d3ae78bfb193fb60b3bd25f5ae8980648efde2f9 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: c28fd08e57c099e3fe1c8bb1297b2e52dc7b9cd3f799cc3b00797f99372db58c all runs: crashed: WARNING in blkdev_put # git bisect bad d3ae78bfb193fb60b3bd25f5ae8980648efde2f9 Bisecting: 874 revisions left to test after this (roughly 10 steps) [16555610ca7ad5184ef2f258c2f1abecf4c8bebb] Merge branch 'for-next' of git://git.kernel.dk/linux-block.git testing commit 16555610ca7ad5184ef2f258c2f1abecf4c8bebb gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8782155e8be41298ecc137868cc60c9c1431b9166ad483aab968440c1c7fc768 all runs: crashed: WARNING in blkdev_put # git bisect bad 16555610ca7ad5184ef2f258c2f1abecf4c8bebb Bisecting: 331 revisions left to test after this (roughly 9 steps) [908cb46cf2fc310d4812dbc9cdeb529a04b7779c] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git testing commit 908cb46cf2fc310d4812dbc9cdeb529a04b7779c gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 18891d30bb696f638dfa977a3cd54df7aed9f337e14c9b12a01df4915f3ce0c1 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 908cb46cf2fc310d4812dbc9cdeb529a04b7779c Bisecting: 165 revisions left to test after this (roughly 7 steps) [d6e94913cb1cb4b4d1d737f72b5cef10b13395ff] block/rnbd: introduce rnbd_access_modes testing commit d6e94913cb1cb4b4d1d737f72b5cef10b13395ff gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: f4d5f2526584f010859459b4dbdbf99b45a29a392edd2a850fc595f8b92b65b5 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good d6e94913cb1cb4b4d1d737f72b5cef10b13395ff Bisecting: 87 revisions left to test after this (roughly 6 steps) [2b4e92c36a6416710985ba4bdcfe78af7c9f45b3] Merge branch 'for-6.5/block' into for-next testing commit 2b4e92c36a6416710985ba4bdcfe78af7c9f45b3 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 111f3da1ce18f8a6d64929424a9f2fb30b85db2fcb970328f9adcae346b4d45c all runs: crashed: WARNING in blkdev_put # git bisect bad 2b4e92c36a6416710985ba4bdcfe78af7c9f45b3 Bisecting: 36 revisions left to test after this (roughly 5 steps) [0dbbd269fb6a8799f312dfc9b1ae1244a144cfc6] Merge branch 'for-6.5/block' into for-next testing commit 0dbbd269fb6a8799f312dfc9b1ae1244a144cfc6 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2a096e51d7161ca221c21f1fb9caa614852e69a0089c95c351cdcdada3c286f0 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 0dbbd269fb6a8799f312dfc9b1ae1244a144cfc6 Bisecting: 18 revisions left to test after this (roughly 4 steps) [5f4eb9d5413fdfc779c099fdaf0ff417eb163145] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool testing commit 5f4eb9d5413fdfc779c099fdaf0ff417eb163145 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 75dbe473ed7198a0255e769c82679a32bdf824f536239057aa038247fffdf256 all runs: crashed: WARNING in blkdev_put # git bisect bad 5f4eb9d5413fdfc779c099fdaf0ff417eb163145 Bisecting: 8 revisions left to test after this (roughly 3 steps) [ae220766d87cd6799dbf918fea10613ae14c0654] block: remove the unused mode argument to ->release testing commit ae220766d87cd6799dbf918fea10613ae14c0654 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 083cd7db7559c0388c2309a9b36722bdf44998184225766b2fe9ef8f06c1fb77 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good ae220766d87cd6799dbf918fea10613ae14c0654 Bisecting: 4 revisions left to test after this (roughly 2 steps) [5ee607675debef509946f8a251d4c30a21493ec2] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path testing commit 5ee607675debef509946f8a251d4c30a21493ec2 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 597999d50fd454c5a0d720708e111e88a8196d0782d59156cb6922cefcec4243 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 5ee607675debef509946f8a251d4c30a21493ec2 Bisecting: 2 revisions left to test after this (roughly 1 step) [2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307] block: use the holder as indication for exclusive opens testing commit 2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307 gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 58fd466174c5a5597d9e1c6d4e081f0727fec4b45c488336bffc424daf069649 all runs: crashed: WARNING in blkdev_put # git bisect bad 2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307 Bisecting: 0 revisions left to test after this (roughly 0 steps) [2ef789288afd365f4245ba97e56189062de5148e] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path testing commit 2ef789288afd365f4245ba97e56189062de5148e gcc compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ff63207adad181a900d07bd07e580c60a1041afccffaa5c9b0812694cb21a6c1 all runs: OK too many neither good nor bad results, skipping this commit # git bisect good 2ef789288afd365f4245ba97e56189062de5148e 2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307 is the first bad commit commit 2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307 Author: Christoph Hellwig Date: Thu Jun 8 13:02:43 2023 +0200 block: use the holder as indication for exclusive opens The current interface for exclusive opens is rather confusing as it requires both the FMODE_EXCL flag and a holder. Remove the need to pass FMODE_EXCL and just key off the exclusive open off a non-NULL holder. For blkdev_put this requires adding the holder argument, which provides better debug checking that only the holder actually releases the hold, but at the same time allows removing the now superfluous mode argument. Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Acked-by: Christian Brauner Acked-by: David Sterba [btrfs] Acked-by: Jack Wang [rnbd] Link: https://lore.kernel.org/r/20230608110258.189493-16-hch@lst.de Signed-off-by: Jens Axboe block/bdev.c | 37 ++++++++++++++++++++---------------- block/fops.c | 6 ++++-- block/genhd.c | 5 ++--- block/ioctl.c | 5 ++--- drivers/block/drbd/drbd_nl.c | 23 +++++++++++++--------- drivers/block/pktcdvd.c | 13 ++++++------- drivers/block/rnbd/rnbd-srv.c | 4 ++-- drivers/block/xen-blkback/xenbus.c | 2 +- drivers/block/zram/zram_drv.c | 8 ++++---- drivers/md/bcache/super.c | 15 +++++++-------- drivers/md/dm.c | 6 +++--- drivers/md/md.c | 38 +++++++++++++++++++------------------ drivers/mtd/devices/block2mtd.c | 4 ++-- drivers/nvme/target/io-cmd-bdev.c | 2 +- drivers/s390/block/dasd_genhd.c | 2 +- drivers/target/target_core_iblock.c | 6 +++--- drivers/target/target_core_pscsi.c | 8 +++----- fs/btrfs/dev-replace.c | 6 +++--- fs/btrfs/ioctl.c | 12 ++++++------ fs/btrfs/volumes.c | 28 +++++++++++++-------------- fs/btrfs/volumes.h | 6 +++--- fs/erofs/super.c | 7 ++++--- fs/ext4/super.c | 11 +++-------- fs/f2fs/super.c | 2 +- fs/jfs/jfs_logmgr.c | 6 +++--- fs/nfs/blocklayout/dev.c | 4 ++-- fs/nilfs2/super.c | 6 +++--- fs/ocfs2/cluster/heartbeat.c | 4 ++-- fs/reiserfs/journal.c | 19 +++++++++---------- fs/reiserfs/reiserfs.h | 1 - fs/super.c | 20 +++++++++---------- fs/xfs/xfs_super.c | 15 ++++++++------- include/linux/blkdev.h | 2 +- kernel/power/hibernate.c | 12 ++++-------- kernel/power/power.h | 2 +- kernel/power/swap.c | 21 +++++++++----------- mm/swapfile.c | 7 +++---- 37 files changed, 183 insertions(+), 192 deletions(-) culprit signature: 58fd466174c5a5597d9e1c6d4e081f0727fec4b45c488336bffc424daf069649 parent signature: ff63207adad181a900d07bd07e580c60a1041afccffaa5c9b0812694cb21a6c1 revisions tested: 16, total time: 6h48m19.845404343s (build: 4h51m44.588974265s, test: 1h50m32.840240104s) first bad commit: 2736e8eeb0ccdc71d1f4256c9c9a28f58cc43307 block: use the holder as indication for exclusive opens recipients (to): ["axboe@kernel.dk" "brauner@kernel.org" "hare@suse.de" "hch@lst.de"] recipients (cc): [] crash: WARNING in blkdev_put ------------[ cut here ]------------ WARNING: CPU: 1 PID: 5353 at block/bdev.c:617 bd_end_claim block/bdev.c:618 [inline] WARNING: CPU: 1 PID: 5353 at block/bdev.c:617 blkdev_put+0x46b/0x830 block/bdev.c:901 Modules linked in: CPU: 1 PID: 5353 Comm: syz-executor.0 Not tainted 6.4.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 RIP: 0010:bd_end_claim block/bdev.c:617 [inline] RIP: 0010:blkdev_put+0x46b/0x830 block/bdev.c:901 Code: 89 fa 48 c1 ea 03 0f b6 04 02 84 c0 74 08 3c 03 0f 8e ad 03 00 00 41 83 ad f0 04 00 00 01 e9 70 fe ff ff 0f 0b e9 01 fd ff ff <0f> 0b e9 bc fc ff ff 4c 8d a3 a8 00 00 00 31 f6 4c 89 4c 24 10 4c RSP: 0018:ffffc90004c9fb50 EFLAGS: 00010283 RAX: ffff88801ce03980 RBX: ffff88801ce03980 RCX: 1ffff110039c0743 RDX: dffffc0000000000 RSI: ffffffff89c2c3a0 RDI: 0000000000000001 RBP: ffff88801db6c000 R08: 0000000000000000 R09: ffff88801ce03a18 R10: fffffbfff1ad15b2 R11: 0000000000000003 R12: ffffc90004e21000 R13: ffff88801ce039b8 R14: ffff88801ce03990 R15: ffff88801db6c460 FS: 0000555556659400(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fb7e4b9c3b0 CR3: 0000000025f9b000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: release_journal_dev fs/reiserfs/journal.c:2592 [inline] free_journal_ram+0x39b/0x570 fs/reiserfs/journal.c:1896 do_journal_release fs/reiserfs/journal.c:1960 [inline] journal_release+0x22c/0x590 fs/reiserfs/journal.c:1971 reiserfs_put_super+0xc8/0x570 fs/reiserfs/super.c:616 generic_shutdown_super+0x13a/0x420 fs/super.c:500 kill_block_super+0x5f/0xb0 fs/super.c:1423 deactivate_locked_super+0x7f/0x130 fs/super.c:331 cleanup_mnt+0x253/0x360 fs/namespace.c:1177 task_work_run+0x12f/0x220 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:171 [inline] exit_to_user_mode_prepare+0x210/0x240 kernel/entry/common.c:204 __syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline] syscall_exit_to_user_mode+0x1d/0x50 kernel/entry/common.c:297 do_syscall_64+0x46/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f7011a8d7f7 Code: ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd1e49f4f8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f7011a8d7f7 RDX: 00007ffd1e49f5c9 RSI: 000000000000000a RDI: 00007ffd1e49f5c0 RBP: 00007ffd1e49f5c0 R08: 00000000ffffffff R09: 00007ffd1e49f390 R10: 000055555665a893 R11: 0000000000000246 R12: 00007f7011ad643b R13: 00007ffd1e4a0680 R14: 000055555665a810 R15: 00007ffd1e4a06c0