bisecting fixing commit since 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 building syzkaller on 8ca3b7d2bb7672b5608051fab4b825fdbbf2356a testing commit 1bab61d3e8cd96f2badf515dcb06e4e1029bc017 with gcc (GCC) 8.1.0 kernel signature: 48c1df37f8d2a7ca571ef7bed5345e28a2d5519fa322e33f298de35dd59af05f all runs: crashed: general protection fault in get_unique_tuple testing current HEAD b09c34517e1ac4018e3bb75ed5c8610a8a1f486b testing commit b09c34517e1ac4018e3bb75ed5c8610a8a1f486b with gcc (GCC) 8.1.0 kernel signature: ff8ae5eb343dab9eea567e611878e9294e818e431750bc2934ad68b5930b734b all runs: crashed: general protection fault in get_unique_tuple revisions tested: 2, total time: 26m28.633674959s (build: 18m26.658224083s, test: 7m7.324870818s) the crash still happens on HEAD commit msg: Linux 4.19.149 crash: general protection fault in get_unique_tuple batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 general protection fault: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 7826 Comm: syz-executor.3 Not tainted 4.19.149-syzkaller #0 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 RIP: 0010:__read_once_size include/linux/compiler.h:193 [inline] RIP: 0010:__nf_nat_l4proto_find net/netfilter/nf_nat_core.c:73 [inline] RIP: 0010:get_unique_tuple+0x210/0x1ec0 net/netfilter/nf_nat_core.c:336 Code: c1 ea 03 80 3c 02 00 0f 85 f6 17 00 00 4a 8b 04 e5 20 fa 23 89 4e 8d 24 f8 48 b8 00 00 00 00 00 fc ff df 4c 89 e2 48 c1 ea 03 <80> 3c 02 00 0f 85 b4 17 00 00 49 8b 04 24 4c 89 85 20 ff ff ff 48 RSP: 0018:ffff88808e97edb8 EFLAGS: 00010246 RAX: dffffc0000000000 RBX: ffff88808e97ef88 RCX: ffffed1011f7fd98 RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff8923fcc8 RBP: ffff88808e97eed8 R08: ffff88808e97ef4e R09: ffffed1015d4473a R10: ffffed1015d4473a R11: ffff8880aea239d3 R12: 0000000000000000 R13: ffff88808e97f0a8 R14: ffff88808e97ef28 R15: 0000000000000000 FS: 00007fda18e30700(0000) GS:ffff8880aea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffedb94ba40 CR3: 000000008e80a000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 IPv6: ADDRCONF(NETDEV_UP): batadv_slave_0: link is not ready Call Trace: nf_nat_setup_info+0x18a/0x740 net/netfilter/nf_nat_core.c:431 batman_adv: batadv0: Interface activated: batadv_slave_0 IPv6: ADDRCONF(NETDEV_UP): veth1_macvtap: link is not ready device veth1_macvtap entered promiscuous mode IPv6: ADDRCONF(NETDEV_UP): macsec0: link is not ready __nf_nat_alloc_null_binding+0x109/0x1a0 net/netfilter/nf_nat_core.c:490 IPv6: ADDRCONF(NETDEV_UP): veth0_to_batadv: link is not ready nfnetlink_parse_nat_setup+0x2e2/0x350 net/netfilter/nf_nat_core.c:882 ctnetlink_parse_nat_setup+0x7c/0x430 net/netfilter/nf_conntrack_netlink.c:1521 ctnetlink_setup_nat net/netfilter/nf_conntrack_netlink.c:1591 [inline] ctnetlink_create_conntrack+0x389/0xfd0 net/netfilter/nf_conntrack_netlink.c:1984 IPv6: ADDRCONF(NETDEV_UP): veth1_to_batadv: link is not ready batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 ctnetlink_new_conntrack+0x46c/0xe4e net/netfilter/nf_conntrack_netlink.c:2114 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! nfnetlink_rcv_msg+0x930/0xc00 net/netfilter/nfnetlink.c:233 netlink_rcv_skb+0x13e/0x3d0 net/netlink/af_netlink.c:2455 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 nfnetlink_rcv+0x163/0x3b0 net/netfilter/nfnetlink.c:565 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline] netlink_unicast+0x443/0x660 net/netlink/af_netlink.c:1344 netlink_sendmsg+0x666/0xc50 net/netlink/af_netlink.c:1909 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 sock_sendmsg_nosec net/socket.c:622 [inline] sock_sendmsg+0xac/0xf0 net/socket.c:632 ___sys_sendmsg+0x647/0x950 net/socket.c:2115 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! IPv6: ADDRCONF(NETDEV_UP): batadv_slave_0: link is not ready __sys_sendmsg+0xd9/0x180 net/socket.c:2153 batman_adv: batadv0: Interface activated: batadv_slave_0 __do_sys_sendmsg net/socket.c:2162 [inline] __se_sys_sendmsg net/socket.c:2160 [inline] __x64_sys_sendmsg+0x73/0xb0 net/socket.c:2160 do_syscall_64+0xd0/0x4e0 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45caa9 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1 Code: 8d b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 5b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fda18e2fc78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00000000004fe7c0 RCX: 000000000045caa9 RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000000000003 RBP: 000000000078bf00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff R13: 0000000000000964 R14: 00000000004cc40b R15: 00007fda18e306d4 Modules linked in: ---[ end trace 3443851e8e760e1b ]--- batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! RIP: 0010:__read_once_size include/linux/compiler.h:193 [inline] RIP: 0010:__nf_nat_l4proto_find net/netfilter/nf_nat_core.c:73 [inline] RIP: 0010:get_unique_tuple+0x210/0x1ec0 net/netfilter/nf_nat_core.c:336 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1 Code: c1 ea 03 80 3c 02 00 0f 85 f6 17 00 00 4a 8b 04 e5 20 fa 23 89 4e 8d 24 f8 48 b8 00 00 00 00 00 fc ff df 4c 89 e2 48 c1 ea 03 <80> 3c 02 00 0f 85 b4 17 00 00 49 8b 04 24 4c 89 85 20 ff ff ff 48 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! RSP: 0018:ffff88808e97edb8 EFLAGS: 00010246 batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1 batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems! RAX: dffffc0000000000 RBX: ffff88808e97ef88 RCX: ffffed1011f7fd98 IPv6: ADDRCONF(NETDEV_UP): batadv_slave_1: link is not ready RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff8923fcc8 batman_adv: batadv0: Interface activated: batadv_slave_1 RBP: ffff88808e97eed8 R08: ffff88808e97ef4e R09: ffffed1015d4473a IPv6: ADDRCONF(NETDEV_CHANGE): macvtap0: link becomes ready R10: ffffed1015d4473a R11: ffff8880aea239d3 R12: 0000000000000000 IPv6: ADDRCONF(NETDEV_CHANGE): macsec0: link becomes ready R13: ffff88808e97f0a8 R14: ffff88808e97ef28 R15: 0000000000000000 IPv6: ADDRCONF(NETDEV_CHANGE): batadv_slave_0: link becomes ready FS: 00007fda18e30700(0000) GS:ffff8880aea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fda18deddb8 CR3: 000000008e80a000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400