diff --git a/fs/romfs/super.c b/fs/romfs/super.c index 7f783d6173e8..846b57f265ef 100644 --- a/fs/romfs/super.c +++ b/fs/romfs/super.c @@ -143,7 +143,7 @@ static int romfs_readdir(struct file *file, struct dir_context *ctx) { struct inode *i = file_inode(file); struct romfs_inode ri; - unsigned long offset, maxoff; + unsigned long offset, maxoff, next; int j, ino, nextfh; char fsname[ROMFS_MAXFN]; /* XXX dynamic? */ int ret; @@ -191,7 +191,16 @@ static int romfs_readdir(struct file *file, struct dir_context *ctx) romfs_dtype_table[nextfh & ROMFH_TYPE])) goto out; - offset = nextfh & ROMFH_MASK; + /* likewise, a chain that does not move forward would have + * getdents() repeat entries forever + */ + next = nextfh & ROMFH_MASK; + if (next && next <= offset) { + offset = maxoff; + ctx->pos = offset; + goto out; + } + offset = next; } out: return 0; @@ -203,7 +212,7 @@ static int romfs_readdir(struct file *file, struct dir_context *ctx) static struct dentry *romfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) { - unsigned long offset, maxoff; + unsigned long offset, maxoff, next; struct inode *inode = NULL; struct romfs_inode ri; const char *name; /* got from dentry */ @@ -245,8 +254,15 @@ static struct dentry *romfs_lookup(struct inode *dir, struct dentry *dentry, break; } - /* next entry */ - offset = be32_to_cpu(ri.next) & ROMFH_MASK; + /* next entry; the chain must move forward, or a corrupt image + * will keep us here forever + */ + next = be32_to_cpu(ri.next) & ROMFH_MASK; + if (next && next <= offset) { + ret = -EIO; + goto error; + } + offset = next; } return d_splice_alias(inode, dentry);