diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 5adcb6bd0fc5..27bbaf916574 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -228,7 +228,6 @@ static int validate_beacon_head(const struct nlattr *attr, { const u8 *data = nla_data(attr); unsigned int len = nla_len(attr); - const struct element *elem; const struct ieee80211_mgmt *mgmt = (void *)data; const struct ieee80211_ext *ext; unsigned int fixedlen, hdrlen; @@ -259,13 +258,8 @@ static int validate_beacon_head(const struct nlattr *attr, data += fixedlen; len -= fixedlen; - for_each_element(elem, data, len) { - /* nothing */ - } - - if (for_each_element_completed(elem, data, len)) + if (cfg80211_validate_ies(data, len)) return 0; - err: NL_SET_ERR_MSG_ATTR(extack, attr, "malformed beacon head"); return -EINVAL; @@ -276,13 +270,8 @@ static int validate_ie_attr(const struct nlattr *attr, { const u8 *data = nla_data(attr); unsigned int len = nla_len(attr); - const struct element *elem; - - for_each_element(elem, data, len) { - /* nothing */ - } - if (for_each_element_completed(elem, data, len)) + if (cfg80211_validate_ies(data, len)) return 0; NL_SET_ERR_MSG_ATTR(extack, attr, "malformed information elements"); diff --git a/net/wireless/nl80211.h b/net/wireless/nl80211.h index bdb065d14054..8322ced6b551 100644 --- a/net/wireless/nl80211.h +++ b/net/wireless/nl80211.h @@ -129,4 +129,6 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info); void nl80211_mlo_reconf_add_done(struct net_device *dev, struct cfg80211_mlo_reconf_done_data *data); +bool cfg80211_validate_ies(const u8 *data, int len); + #endif /* __NET_WIRELESS_NL80211_H */ diff --git a/net/wireless/util.c b/net/wireless/util.c index 24527bf321b2..dcaa5903bcd2 100644 --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -3083,3 +3083,14 @@ bool cfg80211_wdev_channel_allowed(struct wireless_dev *wdev, return false; } EXPORT_SYMBOL(cfg80211_wdev_channel_allowed); + +bool cfg80211_validate_ies(const u8 *data, int len) +{ + const struct element *elem; + + for_each_element(elem, data, len) { + /* nothing */ + } + + return for_each_element_completed(elem, data, len); +} diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c index 573b6b15a446..1476d933c7e7 100644 --- a/net/wireless/wext-sme.c +++ b/net/wireless/wext-sme.c @@ -319,6 +319,9 @@ int cfg80211_wext_siwgenie(struct net_device *dev, return 0; if (ie_len) { + if (!cfg80211_validate_ies(extra, ie_len)) + return -EINVAL; + ie = kmemdup(extra, ie_len, GFP_KERNEL); if (!ie) return -ENOMEM;