diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index 13d58c51fc46b..c00645a4a5733 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c @@ -41,7 +41,7 @@ u32 check_and_correct_requested_length(struct hfs_bnode *node, u32 off, u32 len) node_size = node->tree->node_size; - if ((off + len) > node_size) { + if (len > node_size - off) { u32 new_len = node_size - off; pr_err("requested length has been corrected: " diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h index 3545b8dbf11c5..10b2dda3f8044 100644 --- a/fs/hfsplus/hfsplus_fs.h +++ b/fs/hfsplus/hfsplus_fs.h @@ -600,7 +600,7 @@ u32 check_and_correct_requested_length(struct hfs_bnode *node, u32 off, u32 len) node_size = node->tree->node_size; - if ((off + len) > node_size) { + if (len > node_size - off) { u32 new_len = node_size - off; pr_err("requested length has been corrected: " diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index c00645a4a5733..08307faea7a68 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c @@ -97,7 +97,7 @@ void hfs_bnode_read(struct hfs_bnode *node, void *buf, u32 off, u32 len) u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) { - __be16 data; + __be16 data = 0; // optimize later... hfs_bnode_read(node, &data, off, 2); return be16_to_cpu(data); @@ -105,7 +105,7 @@ u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) u8 hfs_bnode_read_u8(struct hfs_bnode *node, u32 off) { - u8 data; + u8 data = 0; // optimize later... hfs_bnode_read(node, &data, off, 1); return data; diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index f8b5a8ae58ff5..35790085b5b2e 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -55,7 +55,7 @@ void hfs_bnode_read(struct hfs_bnode *node, void *buf, u32 off, u32 len) u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) { - __be16 data; + __be16 data = 0; /* TODO: optimize later... */ hfs_bnode_read(node, &data, off, 2); return be16_to_cpu(data); @@ -63,7 +63,7 @@ u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) u8 hfs_bnode_read_u8(struct hfs_bnode *node, u32 off) { - u8 data; + u8 data = 0; /* TODO: optimize later... */ hfs_bnode_read(node, &data, off, 1); return data;