diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 8bd4ec08fb36..e936eed99b27 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3320,7 +3320,7 @@ void trace_printk_init_buffers(void) * allocated here, then this was called by module code. */ if (global_trace.array_buffer.buffer) - tracing_start_cmdline_record(); + (void)tracing_start_cmdline_record(); } EXPORT_SYMBOL_GPL(trace_printk_init_buffers); @@ -3329,7 +3329,7 @@ void trace_printk_start_comm(void) /* Start tracing comms if trace printk is set */ if (!buffers_allocated) return; - tracing_start_cmdline_record(); + (void)tracing_start_cmdline_record(); } static void trace_printk_start_stop_comm(int enabled) @@ -3338,7 +3338,7 @@ static void trace_printk_start_stop_comm(int enabled) return; if (enabled) - tracing_start_cmdline_record(); + (void)tracing_start_cmdline_record(); else tracing_stop_cmdline_record(); } diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index b6d42fe06115..6fe2c8429560 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -751,9 +751,9 @@ void trace_graph_return(struct ftrace_graph_ret *trace, struct fgraph_ops *gops, int trace_graph_entry(struct ftrace_graph_ent *trace, struct fgraph_ops *gops, struct ftrace_regs *fregs); -void tracing_start_cmdline_record(void); +int tracing_start_cmdline_record(void); void tracing_stop_cmdline_record(void); -void tracing_start_tgid_record(void); +int tracing_start_tgid_record(void); void tracing_stop_tgid_record(void); int register_tracer(struct tracer *type); diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 137b4d9bb116..e6713aa80a03 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -734,9 +734,9 @@ void trace_event_enable_cmd_record(bool enable) continue; if (enable) { - tracing_start_cmdline_record(); - set_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); - } else { + if (!tracing_start_cmdline_record()) + set_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); + } else if (file->flags & EVENT_FILE_FL_RECORDED_CMD) { tracing_stop_cmdline_record(); clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); } @@ -755,9 +755,9 @@ void trace_event_enable_tgid_record(bool enable) continue; if (enable) { - tracing_start_tgid_record(); - set_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); - } else { + if (!tracing_start_tgid_record()) + set_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); + } else if (file->flags & EVENT_FILE_FL_RECORDED_TGID) { tracing_stop_tgid_record(); clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); @@ -847,14 +847,26 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file, set_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &file->flags); if (tr->trace_flags & TRACE_ITER(RECORD_CMD)) { + ret = tracing_start_cmdline_record(); + if (ret) { + pr_info("event trace: Could not enable event %s\n", + trace_event_name(call)); + break; + } cmd = true; - tracing_start_cmdline_record(); set_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); } if (tr->trace_flags & TRACE_ITER(RECORD_TGID)) { + ret = tracing_start_tgid_record(); + if (ret) { + if (cmd) + tracing_stop_cmdline_record(); + pr_info("event trace: Could not enable event %s\n", + trace_event_name(call)); + break; + } tgid = true; - tracing_start_tgid_record(); set_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); } diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c index c12795c2fb39..14d099734345 100644 --- a/kernel/trace/trace_functions.c +++ b/kernel/trace/trace_functions.c @@ -146,6 +146,8 @@ static bool handle_func_repeats(struct trace_array *tr, u32 flags_val) static int function_trace_init(struct trace_array *tr) { ftrace_func_t func; + int ret; + /* * Instance trace_arrays get their ops allocated * at instance creation. Unless it failed @@ -165,7 +167,11 @@ static int function_trace_init(struct trace_array *tr) tr->array_buffer.cpu = raw_smp_processor_id(); - tracing_start_cmdline_record(); + ret = tracing_start_cmdline_record(); + if (ret) { + ftrace_reset_array_ops(tr); + return ret; + } tracing_start_function_trace(tr); return 0; } diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index 1de6f1573621..6b27ed62fee8 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -487,7 +487,11 @@ static int graph_trace_init(struct trace_array *tr) ret = register_ftrace_graph(tr->gops); if (ret) return ret; - tracing_start_cmdline_record(); + ret = tracing_start_cmdline_record(); + if (ret) { + unregister_ftrace_graph(tr->gops); + return ret; + } return 0; } diff --git a/kernel/trace/trace_sched_switch.c b/kernel/trace/trace_sched_switch.c index c46d584ded3b..683ea4ca1498 100644 --- a/kernel/trace/trace_sched_switch.c +++ b/kernel/trace/trace_sched_switch.c @@ -89,12 +89,22 @@ static void tracing_sched_unregister(void) unregister_trace_sched_wakeup(probe_sched_wakeup, NULL); } -static void tracing_start_sched_switch(int ops) +static int tracing_start_sched_switch(int ops) { - bool sched_register; + int ret = 0; mutex_lock(&sched_register_mutex); - sched_register = (!sched_cmdline_ref && !sched_tgid_ref); + + /* + * If the registration fails, do not bump the reference count : the + * caller must observe the failure so it can avoid a later matching + * stop that would otherwise unregister probes that were never added. + */ + if (!sched_cmdline_ref && !sched_tgid_ref) { + ret = tracing_sched_register(); + if (ret) + goto out; + } switch (ops) { case RECORD_CMDLINE: @@ -105,10 +115,9 @@ static void tracing_start_sched_switch(int ops) sched_tgid_ref++; break; } - - if (sched_register && (sched_cmdline_ref || sched_tgid_ref)) - tracing_sched_register(); +out: mutex_unlock(&sched_register_mutex); + return ret; } static void tracing_stop_sched_switch(int ops) @@ -130,9 +139,9 @@ static void tracing_stop_sched_switch(int ops) mutex_unlock(&sched_register_mutex); } -void tracing_start_cmdline_record(void) +int tracing_start_cmdline_record(void) { - tracing_start_sched_switch(RECORD_CMDLINE); + return tracing_start_sched_switch(RECORD_CMDLINE); } void tracing_stop_cmdline_record(void) @@ -140,9 +149,9 @@ void tracing_stop_cmdline_record(void) tracing_stop_sched_switch(RECORD_CMDLINE); } -void tracing_start_tgid_record(void) +int tracing_start_tgid_record(void) { - tracing_start_sched_switch(RECORD_TGID); + return tracing_start_sched_switch(RECORD_TGID); } void tracing_stop_tgid_record(void) diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index d88c44f1dfa5..238e7451f8e4 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c @@ -1084,7 +1084,12 @@ trace_selftest_startup_function_graph(struct tracer *trace, warn_failed_init_tracer(trace, ret); goto out; } - tracing_start_cmdline_record(); + ret = tracing_start_cmdline_record(); + if (ret) { + unregister_ftrace_graph(&fgraph_ops); + warn_failed_init_tracer(trace, ret); + goto out; + } /* Sleep for a 1/10 of a second */ msleep(100);