diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 75d87c31e81f4..4322553f2902c 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -356,7 +356,7 @@ static ssize_t adsl_state_store(struct device *dev, if (!strcmp(str_cmd, "stop") || !strcmp(str_cmd, "restart")) { ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_STOP, NULL, 0, NULL, 0); if (ret < 0) { - atm_err(instance->usbatm, "change adsl state:" + usb_err(instance->usbatm, "change adsl state:" " CHIP_ADSL_LINE_STOP returned %d\n", ret); ret = -EIO; @@ -376,7 +376,7 @@ static ssize_t adsl_state_store(struct device *dev, if (!strcmp(str_cmd, "start") || !strcmp(str_cmd, "restart")) { ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_START, NULL, 0, NULL, 0); if (ret < 0) { - atm_err(instance->usbatm, "change adsl state:" + usb_err(instance->usbatm, "change adsl state:" " CHIP_ADSL_LINE_START returned %d\n", ret); ret = -EIO; @@ -481,7 +481,7 @@ static ssize_t adsl_config_store(struct device *dev, ret = cxacru_cm(instance, CM_REQUEST_CARD_DATA_SET, (u8 *) data, 4 + num * 8, NULL, 0); if (ret < 0) { - atm_err(instance->usbatm, + usb_err(instance->usbatm, "set card data returned %d\n", ret); return -EIO; } @@ -490,7 +490,7 @@ static ssize_t adsl_config_store(struct device *dev, snprintf(log + tmp*12, 13, " %02x=%08x", le32_to_cpu(data[tmp * 2 + 1]), le32_to_cpu(data[tmp * 2 + 2])); - atm_info(instance->usbatm, "config%s\n", log); + usb_info(instance->usbatm, "config%s\n", log); num = 0; } } @@ -827,6 +827,12 @@ static void cxacru_poll_status(struct work_struct *work) int keep_polling = 1; int ret; + /* adsl_state_store() calls this directly, before the heavy-init thread + * has set up atm_dev; bail out rather than dereference NULL below. + */ + if (!atm_dev) + return; + ret = cxacru_cm_get_array(instance, CM_REQUEST_CARD_INFO_GET, buf, CXINF_MAX); if (ret < 0) { if (ret != -ESHUTDOWN)