====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc4-syzkaller-00226-g4df7c5fde316 #0 Not tainted ------------------------------------------------------ kworker/1:1/24 is trying to acquire lock: ffff0000d52f5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] ffff0000d52f5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff0000d52f5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x60/0x378 net/can/j1939/transport.c:1564 but task is already holding lock: ffff0000cba445c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] ffff0000cba445c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x3b4 net/can/j1939/socket.c:207 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x48/0x60 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] j1939_sk_queue_drop_all+0x4c/0x200 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0xe0/0x144 net/can/j1939/socket.c:1282 j1939_netdev_notify+0xf0/0x144 net/can/j1939/main.c:381 notifier_call_chain+0x1a4/0x510 kernel/notifier.c:93 raw_notifier_call_chain+0x3c/0x50 kernel/notifier.c:461 __dev_notify_flags+0x2c4/0x550 dev_change_flags+0xd0/0x15c net/core/dev.c:8682 do_setlink+0xc64/0x366c net/core/rtnetlink.c:2916 __rtnl_newlink net/core/rtnetlink.c:3707 [inline] rtnl_newlink+0x14b4/0x1bc0 net/core/rtnetlink.c:3754 rtnetlink_rcv_msg+0x748/0xdbc net/core/rtnetlink.c:6558 netlink_rcv_skb+0x214/0x3c4 net/netlink/af_netlink.c:2545 rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6576 netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline] netlink_unicast+0x65c/0x898 net/netlink/af_netlink.c:1368 netlink_sendmsg+0x83c/0xb20 net/netlink/af_netlink.c:1910 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg net/socket.c:745 [inline] ____sys_sendmsg+0x56c/0x840 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x26c/0x33c net/socket.c:2667 __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2674 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 -> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x48/0x60 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] j1939_sk_errqueue+0x90/0x144 net/can/j1939/socket.c:1083 __j1939_session_release net/can/j1939/transport.c:294 [inline] kref_put include/linux/kref.h:65 [inline] j1939_session_put+0xf0/0x4b4 net/can/j1939/transport.c:299 j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline] j1939_cancel_active_session+0x2ec/0x414 net/can/j1939/transport.c:2194 j1939_netdev_notify+0xe8/0x144 net/can/j1939/main.c:380 notifier_call_chain+0x1a4/0x510 kernel/notifier.c:93 raw_notifier_call_chain+0x3c/0x50 kernel/notifier.c:461 __dev_notify_flags+0x2c4/0x550 dev_change_flags+0xd0/0x15c net/core/dev.c:8682 do_setlink+0xc64/0x366c net/core/rtnetlink.c:2916 __rtnl_newlink net/core/rtnetlink.c:3707 [inline] rtnl_newlink+0x14b4/0x1bc0 net/core/rtnetlink.c:3754 rtnetlink_rcv_msg+0x748/0xdbc net/core/rtnetlink.c:6558 netlink_rcv_skb+0x214/0x3c4 net/netlink/af_netlink.c:2545 rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6576 netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline] netlink_unicast+0x65c/0x898 net/netlink/af_netlink.c:1368 netlink_sendmsg+0x83c/0xb20 net/netlink/af_netlink.c:1910 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg net/socket.c:745 [inline] ____sys_sendmsg+0x56c/0x840 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x26c/0x33c net/socket.c:2667 __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2674 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 -> #0 (&priv->active_session_list_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x48/0x60 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x60/0x378 net/can/j1939/transport.c:1564 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x230/0x3b4 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline] j1939_session_completed net/can/j1939/transport.c:1222 [inline] j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline] j1939_xtp_rx_eoma+0x2c0/0x4c0 net/can/j1939/transport.c:1410 j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline] j1939_tp_recv+0x714/0xe14 net/can/j1939/transport.c:2144 j1939_can_recv+0x5bc/0x930 net/can/j1939/main.c:112 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x308/0x714 net/can/af_can.c:606 can_receive+0x33c/0x49c net/can/af_can.c:663 can_rcv+0x128/0x23c net/can/af_can.c:687 __netif_receive_skb_one_core net/core/dev.c:5529 [inline] __netif_receive_skb+0x18c/0x400 net/core/dev.c:5643 process_backlog+0x3c0/0x70c net/core/dev.c:5971 __napi_poll+0xb4/0x648 net/core/dev.c:6533 napi_poll net/core/dev.c:6602 [inline] net_rx_action+0x5e4/0xdc4 net/core/dev.c:6735 __do_softirq+0x2d8/0xce4 kernel/softirq.c:553 ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:80 call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:886 do_softirq_own_stack+0x20/0x2c arch/arm64/kernel/irq.c:85 do_softirq+0x90/0xf8 kernel/softirq.c:454 __local_bh_enable_ip+0x288/0x44c kernel/softirq.c:381 __raw_spin_unlock_bh include/linux/spinlock_api_smp.h:167 [inline] _raw_spin_unlock_bh+0x3c/0x4c kernel/locking/spinlock.c:210 spin_unlock_bh include/linux/spinlock.h:396 [inline] addrconf_dad_work+0x25c/0x134c net/ipv6/addrconf.c:4167 process_one_work+0x694/0x1204 kernel/workqueue.c:2627 process_scheduled_works kernel/workqueue.c:2700 [inline] worker_thread+0x938/0xef4 kernel/workqueue.c:2781 kthread+0x288/0x310 kernel/kthread.c:388 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:857 other info that might help us debug this: Chain exists of: &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&jsk->sk_session_queue_lock); lock(&priv->j1939_socks_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); *** DEADLOCK *** 6 locks held by kworker/1:1/24: #0: ffff0000cfbb4138 ((wq_completion)ipv6_addrconf){+.+.}-{0:0}, at: process_one_work+0x560/0x1204 kernel/workqueue.c:2600 #1: ffff800091727c20 ((work_completion)(&(&ifa->dad_work)->work)){+.+.}-{0:0}, at: process_one_work+0x5a0/0x1204 kernel/workqueue.c:2602 #2: ffff80008f64dea8 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock+0x20/0x2c net/core/rtnetlink.c:79 #3: ffff80008d542540 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x18/0x54 include/linux/rcupdate.h:300 #4: ffff80008d542540 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x10/0x4c include/linux/rcupdate.h:300 #5: ffff0000cba445c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] #5: ffff0000cba445c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x3b4 net/can/j1939/socket.c:207 stack backtrace: CPU: 1 PID: 24 Comm: kworker/1:1 Not tainted 6.7.0-rc4-syzkaller-00226-g4df7c5fde316 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 Workqueue: ipv6_addrconf addrconf_dad_work Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:233 show_stack+0x2c/0x44 arch/arm64/kernel/stacktrace.c:240 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x48/0x60 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x60/0x378 net/can/j1939/transport.c:1564 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x230/0x3b4 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline] j1939_session_completed net/can/j1939/transport.c:1222 [inline] j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline] j1939_xtp_rx_eoma+0x2c0/0x4c0 net/can/j1939/transport.c:1410 j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline] j1939_tp_recv+0x714/0xe14 net/can/j1939/transport.c:2144 j1939_can_recv+0x5bc/0x930 net/can/j1939/main.c:112 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x308/0x714 net/can/af_can.c:606 can_receive+0x33c/0x49c net/can/af_can.c:663 can_rcv+0x128/0x23c net/can/af_can.c:687 __netif_receive_skb_one_core net/core/dev.c:5529 [inline] __netif_receive_skb+0x18c/0x400 net/core/dev.c:5643 process_backlog+0x3c0/0x70c net/core/dev.c:5971 __napi_poll+0xb4/0x648 net/core/dev.c:6533 napi_poll net/core/dev.c:6602 [inline] net_rx_action+0x5e4/0xdc4 net/core/dev.c:6735 __do_softirq+0x2d8/0xce4 kernel/softirq.c:553 ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:80 call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:886 do_softirq_own_stack+0x20/0x2c arch/arm64/kernel/irq.c:85 do_softirq+0x90/0xf8 kernel/softirq.c:454 __local_bh_enable_ip+0x288/0x44c kernel/softirq.c:381 __raw_spin_unlock_bh include/linux/spinlock_api_smp.h:167 [inline] _raw_spin_unlock_bh+0x3c/0x4c kernel/locking/spinlock.c:210 spin_unlock_bh include/linux/spinlock.h:396 [inline] addrconf_dad_work+0x25c/0x134c net/ipv6/addrconf.c:4167 process_one_work+0x694/0x1204 kernel/workqueue.c:2627 process_scheduled_works kernel/workqueue.c:2700 [inline] worker_thread+0x938/0xef4 kernel/workqueue.c:2781 kthread+0x288/0x310 kernel/kthread.c:388 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:857 vcan0: j1939_tp_rxtimer: 0x0000000045716719: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0x0000000061754e7b: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x000000007095c55e: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x000000009990b83f: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0x0000000045716719: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0x0000000017f47b4e: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0x000000000ab5cddc: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x000000007712296f: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x00000000b4527007: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0x0000000017f47b4e: abort rx timeout. Force session deactivation vcan0: j1939_xtp_rx_dat: no tx connection found vcan0: j1939_tp_rxtimer: 0x000000009cde74a7: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0x00000000350a2c10: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x0000000033a8e663: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x00000000726cece5: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0x000000009cde74a7: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0x000000006ce255df: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0x00000000cc0c89db: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x000000009237b010: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x00000000064d888e: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0x000000006ce255df: abort rx timeout. Force session deactivation vcan0: j1939_xtp_rx_dat_one: 0x0000000026a6adf4: last 00 vcan0: j1939_xtp_rx_dat_one: 0x00000000cf42a502: last 00 vcan0: j1939_xtp_rx_dat: no rx connection found vcan0: j1939_xtp_rx_dpo: no connection found vcan0: j1939_tp_rxtimer: 0x00000000dbe0221e: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0x000000000b46b4ec: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x00000000a45559ef: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0x00000000d8a986bf: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0x00000000dbe0221e: abort rx timeout. Force session deactivation