======================================================
WARNING: possible circular locking dependency detected
6.8.0-rc3-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/2800 is trying to acquire lock:
ffff88810df25920 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:146 [inline]
ffff88810df25920 (&mm->mmap_lock){++++}-{3:3}, at: lock_vma+0x4a/0xf0 mm/userfaultfd.c:73

but task is already holding lock:
ffff888112e3feb0 (&vma->vm_lock->lock){++++}-{3:3}, at: lock_vma+0x7c/0xf0 mm/userfaultfd.c:87

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&vma->vm_lock->lock){++++}-{3:3}:
       down_write+0x29/0xb0 kernel/locking/rwsem.c:1579
       vma_start_write include/linux/mm.h:716 [inline]
       vma_link+0xe4/0x190 mm/mmap.c:416
       insert_vm_struct+0xdd/0x120 mm/mmap.c:3331
       __bprm_mm_init fs/exec.c:282 [inline]
       bprm_mm_init fs/exec.c:384 [inline]
       alloc_bprm+0x2de/0x470 fs/exec.c:1580
       kernel_execve+0x53/0x210 fs/exec.c:2009
       try_to_run_init_process init/main.c:1366 [inline]
       kernel_init+0xcb/0x190 init/main.c:1500
       ret_from_fork+0x32/0x40 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1b/0x30 arch/x86/entry/entry_64.S:242

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x11fd/0x2490 kernel/locking/lockdep.c:5137
       lock_acquire+0xea/0x270 kernel/locking/lockdep.c:5754
       down_read+0x4a/0x440 kernel/locking/rwsem.c:1526
       mmap_read_lock include/linux/mmap_lock.h:146 [inline]
       lock_vma+0x4a/0xf0 mm/userfaultfd.c:73
       find_and_lock_vmas mm/userfaultfd.c:1405 [inline]
       move_pages+0x78/0x2f0 mm/userfaultfd.c:1546
       userfaultfd_move fs/userfaultfd.c:2008 [inline]
       userfaultfd_ioctl+0x38e/0x25d0 fs/userfaultfd.c:2126
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl+0x6e/0xc0 fs/ioctl.c:857
       do_syscall_64+0xa7/0x1c0
       entry_SYSCALL_64_after_hwframe+0x6f/0x77

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&vma->vm_lock->lock);
                               lock(&mm->mmap_lock);
                               lock(&vma->vm_lock->lock);
  rlock(&mm->mmap_lock);

 *** DEADLOCK ***

1 lock held by syz-executor.0/2800:
 #0: ffff888112e3feb0 (&vma->vm_lock->lock){++++}-{3:3}, at: lock_vma+0x7c/0xf0 mm/userfaultfd.c:87

stack backtrace:
CPU: 1 PID: 2800 Comm: syz-executor.0 Not tainted 6.8.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x8d/0xe0 lib/dump_stack.c:106
 check_noncircular+0x119/0x140 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x11fd/0x2490 kernel/locking/lockdep.c:5137
 lock_acquire+0xea/0x270 kernel/locking/lockdep.c:5754
 down_read+0x4a/0x440 kernel/locking/rwsem.c:1526
 mmap_read_lock include/linux/mmap_lock.h:146 [inline]
 lock_vma+0x4a/0xf0 mm/userfaultfd.c:73
 find_and_lock_vmas mm/userfaultfd.c:1405 [inline]
 move_pages+0x78/0x2f0 mm/userfaultfd.c:1546
 userfaultfd_move fs/userfaultfd.c:2008 [inline]
 userfaultfd_ioctl+0x38e/0x25d0 fs/userfaultfd.c:2126
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:871 [inline]
 __se_sys_ioctl+0x6e/0xc0 fs/ioctl.c:857
 do_syscall_64+0xa7/0x1c0
 entry_SYSCALL_64_after_hwframe+0x6f/0x77
RIP: 0033:0x7ffa1a38ada9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffa19f0c0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ffa1a4b8f80 RCX: 00007ffa1a38ada9
RDX: 0000000020000040 RSI: 00000000c028aa05 RDI: 0000000000000003
RBP: 00007ffa1a3d747a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007ffa1a4b8f80 R15: 00007fff54dc4838
 </TASK>