vxcan0: j1939_tp_rxtimer: 0xffff88807772d000: rx timeout, send abort
vxcan0: j1939_tp_rxtimer: 0xffff88807772d000: abort rx timeout. Force session deactivation
======================================================
WARNING: possible circular locking dependency detected
6.6.0-syzkaller-10059-g4684e928dbee #0 Not tainted
------------------------------------------------------
kworker/0:5/5057 is trying to acquire lock:
ffff88807eab9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88807eab9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff88807eab9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x51/0x3e0 net/can/j1939/transport.c:1564
but task is already holding lock:
ffff8880257645c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff8880257645c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x58/0x3f0 net/can/j1939/socket.c:207
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
j1939_sk_queue_drop_all+0x3a/0x240 net/can/j1939/socket.c:139
j1939_sk_netdev_event_netdown+0xed/0x160 net/can/j1939/socket.c:1282
j1939_netdev_notify+0x20d/0x2e0 net/can/j1939/main.c:381
notifier_call_chain+0x18c/0x3a0 kernel/notifier.c:93
__dev_notify_flags+0x207/0x400
dev_change_flags+0xf0/0x1a0 net/core/dev.c:8680
do_setlink+0xfbc/0x4350 net/core/rtnetlink.c:2916
__rtnl_newlink net/core/rtnetlink.c:3707 [inline]
rtnl_newlink+0x17ee/0x2080 net/core/rtnetlink.c:3754
rtnetlink_rcv_msg+0x882/0x1030 net/core/rtnetlink.c:6558
netlink_rcv_skb+0x1df/0x430 net/netlink/af_netlink.c:2545
netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
netlink_unicast+0x7e6/0x980 net/netlink/af_netlink.c:1368
netlink_sendmsg+0xa37/0xd70 net/netlink/af_netlink.c:1910
sock_sendmsg_nosec net/socket.c:730 [inline]
__sock_sendmsg net/socket.c:745 [inline]
____sys_sendmsg+0x592/0x890 net/socket.c:2588
___sys_sendmsg net/socket.c:2642 [inline]
__sys_sendmsg+0x2b0/0x3a0 net/socket.c:2671
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x44/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
-> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
j1939_sk_errqueue+0x96/0x150 net/can/j1939/socket.c:1083
__j1939_session_release net/can/j1939/transport.c:294 [inline]
kref_put include/linux/kref.h:65 [inline]
j1939_session_put+0xff/0x460 net/can/j1939/transport.c:299
j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline]
j1939_cancel_active_session+0x354/0x480 net/can/j1939/transport.c:2194
j1939_netdev_notify+0x205/0x2e0 net/can/j1939/main.c:380
notifier_call_chain+0x18c/0x3a0 kernel/notifier.c:93
__dev_notify_flags+0x207/0x400
dev_change_flags+0xf0/0x1a0 net/core/dev.c:8680
do_setlink+0xfbc/0x4350 net/core/rtnetlink.c:2916
__rtnl_newlink net/core/rtnetlink.c:3707 [inline]
rtnl_newlink+0x17ee/0x2080 net/core/rtnetlink.c:3754
rtnetlink_rcv_msg+0x882/0x1030 net/core/rtnetlink.c:6558
netlink_rcv_skb+0x1df/0x430 net/netlink/af_netlink.c:2545
netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
netlink_unicast+0x7e6/0x980 net/netlink/af_netlink.c:1368
netlink_sendmsg+0xa37/0xd70 net/netlink/af_netlink.c:1910
sock_sendmsg_nosec net/socket.c:730 [inline]
__sock_sendmsg net/socket.c:745 [inline]
____sys_sendmsg+0x592/0x890 net/socket.c:2588
___sys_sendmsg net/socket.c:2642 [inline]
__sys_sendmsg+0x2b0/0x3a0 net/socket.c:2671
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x44/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
-> #0 (&priv->active_session_list_lock){+.-.}-{2:2}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3868 [inline]
__lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136
lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
j1939_session_activate+0x51/0x3e0 net/can/j1939/transport.c:1564
j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
j1939_sk_queue_activate_next+0x26c/0x3f0 net/can/j1939/socket.c:208
j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
j1939_session_completed net/can/j1939/transport.c:1222 [inline]
j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline]
j1939_xtp_rx_eoma+0x323/0x530 net/can/j1939/transport.c:1410
j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline]
j1939_tp_recv+0x88e/0x1050 net/can/j1939/transport.c:2144
j1939_can_recv+0x732/0xb20 net/can/j1939/main.c:112
deliver net/can/af_can.c:572 [inline]
can_rcv_filter+0x349/0x7c0 net/can/af_can.c:606
can_receive+0x327/0x480 net/can/af_can.c:663
can_rcv+0x144/0x260 net/can/af_can.c:687
__netif_receive_skb_one_core net/core/dev.c:5527 [inline]
__netif_receive_skb+0x1ca/0x530 net/core/dev.c:5641
process_backlog+0x385/0x760 net/core/dev.c:5969
__napi_poll+0xc7/0x470 net/core/dev.c:6531
napi_poll net/core/dev.c:6600 [inline]
net_rx_action+0x78b/0x1010 net/core/dev.c:6733
__do_softirq+0x2bf/0x93a kernel/softirq.c:553
do_softirq+0x11b/0x1e0 kernel/softirq.c:454
__local_bh_enable_ip+0x1b5/0x1f0 kernel/softirq.c:381
spin_unlock_bh include/linux/spinlock.h:396 [inline]
nsim_dev_trap_report drivers/net/netdevsim/dev.c:820 [inline]
nsim_dev_trap_report_work+0x759/0xa90 drivers/net/netdevsim/dev.c:850
process_one_work kernel/workqueue.c:2630 [inline]
process_scheduled_works+0x90f/0x1400 kernel/workqueue.c:2703
worker_thread+0xa5f/0xff0 kernel/workqueue.c:2784
kthread+0x2d3/0x370 kernel/kthread.c:388
ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
other info that might help us debug this:
Chain exists of:
&priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&jsk->sk_session_queue_lock);
lock(&priv->j1939_socks_lock);
lock(&jsk->sk_session_queue_lock);
lock(&priv->active_session_list_lock);
*** DEADLOCK ***
7 locks held by kworker/0:5/5057:
#0: ffff888012c70d38 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:2605 [inline]
#0: ffff888012c70d38 ((wq_completion)events){+.+.}-{0:0}, at: process_scheduled_works+0x825/0x1400 kernel/workqueue.c:2703
#1: ffffc900042efd20 ((work_completion)(&(&nsim_dev->trap_data->trap_report_dw)->work)){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:2605 [inline]
#1: ffffc900042efd20 ((work_completion)(&(&nsim_dev->trap_data->trap_report_dw)->work)){+.+.}-{0:0}, at: process_scheduled_works+0x825/0x1400 kernel/workqueue.c:2703
#2: ffff888028c25250 (&devlink->lock_key#3){+.+.}-{3:3}, at: nsim_dev_trap_report_work+0x57/0xa90 drivers/net/netdevsim/dev.c:841
#3: ffff8880651a04e0 (&nsim_trap_data->trap_lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:351 [inline]
#3: ffff8880651a04e0 (&nsim_trap_data->trap_lock){+.+.}-{2:2}, at: nsim_dev_trap_report drivers/net/netdevsim/dev.c:791 [inline]
#3: ffff8880651a04e0 (&nsim_trap_data->trap_lock){+.+.}-{2:2}, at: nsim_dev_trap_report_work+0x191/0xa90 drivers/net/netdevsim/dev.c:850
#4: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:301 [inline]
#4: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:747 [inline]
#4: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x2cd/0x760 net/core/dev.c:5968
#5: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:301 [inline]
#5: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:747 [inline]
#5: ffffffff8d72d520 (rcu_read_lock){....}-{1:2}, at: can_receive+0x1c9/0x480 net/can/af_can.c:656
#6: ffff8880257645c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#6: ffff8880257645c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x58/0x3f0 net/can/j1939/socket.c:207
stack backtrace:
CPU: 0 PID: 5057 Comm: kworker/0:5 Not tainted 6.6.0-syzkaller-10059-g4684e928dbee #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Workqueue: events nsim_dev_trap_report_work
Call Trace:
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3868 [inline]
__lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136
lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
j1939_session_activate+0x51/0x3e0 net/can/j1939/transport.c:1564
j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
j1939_sk_queue_activate_next+0x26c/0x3f0 net/can/j1939/socket.c:208
j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
j1939_session_completed net/can/j1939/transport.c:1222 [inline]
j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline]
j1939_xtp_rx_eoma+0x323/0x530 net/can/j1939/transport.c:1410
j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline]
j1939_tp_recv+0x88e/0x1050 net/can/j1939/transport.c:2144
j1939_can_recv+0x732/0xb20 net/can/j1939/main.c:112
deliver net/can/af_can.c:572 [inline]
can_rcv_filter+0x349/0x7c0 net/can/af_can.c:606
can_receive+0x327/0x480 net/can/af_can.c:663
can_rcv+0x144/0x260 net/can/af_can.c:687
__netif_receive_skb_one_core net/core/dev.c:5527 [inline]
__netif_receive_skb+0x1ca/0x530 net/core/dev.c:5641
process_backlog+0x385/0x760 net/core/dev.c:5969
__napi_poll+0xc7/0x470 net/core/dev.c:6531
napi_poll net/core/dev.c:6600 [inline]
net_rx_action+0x78b/0x1010 net/core/dev.c:6733
__do_softirq+0x2bf/0x93a kernel/softirq.c:553
do_softirq+0x11b/0x1e0 kernel/softirq.c:454
__local_bh_enable_ip+0x1b5/0x1f0 kernel/softirq.c:381
spin_unlock_bh include/linux/spinlock.h:396 [inline]
nsim_dev_trap_report drivers/net/netdevsim/dev.c:820 [inline]
nsim_dev_trap_report_work+0x759/0xa90 drivers/net/netdevsim/dev.c:850
process_one_work kernel/workqueue.c:2630 [inline]
process_scheduled_works+0x90f/0x1400 kernel/workqueue.c:2703
worker_thread+0xa5f/0xff0 kernel/workqueue.c:2784
kthread+0x2d3/0x370 kernel/kthread.c:388
ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
vxcan0: j1939_xtp_rx_dat: no tx connection found
vxcan0: j1939_tp_rxtimer: 0xffff888065aae000: rx timeout, send abort
vxcan0: j1939_tp_rxtimer: 0xffff888065aae000: abort rx timeout. Force session deactivation