loop0: detected capacity change from 0 to 40427
F2FS-fs (loop0): invalid crc value
F2FS-fs (loop0): Found nat_bits in checkpoint
F2FS-fs (loop0): Mounted with checkpoint version = 48b305e4
======================================================
WARNING: possible circular locking dependency detected
6.4.0-rc1-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/3189 is trying to acquire lock:
ffff88810dbeb738 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2133 [inline]
ffff88810dbeb738 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_add_inline_entry+0x134/0x270 fs/f2fs/inline.c:644

but task is already holding lock:
ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline]
ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry fs/f2fs/dir.c:783 [inline]
ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_do_add_link+0x142/0x280 fs/f2fs/dir.c:827

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&fi->i_xattr_sem){.+.+}-{3:3}:
       down_read+0x2c/0x40 kernel/locking/rwsem.c:1520
       f2fs_down_read fs/f2fs/f2fs.h:2108 [inline]
       f2fs_getxattr+0x63/0x6c0 fs/f2fs/xattr.c:532
       __f2fs_get_acl+0x39/0x2a0 fs/f2fs/acl.c:179
       f2fs_acl_create fs/f2fs/acl.c:377 [inline]
       f2fs_init_acl+0x3b/0x340 fs/f2fs/acl.c:420
       f2fs_init_inode_metadata+0x29b/0x470 fs/f2fs/dir.c:558
       f2fs_add_regular_entry+0x2ec/0x4b0 fs/f2fs/dir.c:740
       f2fs_add_dentry fs/f2fs/dir.c:788 [inline]
       f2fs_do_add_link+0x17d/0x280 fs/f2fs/dir.c:827
       f2fs_add_link fs/f2fs/f2fs.h:3555 [inline]
       f2fs_mkdir+0xe0/0x160 fs/f2fs/namei.c:781
       vfs_mkdir+0xb1/0x130 fs/namei.c:4115
       do_mkdirat+0x121/0x1a0 fs/namei.c:4138
       __do_sys_mkdirat fs/namei.c:4153 [inline]
       __se_sys_mkdirat fs/namei.c:4151 [inline]
       __x64_sys_mkdirat+0x29/0x30 fs/namei.c:4151
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0x90 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&fi->i_sem){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3108 [inline]
       check_prevs_add kernel/locking/lockdep.c:3227 [inline]
       validate_chain kernel/locking/lockdep.c:3842 [inline]
       __lock_acquire+0x146c/0x2880 kernel/locking/lockdep.c:5074
       lock_acquire+0xea/0x260 kernel/locking/lockdep.c:5691
       down_write+0x29/0xb0 kernel/locking/rwsem.c:1573
       f2fs_down_write fs/f2fs/f2fs.h:2133 [inline]
       f2fs_add_inline_entry+0x134/0x270 fs/f2fs/inline.c:644
       f2fs_add_dentry fs/f2fs/dir.c:784 [inline]
       f2fs_do_add_link+0x158/0x280 fs/f2fs/dir.c:827
       f2fs_add_link fs/f2fs/f2fs.h:3555 [inline]
       f2fs_mkdir+0xe0/0x160 fs/f2fs/namei.c:781
       vfs_mkdir+0xb1/0x130 fs/namei.c:4115
       ovl_do_mkdir fs/overlayfs/overlayfs.h:189 [inline]
       ovl_mkdir_real+0x2a/0xc0 fs/overlayfs/dir.c:146
       ovl_workdir_create+0x192/0x2d0 fs/overlayfs/super.c:799
       ovl_make_workdir fs/overlayfs/super.c:1286 [inline]
       ovl_get_workdir+0x16c/0x7b0 fs/overlayfs/super.c:1436
       ovl_fill_super+0x6c3/0xb00 fs/overlayfs/super.c:1992
       mount_nodev+0x41/0x80 fs/super.c:1426
       legacy_get_tree+0x29/0x50 fs/fs_context.c:610
       vfs_get_tree+0x20/0x80 fs/super.c:1510
       do_new_mount+0x153/0x370 fs/namespace.c:3039
       do_mount fs/namespace.c:3382 [inline]
       __do_sys_mount fs/namespace.c:3591 [inline]
       __se_sys_mount+0x177/0x1e0 fs/namespace.c:3568
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0x90 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&fi->i_xattr_sem);
                               lock(&fi->i_sem);
                               lock(&fi->i_xattr_sem);
  lock(&fi->i_sem);

 *** DEADLOCK ***

5 locks held by syz-executor.0/3189:
 #0: ffff8881406fc0e0 (&type->s_umount_key#48/1){+.+.}-{3:3}, at: alloc_super+0xd2/0x390 fs/super.c:228
 #1: ffff888141ed9460 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x12/0x30 fs/namespace.c:394
 #2: ffff88810dbea2b0 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:810 [inline]
 #2: ffff88810dbea2b0 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: ovl_workdir_create+0x53/0x2d0 fs/overlayfs/super.c:771
 #3: ffff8881073323a8 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline]
 #3: ffff8881073323a8 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_lock_op fs/f2fs/f2fs.h:2151 [inline]
 #3: ffff8881073323a8 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_mkdir+0xb9/0x160 fs/f2fs/namei.c:780
 #4: ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline]
 #4: ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry fs/f2fs/dir.c:783 [inline]
 #4: ffff88810dbea928 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_do_add_link+0x142/0x280 fs/f2fs/dir.c:827

stack backtrace:
CPU: 0 PID: 3189 Comm: syz-executor.0 Not tainted 6.4.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x8d/0xe0 lib/dump_stack.c:106
 print_circular_bug+0x314/0x350 kernel/locking/lockdep.c:2066
 check_noncircular+0x106/0x110 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3108 [inline]
 check_prevs_add kernel/locking/lockdep.c:3227 [inline]
 validate_chain kernel/locking/lockdep.c:3842 [inline]
 __lock_acquire+0x146c/0x2880 kernel/locking/lockdep.c:5074
 lock_acquire+0xea/0x260 kernel/locking/lockdep.c:5691
 down_write+0x29/0xb0 kernel/locking/rwsem.c:1573
 f2fs_down_write fs/f2fs/f2fs.h:2133 [inline]
 f2fs_add_inline_entry+0x134/0x270 fs/f2fs/inline.c:644
 f2fs_add_dentry fs/f2fs/dir.c:784 [inline]
 f2fs_do_add_link+0x158/0x280 fs/f2fs/dir.c:827
 f2fs_add_link fs/f2fs/f2fs.h:3555 [inline]
 f2fs_mkdir+0xe0/0x160 fs/f2fs/namei.c:781
 vfs_mkdir+0xb1/0x130 fs/namei.c:4115
 ovl_do_mkdir fs/overlayfs/overlayfs.h:189 [inline]
 ovl_mkdir_real+0x2a/0xc0 fs/overlayfs/dir.c:146
 ovl_workdir_create+0x192/0x2d0 fs/overlayfs/super.c:799
 ovl_make_workdir fs/overlayfs/super.c:1286 [inline]
 ovl_get_workdir+0x16c/0x7b0 fs/overlayfs/super.c:1436
 ovl_fill_super+0x6c3/0xb00 fs/overlayfs/super.c:1992
 mount_nodev+0x41/0x80 fs/super.c:1426
 legacy_get_tree+0x29/0x50 fs/fs_context.c:610
 vfs_get_tree+0x20/0x80 fs/super.c:1510
 do_new_mount+0x153/0x370 fs/namespace.c:3039
 do_mount fs/namespace.c:3382 [inline]
 __do_sys_mount fs/namespace.c:3591 [inline]
 __se_sys_mount+0x177/0x1e0 fs/namespace.c:3568
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0x90 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f1d7267cae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1d733a40c8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f1d7279bf80 RCX: 00007f1d7267cae9
RDX: 0000000020000240 RSI: 0000000020000500 RDI: 0000000020000f7a
RBP: 00007f1d726c847a R08: 0000000020000080 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000006 R14: 00007f1d7279bf80 R15: 00007ffd1b4549d8
 </TASK>